Kevin Harwell 12a0edac69 pjsip_messaging, pjsip_header_funcs: Crashes due to NULL pointer dereferences ...

Both res_pjsip_messaging and res_pjsip_header_funcs were causing asterisk to
crash because they were trying to dereference a NULL pointer.

In the case of res_pjsip_messaging it was attempting to "print" a contact
header that did not exist.  In fact contact headers should not be part of
a SIP MESSAGE, so the offending code was simply removed.

In the case of res_pjsip_header_funcs a null private channel tech was being
passed to the function and then later dereferenced.  Added null checks (and
error logging) to the read/write function handlers to guard against crashing.

(closes issue ASTERISK-22821)
Reported by: Anthony Messina
........

Merged revisions 402757 from http://svn.asterisk.org/svn/asterisk/branches/12


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@402758 65c4cc65-6c06-0410-ace0-fbb531ad65f3

2013-11-12 16:49:17 +00:00

..

ael

Clean up and ensure proper usage of alloca()

2012-07-31 20:21:43 +00:00

ari

Fixed a typ.

2013-11-12 15:27:00 +00:00

parking

res_parking: Give parking timeout comebacktoorigin channel DTMF features.

2013-10-22 16:33:16 +00:00

res_pjsip

res_pjsip: Print a helpful error message if sorcery registration fails

2013-11-08 18:53:14 +00:00

snmp

Get the SNMP code to compile.

2013-08-02 15:01:37 +00:00

stasis

res_ari_channels: Add ring operation, dtmf operation, hangup reasons, and tweak early media.

2013-11-01 14:38:21 +00:00

stasis_recording

MALLOC_DEBUG: Fix some misuses of free() when MALLOC_DEBUG is enabled.

2013-10-02 17:12:49 +00:00

ari.make

ARI playback: Rename ARI Playback to Playbacks

2013-11-08 17:59:16 +00:00

Makefile

ARI: Implement /recordings/stored API's

2013-08-30 13:28:50 +00:00

res_adsi.c

Multiple revisions 369323-369324

2012-06-25 15:55:25 +00:00

res_ael_share.c

Merged revisions 328247 via svnmerge from

2011-07-14 20:28:54 +00:00

res_ael_share.exports.in

Allow symbol export filtering to work properly on platforms that have symbol prefixes.

2010-04-02 18:57:58 +00:00

res_agi.c

Make app_queue and res_agi independent of AMI being enabled.

2013-10-08 15:12:46 +00:00

res_agi.exports.in

Allow symbol export filtering to work properly on platforms that have symbol prefixes.

2010-04-02 18:57:58 +00:00

res_ari_applications.c

ari: User better nicknames for ARI operations

2013-11-07 21:10:31 +00:00

res_ari_asterisk.c

ari: User better nicknames for ARI operations

2013-11-07 21:10:31 +00:00

res_ari_bridges.c

ari: User better nicknames for ARI operations

2013-11-07 21:10:31 +00:00

res_ari_channels.c

ari: User better nicknames for ARI operations

2013-11-07 21:10:31 +00:00

res_ari_endpoints.c

ari: User better nicknames for ARI operations

2013-11-07 21:10:31 +00:00

res_ari_events.c

ari: User better nicknames for ARI operations

2013-11-07 21:10:31 +00:00

res_ari_model.c

ARI: Add subscription support

2013-10-04 16:01:48 +00:00

res_ari_model.exports.in

Rename everything Stasis-HTTP to ARI

2013-07-27 23:11:02 +00:00

res_ari_playbacks.c

ARI playback: Rename ARI Playback to Playbacks

2013-11-08 17:59:16 +00:00

res_ari_recordings.c

ari: User better nicknames for ARI operations

2013-11-07 21:10:31 +00:00

res_ari_sounds.c

ari: User better nicknames for ARI operations

2013-11-07 21:10:31 +00:00

res_ari.c

ari: Add application/x-www-form-urlencoded parameter support

2013-11-08 17:29:53 +00:00

res_ari.exports.in

Rename everything Stasis-HTTP to ARI

2013-07-27 23:11:02 +00:00

res_calendar_caldav.c

Fix a variety of memory leaks

2012-05-18 14:43:44 +00:00

res_calendar_ews.c

Properly extract the Body information of an EWS calendar item

2012-10-31 14:58:44 +00:00

res_calendar_exchange.c

Add uuid wrapper API call ast_uuid_generate_str().

2013-03-28 23:59:20 +00:00

res_calendar_icalendar.c

Fix memory leak in res_calendar_icalendar

2013-01-30 14:19:29 +00:00

res_calendar.c

Fix memory/ref counting leaks in a variety of locations

2013-06-25 01:12:58 +00:00

res_calendar.exports.in

Allow symbol export filtering to work properly on platforms that have symbol prefixes.

2010-04-02 18:57:58 +00:00

res_chan_stats.c

Multiple revisions 399887,400138,400178,400180-400181

2013-09-30 18:55:27 +00:00

res_clialiases.c

The UUID commit removed changes made in res_clialiases.c

2012-12-13 15:37:45 +00:00

res_clioriginate.c

Cache string values of formats on ast_format_cap() to save processing.

2013-10-03 14:58:16 +00:00

res_config_curl.c

Add support for a realtime sorcery module.

2013-04-27 12:01:29 +00:00

res_config_ldap.c

Add support for a realtime sorcery module.

2013-04-27 12:01:29 +00:00

res_config_odbc.c

Fix Finding Extensions With Patterns Using ODBC Realtime

2013-05-10 20:28:18 +00:00

res_config_pgsql.c

Minor fixups to Doxygen comments.

2013-05-07 18:30:55 +00:00

res_config_sqlite3.c

Add support for a realtime sorcery module.

2013-04-27 12:01:29 +00:00

res_config_sqlite.c

Update Asterisk's CDRs for the new bridging framework

2013-06-17 03:00:38 +00:00

res_convert.c

Merged revisions 328247 via svnmerge from

2011-07-14 20:28:54 +00:00

res_corosync.c

Disable build of res_corosync until it is back in a compiling state

2013-08-18 02:55:54 +00:00

res_crypto.c

Doxygen Updates - janitor work

2012-09-21 17:14:59 +00:00

res_crypto.exports.in

Remove built-in AES code and use optional_api instead

2010-07-21 19:11:32 +00:00

res_curl.c

Doxygen Updates - Title update

2012-10-14 21:44:27 +00:00

res_fax_spandsp.c

Fix some more fax test errors due to needing the peer in a bridge

2013-05-27 01:33:12 +00:00

res_fax.c

Add channel lock protection around translation path setup.

2013-10-18 16:59:09 +00:00

res_fax.exports.in

Log spandsp's fax debug output to the FAX logger level.

2010-05-21 15:15:58 +00:00

res_format_attr_celt.c

Add support for parsing SDP attributes, generating SDP attributes, and passing it through.

2012-07-13 16:49:40 +00:00

res_format_attr_h263.c

Reduce memory consumption and add the H.264 and H.263 modules I shamefully neglected to add.

2012-07-13 18:41:07 +00:00

res_format_attr_h264.c

AST-2013-001: Prevent buffer overflow through H.264 format negotiation

2013-03-27 14:28:36 +00:00

res_format_attr_opus.c

Add pass through support for Opus and VP8; Opus format attribute negotiation

2013-08-23 15:42:27 +00:00

res_format_attr_silk.c

Add support for parsing SDP attributes, generating SDP attributes, and passing it through.

2012-07-13 16:49:40 +00:00

res_http_post.c

Avoid cppcheck warnings; removing unused vars and a bit of cleanup.

2012-04-17 18:57:40 +00:00

res_http_websocket.c

ARI: Fix WebSocket response when subprotocol isn't specified

2013-09-13 14:19:19 +00:00

res_http_websocket.exports.in

Shuffle RESTful URL's around.

2013-07-03 16:32:00 +00:00

res_jabber.c

Reduce log level of a non-pubsub error message

2013-10-17 15:41:22 +00:00

res_jabber.exports.in

Fix chan_jingle/gtalk load regression introduced in r346087

2011-12-05 14:47:11 +00:00

res_limit.c

Doxygen Updates - Title update

2012-10-14 21:44:27 +00:00

res_monitor.c

Update Asterisk's CDRs for the new bridging framework

2013-06-17 03:00:38 +00:00

res_monitor.exports.in

Allow symbol export filtering to work properly on platforms that have symbol prefixes.

2010-04-02 18:57:58 +00:00

res_musiconhold.c

Fix incorrect usages of ast_realloc().

2013-09-10 18:05:47 +00:00

res_mutestream.c

ARI: Add support for suppressing media streams.

2013-07-18 16:03:12 +00:00

res_odbc.c

Doxygen Updates - Title update

2012-10-14 21:44:27 +00:00

res_odbc.exports.in

Allow symbol export filtering to work properly on platforms that have symbol prefixes.

2010-04-02 18:57:58 +00:00

res_parking.c

res_parking: Update XML documention for DTMF features after parking timeout.

2013-10-22 16:28:05 +00:00

res_phoneprov.c

Doxygen Updates - Title update

2012-10-14 21:44:27 +00:00

res_pjsip_acl.c

Documentation fix and improvements to XML configuration help res_pjsip_acl

2013-09-12 23:23:12 +00:00

res_pjsip_authenticator_digest.c

PJSIP: Improve error handling in digest authenticator

2013-11-07 23:42:31 +00:00

res_pjsip_caller_id.c

pjsip: reinvite for connected line updates occurs when it should not

2013-09-11 14:23:28 +00:00

res_pjsip_diversion.c

The large GULP->PJSIP renaming effort.

2013-07-30 18:14:50 +00:00

res_pjsip_dtmf_info.c

Prevent a crash in res_pjsip_dtmf_info.c

2013-09-03 18:09:02 +00:00

res_pjsip_endpoint_identifier_anonymous.c

The large GULP->PJSIP renaming effort.

2013-07-30 18:14:50 +00:00

res_pjsip_endpoint_identifier_ip.c

Broke the build! Forgot para tags within my description.

2013-09-13 14:27:54 +00:00

res_pjsip_endpoint_identifier_user.c

PJSIP: Add log messages when requests are received for non-existent endpoints

2013-10-25 17:41:38 +00:00

res_pjsip_exten_state.c

Handle default body types for SIP event packages in res_pjsip_pubsub

2013-08-22 17:42:37 +00:00

res_pjsip_exten_state.exports.in

The large GULP->PJSIP renaming effort.

2013-07-30 18:14:50 +00:00

res_pjsip_header_funcs.c

pjsip_messaging, pjsip_header_funcs: Crashes due to NULL pointer dereferences

2013-11-12 16:49:17 +00:00

res_pjsip_log_forwarder.c

res_pjsip: Forward PJSIP logging to Asterisk logging

2013-09-13 14:22:07 +00:00

res_pjsip_logger.c

chan_pjsip: Make logger togglable without loading/unloading

2013-10-04 19:11:38 +00:00

res_pjsip_messaging.c

pjsip_messaging, pjsip_header_funcs: Crashes due to NULL pointer dereferences

2013-11-12 16:49:17 +00:00

res_pjsip_mwi.c

Remove duplicate module info block

2013-10-14 15:01:59 +00:00

res_pjsip_nat.c

The large GULP->PJSIP renaming effort.

2013-07-30 18:14:50 +00:00

res_pjsip_notify.c

res_pjsip_notify: Add documentation

2013-09-28 22:57:17 +00:00

res_pjsip_one_touch_record_info.c

The large GULP->PJSIP renaming effort.

2013-07-30 18:14:50 +00:00

res_pjsip_outbound_authenticator_digest.c

Fix realm comparison for outbound auth

2013-10-12 16:53:06 +00:00

res_pjsip_outbound_registration.c

pjsip outbound registration: Log message says received a 408 when we didn't

2013-10-14 15:54:06 +00:00

res_pjsip_pidf.c

Sanitize XML output for PIDF bodies.

2013-08-30 00:11:22 +00:00

res_pjsip_pubsub.c

Create more accurate Contact headers for dialogs when we are the UAS.

2013-09-13 14:50:38 +00:00

res_pjsip_pubsub.exports.in

The large GULP->PJSIP renaming effort.

2013-07-30 18:14:50 +00:00

res_pjsip_refer.c

Multiple revisions 399887,400138,400178,400180-400181

2013-09-30 18:55:27 +00:00

res_pjsip_registrar_expire.c

The large GULP->PJSIP renaming effort.

2013-07-30 18:14:50 +00:00

res_pjsip_registrar.c

pjsip: race condition in registrar

2013-09-26 18:51:54 +00:00

res_pjsip_rfc3326.c

The large GULP->PJSIP renaming effort.

2013-07-30 18:14:50 +00:00

res_pjsip_sdp_rtp.c

Cache string values of formats on ast_format_cap() to save processing.

2013-10-03 14:58:16 +00:00

res_pjsip_session.c

Fix a race condition in res_pjsip_session with rapidly terminating the session.

2013-10-13 15:42:20 +00:00

res_pjsip_session.exports.in

The large GULP->PJSIP renaming effort.

2013-07-30 18:14:50 +00:00

res_pjsip_t38.c

Fix crashes in res_pjsip_sdp_rtp and res_pjsip_t38 when a stream is rejected and external_media_address is set.

2013-10-03 14:52:24 +00:00

res_pjsip_transport_websocket.c

The large GULP->PJSIP renaming effort.

2013-07-30 18:14:50 +00:00

res_pjsip.c

Clarify an ambiguous error message.

2013-11-08 19:22:53 +00:00

res_pjsip.exports.in

res_pjsip: crash when using localnet and external_signaling_address options

2013-09-27 18:28:41 +00:00

res_pktccops.c

Fix compilation on gcc 4.8.1

2013-07-30 13:46:16 +00:00

res_pktccops.exports.in

Allow symbol export filtering to work properly on platforms that have symbol prefixes.

2010-04-02 18:57:58 +00:00

res_realtime.c

Cleanup references to sipusers and sipfriends dynamic realtime families

2011-11-01 19:53:26 +00:00

res_rtp_asterisk.c

chan_sip: Fix RTCP port for SRFLX ICE candidates

2013-11-01 12:40:40 +00:00

res_rtp_multicast.c

res_rtp_multicast: Ensure SSRC is set properly

2013-10-03 18:32:59 +00:00

res_security_log.c

Multiple revisions 399887,400138,400178,400180-400181

2013-09-30 18:55:27 +00:00

res_smdi.c

Doxygen Updates - Title update

2012-10-14 21:44:27 +00:00

res_smdi.exports.in

Allow symbol export filtering to work properly on platforms that have symbol prefixes.

2010-04-02 18:57:58 +00:00

res_snmp.c

Doxygen Updates - Title update

2012-10-14 21:44:27 +00:00

res_sorcery_astdb.c

Address JSON thread safety issues.

2013-08-02 14:27:35 +00:00

res_sorcery_config.c

Merge the pimp_my_sip branch into trunk.

2013-04-25 18:25:31 +00:00

res_sorcery_memory.c

Pass the sorcery instance to wizards for CUD operations as well as retrieve.

2013-03-20 14:52:23 +00:00

res_sorcery_realtime.c

Add support for a realtime sorcery module.

2013-04-27 12:01:29 +00:00

res_speech.c

Add support for retrieving engine specific settings using the speech API and from dialplan.

2012-10-01 12:29:04 +00:00

res_speech.exports.in

app_speech_utils: Fix unresolved symbol ast_speech_get_setting().

2013-09-16 18:00:32 +00:00

res_srtp.c

Use srtp_shutdown when available

2013-05-15 12:42:04 +00:00

res_srtp.exports.in

Add SRTP support for Asterisk

2010-06-08 05:29:08 +00:00

res_stasis_answer.c

Fix menuselect display for stasis modules.

2013-06-24 21:40:52 +00:00

res_stasis_answer.exports.in

Add missing exports file

2013-05-20 14:21:39 +00:00

res_stasis_playback.c

res_ari_channels: Add ring operation, dtmf operation, hangup reasons, and tweak early media.

2013-11-01 14:38:21 +00:00

res_stasis_playback.exports.in

This patch implements the REST API's for POST /channels/{channelId}/play

2013-05-23 20:11:35 +00:00

res_stasis_recording.c

ARI recordings: Issue HTTP failures for recording requests with file conflicts

2013-10-25 21:28:32 +00:00

res_stasis_recording.exports.in

ARI - channel recording support

2013-07-03 17:58:45 +00:00

res_stasis_test.c

Multiple revisions 399887,400138,400178,400180-400181

2013-09-30 18:55:27 +00:00

res_stasis_test.exports.in

Initial support for endpoints.

2013-05-08 13:39:08 +00:00

res_stasis.c

res_stasis.c: Fix locking issues with the app_bridge_moh container.

2013-11-08 20:37:08 +00:00

res_stasis.exports.in

Moved core logic from app_stasis to res_stasis

2013-04-15 16:43:47 +00:00

res_statsd.c

Rename everything Stasis-HTTP to ARI

2013-07-27 23:11:02 +00:00

res_statsd.exports.in

Example of how to use the Stasis message bus

2013-04-26 20:05:15 +00:00

res_stun_monitor.c

Move channel driver Registry manager events to core.

2013-07-08 14:42:57 +00:00

res_timing_dahdi.c

Refactor ast_timer_ack to return an error and handle the error in timer users

2012-11-05 23:10:14 +00:00

res_timing_kqueue.c

Refactor ast_timer_ack to return an error and handle the error in timer users

2012-11-05 23:10:14 +00:00

res_timing_pthread.c

Prevent res_timing_pthread from blocking callers

2013-04-19 22:27:08 +00:00

res_timing_timerfd.c

Refactor ast_timer_ack to return an error and handle the error in timer users

2012-11-05 23:10:14 +00:00

res_xmpp.c

Reduce log level of a non-pubsub error message

2013-10-17 15:41:22 +00:00

res_xmpp.exports.in

Add a new unified Jingle, Google Jingle, and Google Talk channel driver written from scratch called chan_motif.

2012-07-07 17:06:51 +00:00