Richard Mudgett 9cd8a1df79 res_rtp_asterisk.c: Fix TURN deadlock by using ICE session group lock. ...

When a message is received on the TURN socket, the code processing the
message needs to call into the ICE/STUN session for further processing.
This code path locks the TURN group lock then the ICE/STUN group lock.  In
another thread an ICE/STUN timer can fire off to send a keep alive message
over the TURN socket.  In this code path, the ICE/STUN group lock is
obtained then the TURN group lock is obtained to send the packet.  A
classic deadlock case if the group locks are not the same.

* Made TURN get created using the ICE/STUN session's group lock.

NOTE: I was originally concerned that the ICE/STUN session can get
recreated by ice_reset_session() for an event like RTCP multiplexing
causing a change during SDP negotiation.  In this case the TURN group lock
would become different.  However, TURN is also recreated as part of the
ICE/STUN recreation in ice_create() when all known ICE candidates are
added to the new ICE session.  While the ICE/STUN and TURN sessions are
being recreated there is a period where the group locks could be
different.

ASTERISK-27023 #close
Patches:
    res_rtp_asterisk-turn-deadlock-fix.patch (license #6502)
        patch uploaded by Michael Walton (modified)

Change-Id: Ic870edb99ce4988a8c8eb6e678ca7f19da1432b9

2017-07-06 16:14:48 -05:00

..

ael

core/pbx: dialplan show - display filename/line#

2017-01-04 14:06:20 -06:00

ari

make ari-stubs so doc periodic jobs can run

2017-04-16 18:59:54 -06:00

parking

core/pbx: dialplan show - display filename/line#

2017-01-04 14:06:20 -06:00

res_pjsip

Merge "pjsip_distributor.c: Fix deadlock with TCP type transports."

2017-07-05 16:08:46 -05:00

snmp

Remove ASTERISK_REGISTER_FILE.

2016-10-27 09:53:55 -04:00

srtp

res_srtp: Add support for libsrtp2

2017-05-26 12:15:42 -04:00

stasis

Merge "ari: Implement 'debug all' and request/response logging"

2017-01-26 17:06:40 -06:00

stasis_recording

stasis_recording: Correct ast_asprintf error checking

2017-05-30 16:09:50 -05:00

ari.make

…

Makefile

…

res_adsi.c

Remove ASTERISK_REGISTER_FILE.

2016-10-27 09:53:55 -04:00

res_ael_share.c

Remove ASTERISK_REGISTER_FILE.

2016-10-27 09:53:55 -04:00

res_ael_share.exports.in

…

res_agi.c

Merge "asterisk: Audit locking of channel when manipulating flags."

2017-05-26 09:25:51 -05:00

res_agi.exports.in

…

res_ari_applications.c

res_ari: Add "module loaded" check to ari stubs

2017-06-15 19:34:03 -05:00

res_ari_asterisk.c

res_ari: Add "module loaded" check to ari stubs

2017-06-15 19:34:03 -05:00

res_ari_bridges.c

res_ari: Add "module loaded" check to ari stubs

2017-06-15 19:34:03 -05:00

res_ari_channels.c

res_ari: Add "module loaded" check to ari stubs

2017-06-15 19:34:03 -05:00

res_ari_device_states.c

res_ari: Add "module loaded" check to ari stubs

2017-06-15 19:34:03 -05:00

res_ari_endpoints.c

res_ari: Add "module loaded" check to ari stubs

2017-06-15 19:34:03 -05:00

res_ari_events.c

res_ari: Add "module loaded" check to ari stubs

2017-06-15 19:34:03 -05:00

res_ari_mailboxes.c

res_ari: Add "module loaded" check to ari stubs

2017-06-15 19:34:03 -05:00

res_ari_model.c

modules: change module LOAD_FAILUREs to LOAD_DECLINES

2017-04-12 15:57:21 -06:00

res_ari_model.exports.in

…

res_ari_playbacks.c

res_ari: Add "module loaded" check to ari stubs

2017-06-15 19:34:03 -05:00

res_ari_recordings.c

res_ari: Add "module loaded" check to ari stubs

2017-06-15 19:34:03 -05:00

res_ari_sounds.c

res_ari: Add "module loaded" check to ari stubs

2017-06-15 19:34:03 -05:00

res_ari.c

modules: change module LOAD_FAILUREs to LOAD_DECLINES

2017-04-12 15:57:21 -06:00

res_ari.exports.in

…

res_calendar_caldav.c

res_calendar_caldav: Add support reading gmail calendar

2016-11-29 13:35:26 -02:00

res_calendar_ews.c

Remove ASTERISK_REGISTER_FILE.

2016-10-27 09:53:55 -04:00

res_calendar_exchange.c

Remove ASTERISK_REGISTER_FILE.

2016-10-27 09:53:55 -04:00

res_calendar_icalendar.c

Remove ASTERISK_REGISTER_FILE.

2016-10-27 09:53:55 -04:00

res_calendar.c

modules: change module LOAD_FAILUREs to LOAD_DECLINES

2017-04-12 15:57:21 -06:00

res_calendar.exports.in

…

res_chan_stats.c

modules: change module LOAD_FAILUREs to LOAD_DECLINES

2017-04-12 15:57:21 -06:00

res_clialiases.c

Remove ASTERISK_REGISTER_FILE.

2016-10-27 09:53:55 -04:00

res_clioriginate.c

manager: Restore Originate failure behavior from Asterisk 11

2017-02-10 18:04:41 -05:00

res_config_curl.c

realtime: Centralize some common realtime backend code

2017-02-21 10:53:17 -06:00

res_config_ldap.c

res_config_ldap: Various code improvements

2017-02-22 17:37:52 -06:00

res_config_odbc.c

realtime: Centralize some common realtime backend code

2017-02-21 10:53:17 -06:00

res_config_pgsql.c

res_config_pgsql: Make 'require' return consistent with other backends

2017-03-01 07:27:50 -06:00

res_config_sqlite3.c

Sqlite3: make busy_timeout configurable.

2017-05-25 10:02:42 +02:00

res_config_sqlite.c

modules: change module LOAD_FAILUREs to LOAD_DECLINES

2017-04-12 15:57:21 -06:00

res_convert.c

Remove ASTERISK_REGISTER_FILE.

2016-10-27 09:53:55 -04:00

res_corosync.c

res_corosync: Change thread stack size

2017-06-16 07:53:22 -05:00

res_crypto.c

Remove ASTERISK_REGISTER_FILE.

2016-10-27 09:53:55 -04:00

res_crypto.exports.in

…

res_curl.c

Remove ASTERISK_REGISTER_FILE.

2016-10-27 09:53:55 -04:00

res_endpoint_stats.c

modules: change module LOAD_FAILUREs to LOAD_DECLINES

2017-04-12 15:57:21 -06:00

res_fax_spandsp.c

Remove ASTERISK_REGISTER_FILE.

2016-10-27 09:53:55 -04:00

res_fax.c

Remove ASTERISK_REGISTER_FILE.

2016-10-27 09:53:55 -04:00

res_fax.exports.in

…

res_format_attr_celt.c

Remove ASTERISK_REGISTER_FILE.

2016-10-27 09:53:55 -04:00

res_format_attr_g729.c

Remove ASTERISK_REGISTER_FILE.

2016-10-27 09:53:55 -04:00

res_format_attr_h263.c

res_format_attr_h26x: Trim blanks in fmtp attributes

2017-05-23 10:57:57 -05:00

res_format_attr_h264.c

res_format_attr_h26x: Trim blanks in fmtp attributes

2017-05-23 10:57:57 -05:00

res_format_attr_ilbc.c

…

res_format_attr_opus.c

res_format_attr_opus: Fix crash when fmtp contains spaces.

2016-12-08 11:47:30 +00:00

res_format_attr_silk.c

Remove ASTERISK_REGISTER_FILE.

2016-10-27 09:53:55 -04:00

res_format_attr_siren7.c

Remove ASTERISK_REGISTER_FILE.

2016-10-27 09:53:55 -04:00

res_format_attr_siren14.c

Remove ASTERISK_REGISTER_FILE.

2016-10-27 09:53:55 -04:00

res_format_attr_vp8.c

Remove ASTERISK_REGISTER_FILE.

2016-10-27 09:53:55 -04:00

res_hep_pjsip.c

res_hep: Capture actual transport type in use

2017-03-21 13:40:29 -06:00

res_hep_rtcp.c

res_hep_rtcp: Add support level to module info

2017-05-18 16:36:21 -05:00

res_hep.c

res_hep: Add additional config initialization and validation

2017-04-24 13:22:48 -05:00

res_hep.exports.in

…

res_http_media_cache.c

modules: change module LOAD_FAILUREs to LOAD_DECLINES (14)

2017-04-12 15:57:39 -06:00

res_http_post.c

Implement internal abstraction for iostreams

2016-11-15 22:25:14 +02:00

res_http_websocket.c

modules: change module LOAD_FAILUREs to LOAD_DECLINES

2017-04-12 15:57:21 -06:00

res_http_websocket.exports.in

…

res_limit.c

modules: change module LOAD_FAILUREs to LOAD_DECLINES

2017-04-12 15:57:21 -06:00

res_manager_devicestate.c

…

res_manager_presencestate.c

…

res_monitor.c

Remove ASTERISK_REGISTER_FILE.

2016-10-27 09:53:55 -04:00

res_monitor.exports.in

…

res_musiconhold.c

asterisk: Audit locking of channel when manipulating flags.

2017-05-16 14:25:23 +00:00

res_mutestream.c

Remove ASTERISK_REGISTER_FILE.

2016-10-27 09:53:55 -04:00

res_mwi_external_ami.c

Remove ASTERISK_REGISTER_FILE.

2016-10-27 09:53:55 -04:00

res_mwi_external.c

Remove ASTERISK_REGISTER_FILE.

2016-10-27 09:53:55 -04:00

res_mwi_external.exports.in

…

res_odbc_transaction.c

res_odbc_transaction: add dep on generic_odbc

2016-08-21 18:56:01 -05:00

res_odbc_transaction.exports.in

…

res_odbc.c

Remove ASTERISK_REGISTER_FILE.

2016-10-27 09:53:55 -04:00

res_odbc.exports.in

…

res_parking.c

core/pbx: dialplan show - display filename/line#

2017-01-04 14:06:20 -06:00

res_phoneprov.c

Implement internal abstraction for iostreams

2016-11-15 22:25:14 +02:00

res_phoneprov.exports.in

…

res_pjproject.c

PJPROJECT logging: Fix detection of max supported log level.

2017-01-24 11:25:19 -06:00

res_pjproject.exports.in

…

res_pjsip_acl.c

…

res_pjsip_authenticator_digest.c

res_pjsip_authenticator_digest.c: Fix sorcery's immutable contract violation.

2017-02-20 22:24:31 -06:00

res_pjsip_caller_id.c

res_pjsip/res_pjsip_callerid: NULL check on caller id name string

2017-04-26 15:32:11 -05:00

res_pjsip_config_wizard.c

res_pjsip_config_wizard: Add 2 new parameters to help with proxy config

2017-03-28 15:51:21 -06:00

res_pjsip_dialog_info_body_generator.c

res_pjsip: New endpoint option "notify_early_inuse_ringing"

2017-06-16 11:25:07 -05:00

res_pjsip_diversion.c

res_pjsip: Fix known compact header issues

2016-12-31 20:00:46 -06:00

res_pjsip_dlg_options.c

Remove ASTERISK_REGISTER_FILE.

2016-10-27 09:53:55 -04:00

res_pjsip_dtmf_info.c

…

res_pjsip_empty_info.c

Remove ASTERISK_REGISTER_FILE.

2016-10-27 09:53:55 -04:00

res_pjsip_endpoint_identifier_anonymous.c

…

res_pjsip_endpoint_identifier_ip.c

res_pjsip_endpoint_identifier_ip: Don't output error if no header_match.

2017-03-15 13:52:15 +00:00

res_pjsip_endpoint_identifier_user.c

res_pjsip: Add ignore_uri_user_options option.

2016-09-09 17:13:02 -05:00

res_pjsip_exten_state.c

res_pjsip_pubsub: Correctly implement persisted subscriptions

2017-02-15 13:11:46 -06:00

res_pjsip_exten_state.exports.in

…

res_pjsip_header_funcs.c

…

res_pjsip_history.c

pjproject_bundled: Update for pjproject 2.6

2017-02-23 16:23:53 -06:00

res_pjsip_logger.c

Remove ASTERISK_REGISTER_FILE.

2016-10-27 09:53:55 -04:00

res_pjsip_messaging.c

res_pjsip_messaging: Check URI type before dereferencing

2017-03-21 08:45:37 -06:00

res_pjsip_mwi_body_generator.c

…

res_pjsip_mwi.c

Merge "res_pjsip_mwi: update unsolicited MWI subscriptions on updating contact"

2017-06-22 16:01:52 -05:00

res_pjsip_nat.c

modules: change module LOAD_FAILUREs to LOAD_DECLINES

2017-04-12 15:57:21 -06:00

res_pjsip_notify.c

…

res_pjsip_one_touch_record_info.c

modules: change module LOAD_FAILUREs to LOAD_DECLINES

2017-04-12 15:57:21 -06:00

res_pjsip_outbound_authenticator_digest.c

res_pjsip_outbound_authenticator_digest: Add context to log messages

2017-04-28 11:04:57 -05:00

res_pjsip_outbound_publish.c

modules: change module LOAD_FAILUREs to LOAD_DECLINES

2017-04-12 15:57:21 -06:00

res_pjsip_outbound_publish.exports.in

…

res_pjsip_outbound_registration.c

modules: change module LOAD_FAILUREs to LOAD_DECLINES

2017-04-12 15:57:21 -06:00

res_pjsip_path.c

res_pjsip: Add ignore_uri_user_options option.

2016-09-09 17:13:02 -05:00

res_pjsip_phoneprov_provider.c

…

res_pjsip_pidf_body_generator.c

res_pjsip: New endpoint option "notify_early_inuse_ringing"

2017-06-16 11:25:07 -05:00

res_pjsip_pidf_digium_body_supplement.c

…

res_pjsip_pidf_eyebeam_body_supplement.c

res_pjsip: New endpoint option "notify_early_inuse_ringing"

2017-06-16 11:25:07 -05:00

res_pjsip_publish_asterisk.c

pjsip: Add Alembic for PUBLISH support.

2017-04-07 08:44:49 -05:00

res_pjsip_pubsub.c

res_pjsip_pubsub: Fix reference to released endpoint

2017-06-14 11:16:54 -05:00

res_pjsip_pubsub.exports.in

…

res_pjsip_refer.c

res_pjsip_refer/session: Calls dropped during transfer

2017-06-13 14:28:21 -05:00

res_pjsip_registrar_expire.c

res_pjsip_registrar_expire.c: Remove extra linefeed in debug message.

2016-11-10 16:59:41 -05:00

res_pjsip_registrar.c

Revert "Update qualifies when AOR configuration changes."

2017-02-08 11:54:39 -06:00

res_pjsip_rfc3326.c

…

res_pjsip_sdp_rtp.c

res_pjsip: Add DTMF INFO Failback mode

2017-06-29 07:57:01 -06:00

res_pjsip_send_to_voicemail.c

modules: change module LOAD_FAILUREs to LOAD_DECLINES

2017-04-12 15:57:21 -06:00

res_pjsip_session.c

chan_pjsip: Add support for multiple streams of the same type.

2017-06-28 18:36:29 +00:00

res_pjsip_session.exports.in

chan_pjsip: Add support for multiple streams of the same type.

2017-06-28 18:36:29 +00:00

res_pjsip_sips_contact.c

…

res_pjsip_t38.c

chan_pjsip: Add support for multiple streams of the same type.

2017-06-28 18:36:29 +00:00

res_pjsip_transport_management.c

res_pjsip_transport_management: Convert time in log message to seconds.

2016-09-14 09:53:33 -05:00

res_pjsip_transport_websocket.c

res_pjsip_transport_websocket: Add NULL check in get_write_timeout

2017-06-09 09:55:44 -05:00

res_pjsip_xpidf_body_generator.c

res_pjsip: New endpoint option "notify_early_inuse_ringing"

2017-06-16 11:25:07 -05:00

res_pjsip.c

Merge "chan_pjsip: Fix ability to send UPDATE on COLP"

2017-07-05 14:17:23 -05:00

res_pjsip.exports.in

…

res_pktccops.c

Remove ASTERISK_REGISTER_FILE.

2016-10-27 09:53:55 -04:00

res_pktccops.exports.in

…

res_realtime.c

Remove ASTERISK_REGISTER_FILE.

2016-10-27 09:53:55 -04:00

res_resolver_unbound.c

res_resolver_unbound.c: Fix frequent ref leak caught by excessive ref trap.

2017-02-01 17:33:41 -06:00

res_rtp_asterisk.c

res_rtp_asterisk.c: Fix TURN deadlock by using ICE session group lock.

2017-07-06 16:14:48 -05:00

res_rtp_multicast.c

res_rtp_multicast: Use consistent timestamps when possible

2017-06-06 10:55:04 -05:00

res_rtp_multicast.exports.in

…

res_sdp_translator_pjmedia.c

res_sdp_translator_pjmedia.c: Add TODO notes.

2017-04-27 19:08:05 -05:00

res_security_log.c

Remove ASTERISK_REGISTER_FILE.

2016-10-27 09:53:55 -04:00

res_smdi.c

modules: change module LOAD_FAILUREs to LOAD_DECLINES

2017-04-12 15:57:21 -06:00

res_smdi.exports.in

…

res_snmp.c

Remove ASTERISK_REGISTER_FILE.

2016-10-27 09:53:55 -04:00

res_sorcery_astdb.c

Remove ASTERISK_REGISTER_FILE.

2016-10-27 09:53:55 -04:00

res_sorcery_config.c

Remove ASTERISK_REGISTER_FILE.

2016-10-27 09:53:55 -04:00

res_sorcery_memory_cache.c

cli: Fix various CLI documentation and completion issues

2017-02-13 11:33:15 -05:00

res_sorcery_memory.c

Remove ASTERISK_REGISTER_FILE.

2016-10-27 09:53:55 -04:00

res_sorcery_realtime.c

Remove ASTERISK_REGISTER_FILE.

2016-10-27 09:53:55 -04:00

res_speech.c

Remove ASTERISK_REGISTER_FILE.

2016-10-27 09:53:55 -04:00

res_speech.exports.in

…

res_srtp.c

res_srtp: Add support for libsrtp2

2017-05-26 12:15:42 -04:00

res_srtp.exports.in

…

res_stasis_answer.c

Remove ASTERISK_REGISTER_FILE.

2016-10-27 09:53:55 -04:00

res_stasis_answer.exports.in

…

res_stasis_device_state.c

modules: change module LOAD_FAILUREs to LOAD_DECLINES

2017-04-12 15:57:21 -06:00

res_stasis_device_state.exports.in

…

res_stasis_mailbox.c

Remove ASTERISK_REGISTER_FILE.

2016-10-27 09:53:55 -04:00

res_stasis_mailbox.exports.in

…

res_stasis_playback.c

modules: change module LOAD_FAILUREs to LOAD_DECLINES

2017-04-12 15:57:21 -06:00

res_stasis_playback.exports.in

…

res_stasis_recording.c

modules: change module LOAD_FAILUREs to LOAD_DECLINES

2017-04-12 15:57:21 -06:00

res_stasis_recording.exports.in

…

res_stasis_snoop.c

Remove ASTERISK_REGISTER_FILE.

2016-10-27 09:53:55 -04:00

res_stasis_snoop.exports.in

…

res_stasis_test.c

modules: change module LOAD_FAILUREs to LOAD_DECLINES

2017-04-12 15:57:21 -06:00

res_stasis_test.exports.in

…

res_stasis.c

res_stasis: Plug reference leak on stolen channels

2017-06-16 15:08:45 -05:00

res_stasis.exports.in

…

res_statsd.c

modules: change module LOAD_FAILUREs to LOAD_DECLINES

2017-04-12 15:57:21 -06:00

res_statsd.exports.in

…

res_stun_monitor.c

res_stun_monitor: Don't fail to load if DNS resolution fails

2017-04-14 16:55:03 -05:00

res_timing_dahdi.c

Remove ASTERISK_REGISTER_FILE.

2016-10-27 09:53:55 -04:00

res_timing_kqueue.c

…

res_timing_pthread.c

Remove ASTERISK_REGISTER_FILE.

2016-10-27 09:53:55 -04:00

res_timing_timerfd.c

…

res_xmpp.c

Merge "res_xmpp: Fix ref counting issue"

2017-03-29 06:57:49 -05:00

res_xmpp.exports.in

…

res.xml

build_tools: Add ability to download variants to download_externals

2016-09-25 13:40:23 -05:00