Richard Mudgett a63f7ad04a translate.c: Only select audio codecs to determine the best translation choice. ...

Given a source capability of h264 and ulaw, a destination capability of
h264 and g722 then ast_translator_best_choice() would pick h264 as the
best choice even though h264 is a video codec and Asterisk only supports
translation of audio codecs.  When the audio starts flowing, there are
warnings about a codec mismatch when the channel tries to write a frame to
the peer.

* Made ast_translator_best_choice() only select audio codecs.

* Restore a check in channel.c:set_format() lost after v1.8 to prevent
trying to set a non-audio codec.

This is an intermediate patch for a series of patches aimed at improving
translation path choices for ASTERISK-24841.

This patch is a complete enough fix for ASTERISK-21777 as the v11 version
of ast_translator_best_choice() does the same thing.  However, chan_sip.c
still somehow tries to call ast_codec_choose() which then calls
ast_best_codec() with a capability set that doesn't contain any audio
formats for the incoming call.  The remaining warning message seems to be
a benign transient.

ASTERISK-21777 #close
Reported by: Nick Ruggles

ASTERISK-24380 #close
Reported by: Matt Jordan

Review: https://reviewboard.asterisk.org/r/4605/
........

Merged revisions 434614 from http://svn.asterisk.org/svn/asterisk/branches/11


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/13@434615 65c4cc65-6c06-0410-ace0-fbb531ad65f3

2015-04-10 16:28:50 +00:00

..

editline

clang compiler warnings: Fix a variety of "unused" warnings

2015-03-28 12:56:12 +00:00

stdtime

main/stdtime/localtime: Fix warning introduced in r433720

2015-03-30 02:29:10 +00:00

abstract_jb.c

func_jitterbuffer: fix frame leaks.

2014-11-02 07:39:36 +00:00

acl.c

Fix error with mixed address family ACLs.

2014-11-20 16:36:54 +00:00

adsi.c

Allow Asterisk to compile under GCC 4.10

2014-05-09 22:49:26 +00:00

alaw.c

…

aoc.c

Replace most uses of ast_register_atexit with ast_register_cleanup.

2015-03-26 22:19:21 +00:00

app.c

clang compiler warnings: Fix autological comparisons

2015-04-09 12:56:30 +00:00

ast_expr2.c

…

ast_expr2.fl

…

ast_expr2.h

…

ast_expr2.y

…

ast_expr2f.c

Doxygen Updates - janitor work

2012-09-21 17:14:59 +00:00

asterisk.c

loader/main: Don't set ast_fully_booted until deferred reloads are processed

2015-04-09 22:31:58 +00:00

asterisk.dynamics

Fix error loading res_monitor.

2014-04-23 15:02:39 +00:00

asterisk.exports.in

Add _IO_stdin_used in version-script to fix SIGBUSes on Sparc.

2013-08-22 08:26:55 +00:00

astfd.c

Replace most uses of ast_register_atexit with ast_register_cleanup.

2015-03-26 22:19:21 +00:00

astmm.c

Replace most uses of ast_register_atexit with ast_register_cleanup.

2015-03-26 22:19:21 +00:00

astobj2_container_private.h

astobj2: Additional refactoring to push impl specific code down into the impls.

2014-06-20 15:27:43 +00:00

astobj2_container.c

Replace most uses of ast_register_atexit with ast_register_cleanup.

2015-03-26 22:19:21 +00:00

astobj2_hash.c

astobj2: Additional refactoring to push impl specific code down into the impls.

2014-06-20 15:27:43 +00:00

astobj2_private.h

astobj2: Additional refactoring to push impl specific code down into the impls.

2014-06-20 15:27:43 +00:00

astobj2_rbtree.c

astobj2: Additional refactoring to push impl specific code down into the impls.

2014-06-20 15:27:43 +00:00

astobj2.c

Improved and portable ast_log recursion avoidance

2015-03-27 07:09:26 +00:00

audiohook.c

main/audiohook: Update internal sample rate on reads

2015-03-12 12:58:11 +00:00

autochan.c

…

autoservice.c

autoservice: stop thread on graceful shutdown

2014-06-09 03:50:45 +00:00

backtrace.c

Fix memory corruption when trying to get "core show locks".

2013-08-23 18:07:40 +00:00

bridge_after.c

Fix some memory leaks.

2015-01-30 16:47:50 +00:00

bridge_basic.c

bridge: avoid leaking channel during blond transfer pt2

2015-01-05 22:49:40 +00:00

bridge_channel.c

ARI: Add the ability to intercept hold and raise an event

2015-04-07 15:21:17 +00:00

bridge_roles.c

ARI: bridges/{bridgeID}/addChannel: add roles parameter

2013-08-05 16:59:13 +00:00

bridge.c

Bridging: Eliminate the unnecessary make channel compatible with bridge operation.

2015-04-08 18:14:00 +00:00

bucket.c

A couple minor cleanup tweaks.

2015-03-25 18:37:04 +00:00

buildinfo.c

…

callerid.c

CallerID: Fix parsing regression

2014-10-10 13:01:41 +00:00

ccss.c

build: Fixes for gcc 5 compilation

2015-04-06 19:02:23 +00:00

cdr.c

Fix compilations errors on 64-bit OpenBSD systems

2015-03-22 23:58:23 +00:00

cel.c

clang compiler warnings: Fix autological comparisons

2015-04-09 12:56:30 +00:00

channel_internal_api.c

Stasis: Fix StasisStart/End order and missing events

2014-12-08 15:43:14 +00:00

channel.c

translate.c: Only select audio codecs to determine the best translation choice.

2015-04-10 16:28:50 +00:00

chanvars.c

res_phoneprov: Refactor phoneprov to allow pluggable config providers

2014-10-09 17:45:23 +00:00

cli.c

Replace most uses of ast_register_atexit with ast_register_cleanup.

2015-03-26 22:19:21 +00:00

codec_builtin.c

Various: bugfixes found via chaos

2015-03-17 22:15:09 +00:00

codec.c

Replace most uses of ast_register_atexit with ast_register_cleanup.

2015-03-26 22:19:21 +00:00

config_options.c

Replace most uses of ast_register_atexit with ast_register_cleanup.

2015-03-26 22:19:21 +00:00

config.c

clang compiler warnings: Fix -Wunused-function; make inline function static

2015-03-28 12:19:53 +00:00

core_local.c

Fix compile errors caused by r4500 / r4501.

2015-03-26 23:07:15 +00:00

core_unreal.c

AMI: Add missing VarSet events when a channel inherits variables.

2014-10-17 02:41:34 +00:00

crypt.c

Fix utils directory breakage.

2013-07-04 13:06:15 +00:00

cygload.c

…

data.c

Replace most uses of ast_register_atexit with ast_register_cleanup.

2015-03-26 22:19:21 +00:00

datastore.c

This is no longer needed.

2013-06-29 00:18:57 +00:00

db.c

AMI: Make AMI actions that generate event lists consistent.

2015-01-09 17:54:49 +00:00

devicestate.c

devicestate.c: Minor tweaks

2014-09-05 17:36:35 +00:00

dial.c

Dial API: add self destruct option when complete

2015-02-26 18:52:56 +00:00

dns.c

Clean up files that do not end with newlines

2014-08-21 14:52:06 +00:00

dnsmgr.c

Replace most uses of ast_register_atexit with ast_register_cleanup.

2015-03-26 22:19:21 +00:00

dsp.c

build: Fixes for gcc 5 compilation

2015-04-06 19:02:23 +00:00

ecdisa.h

…

endpoints.c

Various: bugfixes found via chaos

2015-03-17 22:15:09 +00:00

enum.c

clang compiler warnings: Fix autological comparisons

2015-04-09 12:56:30 +00:00

event.c

clang compiler warnings: Fix autological comparisons

2015-04-09 12:56:30 +00:00

features_config.c

Allow for transferer to retry when dialing an invalid extension.

2014-11-17 16:51:16 +00:00

features.c

clang compiler warnings: Fix a variety of "unused" warnings

2015-03-28 12:56:12 +00:00

file.c

Replace most uses of ast_register_atexit with ast_register_cleanup.

2015-03-26 22:19:21 +00:00

fixedjitterbuf.c

…

fixedjitterbuf.h

…

format_cache.c

format_cache.c: Add missing slin12 format to ast_format_cache_is_slinear().

2015-04-08 16:23:00 +00:00

format_cap.c

main/frame: Don't report empty disallow values as an error

2015-03-14 02:28:56 +00:00

format_compatibility.c

chan_iax2: Several media format fixes.

2014-08-07 18:51:16 +00:00

format.c

Ensure that a non-zero sample rate is returned for all formats.

2015-04-06 16:02:09 +00:00

frame.c

media formats: re-architect handling of media for performance improvements

2014-07-20 22:06:33 +00:00

framehook.c

clang compiler warnings: Fix format specified in framehook

2015-04-06 17:52:13 +00:00

fskmodem_float.c

…

fskmodem_int.c

…

fskmodem.c

…

global_datastores.c

…

hashtab.c

Improved and portable ast_log recursion avoidance

2015-03-27 07:09:26 +00:00

heap.c

Fix incorrect usages of ast_realloc().

2013-09-10 18:05:47 +00:00

http.c

Replace most uses of ast_register_atexit with ast_register_cleanup.

2015-03-26 22:19:21 +00:00

image.c

Replace most uses of ast_register_atexit with ast_register_cleanup.

2015-03-26 22:19:21 +00:00

indications.c

clang compiler warnings: Fix autological comparisons

2015-04-09 12:56:30 +00:00

io.c

Allow Asterisk to compile under GCC 4.10

2014-05-09 22:49:26 +00:00

jitterbuf.c

clang compiler warnings: Fix -Wabsolute-value warnings

2015-03-30 02:44:57 +00:00

json.c

ARI: Fix crash if integer values used in JSON payload 'variables' object.

2015-02-27 18:23:22 +00:00

libasteriskssl.c

Resolve memory leaks in TLS initialization and TLS client connections

2012-09-14 19:53:43 +00:00

libasteriskssl.exports.in

…

loader.c

loader/main: Don't set ast_fully_booted until deferred reloads are processed

2015-04-09 22:31:58 +00:00

lock.c

DEBUG_THREADS: Fix regression and lock tracking initialization problems.

2014-12-12 23:40:50 +00:00

logger.c

Improved and portable ast_log recursion avoidance

2015-03-27 07:09:26 +00:00

Makefile

Fix an ABI compatibility issue with ast_log_safe for modules.

2015-03-30 11:42:00 +00:00

manager_bridges.c

Replace most uses of ast_register_atexit with ast_register_cleanup.

2015-03-26 22:19:21 +00:00

manager_channels.c

ARI: Add the ability to intercept hold and raise an event

2015-04-07 15:21:17 +00:00

manager_endpoints.c

Replace most uses of ast_register_atexit with ast_register_cleanup.

2015-03-26 22:19:21 +00:00

manager_mwi.c

Replace most uses of ast_register_atexit with ast_register_cleanup.

2015-03-26 22:19:21 +00:00

manager_system.c

Replace most uses of ast_register_atexit with ast_register_cleanup.

2015-03-26 22:19:21 +00:00

manager.c

build: Fixes for gcc 5 compilation

2015-04-06 19:02:23 +00:00

md5.c

…

media_index.c

media formats: re-architect handling of media for performance improvements

2014-07-20 22:06:33 +00:00

message.c

Replace most uses of ast_register_atexit with ast_register_cleanup.

2015-03-26 22:19:21 +00:00

mixmonitor.c

Removed quotes from svn:keywords props on a few files.

2013-07-29 17:51:25 +00:00

named_acl.c

acl: Fix reloading of configuration if configuration file does not exist at startup.

2014-12-20 20:57:19 +00:00

netsock2.c

Audit ast_sockaddr_resolve() usage for memory leaks.

2015-03-17 21:49:30 +00:00

netsock.c

Move eid functions to utils.c, mark netsock.h deprecated

2014-06-24 02:50:15 +00:00

optional_api.c

Logger/CLI/etc.: Fix some aesthetic issues; reduce chatty verbose messages

2014-05-28 22:54:12 +00:00

parking.c

res_pjsip_refer: Fix bugs involving Parking/PJSIP/transfers

2014-05-22 15:52:30 +00:00

pbx.c

Replace most uses of ast_register_atexit with ast_register_cleanup.

2015-03-26 22:19:21 +00:00

pickup.c

Replace most uses of ast_register_atexit with ast_register_cleanup.

2015-03-26 22:19:21 +00:00

plc.c

…

poll.c

…

presencestate.c

clang compiler warnings: Fix autological comparisons

2015-04-09 12:56:30 +00:00

privacy.c

…

rtp_engine.c

Replace most uses of ast_register_atexit with ast_register_cleanup.

2015-03-26 22:19:21 +00:00

say.c

app_voicemail, say: Add support for Japanese Language

2014-06-30 04:00:19 +00:00

sched.c

Create work around for scheduler leaks during shutdown.

2015-02-19 02:01:34 +00:00

sdp_srtp.c

channels/sip/sdp_crypto: Handle SRTP keys negotiated with key lifetime/MKI

2015-02-25 21:42:04 +00:00

security_events.c

clang compiler warnings: Fix autological comparisons

2015-04-09 12:56:30 +00:00

sem.c

Various fixes for OS X

2015-01-26 14:49:32 +00:00

sha1.c

Doxygen Updates - janitor work

2012-09-21 17:14:59 +00:00

sip_api.c

Don't make chan_sip export global symbols.

2012-10-11 15:49:02 +00:00

slinfactory.c

media formats: re-architect handling of media for performance improvements

2014-07-20 22:06:33 +00:00

smoother.c

media formats: re-architect handling of media for performance improvements

2014-07-20 22:06:33 +00:00

sorcery.c

Replace most uses of ast_register_atexit with ast_register_cleanup.

2015-03-26 22:19:21 +00:00

sounds_index.c

Replace most uses of ast_register_atexit with ast_register_cleanup.

2015-03-26 22:19:21 +00:00

srv.c

Removed #if checks for crazy old versions of OS X.

2013-05-08 20:25:28 +00:00

stasis_bridges.c

core: Don't create snapshots with locks.

2015-03-10 23:09:17 +00:00

stasis_cache_pattern.c

stasis: use ao2_t_alloc for certain object allocators

2014-07-18 19:55:24 +00:00

stasis_cache.c

main/stasis: Allow subscriptions to use a threadpool for message delivery

2014-12-01 17:57:12 +00:00

stasis_channels.c

ARI: Add the ability to intercept hold and raise an event

2015-04-07 15:21:17 +00:00

stasis_endpoints.c

Stasis: Allow message types to be blocked

2014-08-06 12:55:28 +00:00

stasis_message_router.c

res_pjsip: make it unloadable (take 2)

2015-01-27 19:08:44 +00:00

stasis_message.c

Stasis: Allow message types to be blocked

2014-08-06 12:55:28 +00:00

stasis_system.c

Stasis: Allow message types to be blocked

2014-08-06 12:55:28 +00:00

stasis.c

Replace most uses of ast_register_atexit with ast_register_cleanup.

2015-03-26 22:19:21 +00:00

strcompat.c

Add builtin roundf() for systems lacking it.

2013-01-19 20:54:07 +00:00

strings.c

clang compiler warnings: Fix invalid enum conversion

2015-03-30 02:39:18 +00:00

stun.c

Replace most uses of ast_register_atexit with ast_register_cleanup.

2015-03-26 22:19:21 +00:00

syslog.c

main/syslog: Allow dynamic logs, such as security events, to log to the syslog

2015-01-12 18:01:24 +00:00

taskprocessor.c

Replace most uses of ast_register_atexit with ast_register_cleanup.

2015-03-26 22:19:21 +00:00

tcptls.c

Security/tcptls: MitM Attack potential from certificate with NULL byte in CN.

2015-04-08 16:40:25 +00:00

tdd.c

Doxygen Updates - janitor work

2012-09-21 17:14:59 +00:00

term.c

Revamp of terminal color codes

2013-02-14 18:47:56 +00:00

test.c

main/test: Fix compilation issue on 32-bit systems

2014-12-04 17:13:34 +00:00

threadpool.c

threadpool.c: Minor cleanup fixes.

2014-09-29 20:26:50 +00:00

threadstorage.c

Replace most uses of ast_register_atexit with ast_register_cleanup.

2015-03-26 22:19:21 +00:00

timing.c

Replace most uses of ast_register_atexit with ast_register_cleanup.

2015-03-26 22:19:21 +00:00

translate.c

translate.c: Only select audio codecs to determine the best translation choice.

2015-04-10 16:28:50 +00:00

udptl.c

clang compiler warnings: Fix autological comparisons

2015-04-09 12:56:30 +00:00

ulaw.c

…

uri.c

uri: Quiet warning about type qualifiers ignored on function return type

2014-08-21 14:39:27 +00:00

utils.c

Re-add _ast_mem_backtrace_buffer variable for ABI compatibility.

2015-03-31 11:47:14 +00:00

uuid.c

Fix printf problems with high ascii characters after r413586 (1.8).

2014-12-17 09:54:00 +00:00

xml.c

Detect and use xsltCleanupGlobals when available

2013-10-03 18:00:15 +00:00

xmldoc.c

Replace most uses of ast_register_atexit with ast_register_cleanup.

2015-03-26 22:19:21 +00:00