Richard Mudgett aa514f420b res_rtp_asterisk.c: Fix TURN deadlock by using ICE session group lock. ...

When a message is received on the TURN socket, the code processing the
message needs to call into the ICE/STUN session for further processing.
This code path locks the TURN group lock then the ICE/STUN group lock.  In
another thread an ICE/STUN timer can fire off to send a keep alive message
over the TURN socket.  In this code path, the ICE/STUN group lock is
obtained then the TURN group lock is obtained to send the packet.  A
classic deadlock case if the group locks are not the same.

* Made TURN get created using the ICE/STUN session's group lock.

NOTE: I was originally concerned that the ICE/STUN session can get
recreated by ice_reset_session() for an event like RTCP multiplexing
causing a change during SDP negotiation.  In this case the TURN group lock
would become different.  However, TURN is also recreated as part of the
ICE/STUN recreation in ice_create() when all known ICE candidates are
added to the new ICE session.  While the ICE/STUN and TURN sessions are
being recreated there is a period where the group locks could be
different.

ASTERISK-27023 #close
Patches:
    res_rtp_asterisk-turn-deadlock-fix.patch (license #6502)
        patch uploaded by Michael Walton (modified)

Change-Id: Ic870edb99ce4988a8c8eb6e678ca7f19da1432b9

2017-07-06 16:11:45 -05:00

..

ael

fix: memory leaks, resource leaks, out of bounds and bugs

2016-06-20 13:06:00 -04:00

ari

ari: Implement 'debug all' and request/response logging

2017-01-24 10:48:41 -07:00

parking

Merge "res_parking: Misc fixes." into 13

2016-03-29 08:53:45 -05:00

res_pjsip

Merge "pjsip_distributor.c: Fix deadlock with TCP type transports." into 13

2017-07-05 16:08:18 -05:00

snmp

CHANNEL(peer), chan_iax2, res_fax, SNMP agent: Fix deadlock from reaching across a bridge.

2015-01-20 16:46:16 +00:00

srtp

res_srtp: Add support for libsrtp2

2017-05-26 12:06:34 -04:00

stasis

Merge "ari: Implement 'debug all' and request/response logging" into 13

2017-01-27 07:01:21 -06:00

stasis_recording

stasis_recording: Correct ast_asprintf error checking

2017-05-30 17:07:56 -04:00

ari.make

ARI: Fix missing dependencies.

2015-04-29 07:39:22 -04:00

Makefile

core: Remove embedded module support

2017-03-27 10:36:23 -04:00

res_adsi.c

Add module support level to ast_module_info structure. Print it in CLI "module show" .

2014-07-25 16:47:17 +00:00

res_ael_share.c

Add module support level to ast_module_info structure. Print it in CLI "module show" .

2014-07-25 16:47:17 +00:00

res_ael_share.exports.in

…

res_agi.c

Merge "asterisk: Audit locking of channel when manipulating flags." into 13

2017-05-26 09:12:11 -05:00

res_agi.exports.in

…

res_ari_applications.c

res_ari: Add "module loaded" check to ari stubs

2017-06-15 18:31:53 -06:00

res_ari_asterisk.c

res_ari: Add "module loaded" check to ari stubs

2017-06-15 18:31:53 -06:00

res_ari_bridges.c

res_ari: Add "module loaded" check to ari stubs

2017-06-15 18:31:53 -06:00

res_ari_channels.c

res_ari: Add "module loaded" check to ari stubs

2017-06-15 18:31:53 -06:00

res_ari_device_states.c

res_ari: Add "module loaded" check to ari stubs

2017-06-15 18:31:53 -06:00

res_ari_endpoints.c

res_ari: Add "module loaded" check to ari stubs

2017-06-15 18:31:53 -06:00

res_ari_events.c

res_ari: Add "module loaded" check to ari stubs

2017-06-15 18:31:53 -06:00

res_ari_mailboxes.c

res_ari: Add "module loaded" check to ari stubs

2017-06-15 18:31:53 -06:00

res_ari_model.c

modules: change module LOAD_FAILUREs to LOAD_DECLINES

2017-04-12 16:46:22 -05:00

res_ari_model.exports.in

…

res_ari_playbacks.c

res_ari: Add "module loaded" check to ari stubs

2017-06-15 18:31:53 -06:00

res_ari_recordings.c

res_ari: Add "module loaded" check to ari stubs

2017-06-15 18:31:53 -06:00

res_ari_sounds.c

res_ari: Add "module loaded" check to ari stubs

2017-06-15 18:31:53 -06:00

res_ari.c

modules: change module LOAD_FAILUREs to LOAD_DECLINES

2017-04-12 16:46:22 -05:00

res_ari.exports.in

…

res_calendar_caldav.c

res_calendar_caldav: Add support reading gmail calendar

2016-11-30 14:16:10 -05:00

res_calendar_ews.c

res_calendar_ews: Relax neon version check to work with 0.30 too.

2014-10-12 07:44:32 +00:00

res_calendar_exchange.c

Add module support level to ast_module_info structure. Print it in CLI "module show" .

2014-07-25 16:47:17 +00:00

res_calendar_icalendar.c

Add module support level to ast_module_info structure. Print it in CLI "module show" .

2014-07-25 16:47:17 +00:00

res_calendar.c

modules: change module LOAD_FAILUREs to LOAD_DECLINES

2017-04-12 16:46:22 -05:00

res_calendar.exports.in

…

res_chan_stats.c

modules: change module LOAD_FAILUREs to LOAD_DECLINES

2017-04-12 16:46:22 -05:00

res_clialiases.c

Add module support level to ast_module_info structure. Print it in CLI "module show" .

2014-07-25 16:47:17 +00:00

res_clioriginate.c

manager: Restore Originate failure behavior from Asterisk 11

2017-02-10 18:01:54 -05:00

res_config_curl.c

realtime: Centralize some common realtime backend code

2017-02-21 11:50:56 -05:00

res_config_ldap.c

res_config_ldap: Various code improvements

2017-02-22 17:37:34 -06:00

res_config_odbc.c

realtime: Centralize some common realtime backend code

2017-02-21 11:50:56 -05:00

res_config_pgsql.c

res_config_pgsql: Make 'require' return consistent with other backends

2017-03-01 08:23:55 -05:00

res_config_sqlite3.c

modules: change module LOAD_FAILUREs to LOAD_DECLINES

2017-04-12 16:46:22 -05:00

res_config_sqlite.c

modules: change module LOAD_FAILUREs to LOAD_DECLINES

2017-04-12 16:46:22 -05:00

res_convert.c

…

res_corosync.c

res_corosync: Change thread stack size

2017-06-16 14:44:34 +02:00

res_crypto.c

res_crypto: Perform cleanup at shutdown.

2016-01-09 13:39:00 -06:00

res_crypto.exports.in

…

res_curl.c

Add module support level to ast_module_info structure. Print it in CLI "module show" .

2014-07-25 16:47:17 +00:00

res_endpoint_stats.c

modules: change module LOAD_FAILUREs to LOAD_DECLINES

2017-04-12 16:46:22 -05:00

res_fax_spandsp.c

res_fax: allow 2400 transmission rate according to v.27ter standard

2015-04-29 15:37:12 -05:00

res_fax.c

Audit ast_json_pack() calls for needed UTF-8 checks.

2016-10-13 18:11:37 -05:00

res_fax.exports.in

res_fax: Provide AMI equivalents for fax CLI commands

2014-07-18 15:49:46 +00:00

res_format_attr_celt.c

Add module support level to ast_module_info structure. Print it in CLI "module show" .

2014-07-25 16:47:17 +00:00

res_format_attr_g729.c

res_format_attr_g729: Add annexb=no format parameter to SDPs

2016-08-18 17:15:04 -05:00

res_format_attr_h263.c

res_format_attr_h26x: Trim blanks in fmtp attributes

2017-05-23 11:57:18 -04:00

res_format_attr_h264.c

res_format_attr_h26x: Trim blanks in fmtp attributes

2017-05-23 11:57:18 -04:00

res_format_attr_opus.c

res_format_attr_opus: Fix crash when fmtp contains spaces.

2016-12-08 11:46:30 +00:00

res_format_attr_silk.c

Update support for SILK format.

2016-07-14 15:54:21 -05:00

res_format_attr_siren7.c

siren: Add format attribute modules for Siren7 and Siren14.

2016-06-23 10:03:01 -03:00

res_format_attr_siren14.c

siren: Add format attribute modules for Siren7 and Siren14.

2016-06-23 10:03:01 -03:00

res_format_attr_vp8.c

res_format_attr_vp8: In SDP, forward max-fr and max-fs for video-codec VP8.

2015-12-04 08:57:50 -06:00

res_hep_pjsip.c

res_hep: Capture actual transport type in use

2017-03-21 15:40:08 -04:00

res_hep_rtcp.c

res_hep_rtcp: Add support level to module info

2017-05-18 17:35:21 -04:00

res_hep.c

res_hep: Add additional config initialization and validation

2017-04-24 14:21:41 -04:00

res_hep.exports.in

res_hep_{pjsip|rtcp}: Decline module loads if res_hep had not loaded

2016-06-08 12:26:29 -05:00

res_http_post.c

Add module support level to ast_module_info structure. Print it in CLI "module show" .

2014-07-25 16:47:17 +00:00

res_http_websocket.c

modules: change module LOAD_FAILUREs to LOAD_DECLINES

2017-04-12 16:46:22 -05:00

res_http_websocket.exports.in

…

res_limit.c

modules: change module LOAD_FAILUREs to LOAD_DECLINES

2017-04-12 16:46:22 -05:00

res_manager_devicestate.c

AMI: Make AMI actions that generate event lists consistent.

2015-01-09 17:54:49 +00:00

res_manager_presencestate.c

AMI: Make AMI actions that generate event lists consistent.

2015-01-09 17:54:49 +00:00

res_monitor.c

res_monitor: Add dependency on func_periodic_hook.

2015-04-13 07:27:40 -04:00

res_monitor.exports.in

…

res_musiconhold.c

asterisk: Audit locking of channel when manipulating flags.

2017-05-16 14:25:01 +00:00

res_mutestream.c

…

res_mwi_external_ami.c

res_mwi_external_ami: Use module version of AMI registration.

2015-05-21 18:18:16 -05:00

res_mwi_external.c

voicemail: Move app_voicemail / res_mwi_external conflict to runtime

2016-01-04 16:28:48 -07:00

res_mwi_external.exports.in

…

res_odbc_transaction.c

res_odbc_transaction: add dep on generic_odbc

2016-08-21 18:54:26 -05:00

res_odbc_transaction.exports.in

res_odbc: Remove connection management

2016-01-29 08:32:35 -06:00

res_odbc.c

res_odbc: Make pooling option deprecation notice more useful.

2016-09-21 11:05:34 -05:00

res_odbc.exports.in

res_odbc: Fix exports.in for missing symbols

2016-02-16 15:37:48 -07:00

res_parking.c

Merge "res_parking: Misc fixes." into 13

2016-03-29 08:53:45 -05:00

res_phoneprov.c

fix: memory leaks, resource leaks, out of bounds and bugs

2016-06-20 13:06:00 -04:00

res_phoneprov.exports.in

res_phoneprov: Refactor phoneprov to allow pluggable config providers

2014-10-09 17:45:23 +00:00

res_pjproject.c

PJPROJECT logging: Fix detection of max supported log level.

2017-01-24 11:23:05 -06:00

res_pjproject.exports.in

res_pjproject: Add module providing pjproject logging and utils

2016-01-20 06:13:41 -07:00

res_pjsip_acl.c

Audit ast_sockaddr_resolve() usage for memory leaks.

2015-03-17 21:49:30 +00:00

res_pjsip_authenticator_digest.c

res_pjsip_authenticator_digest.c: Fix sorcery's immutable contract violation.

2017-02-20 22:20:54 -06:00

res_pjsip_caller_id.c

res_pjsip/res_pjsip_callerid: NULL check on caller id name string

2017-04-26 15:31:42 -05:00

res_pjsip_config_wizard.c

res_pjsip_config_wizard: Add 2 new parameters to help with proxy config

2017-03-28 15:44:07 -06:00

res_pjsip_dialog_info_body_generator.c

res_pjsip: New endpoint option "notify_early_inuse_ringing"

2017-06-16 12:08:27 -04:00

res_pjsip_diversion.c

res_pjsip: Fix known compact header issues

2016-12-31 18:56:09 -07:00

res_pjsip_dlg_options.c

res_pjsip_dlg_options: Fix MODULEINFO section.

2015-05-02 03:15:15 -04:00

res_pjsip_dtmf_info.c

res_pjsip_empty_info: Respond to empty SIP INFO packets

2016-05-19 09:06:30 -03:00

res_pjsip_empty_info.c

res_pjsip_empty_info: Respond to empty SIP INFO packets

2016-05-19 09:06:30 -03:00

res_pjsip_endpoint_identifier_anonymous.c

res_pjsip: disable multi domain to improve realtime performace

2016-04-27 10:58:25 -05:00

res_pjsip_endpoint_identifier_ip.c

res_pjsip_endpoint_identifier_ip: Don't output error if no header_match.

2017-03-15 13:44:43 +00:00

res_pjsip_endpoint_identifier_user.c

res_pjsip: Add ignore_uri_user_options option.

2016-09-09 17:09:54 -05:00

res_pjsip_exten_state.c

res_pjsip_pubsub: Correctly implement persisted subscriptions

2017-02-15 12:11:18 -07:00

res_pjsip_exten_state.exports.in

…

res_pjsip_header_funcs.c

res_pjsip: Add clarifying documentation to PJSIP_HEADER help text

2016-05-27 12:42:40 -05:00

res_pjsip_history.c

pjproject_bundled: Update for pjproject 2.6

2017-02-23 15:23:15 -07:00

res_pjsip_logger.c

PJSIP: Enforce module load dependencies

2014-10-16 14:35:00 +00:00

res_pjsip_messaging.c

res_pjsip_messaging: Check URI type before dereferencing

2017-03-21 10:44:30 -04:00

res_pjsip_mwi_body_generator.c

res_pjsip_mwi_body_generator: Re-order the body items

2016-05-30 18:27:35 -06:00

res_pjsip_mwi.c

res_pjsip_mwi.c: Eliminate RAII_VAR in contact delete observer

2017-06-21 18:21:57 -05:00

res_pjsip_nat.c

modules: change module LOAD_FAILUREs to LOAD_DECLINES

2017-04-12 16:46:22 -05:00

res_pjsip_notify.c

res_pjsip: Strip spaces from items parsed from comma-separated lists

2016-03-07 12:15:58 -07:00

res_pjsip_one_touch_record_info.c

modules: change module LOAD_FAILUREs to LOAD_DECLINES

2017-04-12 16:46:22 -05:00

res_pjsip_outbound_authenticator_digest.c

res_pjsip_outbound_authenticator_digest: Add context to log messages

2017-04-28 09:56:20 -06:00

res_pjsip_outbound_publish.c

modules: change module LOAD_FAILUREs to LOAD_DECLINES

2017-04-12 16:46:22 -05:00

res_pjsip_outbound_publish.exports.in

res_pjsip_outbound_publish: Add module which provides outbound PUBLISH support.

2014-08-07 14:35:09 +00:00

res_pjsip_outbound_registration.c

modules: change module LOAD_FAILUREs to LOAD_DECLINES

2017-04-12 16:46:22 -05:00

res_pjsip_path.c

res_pjsip: Add ignore_uri_user_options option.

2016-09-09 17:09:54 -05:00

res_pjsip_phoneprov_provider.c

res_pjsip_phoneprov_provider: Fix reference leak on unload

2015-04-09 22:35:11 +00:00

res_pjsip_pidf_body_generator.c

res_pjsip: New endpoint option "notify_early_inuse_ringing"

2017-06-16 12:08:27 -04:00

res_pjsip_pidf_digium_body_supplement.c

res_pjsip: Ensure sanitized XML is NULL terminated.

2015-08-06 07:03:28 -03:00

res_pjsip_pidf_eyebeam_body_supplement.c

res_pjsip: New endpoint option "notify_early_inuse_ringing"

2017-06-16 12:08:27 -04:00

res_pjsip_publish_asterisk.c

pjsip: Add Alembic for PUBLISH support.

2017-04-07 13:38:14 +00:00

res_pjsip_pubsub.c

res_pjsip_pubsub: Fix reference to released endpoint

2017-06-14 10:12:21 -06:00

res_pjsip_pubsub.exports.in

res_pjsip_mwi: Add voicemail extension and mwi_subscribe_replaces_unsolicited

2016-03-30 12:17:29 -06:00

res_pjsip_refer.c

res_pjsip_refer/session: Calls dropped during transfer

2017-06-13 14:17:29 -05:00

res_pjsip_registrar_expire.c

res_pjsip_registrar_expire.c: Remove extra linefeed in debug message.

2016-11-10 14:23:46 -06:00

res_pjsip_registrar.c

Revert "Update qualifies when AOR configuration changes."

2017-02-08 11:53:32 -06:00

res_pjsip_rfc3326.c

res_pjsip_rfc3326.c: Fix crash when channel goes away.

2015-11-13 15:31:02 -06:00

res_pjsip_sdp_rtp.c

res_pjsip: Add DTMF INFO Failback mode

2017-06-23 09:15:24 +02:00

res_pjsip_send_to_voicemail.c

modules: change module LOAD_FAILUREs to LOAD_DECLINES

2017-04-12 16:46:22 -05:00

res_pjsip_session.c

Merge "res_pjsip_refer/session: Calls dropped during transfer" into 13

2017-06-15 08:01:31 -05:00

res_pjsip_session.exports.in

res_pjsip_refer/session: Calls dropped during transfer

2017-06-13 14:17:29 -05:00

res_pjsip_sips_contact.c

Use SIPS URIs in Contact headers when appropriate.

2015-01-29 20:58:12 +00:00

res_pjsip_t38.c

res/res_pjsip_t38: fix incorrect increment of media_count

2017-06-27 17:46:43 +02:00

res_pjsip_transport_management.c

res_pjsip_transport_management: Convert time in log message to seconds.

2016-09-14 09:53:25 -05:00

res_pjsip_transport_websocket.c

res_pjsip_transport_websocket: Add NULL check in get_write_timeout

2017-06-14 09:54:16 -05:00

res_pjsip_xpidf_body_generator.c

res_pjsip: New endpoint option "notify_early_inuse_ringing"

2017-06-16 12:08:27 -04:00

res_pjsip.c

chan_pjsip: Fix ability to send UPDATE on COLP

2017-06-29 14:44:43 -06:00

res_pjsip.exports.in

…

res_pktccops.c

Fix printf problems with high ascii characters after r413586 (1.8).

2014-12-17 09:54:00 +00:00

res_pktccops.exports.in

…

res_realtime.c

…

res_rtp_asterisk.c

res_rtp_asterisk.c: Fix TURN deadlock by using ICE session group lock.

2017-07-06 16:11:45 -05:00

res_rtp_multicast.c

res_rtp_multicast: Use consistent timestamps when possible

2017-06-06 11:54:07 -04:00

res_rtp_multicast.exports.in

chan_rtp: Backport changes from master.

2016-06-10 17:24:00 -05:00

res_security_log.c

Stasis: Fix unsafe use of stasis_unsubscribe in modules.

2015-05-22 22:58:32 -04:00

res_smdi.c

modules: change module LOAD_FAILUREs to LOAD_DECLINES

2017-04-12 16:46:22 -05:00

res_smdi.exports.in

…

res_snmp.c

Add module support level to ast_module_info structure. Print it in CLI "module show" .

2014-07-25 16:47:17 +00:00

res_sorcery_astdb.c

res_sorcery_astdb: Filter fields to only the registered ones.

2016-05-19 19:47:21 -03:00

res_sorcery_config.c

res_sorcery_config.c: Cleanup ao2 container usage idioms.

2016-08-15 13:10:35 -05:00

res_sorcery_memory_cache.c

cli: Fix various CLI documentation and completion issues

2017-02-13 10:57:16 -05:00

res_sorcery_memory.c

sorcery: Use more compatible regex for local expressions.

2016-08-02 10:25:16 +00:00

res_sorcery_realtime.c

res_sorcery_realtime: fix bug when successful UPDATE is treated as failed

2016-07-07 10:02:45 -04:00

res_speech.c

Add module support level to ast_module_info structure. Print it in CLI "module show" .

2014-07-25 16:47:17 +00:00

res_speech.exports.in

…

res_srtp.c

res_srtp: Add support for libsrtp2

2017-05-26 12:06:34 -04:00

res_srtp.exports.in

Revert accidental change in r434261

2015-04-07 19:38:27 +00:00

res_stasis_answer.c

ARI: Fix a crash caused by hanging during playback to a channel in a bridge

2014-08-22 16:44:21 +00:00

res_stasis_answer.exports.in

…

res_stasis_device_state.c

modules: change module LOAD_FAILUREs to LOAD_DECLINES

2017-04-12 16:46:22 -05:00

res_stasis_device_state.exports.in

…

res_stasis_mailbox.c

Add module support level to ast_module_info structure. Print it in CLI "module show" .

2014-07-25 16:47:17 +00:00

res_stasis_mailbox.exports.in

…

res_stasis_playback.c

modules: change module LOAD_FAILUREs to LOAD_DECLINES

2017-04-12 16:46:22 -05:00

res_stasis_playback.exports.in

…

res_stasis_recording.c

modules: change module LOAD_FAILUREs to LOAD_DECLINES

2017-04-12 16:46:22 -05:00

res_stasis_recording.exports.in

…

res_stasis_snoop.c

res_stasis_snoop: Spying on a single direction continually increases CPU

2015-05-06 16:09:33 -05:00

res_stasis_snoop.exports.in

…

res_stasis_test.c

modules: change module LOAD_FAILUREs to LOAD_DECLINES

2017-04-12 16:46:22 -05:00

res_stasis_test.exports.in

…

res_stasis.c

res_stasis: Plug reference leak on stolen channels

2017-06-16 15:06:56 -05:00

res_stasis.exports.in

…

res_statsd.c

modules: change module LOAD_FAILUREs to LOAD_DECLINES

2017-04-12 16:46:22 -05:00

res_statsd.exports.in

res_statsd: Fix exports.in for missing symbols

2016-02-16 11:20:57 -07:00

res_stun_monitor.c

res_stun_monitor: Don't fail to load if DNS resolution fails

2017-04-14 17:50:56 -04:00

res_timing_dahdi.c

Add module support level to ast_module_info structure. Print it in CLI "module show" .

2014-07-25 16:47:17 +00:00

res_timing_kqueue.c

res_timing: Don't close FD 0 when out of open files.

2015-07-02 12:10:22 +02:00

res_timing_pthread.c

res_timing_pthread: Fix leaky pipes.

2015-02-15 12:39:09 +00:00

res_timing_timerfd.c

res_timing: Don't close FD 0 when out of open files.

2015-07-02 12:10:22 +02:00

res_xmpp.c

res_xmpp: Use incremental backoff when a read error occurs

2017-03-25 12:01:28 -04:00

res_xmpp.exports.in

…

res.xml

build_tools: Add ability to download variants to download_externals

2016-09-25 13:40:35 -05:00