mirror of
https://github.com/asterisk/asterisk.git
synced 2025-10-29 07:24:55 +00:00
f2dfa64228
https://origsvn.digium.com/svn/asterisk/trunk ........ r251877 | tilghman | 2010-03-11 14:25:02 -0600 (Thu, 11 Mar 2010) | 8 lines If the argument to the system application is quoted, ensure we remove the quotes before trying to execute. (closes issue #16842) Reported by: ip-rob Patches: 20100310__issue16842.diff.txt uploaded by tilghman (license 14) Tested by: ip-rob ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@251878 65c4cc65-6c06-0410-ace0-fbb531ad65f3
146 lines
3.8 KiB
C
146 lines
3.8 KiB
C
/*
|
|
* Asterisk -- An open source telephony toolkit.
|
|
*
|
|
* Copyright (C) 1999 - 2005, Digium, Inc.
|
|
*
|
|
* Mark Spencer <markster@digium.com>
|
|
*
|
|
* See http://www.asterisk.org for more information about
|
|
* the Asterisk project. Please do not directly contact
|
|
* any of the maintainers of this project for assistance;
|
|
* the project provides a web site, mailing lists and IRC
|
|
* channels for your use.
|
|
*
|
|
* This program is free software, distributed under the terms of
|
|
* the GNU General Public License Version 2. See the LICENSE file
|
|
* at the top of the source tree.
|
|
*/
|
|
|
|
/*! \file
|
|
*
|
|
* \brief Execute arbitrary system commands
|
|
*
|
|
* \author Mark Spencer <markster@digium.com>
|
|
*
|
|
* \ingroup applications
|
|
*/
|
|
|
|
#include "asterisk.h"
|
|
|
|
ASTERISK_FILE_VERSION(__FILE__, "$Revision$")
|
|
|
|
#include "asterisk/pbx.h"
|
|
#include "asterisk/module.h"
|
|
#include "asterisk/app.h"
|
|
#include "asterisk/channel.h" /* autoservice */
|
|
#include "asterisk/strings.h"
|
|
#include "asterisk/threadstorage.h"
|
|
|
|
AST_THREADSTORAGE(buf_buf);
|
|
|
|
static char *app = "System";
|
|
|
|
static char *app2 = "TrySystem";
|
|
|
|
static char *synopsis = "Execute a system command";
|
|
|
|
static char *synopsis2 = "Try executing a system command";
|
|
|
|
static char *chanvar = "SYSTEMSTATUS";
|
|
|
|
static char *descrip =
|
|
" System(command): Executes a command by using system(). If the command\n"
|
|
"fails, the console should report a fallthrough. \n"
|
|
"Result of execution is returned in the SYSTEMSTATUS channel variable:\n"
|
|
" FAILURE Could not execute the specified command\n"
|
|
" SUCCESS Specified command successfully executed\n";
|
|
|
|
static char *descrip2 =
|
|
" TrySystem(command): Executes a command by using system().\n"
|
|
"on any situation.\n"
|
|
"Result of execution is returned in the SYSTEMSTATUS channel variable:\n"
|
|
" FAILURE Could not execute the specified command\n"
|
|
" SUCCESS Specified command successfully executed\n"
|
|
" APPERROR Specified command successfully executed, but returned error code\n";
|
|
|
|
static int system_exec_helper(struct ast_channel *chan, void *data, int failmode)
|
|
{
|
|
int res = 0;
|
|
struct ast_str *buf = ast_str_thread_get(&buf_buf, 16);
|
|
char *cbuf;
|
|
|
|
if (ast_strlen_zero(data)) {
|
|
ast_log(LOG_WARNING, "System requires an argument(command)\n");
|
|
pbx_builtin_setvar_helper(chan, chanvar, "FAILURE");
|
|
return failmode;
|
|
}
|
|
|
|
ast_autoservice_start(chan);
|
|
|
|
/* Do our thing here */
|
|
ast_str_get_encoded_str(&buf, 0, (char *) data);
|
|
cbuf = ast_str_buffer(buf);
|
|
|
|
if (strchr("\"'", cbuf[0]) && cbuf[ast_str_strlen(buf) - 1] == cbuf[0]) {
|
|
cbuf[ast_str_strlen(buf) - 1] = '\0';
|
|
cbuf++;
|
|
ast_log(LOG_NOTICE, "It is not necessary to quote the argument to the System application.\n");
|
|
}
|
|
|
|
res = ast_safe_system(cbuf);
|
|
|
|
if ((res < 0) && (errno != ECHILD)) {
|
|
ast_log(LOG_WARNING, "Unable to execute '%s'\n", (char *)data);
|
|
pbx_builtin_setvar_helper(chan, chanvar, "FAILURE");
|
|
res = failmode;
|
|
} else if (res == 127) {
|
|
ast_log(LOG_WARNING, "Unable to execute '%s'\n", (char *)data);
|
|
pbx_builtin_setvar_helper(chan, chanvar, "FAILURE");
|
|
res = failmode;
|
|
} else {
|
|
if (res < 0)
|
|
res = 0;
|
|
if (res != 0)
|
|
pbx_builtin_setvar_helper(chan, chanvar, "APPERROR");
|
|
else
|
|
pbx_builtin_setvar_helper(chan, chanvar, "SUCCESS");
|
|
res = 0;
|
|
}
|
|
|
|
ast_autoservice_stop(chan);
|
|
|
|
return res;
|
|
}
|
|
|
|
static int system_exec(struct ast_channel *chan, void *data)
|
|
{
|
|
return system_exec_helper(chan, data, -1);
|
|
}
|
|
|
|
static int trysystem_exec(struct ast_channel *chan, void *data)
|
|
{
|
|
return system_exec_helper(chan, data, 0);
|
|
}
|
|
|
|
static int unload_module(void)
|
|
{
|
|
int res;
|
|
|
|
res = ast_unregister_application(app);
|
|
res |= ast_unregister_application(app2);
|
|
|
|
return res;
|
|
}
|
|
|
|
static int load_module(void)
|
|
{
|
|
int res;
|
|
|
|
res = ast_register_application(app2, trysystem_exec, synopsis2, descrip2);
|
|
res |= ast_register_application(app, system_exec, synopsis, descrip);
|
|
|
|
return res;
|
|
}
|
|
|
|
AST_MODULE_INFO_STANDARD(ASTERISK_GPL_KEY, "Generic System() application");
|