George Joseph bc973bd719
jitterbuffer: Correct signed/unsigned mismatch causing assert ...
If the system time has stepped backwards because of a time
adjustment between the time a frame is timestamped and the
time we check the timestamps in abstract_jb:hook_event_cb(),
we get a negative interval, but we don't check for that there.
abstract_jb:hook_event_cb() then calls
fixedjitterbuffer:fixed_jb_get() (via abstract_jb:jb_get_fixed)
and the first thing that does is assert(interval >= 0).
There are several issues with this...
* abstract_jb:hook_event_cb() saves the interval in a variable
named "now" which is confusing in itself.
* "now" is defined as an unsigned int which converts the negative
value returned from ast_tvdiff_ms() to a large positive value.
* fixed_jb_get()'s parameter is defined as a signed int so the
interval gets converted back to a negative value.
* fixed_jb_get()'s assert is NOT an ast_assert but a direct define
that points to the system assert() so it triggers even in
production mode.
So...
* hook_event_cb()'s "now" was renamed to "relative_frame_start" and
changed to an int64_t.
* hook_event_cb() now checks for a negative value right after
retrieving both the current and framedata timestamps and just
returns the frame if the difference is negative.
* fixed_jb_get()'s local define of ASSERT() was changed to call
ast_assert() instead of the system assert().
ASTERISK-29480
Reported by: Dan Cropp
Change-Id: Ic469dec73c2edc3ba134cda6721a999a9714f3c9
2021-06-24 08:18:19 -05:00
2018-03-06 13:17:54 -06:00
2021-06-24 08:18:19 -05:00
2020-07-20 11:38:05 -05:00
2017-12-22 09:23:22 -05:00
2018-12-07 09:06:08 -05:00
2019-08-01 15:31:48 -06:00
2020-05-08 13:44:08 -05:00
2020-05-05 10:06:43 -05:00
2017-12-22 09:23:22 -05:00
2020-05-05 10:06:43 -05:00
2017-12-22 09:23:22 -05:00
2021-05-25 09:20:59 -05:00
2020-06-02 11:35:07 -05:00
2018-10-12 12:21:47 -05:00
2019-09-23 07:25:33 -05:00
2019-09-23 13:34:14 -04:00
2019-09-23 07:35:48 -04:00
2019-09-23 13:34:14 -04:00
2019-09-23 13:34:14 -04:00
2019-09-25 08:16:39 -05:00
2020-03-13 09:56:40 -05:00
2018-06-19 15:02:52 -05:00
2020-04-06 10:23:20 -05:00
2017-09-06 13:00:49 -05:00
2020-11-18 10:13:06 -06:00
2021-04-05 07:52:41 -05:00
2018-02-15 14:31:32 -06:00
2020-10-02 08:04:31 -05:00
2020-12-09 11:17:27 -06:00
2018-03-07 16:03:01 -06:00
2019-08-01 15:31:48 -06:00
2020-01-22 13:13:57 -06:00
2019-08-07 07:48:32 -03:00
2021-04-05 07:52:41 -05:00
2021-06-22 08:48:06 -05:00
2018-03-01 13:13:55 -06:00
2020-10-02 12:58:18 -05:00
2021-01-04 05:00:58 -06:00
2018-10-19 17:33:05 -04:00
2018-11-21 09:56:16 -05:00
2019-12-19 04:48:58 -06:00
2020-09-02 06:27:24 -05:00
2021-04-29 08:41:03 -05:00
2021-03-22 07:49:48 -05:00
2017-06-08 10:42:54 -05:00
2020-04-15 13:56:40 -05:00
2018-11-21 09:56:16 -05:00
2019-12-27 17:32:22 -06:00
2019-03-11 11:39:35 -03:00
2020-03-31 11:58:48 -05:00
2020-03-13 09:58:59 -05:00
2018-11-14 09:25:32 -05:00
2020-06-10 09:33:28 -05:00
2018-03-13 13:46:08 -04:00
2020-04-28 13:05:55 -05:00
2017-12-22 09:23:22 -05:00
2018-07-26 14:29:18 -05:00
2020-09-23 15:21:48 -05:00
2019-03-11 11:39:35 -03:00
2020-03-09 10:15:49 -05:00
2019-11-18 08:30:45 -06:00
2018-10-19 17:33:05 -04:00
2018-03-14 05:20:12 -04:00
2020-08-18 05:16:43 -05:00
2021-05-17 09:26:50 -05:00
2021-06-24 08:18:19 -05:00
2021-01-04 05:00:58 -06:00
2020-09-15 14:37:36 -05:00
2021-01-04 05:00:58 -06:00
2018-10-19 17:33:05 -04:00
2021-01-27 10:40:41 -06:00
2017-12-22 09:23:22 -05:00
2018-03-01 13:13:55 -06:00
2018-03-01 13:13:55 -06:00
2020-06-10 09:33:28 -05:00
2020-11-03 15:47:33 -06:00
2017-06-19 13:33:48 -04:00
2020-01-02 15:51:37 -06:00
2017-12-20 12:40:01 -05:00
2019-03-26 21:16:47 +01:00
2018-05-20 13:55:26 +02:00
2021-04-02 12:58:07 -05:00
2018-10-19 12:34:08 -04:00
2020-10-02 12:58:18 -05:00
2021-03-22 11:17:23 -05:00
2019-11-08 10:20:13 -05:00
2018-11-26 14:30:02 -07:00
2021-05-19 08:40:05 -05:00
2017-12-22 09:23:22 -05:00
2019-04-23 17:40:15 -05:00
2017-12-19 09:42:19 -05:00
2021-01-06 09:11:43 -06:00
2020-12-03 08:35:41 -06:00
2019-01-28 12:26:58 -07:00
2021-05-06 06:23:51 -05:00
2019-07-08 18:12:49 -05:00
2020-03-31 11:08:45 -05:00
2017-12-30 13:20:16 -05:00
2018-05-21 11:03:10 -05:00
2018-02-12 22:53:35 -05:00
2020-12-09 11:17:27 -06:00
2019-03-11 11:39:35 -03:00
2018-03-15 07:25:28 -04:00
2021-06-15 09:00:14 -05:00
2018-06-19 10:46:46 -06:00
2017-12-22 09:23:22 -05:00
2020-12-09 11:17:27 -06:00
2021-06-22 08:48:06 -05:00
2018-10-19 17:33:05 -04:00
2018-07-26 14:29:18 -05:00
2017-12-22 09:23:22 -05:00
2019-03-11 11:39:35 -03:00
2020-10-02 12:58:18 -05:00
2021-03-02 11:20:19 -06:00
2019-07-18 01:22:55 -06:00
2017-12-22 09:23:22 -05:00
2019-03-11 11:39:35 -03:00
2019-11-18 11:05:24 -05:00
2017-12-22 09:23:22 -05:00
2021-03-05 10:32:28 -06:00
2019-02-04 14:40:35 -06:00
2019-06-13 14:07:16 -06:00
2019-03-11 11:39:35 -03:00
2019-11-18 08:30:45 -06:00
2021-05-19 08:40:05 -05:00
2019-03-11 11:39:35 -03:00
2019-01-17 14:51:47 -04:00
2018-12-07 08:59:00 -05:00
2019-09-24 14:33:33 -05:00
2019-03-11 11:39:35 -03:00
2021-05-19 08:40:05 -05:00
2020-05-08 13:44:08 -05:00
2020-09-14 09:27:14 -05:00
2018-03-13 16:24:06 -04:00
2019-03-13 09:30:40 -04:00
2020-10-02 12:58:18 -05:00
2019-10-07 16:54:16 -05:00
2020-10-08 05:49:18 -05:00
2017-12-22 09:23:22 -05:00
2019-03-11 11:39:35 -03:00
2019-02-20 11:51:08 -06:00
2017-12-22 09:23:22 -05:00
2021-03-31 09:30:36 -05:00
2018-01-03 17:23:36 -05:00
2021-04-30 15:32:09 -05:00
2019-07-30 10:10:16 -06:00
2017-12-22 09:23:22 -05:00
2020-07-28 09:45:29 -05:00
2021-05-12 06:42:55 -05:00
2018-06-23 08:26:19 +02:00
2018-07-23 06:47:20 -05:00
2018-11-21 09:56:16 -05:00
bc973bd719