Richard Mudgett 3037924c69 CEL: Protect data structures during reload and shutdown. ...

The CEL data structures need to be protected during a configuration reload
and shutdown.  Asterisk crashed during a shutdown because CEL events were
still in flight and the CEL data structures were already destroyed.

* Protected the cel_backends, cel_dialstatus_store, and cel_linkedids ao2
containers with a global ao2 object wrapper.

* Added NULL checks before use of the cel_backends, cel_dialstatus_store,
and cel_linkedids ao2 containers in case the CEL module is already
shutdown.

* Fixed overloading of the cel_linkedids held objects reference count.
During shutdown any held objects would be leaked.

* Fixed memory leak of cel_linkedids held objects if the LINKEDID_END is
not being tracked.  The objects in the cel_linkedids container were not
removed if the LINKEDID_END event is not used.

* Added access protection to the cel_backends container during the CLI
"cel show status" command.

* Made cel_backends, cel_dialstatus_store, and cel_linkedids use the
standard ao2 callback templates for the hash and cmp functions.

* Eliminated unnecessary uses of RAII_VAR().

* Made ast_cel_engine_init() cleanup alocated resources on failure.

(closes issue AST-1253)
Reported by: Guenther Kelleter

Review: https://reviewboard.asterisk.org/r/3128/
........

Merged revisions 406417 from http://svn.asterisk.org/svn/asterisk/branches/1.8
........

Merged revisions 406418 from http://svn.asterisk.org/svn/asterisk/branches/11


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/12@406465 65c4cc65-6c06-0410-ace0-fbb531ad65f3

2014-01-24 23:29:57 +00:00

..

editline

memory leaks: Memory leak cleanup patch by Corey Farrell (first set)

2013-10-23 20:02:21 +00:00

stdtime

Fix some uninitialized buffers for CDR handling valgrind found.

2013-08-28 23:14:57 +00:00

abstract_jb.c

Fix jitter buffer log file creation

2013-09-18 19:59:24 +00:00

acl.c

res_pjsip: AMI commands and events.

2013-11-23 17:14:22 +00:00

adsi.c

…

alaw.c

…

aoc.c

Fix documentation replication issues

2013-08-01 17:07:52 +00:00

app.c

Voicemail: Remove mailbox identifier format (box@context) assumptions in the system.

2013-12-19 16:37:56 +00:00

ast_expr2.c

…

ast_expr2.fl

…

ast_expr2.h

…

ast_expr2.y

…

ast_expr2f.c

…

asterisk.c

verbosity: Fix performance of console verbose messages.

2014-01-14 18:03:06 +00:00

asterisk.dynamics

…

asterisk.exports.in

Add _IO_stdin_used in version-script to fix SIGBUSes on Sparc.

2013-08-22 08:26:55 +00:00

astfd.c

Unregister CLI commands on exit

2013-08-20 15:36:10 +00:00

astmm.c

MALLOC_DEBUG: Change fence magic number to be completely different from the freed magic number.

2013-09-09 23:23:02 +00:00

astobj2.c

astobj2: Correct ao2_iterator opacity violations

2014-01-09 20:25:24 +00:00

audiohook.c

ari: Add Snoop operation for spying/whispering on channels.

2013-11-23 12:38:04 +00:00

autochan.c

…

autoservice.c

Don't leak frames when memory is full in autoservice_run.

2013-08-09 20:29:09 +00:00

backtrace.c

Fix memory corruption when trying to get "core show locks".

2013-08-23 18:07:40 +00:00

bridge_after.c

A great big renaming patch

2013-07-25 04:06:32 +00:00

bridge_basic.c

bridging: Give bridges a name and a known creator

2013-12-17 23:17:32 +00:00

bridge_channel.c

channel locking: Add locking for channel snapshot creation

2013-12-18 20:25:39 +00:00

bridge_roles.c

ARI: bridges/{bridgeID}/addChannel: add roles parameter

2013-08-05 16:59:13 +00:00

bridge.c

channel locking: Add locking for channel snapshot creation

2013-12-18 20:25:39 +00:00

bucket.c

sorcery, bucket: Change observer remove calls to take const callbacks struct.

2013-12-03 17:23:50 +00:00

buildinfo.c

…

callerid.c

…

ccss.c

Cache string values of formats on ast_format_cap() to save processing.

2013-10-02 22:34:05 +00:00

cdr.c

CDRs: Synchronize dialplan applications that manipulate CDRs with the engine

2014-01-12 21:58:32 +00:00

cel.c

CEL: Protect data structures during reload and shutdown.

2014-01-24 23:29:57 +00:00

channel_internal_api.c

Remove publication of a channel snapshot when the technology is set

2013-10-03 21:40:20 +00:00

channel.c

channels.c: core show channeltypes slicing

2013-12-30 23:21:56 +00:00

chanvars.c

…

cli.c

verbosity: Fix performance of console verbose messages.

2014-01-14 18:03:06 +00:00

config_options.c

Ensure global types in the config framework are initialized

2013-09-20 22:41:25 +00:00

config.c

res_pjsip: Add PJSIP CLI commands

2013-12-20 21:23:24 +00:00

core_local.c

channel locking: Add locking for channel snapshot creation

2013-12-18 20:25:39 +00:00

core_unreal.c

channels: Return allocated channels locked.

2013-12-18 19:20:02 +00:00

crypt.c

Fix utils directory breakage.

2013-07-04 13:06:15 +00:00

cygload.c

…

data.c

memory leaks: Memory leak cleanup patch by Corey Farrell (second set)

2013-10-24 16:58:30 +00:00

datastore.c

This is no longer needed.

2013-06-29 00:18:57 +00:00

db.c

astdb: crash in sqlite3 during shutdown

2013-12-19 16:31:57 +00:00

devicestate.c

ARI: Implement device state API

2013-11-23 17:38:29 +00:00

dial.c

channel locking: Add locking for channel snapshot creation

2013-12-18 20:25:39 +00:00

dns.c

Remove redundant code in dns.c

2013-07-14 02:05:04 +00:00

dnsmgr.c

Migrate a large number of AMI events over to Stasis-Core

2013-05-24 20:44:07 +00:00

dsp.c

…

ecdisa.h

…

endpoints.c

channel locking: Add locking for channel snapshot creation

2013-12-18 20:25:39 +00:00

enum.c

Migrate a large number of AMI events over to Stasis-Core

2013-05-24 20:44:07 +00:00

event.c

Fix incorrect usages of ast_realloc().

2013-09-10 18:03:45 +00:00

features_config.c

Features: Rearm the parking config options have moved warning for each reload.

2013-10-01 16:34:51 +00:00

features.c

Documentation: doc fixes across various parts of the code for ASTERISK issues 23061,23028,23046,23027

2014-01-17 17:14:16 +00:00

file.c

Cache string values of formats on ast_format_cap() to save processing.

2013-10-02 22:34:05 +00:00

fixedjitterbuf.c

…

fixedjitterbuf.h

…

format_cap.c

Cache string values of formats on ast_format_cap() to save processing.

2013-10-02 22:34:05 +00:00

format_pref.c

pjsip: fix support for allow=all

2014-01-17 21:32:18 +00:00

format.c

Add pass through support for Opus and VP8; Opus format attribute negotiation

2013-08-23 15:42:27 +00:00

frame.c

pjsip: fix support for allow=all

2014-01-17 21:32:18 +00:00

framehook.c

framehooks: Re-iterate if framehook provides different frame.

2013-12-17 18:25:26 +00:00

fskmodem_float.c

…

fskmodem_int.c

…

fskmodem.c

…

global_datastores.c

…

hashtab.c

Fix utilities compilation/linking.

2013-08-16 16:26:11 +00:00

heap.c

Fix incorrect usages of ast_realloc().

2013-09-10 18:03:45 +00:00

http.c

http: supported chunked Transfer-Encoding

2014-01-17 20:49:57 +00:00

image.c

…

indications.c

Fix incorrect usages of ast_realloc().

2013-09-10 18:03:45 +00:00

io.c

…

jitterbuf.c

jitterbuf: Fix memory leak on jitter buffer reset

2013-10-24 19:41:49 +00:00

json.c

ARI: Don't leak implementation details

2013-11-22 20:01:26 +00:00

libasteriskssl.c

…

libasteriskssl.exports.in

…

loader.c

core/loader: Don't call dlclose in a while loop

2013-10-31 16:04:59 +00:00

lock.c

Fix DEBUG_THREADS when lock is acquired in __constructor__

2013-09-09 20:12:46 +00:00

logger.c

verbosity: Fix performance of console verbose messages.

2014-01-14 18:03:06 +00:00

Makefile

Add the bucket API.

2013-08-23 21:49:47 +00:00

manager_bridges.c

bridging: Give bridges a name and a known creator

2013-12-17 23:17:32 +00:00

manager_channels.c

Remove dispatch object allocation from Stasis publishing

2013-09-30 18:48:57 +00:00

manager_endpoints.c

Remove dispatch object allocation from Stasis publishing

2013-09-30 18:48:57 +00:00

manager_mwi.c

Remove dispatch object allocation from Stasis publishing

2013-09-30 18:48:57 +00:00

manager_system.c

Optimize how Stasis forwards are dispatched

2013-09-30 18:39:34 +00:00

manager.c

manager: Register atexit shutdown routine only once.

2014-01-24 22:14:57 +00:00

md5.c

…

media_index.c

media_index: Make media indexing tolerable of bad symlinks.

2013-12-03 16:37:26 +00:00

message.c

channels: Return allocated channels locked.

2013-12-18 19:20:02 +00:00

mixmonitor.c

Removed quotes from svn:keywords props on a few files.

2013-07-29 17:51:25 +00:00

named_acl.c

Fix various memory leaks

2013-08-30 19:20:47 +00:00

netsock2.c

Add IPv6 Support To chan_iax2

2013-10-04 21:40:33 +00:00

netsock.c

Add IPv6 Support To chan_iax2

2013-10-04 21:40:33 +00:00

optional_api.c

optional_api: Make always use the standard malloc functions even with MALLOC_DEBUG.

2013-09-19 23:16:31 +00:00

parking.c

astobj2: Add warn unused attribute to some functions.

2013-09-06 19:20:06 +00:00

pbx.c

pbx.c: Pre-initialize timezone to avoid crash on destroy

2014-01-22 22:23:16 +00:00

pickup.c

channel locking: Add locking for channel snapshot creation

2013-12-18 20:25:39 +00:00

plc.c

…

poll.c

…

presencestate.c

Strip down the old event system

2013-08-17 14:39:27 +00:00

privacy.c

…

rtp_engine.c

Several components: fixing Typos in comments and code, "avaliable" instead of "available"

2013-12-17 23:36:56 +00:00

say.c

say.c: correct time for polish

2013-12-20 21:16:47 +00:00

sched.c

…

sdp_srtp.c

Merge in current pimp_my_sip work, including:

2013-06-22 14:03:22 +00:00

security_events.c

security_events: Push out security events over AMI events

2013-11-08 19:28:11 +00:00

sem.c

Taskprocessor optimization; switch Stasis to use taskprocessors

2013-09-30 18:26:27 +00:00

sha1.c

…

sip_api.c

…

slinfactory.c

Fix a memory copying bug in slinfactory which was causing mixmonitor issues.

2013-05-28 17:47:29 +00:00

sorcery.c

pjsip: fix support for allow=all

2014-01-17 21:32:18 +00:00

sounds_index.c

Whitespace fixes.

2013-12-20 19:06:12 +00:00

srv.c

…

stasis_bridges.c

channel locking: Add locking for channel snapshot creation

2013-12-18 20:25:39 +00:00

stasis_cache_pattern.c

Optimize how Stasis forwards are dispatched

2013-09-30 18:39:34 +00:00

stasis_cache.c

MALLOC_DEBUG: Fix some misuses of free() when MALLOC_DEBUG is enabled.

2013-10-02 17:11:42 +00:00

stasis_channels.c

channel locking: Add locking for channel snapshot creation

2013-12-18 20:25:39 +00:00

stasis_endpoints.c

ARI: Don't leak implementation details

2013-11-22 20:01:26 +00:00

stasis_message_router.c

stasis: Add methods to allow for synchronous publishing to subscriber

2014-01-12 21:55:11 +00:00

stasis_message.c

ARI: Don't leak implementation details

2013-11-22 20:01:26 +00:00

stasis_system.c

Convert CCSS manager events to stasis.

2013-07-19 18:00:35 +00:00

stasis.c

stasis: Add methods to allow for synchronous publishing to subscriber

2014-01-12 21:55:11 +00:00

strcompat.c

…

strings.c

string container: Remove unnecessary RAII_VAR usage and string object lock.

2014-01-14 21:44:10 +00:00

stun.c

…

syslog.c

…

taskprocessor.c

taskprocessor: Made use pthread_equal() to compare thread ids.

2013-10-25 23:52:13 +00:00

tcptls.c

security: Inhibit execution of privilege escalating functions

2013-12-16 18:31:27 +00:00

tdd.c

…

term.c

…

test.c

test.c: Fix too sticky unit test failed status.

2013-12-13 20:06:53 +00:00

threadpool.c

Fix threadpool rapid growth problem.

2013-06-20 16:29:35 +00:00

threadstorage.c

Unregister CLI commands on exit

2013-08-20 15:36:10 +00:00

timing.c

…

translate.c

translate: Move freeing of frame to after it is used.

2013-11-22 17:11:46 +00:00

udptl.c

udptl: Dead code elimination. ast_udptl_bridge was not used.

2013-12-19 17:03:55 +00:00

ulaw.c

…

utils.c

res_pjsip: AMI commands and events.

2013-11-23 17:14:22 +00:00

uuid.c

…

xml.c

Detect and use xsltCleanupGlobals when available

2013-10-03 17:57:49 +00:00

xmldoc.c

func_channel, chan_pjsip: Add CHANNEL read function support for chan_pjsip

2013-12-11 13:05:12 +00:00