Mark Michelson f436b9ab11 res_pjsip_registrar: Fix bad memory-ness with user_agent. ...

Recent changes to the PJSIP registrar resulted in tests failing due to
missing AOR_CONTACT_ADDED test events. The reason for this was that the
user_agent string had junk values in it, resulting in being unable to
generate the event.

I'm going to be honest here, I have no idea why this was happening. Here
are the steps needed for the user_agent variable to get messed up:
* REGISTER is received
* First contact in the REGISTER results in a contact being removed
* Second contact in the REGISTER results in a contact being added
* The contact, AOR, expiration, and user agent all have to be passed as
  format parameters to the creation of a string. Any subset of those
  parameters would not be enough to cause the problem.

Looking into what was happening, the thing that struck me as odd was
that the user_agent variable was meant to be set to the value of the
User-Agent SIP header in the incoming REGISTER. However, when removing a
contact, the user_agent variable would be set (via ast_strdupa inside a
loop) to the stored contact's user_agent. This means that the
user_agent's value would be incorrect when attempting to process further
contacts in the incoming REGISTER.

The fix here is to use a different variable for the stored user agent
when removing a contact. Correcting the behavior to be correct also
means the memory usage is less weird, and the issue no longer occurs.

ASTERISK-25929 #close
Reported by Joshua Colp

Change-Id: I7cd24c86a38dec69ebcc94150614bc25f46b8c08

2016-04-19 08:23:54 -05:00

..

ael

Add .gitignore and .gitreview files

2015-04-12 13:48:10 -05:00

ari

Merge "res_stasis: Add control ref to playback and recording structs." into 13

2016-03-31 13:39:03 -05:00

parking

Merge "res_parking: Misc fixes." into 13

2016-03-29 08:53:45 -05:00

res_pjsip

AST-2016-004: Fix crash on REGISTER with long URI.

2016-04-14 07:15:47 -05:00

snmp

CHANNEL(peer), chan_iax2, res_fax, SNMP agent: Fix deadlock from reaching across a bridge.

2015-01-20 16:46:16 +00:00

stasis

res_stasis: Add control ref to playback and recording structs.

2016-03-30 16:23:40 -05:00

stasis_recording

clang compiler warnings: Fix non-literal-null-conversion warnings

2015-04-07 02:03:20 +00:00

ari.make

ARI: Fix missing dependencies.

2015-04-29 07:39:22 -04:00

Makefile

res/Makefile: Fix bug in "clean" target for ari

2016-02-01 13:19:41 -06:00

res_adsi.c

Add module support level to ast_module_info structure. Print it in CLI "module show" .

2014-07-25 16:47:17 +00:00

res_ael_share.c

Add module support level to ast_module_info structure. Print it in CLI "module show" .

2014-07-25 16:47:17 +00:00

res_ael_share.exports.in

…

res_agi.c

fastagi: record file closed after sending result

2015-11-25 15:33:29 -06:00

res_agi.exports.in

…

res_ari_applications.c

ARI: Fix missing dependencies.

2015-04-29 07:39:22 -04:00

res_ari_asterisk.c

ARI: Retrieve existing log channels

2015-08-07 14:55:53 -05:00

res_ari_bridges.c

ARI: Fix missing dependencies.

2015-04-29 07:39:22 -04:00

res_ari_channels.c

ARI: Fix missing dependencies.

2015-04-29 07:39:22 -04:00

res_ari_device_states.c

ARI: Fix missing dependencies.

2015-04-29 07:39:22 -04:00

res_ari_endpoints.c

ARI: Fix missing dependencies.

2015-04-29 07:39:22 -04:00

res_ari_events.c

ARI: Add the ability to subscribe to all events

2015-09-22 13:27:14 -05:00

res_ari_mailboxes.c

ARI: Fix missing dependencies.

2015-04-29 07:39:22 -04:00

res_ari_model.c

Add module support level to ast_module_info structure. Print it in CLI "module show" .

2014-07-25 16:47:17 +00:00

res_ari_model.exports.in

Rename everything Stasis-HTTP to ARI

2013-07-27 23:11:02 +00:00

res_ari_playbacks.c

ARI: Fix missing dependencies.

2015-04-29 07:39:22 -04:00

res_ari_recordings.c

ARI: Fix missing dependencies.

2015-04-29 07:39:22 -04:00

res_ari_sounds.c

ARI: Fix missing dependencies.

2015-04-29 07:39:22 -04:00

res_ari.c

res_ari.c: Add missing off nominal unlock and remove a RAII_VAR().

2015-08-18 16:49:25 -05:00

res_ari.exports.in

Rename everything Stasis-HTTP to ARI

2013-07-27 23:11:02 +00:00

res_calendar_caldav.c

Add module support level to ast_module_info structure. Print it in CLI "module show" .

2014-07-25 16:47:17 +00:00

res_calendar_ews.c

res_calendar_ews: Relax neon version check to work with 0.30 too.

2014-10-12 07:44:32 +00:00

res_calendar_exchange.c

Add module support level to ast_module_info structure. Print it in CLI "module show" .

2014-07-25 16:47:17 +00:00

res_calendar_icalendar.c

Add module support level to ast_module_info structure. Print it in CLI "module show" .

2014-07-25 16:47:17 +00:00

res_calendar.c

res_calendar: Cleanup scheduler context at unload.

2016-01-10 13:32:48 -06:00

res_calendar.exports.in

…

res_chan_stats.c

res_chan_stats: Fix bug to send correct statistics to StatsD

2015-12-09 15:57:35 -06:00

res_clialiases.c

Add module support level to ast_module_info structure. Print it in CLI "module show" .

2014-07-25 16:47:17 +00:00

res_clioriginate.c

media formats: re-architect handling of media for performance improvements

2014-07-20 22:06:33 +00:00

res_config_curl.c

Add module support level to ast_module_info structure. Print it in CLI "module show" .

2014-07-25 16:47:17 +00:00

res_config_ldap.c

Add module support level to ast_module_info structure. Print it in CLI "module show" .

2014-07-25 16:47:17 +00:00

res_config_odbc.c

res/res_config_odbc: Fix improper escaping of backslashes with MySQL

2015-03-10 21:33:40 +00:00

res_config_pgsql.c

res_config_pgsql.c: Fix deadlock loading realtime configuration.

2015-10-14 14:18:45 -05:00

res_config_sqlite3.c

res_config_sqlite3: Fix crashes when reading peers from sqlite3 tables

2016-02-23 16:01:52 -06:00

res_config_sqlite.c

CHAOS: avoid crash if string create fails

2015-09-18 13:52:46 -05:00

res_convert.c

Merged revisions 328247 via svnmerge from

2011-07-14 20:28:54 +00:00

res_corosync.c

res/res_corosync: Always decline module load, instead of failing

2015-06-26 22:02:42 -05:00

res_crypto.c

res_crypto: Perform cleanup at shutdown.

2016-01-09 13:39:00 -06:00

res_crypto.exports.in

Remove built-in AES code and use optional_api instead

2010-07-21 19:11:32 +00:00

res_curl.c

Add module support level to ast_module_info structure. Print it in CLI "module show" .

2014-07-25 16:47:17 +00:00

res_endpoint_stats.c

Fixed some typos

2015-11-24 13:54:54 -06:00

res_fax_spandsp.c

res_fax: allow 2400 transmission rate according to v.27ter standard

2015-04-29 15:37:12 -05:00

res_fax.c

json: Audit ast_json_* usage for thread safety.

2015-12-16 17:17:30 -04:00

res_fax.exports.in

res_fax: Provide AMI equivalents for fax CLI commands

2014-07-18 15:49:46 +00:00

res_format_attr_celt.c

Add module support level to ast_module_info structure. Print it in CLI "module show" .

2014-07-25 16:47:17 +00:00

res_format_attr_h263.c

Add module support level to ast_module_info structure. Print it in CLI "module show" .

2014-07-25 16:47:17 +00:00

res_format_attr_h264.c

res_format_attr_h264: Do not reset string buffer.

2015-11-19 08:15:30 +01:00

res_format_attr_opus.c

res_format_attr_opus: Update to latest RFC 7587.

2015-12-04 07:21:06 -06:00

res_format_attr_silk.c

res/res_format_attr_silk: Expose format attributes to other modules

2015-08-09 18:42:00 -05:00

res_format_attr_vp8.c

res_format_attr_vp8: In SDP, forward max-fr and max-fs for video-codec VP8.

2015-12-04 08:57:50 -06:00

res_hep_pjsip.c

PJSIP: Enforce module load dependencies

2014-10-16 14:35:00 +00:00

res_hep_rtcp.c

Stasis: Fix unsafe use of stasis_unsubscribe in modules.

2015-05-22 22:58:32 -04:00

res_hep.c

res_hep: fix major leak that occurs when config is missing or enabled=no.

2014-11-06 09:23:32 +00:00

res_hep.exports.in

res_hep/res_hep_pjsip: Add a HEPv3 capture agent module and a logger for PJSIP

2014-03-28 18:32:50 +00:00

res_http_post.c

Add module support level to ast_module_info structure. Print it in CLI "module show" .

2014-07-25 16:47:17 +00:00

res_http_websocket.c

res_http_websocket: Make core supported.

2016-04-05 12:21:32 -03:00

res_http_websocket.exports.in

res_http_websocket: Export symbol for ast_websocket_set_timeout

2014-06-26 18:27:53 +00:00

res_limit.c

Doxygen Updates - Title update

2012-10-14 21:44:27 +00:00

res_manager_devicestate.c

AMI: Make AMI actions that generate event lists consistent.

2015-01-09 17:54:49 +00:00

res_manager_presencestate.c

AMI: Make AMI actions that generate event lists consistent.

2015-01-09 17:54:49 +00:00

res_monitor.c

res_monitor: Add dependency on func_periodic_hook.

2015-04-13 07:27:40 -04:00

res_monitor.exports.in

…

res_musiconhold.c

musiconhold: Only warn if music class is not found in memory and database.

2016-03-24 13:45:06 +01:00

res_mutestream.c

Fix dialplan function NULL channel safety issues

2014-03-27 19:21:44 +00:00

res_mwi_external_ami.c

res_mwi_external_ami: Use module version of AMI registration.

2015-05-21 18:18:16 -05:00

res_mwi_external.c

voicemail: Move app_voicemail / res_mwi_external conflict to runtime

2016-01-04 16:28:48 -07:00

res_mwi_external.exports.in

External MWI core support.

2014-01-06 17:45:25 +00:00

res_odbc_transaction.c

res_odbc: Remove connection management

2016-01-29 08:32:35 -06:00

res_odbc_transaction.exports.in

res_odbc: Remove connection management

2016-01-29 08:32:35 -06:00

res_odbc.c

logging: Remove/fix some message annoyances

2016-02-03 13:07:07 -07:00

res_odbc.exports.in

res_odbc: Fix exports.in for missing symbols

2016-02-16 15:37:48 -07:00

res_parking.c

Merge "res_parking: Misc fixes." into 13

2016-03-29 08:53:45 -05:00

res_phoneprov.c

Resources/res_phoneprov: fix memory leak and heap-use-after-free

2016-02-11 19:59:02 +00:00

res_phoneprov.exports.in

res_phoneprov: Refactor phoneprov to allow pluggable config providers

2014-10-09 17:45:23 +00:00

res_pjproject.c

res_pjproject: Add ability to map pjproject log levels to Asterisk log levels

2016-02-18 16:30:18 -06:00

res_pjproject.exports.in

res_pjproject: Add module providing pjproject logging and utils

2016-01-20 06:13:41 -07:00

res_pjsip_acl.c

Audit ast_sockaddr_resolve() usage for memory leaks.

2015-03-17 21:49:30 +00:00

res_pjsip_authenticator_digest.c

PJSIP: Enforce module load dependencies

2014-10-16 14:35:00 +00:00

res_pjsip_caller_id.c

res_pjsip_caller_id: Anonymize 'From' when caller id presentation is prohibited

2016-03-03 19:32:33 -07:00

res_pjsip_config_wizard.c

res_pjsip_config_wizard: Add command to export primitive objects

2016-02-15 21:36:57 -06:00

res_pjsip_dialog_info_body_generator.c

res_pjsip_dialog_info: Add missing "direction" attribute in NOTIFY event

2016-04-08 05:48:51 -05:00

res_pjsip_diversion.c

SIP diversion: Fix REDIRECTING(reason) value inconsistencies.

2016-03-01 20:13:39 -06:00

res_pjsip_dlg_options.c

res_pjsip_dlg_options: Fix MODULEINFO section.

2015-05-02 03:15:15 -04:00

res_pjsip_dtmf_info.c

res_pjsip_dtmf_info: NULL terminate the message body.

2016-03-03 12:42:57 -04:00

res_pjsip_endpoint_identifier_anonymous.c

res_pjsip: Fix infinite recursion when loading transports from realtime

2016-02-08 18:08:32 -07:00

res_pjsip_endpoint_identifier_ip.c

res_pjsip: Strip spaces from items parsed from comma-separated lists

2016-03-07 12:15:58 -07:00

res_pjsip_endpoint_identifier_user.c

res_pjsip: Fix infinite recursion when loading transports from realtime

2016-02-08 18:08:32 -07:00

res_pjsip_exten_state.c

res_pjsip_pubsub: Solidify lifetime and ownership of objects.

2015-10-22 15:07:41 -05:00

res_pjsip_exten_state.exports.in

The large GULP->PJSIP renaming effort.

2013-07-30 18:14:50 +00:00

res_pjsip_header_funcs.c

PJSIP: Enforce module load dependencies

2014-10-16 14:35:00 +00:00

res_pjsip_history.c

res_pjsip_history: Add a module that provides PJSIP history for debugging

2015-12-26 11:50:03 -06:00

res_pjsip_logger.c

PJSIP: Enforce module load dependencies

2014-10-16 14:35:00 +00:00

res_pjsip_messaging.c

Merge "CHAOS: cleanup possible null vars on msg alloc failure" into 13

2016-03-02 18:12:00 -06:00

res_pjsip_multihomed.c

res_pjsip: Fix infinite recursion when loading transports from realtime

2016-02-08 18:08:32 -07:00

res_pjsip_mwi_body_generator.c

res_pjsip_mwi: Add voicemail extension and mwi_subscribe_replaces_unsolicited

2016-03-30 12:17:29 -06:00

res_pjsip_mwi.c

res_pjsip_mwi: Fix segv caused by 16c7d8e74a

2016-04-04 17:04:15 -06:00

res_pjsip_nat.c

res_pjsip: Fix infinite recursion when loading transports from realtime

2016-02-08 18:08:32 -07:00

res_pjsip_notify.c

res_pjsip: Strip spaces from items parsed from comma-separated lists

2016-03-07 12:15:58 -07:00

res_pjsip_one_touch_record_info.c

PJSIP: Enforce module load dependencies

2014-10-16 14:35:00 +00:00

res_pjsip_outbound_authenticator_digest.c

res_pjsip_outbound_authenticator_digest: Add missing outbound authenticator callback.

2015-04-30 14:13:42 -05:00

res_pjsip_outbound_publish.c

res_pjsip_outbound_publish: Add transport for outbound PUBLISH

2016-04-08 13:44:53 -05:00

res_pjsip_outbound_publish.exports.in

res_pjsip_outbound_publish: Add module which provides outbound PUBLISH support.

2014-08-07 14:35:09 +00:00

res_pjsip_outbound_registration.c

AST-2016-004: Fix crash on REGISTER with long URI.

2016-04-14 07:15:47 -05:00

res_pjsip_path.c

res_pjsip: Strip spaces from items parsed from comma-separated lists

2016-03-07 12:15:58 -07:00

res_pjsip_phoneprov_provider.c

res_pjsip_phoneprov_provider: Fix reference leak on unload

2015-04-09 22:35:11 +00:00

res_pjsip_pidf_body_generator.c

PJSIP XML, XPIDF: Fix buffer size overwrite memory corruption error.

2015-07-06 15:38:15 -05:00

res_pjsip_pidf_digium_body_supplement.c

res_pjsip: Ensure sanitized XML is NULL terminated.

2015-08-06 07:03:28 -03:00

res_pjsip_pidf_eyebeam_body_supplement.c

PJSIP: Enforce module load dependencies

2014-10-16 14:35:00 +00:00

res_pjsip_publish_asterisk.c

ASTERISK-24811: Add ast_sorcery_apply_config() to res_pjsip_publish_asterisk.

2015-02-20 17:46:17 +00:00

res_pjsip_pubsub.c

res_pjsip_mwi: Add voicemail extension and mwi_subscribe_replaces_unsolicited

2016-03-30 12:17:29 -06:00

res_pjsip_pubsub.exports.in

res_pjsip_mwi: Add voicemail extension and mwi_subscribe_replaces_unsolicited

2016-03-30 12:17:29 -06:00

res_pjsip_refer.c

res_pjsip_refer.c: Fix seg fault in process of Refer-to header.

2016-03-17 13:12:29 -05:00

res_pjsip_registrar_expire.c

res_pjsip contact: Lock expiration/addition of contacts

2016-04-11 13:00:14 -05:00

res_pjsip_registrar.c

res_pjsip_registrar: Fix bad memory-ness with user_agent.

2016-04-19 08:23:54 -05:00

res_pjsip_rfc3326.c

res_pjsip_rfc3326.c: Fix crash when channel goes away.

2015-11-13 15:31:02 -06:00

res_pjsip_sdp_rtp.c

res_pjsip: Fix infinite recursion when loading transports from realtime

2016-02-08 18:08:32 -07:00

res_pjsip_send_to_voicemail.c

Merge "res_pjsip_send_to_voicemail.c: Fix off-nominal double channel unref." into 13

2016-03-03 05:32:51 -06:00

res_pjsip_session.c

res_pjsip: Handle deferred SDP hold/unhold properly.

2016-04-05 16:12:47 -05:00

res_pjsip_session.exports.in

res_pjsip_refer: Fix occasional unexpected BYE sent after receiving a REFER.

2015-03-10 16:04:32 +00:00

res_pjsip_sips_contact.c

Use SIPS URIs in Contact headers when appropriate.

2015-01-29 20:58:12 +00:00

res_pjsip_t38.c

res_pjsip_t38.c: Back out part of an earlier fix attempt.

2016-02-29 12:50:19 -06:00

res_pjsip_transport_management.c

transport management: Register thread with PJProject.

2016-04-14 14:25:13 -05:00

res_pjsip_transport_websocket.c

res_pjsip: Fix infinite recursion when loading transports from realtime

2016-02-08 18:08:32 -07:00

res_pjsip_xpidf_body_generator.c

PJSIP XML, XPIDF: Fix buffer size overwrite memory corruption error.

2015-07-06 15:38:15 -05:00

res_pjsip.c

res_pjsip: Add headers to AMI Event ContactStatusDetail

2016-04-11 22:24:50 -05:00

res_pjsip.exports.in

res_pjsip: AMI commands and events.

2013-11-23 17:26:57 +00:00

res_pktccops.c

Fix printf problems with high ascii characters after r413586 (1.8).

2014-12-17 09:54:00 +00:00

res_pktccops.exports.in

…

res_realtime.c

Cleanup references to sipusers and sipfriends dynamic realtime families

2011-11-01 19:53:26 +00:00

res_rtp_asterisk.c

Merge "res_rtp_asterisk: Use separate SRTP session for RTCP with DTLS" into 13

2016-04-05 05:37:09 -05:00

res_rtp_multicast.c

Add module support level to ast_module_info structure. Print it in CLI "module show" .

2014-07-25 16:47:17 +00:00

res_security_log.c

Stasis: Fix unsafe use of stasis_unsubscribe in modules.

2015-05-22 22:58:32 -04:00

res_smdi.c

clang compiler warnings: Fix pointer-bool-converesion warnings

2015-04-08 11:44:32 +00:00

res_smdi.exports.in

…

res_snmp.c

Add module support level to ast_module_info structure. Print it in CLI "module show" .

2014-07-25 16:47:17 +00:00

res_sorcery_astdb.c

sorcery/res_pjsip: Refactor for realtime performance

2016-03-25 19:19:39 -06:00

res_sorcery_config.c

sorcery/res_pjsip: Refactor for realtime performance

2016-03-25 19:19:39 -06:00

res_sorcery_memory_cache.c

sorcery/res_pjsip: Refactor for realtime performance

2016-03-25 19:19:39 -06:00

res_sorcery_memory.c

sorcery/res_pjsip: Refactor for realtime performance

2016-03-25 19:19:39 -06:00

res_sorcery_realtime.c

sorcery/res_pjsip: Refactor for realtime performance

2016-03-25 19:19:39 -06:00

res_speech.c

Add module support level to ast_module_info structure. Print it in CLI "module show" .

2014-07-25 16:47:17 +00:00

res_speech.exports.in

app_speech_utils: Fix unresolved symbol ast_speech_get_setting().

2013-09-16 18:00:32 +00:00

res_srtp.c

res/res_srtp: Fix include issue for libsrtp 1.5.0

2014-10-27 01:47:26 +00:00

res_srtp.exports.in

Revert accidental change in r434261

2015-04-07 19:38:27 +00:00

res_stasis_answer.c

ARI: Fix a crash caused by hanging during playback to a channel in a bridge

2014-08-22 16:44:21 +00:00

res_stasis_answer.exports.in

Add missing exports file

2013-05-20 14:21:39 +00:00

res_stasis_device_state.c

res_stasis_device_state: Fix refcounting error.

2016-02-04 11:39:10 -06:00

res_stasis_device_state.exports.in

ARI: Implement device state API

2013-11-23 17:48:28 +00:00

res_stasis_mailbox.c

Add module support level to ast_module_info structure. Print it in CLI "module show" .

2014-07-25 16:47:17 +00:00

res_stasis_mailbox.exports.in

ARI: Add mailboxes resource for controlling and polling external MWI

2014-01-14 23:44:57 +00:00

res_stasis_playback.c

res_stasis: Add control ref to playback and recording structs.

2016-03-30 16:23:40 -05:00

res_stasis_playback.exports.in

This patch implements the REST API's for POST /channels/{channelId}/play

2013-05-23 20:11:35 +00:00

res_stasis_recording.c

Merge "res_stasis: Add control ref to playback and recording structs." into 13

2016-03-31 13:39:03 -05:00

res_stasis_recording.exports.in

ARI - channel recording support

2013-07-03 17:58:45 +00:00

res_stasis_snoop.c

res_stasis_snoop: Spying on a single direction continually increases CPU

2015-05-06 16:09:33 -05:00

res_stasis_snoop.exports.in

ari: Add Snoop operation for spying/whispering on channels.

2013-11-23 12:40:46 +00:00

res_stasis_test.c

Stasis: Allow message types to be blocked

2014-08-06 12:55:28 +00:00

res_stasis_test.exports.in

Initial support for endpoints.

2013-05-08 13:39:08 +00:00

res_stasis.c

Merge "res_stasis: Add control ref to playback and recording structs." into 13

2016-03-31 13:39:03 -05:00

res_stasis.exports.in

Moved core logic from app_stasis to res_stasis

2013-04-15 16:43:47 +00:00

res_statsd.c

res_statsd: Add functions that support variable arguments

2015-11-18 16:48:13 -06:00

res_statsd.exports.in

res_statsd: Fix exports.in for missing symbols

2016-02-16 11:20:57 -07:00

res_stun_monitor.c

Stasis: Allow message types to be blocked

2014-08-06 12:55:28 +00:00

res_timing_dahdi.c

Add module support level to ast_module_info structure. Print it in CLI "module show" .

2014-07-25 16:47:17 +00:00

res_timing_kqueue.c

res_timing: Don't close FD 0 when out of open files.

2015-07-02 12:10:22 +02:00

res_timing_pthread.c

res_timing_pthread: Fix leaky pipes.

2015-02-15 12:39:09 +00:00

res_timing_timerfd.c

res_timing: Don't close FD 0 when out of open files.

2015-07-02 12:10:22 +02:00

res_xmpp.c

res_xmpp: Does not connect in component mode

2016-02-02 06:48:01 -06:00

res_xmpp.exports.in

Add a new unified Jingle, Google Jingle, and Google Talk channel driver written from scratch called chan_motif.

2012-07-07 17:06:51 +00:00