Richard Mudgett ecd1f0eef5 chan_sip.c: Fix channel staging assertion failure. ...

The failing assertion ensures that the final snapshot gets generated so
CDR records can get finalized.  The only place where a channel staging
snapshot flag could be left set is in chan_sip.c:handle_request_bye().
The function could return before clearing the flag because the channel
could dissappear while the function had to have the channel unlocked.

* Fixed handle_request_bye() channel snapshot staging coverage area to not
have a return in the middle of it and be unable to clear the staging flag.

* Pushed the channel snapshot staging coverage area into
ast_rtp_instance_set_stats_vars() to ensure that the staging is not
interrutped.

* Made callers of ast_rtp_instance_set_stats_vars() not call it with any
channels or channel driver private locks held to eliminate the deadlock
potential.  The callers must hold references to the passed in channel and
rtp objects.

* Eliminated sip_hangup() trying to get the bridge peer.  It is futile at
this point because the channel could never be in a bridge.

Review: https://reviewboard.asterisk.org/r/3431/


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/12@412385 65c4cc65-6c06-0410-ace0-fbb531ad65f3

2014-04-15 17:01:33 +00:00

..

editline

memory leaks: Memory leak cleanup patch by Corey Farrell (first set)

2013-10-23 20:02:21 +00:00

stdtime

Fix some uninitialized buffers for CDR handling valgrind found.

2013-08-28 23:14:57 +00:00

abstract_jb.c

Fix jitter buffer log file creation

2013-09-18 19:59:24 +00:00

acl.c

PJSIP: TOS values should be represented as decimals in sorcery objects

2014-03-14 16:26:07 +00:00

adsi.c

Fix crash in unloading of res_adsi module

2012-06-26 13:23:12 +00:00

alaw.c

Multiple revisions 369001-369002

2012-06-15 16:20:16 +00:00

aoc.c

Fix documentation replication issues

2013-08-01 17:07:52 +00:00

app.c

res_mwi_external: Clear the stasis cache entry when the external MWI is deleted.

2014-03-14 15:55:51 +00:00

ast_expr2.c

Allow the REALTIME() function to report errors back to the caller.

2012-07-11 17:16:50 +00:00

ast_expr2.fl

…

ast_expr2.h

Allow the REALTIME() function to report errors back to the caller.

2012-07-11 17:16:50 +00:00

ast_expr2.y

…

ast_expr2f.c

Doxygen Updates - janitor work

2012-09-21 17:14:59 +00:00

asterisk.c

main/astobj2: Make REF_DEBUG a menuselect item; improve REF_DEBUG output

2014-04-11 02:48:50 +00:00

asterisk.dynamics

…

asterisk.exports.in

Add _IO_stdin_used in version-script to fix SIGBUSes on Sparc.

2013-08-22 08:26:55 +00:00

astfd.c

Unregister CLI commands on exit

2013-08-20 15:36:10 +00:00

astmm.c

MALLOC_DEBUG: Change fence magic number to be completely different from the freed magic number.

2013-09-09 23:23:02 +00:00

astobj2.c

main/astobj2: Make REF_DEBUG a menuselect item; improve REF_DEBUG output

2014-04-11 02:48:50 +00:00

audiohook.c

ari: Add Snoop operation for spying/whispering on channels.

2013-11-23 12:38:04 +00:00

autochan.c

Multiple revisions 369001-369002

2012-06-15 16:20:16 +00:00

autoservice.c

autoservice: fix reference leak of logger callid.

2014-04-14 15:53:26 +00:00

backtrace.c

Fix memory corruption when trying to get "core show locks".

2013-08-23 18:07:40 +00:00

bridge_after.c

CDRs: fix a variety of dial status problems, h/hangup handler creating CDRs

2014-01-31 23:40:24 +00:00

bridge_basic.c

bridging: Ensure locking during snapshot creation

2014-04-11 12:35:52 +00:00

bridge_channel.c

Fix stuck channel in ARI through the introduction of synchronous bridge actions.

2014-03-17 16:52:12 +00:00

bridge_roles.c

ARI: bridges/{bridgeID}/addChannel: add roles parameter

2013-08-05 16:59:13 +00:00

bridge.c

bridging: Ensure locking during snapshot creation

2014-04-11 12:35:52 +00:00

bucket.c

Prevent duplicate sorcery wizards from being applied to sorcery object types.

2014-03-25 17:52:39 +00:00

buildinfo.c

…

callerid.c

!fixup: callerid: Logic error in checksum processing

2014-03-17 21:56:57 +00:00

ccss.c

uniqueid: channel linkedid, ami, ari object creation with id's

2014-03-07 15:46:32 +00:00

cdr.c

cdr: Add asserts for when we don't know about a CDR for a channel

2014-03-18 15:28:13 +00:00

cel.c

uniqueid: channel linkedid, ami, ari object creation with id's

2014-03-07 15:46:32 +00:00

channel_internal_api.c

assigned-uniqueids: Miscellaneous cleanup and fixes.

2014-03-20 16:27:49 +00:00

channel.c

internal_timing: Remove the option and always make it enabled if a timing module is loaded.

2014-04-04 19:02:57 +00:00

chanvars.c

Multiple revisions 369001-369002

2012-06-15 16:20:16 +00:00

cli.c

verbosity: Fix performance of console verbose messages.

2014-01-14 18:03:06 +00:00

config_options.c

config_options: Display the see-also information for CLI config option help

2014-03-07 21:53:17 +00:00

config.c

config: Fix CB_ADD_LEN() to work as originally intended.

2014-04-08 20:51:55 +00:00

core_local.c

uniqueid: channel linkedid, ami, ari object creation with id's

2014-03-07 15:46:32 +00:00

core_unreal.c

assigned-uniqueids: Miscellaneous cleanup and fixes.

2014-03-20 16:27:49 +00:00

crypt.c

Fix utils directory breakage.

2013-07-04 13:06:15 +00:00

cygload.c

…

data.c

memory leaks: Memory leak cleanup patch by Corey Farrell (second set)

2013-10-24 16:58:30 +00:00

datastore.c

This is no longer needed.

2013-06-29 00:18:57 +00:00

db.c

Remove an extra ast_cond_wait() that slipped through the patch.

2014-03-14 20:53:35 +00:00

devicestate.c

stasis cache: Enhance to keep track of an item from different entities.

2014-03-07 20:28:12 +00:00

dial.c

assigned-uniqueids: Miscellaneous cleanup and fixes.

2014-03-20 16:27:49 +00:00

dns.c

res_pjsip: Enable PJSIP DNS client support.

2014-03-17 22:53:08 +00:00

dnsmgr.c

Migrate a large number of AMI events over to Stasis-Core

2013-05-24 20:44:07 +00:00

dsp.c

Doxygen Updates - Title update

2012-10-18 14:17:40 +00:00

ecdisa.h

…

endpoints.c

channel locking: Add locking for channel snapshot creation

2013-12-18 20:25:39 +00:00

enum.c

Migrate a large number of AMI events over to Stasis-Core

2013-05-24 20:44:07 +00:00

event.c

Fix incorrect usages of ast_realloc().

2013-09-10 18:03:45 +00:00

features_config.c

Fix dialplan function NULL channel safety issues

2014-03-27 19:15:35 +00:00

features.c

Documentation: doc fixes across various parts of the code for ASTERISK issues 23061,23028,23046,23027

2014-01-17 17:14:16 +00:00

file.c

Protect ast_filestream object when on a channel

2014-01-27 01:19:18 +00:00

fixedjitterbuf.c

Multiple revisions 369001-369002

2012-06-15 16:20:16 +00:00

fixedjitterbuf.h

…

format_cap.c

Cache string values of formats on ast_format_cap() to save processing.

2013-10-02 22:34:05 +00:00

format_pref.c

pjsip: fix support for allow=all

2014-01-17 21:32:18 +00:00

format.c

main/formats: Fix crash in ast_format_cmp during non-clean shutdown.

2014-03-27 18:24:24 +00:00

frame.c

Fix stuck channel in ARI through the introduction of synchronous bridge actions.

2014-03-17 16:52:12 +00:00

framehook.c

framehooks: Re-iterate if framehook provides different frame.

2013-12-17 18:25:26 +00:00

fskmodem_float.c

Multiple revisions 369001-369002

2012-06-15 16:20:16 +00:00

fskmodem_int.c

Multiple revisions 369001-369002

2012-06-15 16:20:16 +00:00

fskmodem.c

Multiple revisions 369001-369002

2012-06-15 16:20:16 +00:00

global_datastores.c

Multiple revisions 369001-369002

2012-06-15 16:20:16 +00:00

hashtab.c

Fix utilities compilation/linking.

2013-08-16 16:26:11 +00:00

heap.c

Fix incorrect usages of ast_realloc().

2013-09-10 18:03:45 +00:00

http.c

http: Fix spurious ERROR message in responses with no content

2014-04-04 15:11:48 +00:00

image.c

Reset automerge property.

2012-12-11 22:25:21 +00:00

indications.c

Fix incorrect usages of ast_realloc().

2013-09-10 18:03:45 +00:00

io.c

Multiple revisions 369001-369002

2012-06-15 16:20:16 +00:00

jitterbuf.c

jitterbuf: Fix memory leak on jitter buffer reset

2013-10-24 19:41:49 +00:00

json.c

json: Fix json API wrapper code for json library versions earlier than 2.3.0.

2014-02-21 17:43:00 +00:00

libasteriskssl.c

Resolve memory leaks in TLS initialization and TLS client connections

2012-09-14 19:53:43 +00:00

libasteriskssl.exports.in

…

loader.c

core/loader: Don't call dlclose in a while loop

2013-10-31 16:04:59 +00:00

lock.c

Fix DEBUG_THREADS when lock is acquired in __constructor__

2013-09-09 20:12:46 +00:00

logger.c

Logger: Fix handling of absolute paths

2014-02-05 20:43:07 +00:00

Makefile

Add the bucket API.

2013-08-23 21:49:47 +00:00

manager_bridges.c

bridging: Give bridges a name and a known creator

2013-12-17 23:17:32 +00:00

manager_channels.c

AGI/Manager: Prevent multiple NewExten events during AGI application changes

2014-04-07 16:02:44 +00:00

manager_endpoints.c

Remove dispatch object allocation from Stasis publishing

2013-09-30 18:48:57 +00:00

manager_mwi.c

Remove dispatch object allocation from Stasis publishing

2013-09-30 18:48:57 +00:00

manager_system.c

Optimize how Stasis forwards are dispatched

2013-09-30 18:39:34 +00:00

manager.c

http: response body often missing after specific request

2014-03-28 16:17:52 +00:00

md5.c

md5: supress some compiler warnings.

2012-04-28 01:33:49 +00:00

media_index.c

media_index: Make media indexing tolerable of bad symlinks.

2013-12-03 16:37:26 +00:00

message.c

Fix dialplan function NULL channel safety issues

2014-03-27 19:15:35 +00:00

mixmonitor.c

Removed quotes from svn:keywords props on a few files.

2013-07-29 17:51:25 +00:00

named_acl.c

Fix various memory leaks

2013-08-30 19:20:47 +00:00

netsock2.c

Add IPv6 Support To chan_iax2

2013-10-04 21:40:33 +00:00

netsock.c

Add IPv6 Support To chan_iax2

2013-10-04 21:40:33 +00:00

optional_api.c

optional_api: Make always use the standard malloc functions even with MALLOC_DEBUG.

2013-09-19 23:16:31 +00:00

parking.c

astobj2: Add warn unused attribute to some functions.

2013-09-06 19:20:06 +00:00

pbx.c

uniqueid: channel linkedid, ami, ari object creation with id's

2014-03-07 15:46:32 +00:00

pickup.c

channel locking: Add locking for channel snapshot creation

2013-12-18 20:25:39 +00:00

plc.c

Multiple revisions 369001-369002

2012-06-15 16:20:16 +00:00

poll.c

…

presencestate.c

Strip down the old event system

2013-08-17 14:39:27 +00:00

privacy.c

Multiple revisions 369001-369002

2012-06-15 16:20:16 +00:00

rtp_engine.c

chan_sip.c: Fix channel staging assertion failure.

2014-04-15 17:01:33 +00:00

say.c

say: Fix a bug where SayNumber in Polish tries to play incorrect sound.

2014-03-26 22:44:40 +00:00

sched.c

Multiple revisions 369001-369002

2012-06-15 16:20:16 +00:00

sdp_srtp.c

Merge in current pimp_my_sip work, including:

2013-06-22 14:03:22 +00:00

security_events.c

security_events: Fix assertion failure in dev-mode on optional IE parsing

2014-02-07 20:09:01 +00:00

sem.c

Taskprocessor optimization; switch Stasis to use taskprocessors

2013-09-30 18:26:27 +00:00

sha1.c

Doxygen Updates - janitor work

2012-09-21 17:14:59 +00:00

sip_api.c

Don't make chan_sip export global symbols.

2012-10-11 15:49:02 +00:00

slinfactory.c

Fix a memory copying bug in slinfactory which was causing mixmonitor issues.

2013-05-28 17:47:29 +00:00

sorcery.c

Give sorcery instances a reference to their wizards.

2014-03-27 14:20:10 +00:00

sounds_index.c

Whitespace fixes.

2013-12-20 19:06:12 +00:00

srv.c

Removed #if checks for crazy old versions of OS X.

2013-05-08 20:25:28 +00:00

stasis_bridges.c

res_stasis: Enable transfers and provide events when they occur.

2014-02-01 16:23:56 +00:00

stasis_cache_pattern.c

Optimize how Stasis forwards are dispatched

2013-09-30 18:39:34 +00:00

stasis_cache.c

Add some asserts that were handy when looking for a stasis cache problem.

2014-04-04 17:53:20 +00:00

stasis_channels.c

stasis_channels.c: Eliminate another overuse of RAII_VAR().

2014-04-01 22:24:39 +00:00

stasis_endpoints.c

ARI: correct upper/lower case URI discrepancies

2014-02-14 21:44:34 +00:00

stasis_message_router.c

stasis: Add methods to allow for synchronous publishing to subscriber

2014-01-12 21:55:11 +00:00

stasis_message.c

stasis cache: Enhance to keep track of an item from different entities.

2014-03-07 20:28:12 +00:00

stasis_system.c

Convert CCSS manager events to stasis.

2013-07-19 18:00:35 +00:00

stasis.c

stasis.c: Misc code cleanups.

2014-02-28 23:29:58 +00:00

strcompat.c

Add builtin roundf() for systems lacking it.

2013-01-19 20:54:07 +00:00

strings.c

string container: Remove unnecessary RAII_VAR usage and string object lock.

2014-01-14 21:44:10 +00:00

stun.c

Reset automerge property.

2012-12-11 22:25:21 +00:00

syslog.c

Multiple revisions 369001-369002

2012-06-15 16:20:16 +00:00

taskprocessor.c

taskprocessor: Made use pthread_equal() to compare thread ids.

2013-10-25 23:52:13 +00:00

tcptls.c

http: response body often missing after specific request

2014-03-28 16:17:52 +00:00

tdd.c

Doxygen Updates - janitor work

2012-09-21 17:14:59 +00:00

term.c

Revamp of terminal color codes

2013-02-14 18:47:56 +00:00

test.c

test.c: Fix too sticky unit test failed status.

2013-12-13 20:06:53 +00:00

threadpool.c

Fix threadpool rapid growth problem.

2013-06-20 16:29:35 +00:00

threadstorage.c

Unregister CLI commands on exit

2013-08-20 15:36:10 +00:00

timing.c

Reset automerge property.

2012-12-11 22:25:21 +00:00

translate.c

translate: Move freeing of frame to after it is used.

2013-11-22 17:11:46 +00:00

udptl.c

res_rtp_asterisk & udptl: fix port selection to work with SELinux restrictions

2014-01-30 20:34:43 +00:00

ulaw.c

Multiple revisions 369001-369002

2012-06-15 16:20:16 +00:00

utils.c

Add some asserts that were handy when looking for a stasis cache problem.

2014-04-04 17:53:20 +00:00

uuid.c

Add an \extref doxygen pointer for libuuid.

2013-04-26 20:32:11 +00:00

xml.c

Detect and use xsltCleanupGlobals when available

2013-10-03 17:57:49 +00:00

xmldoc.c

func_channel, chan_pjsip: Add CHANNEL read function support for chan_pjsip

2013-12-11 13:05:12 +00:00