mirror of
https://github.com/asterisk/asterisk.git
synced 2025-10-10 14:51:09 +00:00
9bed50db41
With the new work in Asterisk 12, there are some uses of the optional_api that are prone to failure. The details are rather involved, and captured on [the wiki][1]. This patch addresses the issue by removing almost all of the magic from the optional API implementation. Instead of relying on weak symbol resolution, a new optional_api.c module was added to Asterisk core. For modules providing an optional API, the pointer to the implementation function is registered with the core. For modules that use an optional API, a pointer to a stub function, along with a optional_ref function pointer are registered with the core. The optional_ref function pointers is set to the implementation function when it's provided, or the stub function when it's now. Since the implementation no longer relies on magic, it is now supported on all platforms. In the spirit of choice, an OPTIONAL_API flag was added, so we can disable the optional_api if needed (maybe it's buggy on some bizarre platform I haven't tested on) The AST_OPTIONAL_API*() macros themselves remained unchanged, so existing code could remain unchanged. But to help with debugging the optional_api, the patch limits the #include of optional API's to just the modules using the API. This also reduces resource waste maintaining optional_ref pointers that aren't used. Other changes made as a part of this patch: * The stubs for http_websocket that wrap system calls set errno to ENOSYS. * res_http_websocket now properly increments module use count. * In loader.c, the while() wrappers around dlclose() were removed. The while(!dlclose()) is actually an anti-pattern, which can lead to infinite loops if the module you're attempting to unload exports a symbol that was directly linked to. * The special handling of nonoptreq on systems without weak symbol support was removed, since we no longer rely on weak symbols for optional_api. [1]: https://wiki.asterisk.org/wiki/x/wACUAQ (closes issue ASTERISK-22296) Reported by: Matt Jordan Review: https://reviewboard.asterisk.org/r/2797/ ........ Merged revisions 397989 from http://svn.asterisk.org/svn/asterisk/branches/12 git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@397990 65c4cc65-6c06-0410-ace0-fbb531ad65f3
84 lines
2.0 KiB
C
84 lines
2.0 KiB
C
/*
|
|
* Asterisk -- An open source telephony toolkit.
|
|
*
|
|
* Copyright (C) 1999 - 2005, Digium, Inc.
|
|
*
|
|
* Mark Spencer <markster@digium.com>
|
|
*
|
|
* See http://www.asterisk.org for more information about
|
|
* the Asterisk project. Please do not directly contact
|
|
* any of the maintainers of this project for assistance;
|
|
* the project provides a web site, mailing lists and IRC
|
|
* channels for your use.
|
|
*
|
|
* This program is free software, distributed under the terms of
|
|
* the GNU General Public License Version 2. See the LICENSE file
|
|
* at the top of the source tree.
|
|
*/
|
|
|
|
/*! \file
|
|
* \brief Compiler-specific macros and other items
|
|
*/
|
|
|
|
#ifndef _ASTERISK_COMPILER_H
|
|
#define _ASTERISK_COMPILER_H
|
|
|
|
#ifdef HAVE_ATTRIBUTE_always_inline
|
|
#define force_inline __attribute__((always_inline)) inline
|
|
#else
|
|
#define force_inline inline
|
|
#endif
|
|
|
|
#ifdef HAVE_ATTRIBUTE_pure
|
|
#define attribute_pure __attribute__((pure))
|
|
#else
|
|
#define attribute_pure
|
|
#endif
|
|
|
|
#ifdef HAVE_ATTRIBUTE_const
|
|
#define attribute_const __attribute__((const))
|
|
#else
|
|
#define attribute_const
|
|
#endif
|
|
|
|
#ifdef HAVE_ATTRIBUTE_deprecated
|
|
#define attribute_deprecated __attribute__((deprecated))
|
|
#else
|
|
#define attribute_deprecated
|
|
#endif
|
|
|
|
#ifdef HAVE_ATTRIBUTE_unused
|
|
#define attribute_unused __attribute__((unused))
|
|
#else
|
|
#define attribute_unused
|
|
#endif
|
|
|
|
#ifdef HAVE_ATTRIBUTE_malloc
|
|
#define attribute_malloc __attribute__((malloc))
|
|
#else
|
|
#define attribute_malloc
|
|
#endif
|
|
|
|
#ifdef HAVE_ATTRIBUTE_sentinel
|
|
#define attribute_sentinel __attribute__((sentinel))
|
|
#else
|
|
#define attribute_sentinel
|
|
#endif
|
|
|
|
#ifdef HAVE_ATTRIBUTE_warn_unused_result
|
|
#define attribute_warn_unused_result __attribute__((warn_unused_result))
|
|
#else
|
|
#define attribute_warn_unused_result
|
|
#endif
|
|
|
|
#ifdef HAVE_ATTRIBUTE_may_alias
|
|
#define attribute_may_alias __attribute__((may_alias))
|
|
#else
|
|
#define attribute_may_alias
|
|
#endif
|
|
|
|
/* Some older version of GNU gcc (3.3.5 on OpenBSD 4.3 for example) dont like 'NULL' as sentinel */
|
|
#define SENTINEL ((char *)NULL)
|
|
|
|
#endif /* _ASTERISK_COMPILER_H */
|