Files
firefly-iii/app/Validation/RecurrenceValidation.php

422 lines
18 KiB
PHP
Raw Normal View History

2018-07-05 18:02:02 +02:00
<?php
/**
* RecurrenceValidation.php
2020-02-16 13:58:22 +01:00
* Copyright (c) 2019 james@firefly-iii.org
2018-07-05 18:02:02 +02:00
*
* This file is part of Firefly III (https://github.com/firefly-iii).
2018-07-05 18:02:02 +02:00
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU Affero General Public License as
* published by the Free Software Foundation, either version 3 of the
* License, or (at your option) any later version.
2018-07-05 18:02:02 +02:00
*
* This program is distributed in the hope that it will be useful,
2018-07-05 18:02:02 +02:00
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU Affero General Public License for more details.
2018-07-05 18:02:02 +02:00
*
* You should have received a copy of the GNU Affero General Public License
* along with this program. If not, see <https://www.gnu.org/licenses/>.
2018-07-05 18:02:02 +02:00
*/
declare(strict_types=1);
namespace FireflyIII\Validation;
use Carbon\Carbon;
2021-03-15 19:51:55 +01:00
use FireflyIII\Models\Recurrence;
use FireflyIII\Models\RecurrenceTransaction;
2023-05-29 13:56:55 +02:00
use Illuminate\Support\Facades\Log;
2018-07-05 18:02:02 +02:00
use Illuminate\Validation\Validator;
use InvalidArgumentException;
/**
* Trait RecurrenceValidation
*
* Contains advanced validation rules used in validation of new and existing recurrences.
*
*/
trait RecurrenceValidation
{
2019-08-27 05:57:09 +02:00
/**
* Validate account information input for recurrences which are being updated.
*
2022-10-30 11:43:17 +01:00
* TODO Must always trigger when the type of the recurrence changes.
2019-08-27 05:57:09 +02:00
*
2023-06-21 12:34:58 +02:00
* @param Validator $validator
2019-08-27 05:57:09 +02:00
*/
public function valUpdateAccountInfo(Validator $validator): void
{
$data = $validator->getData();
$transactionType = $data['type'] ?? 'invalid';
2021-03-15 19:51:55 +01:00
// grab model from parameter and try to set the transaction type from it
if ('invalid' === $transactionType) {
Log::debug('Type is invalid but we will search for it.');
/** @var Recurrence $recurrence */
$recurrence = $this->route()->parameter('recurrence');
if (null !== $recurrence) {
Log::debug('There is a recurrence in the route.');
// ok so we have a recurrence should be able to extract type somehow.
2021-04-06 08:51:27 +02:00
/** @var RecurrenceTransaction|null $first */
2021-03-15 19:51:55 +01:00
$first = $recurrence->recurrenceTransactions()->first();
if (null !== $first) {
$transactionType = $first->transactionType ? $first->transactionType->type : 'withdrawal';
Log::debug(sprintf('Determined type to be %s.', $transactionType));
}
2021-03-21 09:15:40 +01:00
if (null === $first) {
2022-10-30 14:44:49 +01:00
app('log')->warning('Just going to assume type is a withdrawal.');
2021-03-15 19:51:55 +01:00
$transactionType = 'withdrawal';
}
}
}
$transactions = $data['transactions'] ?? [];
2019-08-27 05:57:09 +02:00
/** @var AccountValidator $accountValidator */
$accountValidator = app(AccountValidator::class);
Log::debug(sprintf('Going to loop %d transaction(s)', count($transactions)));
foreach ($transactions as $index => $transaction) {
$transactionType = $transaction['type'] ?? $transactionType;
$accountValidator->setTransactionType($transactionType);
2021-03-21 09:15:40 +01:00
if (
!array_key_exists('source_id', $transaction)
&& !array_key_exists('destination_id', $transaction)
&& !array_key_exists('source_name', $transaction)
&& !array_key_exists('destination_name', $transaction)
2021-03-20 19:17:22 +01:00
) {
continue;
}
2019-08-27 05:57:09 +02:00
// validate source account.
2022-12-29 19:42:40 +01:00
$sourceId = array_key_exists('source_id', $transaction) ? (int)$transaction['source_id'] : null;
2019-08-27 05:57:09 +02:00
$sourceName = $transaction['source_name'] ?? null;
2022-02-23 06:33:27 +01:00
$validSource = $accountValidator->validateSource(['id' => $sourceId, 'name' => $sourceName]);
2019-08-27 05:57:09 +02:00
// do something with result:
if (false === $validSource) {
$validator->errors()->add(sprintf('transactions.%d.source_id', $index), $accountValidator->sourceError);
$validator->errors()->add(sprintf('transactions.%d.source_name', $index), $accountValidator->sourceError);
return;
}
// validate destination account
2022-12-29 19:42:40 +01:00
$destinationId = array_key_exists('destination_id', $transaction) ? (int)$transaction['destination_id'] : null;
2019-08-27 05:57:09 +02:00
$destinationName = $transaction['destination_name'] ?? null;
2021-12-18 12:35:17 +01:00
$validDestination = $accountValidator->validateDestination(['id' => $destinationId, 'name' => $destinationName,]);
2019-08-27 05:57:09 +02:00
// do something with result:
if (false === $validDestination) {
$validator->errors()->add(sprintf('transactions.%d.destination_id', $index), $accountValidator->destError);
$validator->errors()->add(sprintf('transactions.%d.destination_name', $index), $accountValidator->destError);
return;
}
}
}
2018-08-06 19:14:30 +02:00
/**
* Adds an error to the validator when there are no repetitions in the array of data.
*
2023-06-21 12:34:58 +02:00
* @param Validator $validator
2018-08-06 19:14:30 +02:00
*/
public function validateOneRepetition(Validator $validator): void
{
$data = $validator->getData();
$repetitions = $data['repetitions'] ?? [];
// need at least one transaction
2022-11-04 05:11:05 +01:00
if (!is_countable($repetitions) || 0 === count($repetitions)) {
2022-12-29 19:42:40 +01:00
$validator->errors()->add('repetitions', (string)trans('validation.at_least_one_repetition'));
2018-08-06 19:14:30 +02:00
}
}
/**
* Adds an error to the validator when there are no repetitions in the array of data.
*
2023-06-21 12:34:58 +02:00
* @param Validator $validator
*/
public function validateOneRepetitionUpdate(Validator $validator): void
{
$data = $validator->getData();
$repetitions = $data['repetitions'] ?? null;
if (null === $repetitions) {
return;
}
// need at least one transaction
2022-11-04 05:11:05 +01:00
if (0 === count($repetitions)) {
2022-12-29 19:42:40 +01:00
$validator->errors()->add('repetitions', (string)trans('validation.at_least_one_repetition'));
}
}
2018-08-06 19:14:30 +02:00
/**
* Validates that the recurrence has valid repetition information. It either doesn't stop,
* or stops after X times or at X date. Not both of them.,
*
2023-06-21 12:34:58 +02:00
* @param Validator $validator
2018-08-06 19:14:30 +02:00
*/
public function validateRecurrenceRepetition(Validator $validator): void
{
$data = $validator->getData();
$repetitions = $data['nr_of_repetitions'] ?? null;
$repeatUntil = $data['repeat_until'] ?? null;
if (null !== $repetitions && null !== $repeatUntil) {
// expect a date OR count:
2022-12-29 19:42:40 +01:00
$validator->errors()->add('repeat_until', (string)trans('validation.require_repeat_until'));
$validator->errors()->add('nr_of_repetitions', (string)trans('validation.require_repeat_until'));
2018-08-06 19:14:30 +02:00
}
}
2021-03-21 09:15:40 +01:00
public function validateRecurringConfig(Validator $validator)
{
$data = $validator->getData();
2022-12-29 19:42:40 +01:00
$reps = array_key_exists('nr_of_repetitions', $data) ? (int)$data['nr_of_repetitions'] : null;
2021-03-21 09:15:40 +01:00
$repeatUntil = array_key_exists('repeat_until', $data) ? new Carbon($data['repeat_until']) : null;
if (null === $reps && null === $repeatUntil) {
$validator->errors()->add('nr_of_repetitions', trans('validation.require_repeat_until'));
$validator->errors()->add('repeat_until', trans('validation.require_repeat_until'));
return;
}
if ($reps > 0 && null !== $repeatUntil) {
$validator->errors()->add('nr_of_repetitions', trans('validation.require_repeat_until'));
$validator->errors()->add('repeat_until', trans('validation.require_repeat_until'));
}
}
2018-07-05 18:02:02 +02:00
/**
2023-06-21 12:34:58 +02:00
* @param Validator $validator
2018-07-05 18:02:02 +02:00
*/
public function validateRepetitionMoment(Validator $validator): void
{
$data = $validator->getData();
$repetitions = $data['repetitions'] ?? [];
2021-03-06 16:15:39 +01:00
if (!is_array($repetitions)) {
2022-12-29 19:42:40 +01:00
$validator->errors()->add(sprintf('repetitions.%d.type', 0), (string)trans('validation.valid_recurrence_rep_type'));
2021-03-06 16:15:39 +01:00
return;
}
2018-07-05 18:02:02 +02:00
/**
2023-06-21 12:34:58 +02:00
* @var int $index
2018-07-05 18:02:02 +02:00
* @var array $repetition
*/
foreach ($repetitions as $index => $repetition) {
2021-03-12 18:31:19 +01:00
if (!array_key_exists('moment', $repetition)) {
$repetition['moment'] = '';
2021-03-12 18:31:19 +01:00
}
if (null === $repetition['moment']) {
2021-03-06 16:15:39 +01:00
$repetition['moment'] = '';
}
$repetition['moment'] = $repetition['moment'] ?? 'invalid';
2019-08-22 17:56:48 +02:00
switch ($repetition['type'] ?? 'empty') {
2018-07-05 18:02:02 +02:00
default:
2022-12-29 19:42:40 +01:00
$validator->errors()->add(sprintf('repetitions.%d.type', $index), (string)trans('validation.valid_recurrence_rep_type'));
2018-07-05 18:02:02 +02:00
return;
case 'daily':
2022-12-29 19:42:40 +01:00
$this->validateDaily($validator, $index, (string)$repetition['moment']);
2018-07-05 18:02:02 +02:00
break;
case 'monthly':
2022-12-29 19:42:40 +01:00
$this->validateMonthly($validator, $index, (int)$repetition['moment']);
2018-07-05 18:02:02 +02:00
break;
case 'ndom':
2022-12-29 19:42:40 +01:00
$this->validateNdom($validator, $index, (string)$repetition['moment']);
2018-07-05 18:02:02 +02:00
break;
case 'weekly':
2022-12-29 19:42:40 +01:00
$this->validateWeekly($validator, $index, (int)$repetition['moment']);
2018-07-05 18:02:02 +02:00
break;
case 'yearly':
2022-12-29 19:42:40 +01:00
$this->validateYearly($validator, $index, (string)$repetition['moment']);
2018-07-05 18:02:02 +02:00
break;
}
}
}
/**
* If the repetition type is daily, the moment should be empty.
*
2023-06-21 12:34:58 +02:00
* @param Validator $validator
* @param int $index
* @param string $moment
2018-07-05 18:02:02 +02:00
*/
protected function validateDaily(Validator $validator, int $index, string $moment): void
{
if ('' !== $moment) {
2022-12-29 19:42:40 +01:00
$validator->errors()->add(sprintf('repetitions.%d.moment', $index), (string)trans('validation.valid_recurrence_rep_moment'));
2018-07-05 18:02:02 +02:00
}
}
/**
* If the repetition type is monthly, the moment should be a day between 1-31 (inclusive).
*
2023-06-21 12:34:58 +02:00
* @param Validator $validator
* @param int $index
* @param int $dayOfMonth
2018-07-05 18:02:02 +02:00
*/
protected function validateMonthly(Validator $validator, int $index, int $dayOfMonth): void
{
if ($dayOfMonth < 1 || $dayOfMonth > 31) {
2022-12-29 19:42:40 +01:00
$validator->errors()->add(sprintf('repetitions.%d.moment', $index), (string)trans('validation.valid_recurrence_rep_moment'));
2018-07-05 18:02:02 +02:00
}
}
/**
* If the repetition type is "ndom", the first part must be between 1-5 (inclusive), for the week in the month,
* and the second one must be between 1-7 (inclusive) for the day of the week.
*
2023-06-21 12:34:58 +02:00
* @param Validator $validator
* @param int $index
* @param string $moment
2018-07-05 18:02:02 +02:00
*/
protected function validateNdom(Validator $validator, int $index, string $moment): void
{
$parameters = explode(',', $moment);
if (2 !== count($parameters)) {
2022-12-29 19:42:40 +01:00
$validator->errors()->add(sprintf('repetitions.%d.moment', $index), (string)trans('validation.valid_recurrence_rep_moment'));
2018-07-05 18:02:02 +02:00
return;
}
2022-12-29 19:42:40 +01:00
$nthDay = (int)($parameters[0] ?? 0.0);
$dayOfWeek = (int)($parameters[1] ?? 0.0);
2018-07-05 18:02:02 +02:00
if ($nthDay < 1 || $nthDay > 5) {
2022-12-29 19:42:40 +01:00
$validator->errors()->add(sprintf('repetitions.%d.moment', $index), (string)trans('validation.valid_recurrence_rep_moment'));
2018-07-05 18:02:02 +02:00
return;
}
if ($dayOfWeek < 1 || $dayOfWeek > 7) {
2022-12-29 19:42:40 +01:00
$validator->errors()->add(sprintf('repetitions.%d.moment', $index), (string)trans('validation.valid_recurrence_rep_moment'));
2018-07-05 18:02:02 +02:00
}
}
2023-06-03 21:17:49 +02:00
/**
2023-06-21 12:34:58 +02:00
* If the repetition type is weekly, the moment should be a day between 1-7 (inclusive).
*
* @param Validator $validator
* @param int $index
* @param int $dayOfWeek
*/
protected function validateWeekly(Validator $validator, int $index, int $dayOfWeek): void
{
if ($dayOfWeek < 1 || $dayOfWeek > 7) {
$validator->errors()->add(sprintf('repetitions.%d.moment', $index), (string)trans('validation.valid_recurrence_rep_moment'));
}
}
/**
* If the repetition type is yearly, the moment should be a valid date.
*
* @param Validator $validator
* @param int $index
* @param string $moment
*/
protected function validateYearly(Validator $validator, int $index, string $moment): void
{
try {
Carbon::createFromFormat('Y-m-d', $moment);
} catch (InvalidArgumentException $e) {
Log::debug(sprintf('Invalid argument for Carbon: %s', $e->getMessage()));
$validator->errors()->add(sprintf('repetitions.%d.moment', $index), (string)trans('validation.valid_recurrence_rep_moment'));
}
}
/**
* @param Validator $validator
2023-06-03 21:17:49 +02:00
* @return void
*/
protected function validateTransactionId(Recurrence $recurrence, Validator $validator): void
{
Log::debug('Now in validateTransactionId');
$transactions = $this->getTransactionData();
$submittedTrCount = count($transactions);
//$recurrence = $validator->get
if (null === $transactions) {
Log::warning('[a] User submitted no transactions.');
$validator->errors()->add('transactions', (string)trans('validation.at_least_one_transaction'));
return;
}
if (0 === $submittedTrCount) {
Log::warning('[b] User submitted no transactions.');
$validator->errors()->add('transactions', (string)trans('validation.at_least_one_transaction'));
return;
}
$originalTrCount = $recurrence->recurrenceTransactions()->count();
if (1 === $submittedTrCount && 1 === $originalTrCount) {
$first = $transactions[0]; // can safely assume index 0.
if (!array_key_exists('id', $first)) {
Log::debug('Single count and no ID, done.');
return; // home safe!
}
$id = $first['id'];
if ('' === (string)$id) {
Log::debug('Single count and empty ID, done.');
return; // home safe!
}
$integer = (int)$id;
$secondCount = $recurrence->recurrenceTransactions()->where('recurrences_transactions.id', $integer)->count();
Log::debug(sprintf('Result of ID count: %d', $secondCount));
if (0 === $secondCount) {
$validator->errors()->add('transactions.0.id', (string)trans('validation.id_does_not_match', ['id' => $integer]));
}
Log::debug('Single ID validation done.');
return;
}
Log::debug('Multi ID validation.');
$idsMandatory = false;
if ($submittedTrCount < $originalTrCount) {
Log::debug(sprintf('User submits %d transaction, recurrence has %d transactions. All entries must have ID.', $submittedTrCount, $originalTrCount));
$idsMandatory = true;
}
/**
* Loop all transactions submitted by the user.
* If the user has submitted fewer transactions than the original recurrence has, all submitted entries must have an ID.
* Any ID's missing will be deleted later on.
*
* If the user submits more or the same number of transactions (n), the following rules apply:
*
* 1. Any 1 transaction does not need to have an ID. Since the other n-1 can be matched, the last one can be assumed.
* 2. If the user submits more transactions than already present, count the number of existing transactions. At least those must be matched. After that, submit as many as you like.
* 3. If the user submits the same number of transactions as already present, all but one must have an ID.
*/
$unmatchedIds = 0;
foreach ($transactions as $index => $transaction) {
Log::debug(sprintf('Now at %d/%d', $index + 1, $submittedTrCount));
if (!is_array($transaction)) {
Log::warning('Not an array. Give error.');
$validator->errors()->add(sprintf('transactions.%d.id', $index), (string)trans('validation.at_least_one_transaction'));
return;
}
if (!array_key_exists('id', $transaction) && $idsMandatory) {
Log::warning('ID is mandatory but array has no ID.');
$validator->errors()->add(sprintf('transactions.%d.id', $index), (string)trans('validation.need_id_to_match'));
return;
}
if (array_key_exists('id', $transaction)) { // don't matter if $idsMandatory
Log::debug('Array has ID.');
$idCount = $recurrence->recurrenceTransactions()->where('recurrences_transactions.id', (int)$transaction['id'])->count();
if (0 === $idCount) {
Log::debug('ID does not exist or no match. Count another unmatched ID.');
$unmatchedIds++;
}
}
if (!array_key_exists('id', $transaction) && !$idsMandatory) {
Log::debug('Array has no ID but was not mandatory at this point.');
$unmatchedIds++;
}
}
// if too many don't match, but you haven't submitted more than already present:
$maxUnmatched = max(1, $submittedTrCount - $originalTrCount);
Log::debug(sprintf('Submitted: %d. Original: %d. User can submit %d unmatched transactions.', $submittedTrCount, $originalTrCount, $maxUnmatched));
if ($unmatchedIds > $maxUnmatched) {
Log::warning(sprintf('Too many unmatched transactions (%d).', $unmatchedIds));
$validator->errors()->add('transactions.0.id', (string)trans('validation.too_many_unmatched'));
return;
}
Log::debug('Done with ID validation.');
}
}