diff --git a/app/Http/Controllers/HomeController.php b/app/Http/Controllers/HomeController.php index 9263a25937..7473aa1bb1 100644 --- a/app/Http/Controllers/HomeController.php +++ b/app/Http/Controllers/HomeController.php @@ -17,10 +17,8 @@ use Carbon\Carbon; use FireflyIII\Exceptions\FireflyException; use FireflyIII\Helpers\Collector\JournalCollectorInterface; use FireflyIII\Models\AccountType; -use FireflyIII\Models\Tag; use FireflyIII\Repositories\Account\AccountRepositoryInterface as ARI; use FireflyIII\Repositories\Bill\BillRepositoryInterface; -use FireflyIII\Repositories\Tag\TagRepositoryInterface; use Illuminate\Http\Request; use Illuminate\Support\Collection; use Log; @@ -86,30 +84,14 @@ class HomeController extends Controller } /** - * @param TagRepositoryInterface $repository + * @param Request $request * * @return \Illuminate\Http\RedirectResponse|\Illuminate\Routing\Redirector */ - public function flush(TagRepositoryInterface $repository) + public function flush(Request $request) { - Preferences::mark(); - - // get all tags. - // update all counts: - $tags = $repository->get(); - - /** @var Tag $tag */ - foreach ($tags as $tag) { - foreach ($tag->transactionJournals()->get() as $journal) { - $count = $journal->tags()->count(); - $journal->tag_count = $count; - $journal->save(); - } - } - Session::forget(['start', 'end', 'viewRange', 'range', 'is_custom_range']); - - Session::clear(); + $request->session()->forget(['start', 'end', 'viewRange', 'range', 'is_custom_range']); Artisan::call('cache:clear'); return redirect(route('index')); @@ -159,74 +141,6 @@ class HomeController extends Controller ); } - /** - * Display a list of named routes. Excludes some that cannot be "shown". This method - * is used to generate help files (down the road). - */ - public function routes() - { - // these routes are not relevant for the help pages: - $ignore = [ - // login and two-factor routes: - 'login', - 'registe', - 'password.rese', - 'logout', - 'two-fac', - 'lost-two', - // test troutes - 'test-flash', - 'all-routes', - // json routes - 'json.', - // routes that point to modals or that redirect immediately. - 'piggy-banks.add', - 'piggy-banks.remove', - 'rules.rule.up', - 'attachments.download', - 'bills.rescan', - 'rules.rule.down', - 'rules.rule-group.up', - 'rules.rule-group.down', - 'popup.', - 'error', - 'flush', - //'preferences.', - 'admin.users.domains.block-', - 'help.', - // ajax routes: - 'import.json', - // charts: - 'chart.', - // report data: - 'report-data.', - - // others: - 'debugbar', - 'attachments.preview', - 'budgets.income', - 'currencies.default', - - - ]; - $routes = Route::getRoutes(); - $return = '
';
-
-        /** @var \Illuminate\Routing\Route $route */
-        foreach ($routes as $route) {
-            $name    = $route->getName();
-            $methods = $route->getMethods();
-
-            if (!is_null($name) && strlen($name) > 0 && in_array('GET', $methods) && !$this->startsWithAny($ignore, $name)) {
-                $return .= sprintf('touch %s.md', $name) . "\n";
-
-            }
-        }
-        $return .= '

'; - - return $return; - } - /** * @return \Illuminate\Http\RedirectResponse|\Illuminate\Routing\Redirector */ @@ -240,21 +154,4 @@ class HomeController extends Controller return redirect(route('home')); } - /** - * @param array $array - * @param string $needle - * - * @return bool - */ - private function startsWithAny(array $array, string $needle): bool - { - foreach ($array as $entry) { - if ((substr($needle, 0, strlen($entry)) === $entry)) { - return true; - } - } - - return false; - } - } diff --git a/public/js/ff/charts.defaults.js b/public/js/ff/charts.defaults.js index 24095df4da..4679f6565b 100644 --- a/public/js/ff/charts.defaults.js +++ b/public/js/ff/charts.defaults.js @@ -12,7 +12,7 @@ var defaultChartOptions = { elements: { - line : { + line: { cubicInterpolationMode: 'monotone' } }, diff --git a/routes/web.php b/routes/web.php index 8a7b9c8eb7..1210b72f1a 100755 --- a/routes/web.php +++ b/routes/web.php @@ -74,7 +74,6 @@ Route::group( Route::get('/flash', ['uses' => 'HomeController@testFlash', 'as' => 'test-flash']); Route::get('/home', ['uses' => 'HomeController@index', 'as' => 'home']); Route::post('/daterange', ['uses' => 'HomeController@dateRange', 'as' => 'daterange']); - Route::get('/routes', ['uses' => 'HomeController@routes', 'as' => 'all-routes']); } ); diff --git a/tests/Feature/Controllers/BillControllerTest.php b/tests/Feature/Controllers/BillControllerTest.php index 7f096c34ce..ea538a2a27 100644 --- a/tests/Feature/Controllers/BillControllerTest.php +++ b/tests/Feature/Controllers/BillControllerTest.php @@ -12,9 +12,158 @@ declare(strict_types = 1); namespace Tests\Feature\Controllers; +use FireflyIII\Repositories\Bill\BillRepositoryInterface; +use Illuminate\Support\Collection; use Tests\TestCase; class BillControllerTest extends TestCase { + /** + * @covers \FireflyIII\Http\Controllers\BillController::create + */ + public function testCreate() + { + $this->be($this->user()); + $response = $this->get(route('bills.create')); + $response->assertStatus(200); + // has bread crumb + $response->assertSee('