Expand webhook API, edit and create screen.

This commit is contained in:
James Cole
2025-08-20 06:22:55 +02:00
parent 293be04d40
commit 01cce49070
18 changed files with 421 additions and 232 deletions

View File

@@ -68,7 +68,7 @@ export default {
}
},
value: {
type: Number,
type: String,
required: true,
}
},
@@ -84,7 +84,7 @@ export default {
}
this.deliveries.push(
{
id: response.data.data.value[key],
id: key,
name: this.$t('firefly.webhook_delivery_' + key),
}
);

View File

@@ -66,7 +66,7 @@ export default {
}
},
value: {
type: Number,
type: String,
required: true,
}
},
@@ -88,7 +88,7 @@ export default {
}
this.responses.push(
{
id: response.data.data.value[key],
id: key,
name: this.$t('firefly.webhook_response_' + key),
}
);

View File

@@ -29,6 +29,7 @@
</div>
<select v-if="!loading"
ref="trigger"
multiple
v-model="trigger"
:title="$t('form.webhook_trigger')"
class="form-control"
@@ -52,7 +53,7 @@ export default {
name: "WebhookTrigger",
data() {
return {
trigger: 0,
trigger: [],
loading: true,
triggers: [],
};
@@ -66,7 +67,7 @@ export default {
}
},
value: {
type: Number,
type: Array,
required: true,
}
},
@@ -80,11 +81,11 @@ export default {
}
this.triggers.push(
{
id: response.data.data.value[key],
id: key,
name: this.$t('firefly.webhook_trigger_' + key),
}
);
console.log('webhook trigger: id=' + response.data.data.value[key] + ', name=' + key);
// console.log('webhook trigger: id=' + response.data.data.value[key] + ', name=' + key);
}
this.loading = false;
}).catch((error) => {

View File

@@ -54,12 +54,12 @@
<div class="row">
<div class="col-lg-12">
<Title :value=this.title :error="errors.title" v-on:input="title = $event"></Title>
<WebhookTrigger :value=this.trigger :error="errors.trigger"
v-on:input="trigger = $event"></WebhookTrigger>
<WebhookResponse :value=this.response :error="errors.response"
v-on:input="response = $event"></WebhookResponse>
<WebhookDelivery :value=this.delivery :error="errors.delivery"
v-on:input="delivery = $event"></WebhookDelivery>
<WebhookTrigger :value=this.triggers :error="errors.trigger"
v-on:input="triggers = $event"></WebhookTrigger>
<WebhookResponse :value=this.responses :error="errors.response"
v-on:input="responses = $event"></WebhookResponse>
<WebhookDelivery :value=this.deliveries :error="errors.delivery"
v-on:input="deliveries = $event"></WebhookDelivery>
<URL :value=this.url :error="errors.url" v-on:input="url = $event"></URL>
<Checkbox :value=this.active :error="errors.active" help="ACTIVE HELP TODO" :title="$t('form.active')" v-on:input="active = $event"></Checkbox>
</div>
@@ -96,16 +96,16 @@ export default {
error_message: '',
success_message: '',
title: '',
trigger: 100,
response: 200,
delivery: 300,
triggers: ["STORE_TRANSACTION"],
responses: "RELEVANT",
deliveries: "JSON",
active: true,
url: '',
errors: {
title: [],
trigger: [],
response: [],
delivery: [],
triggers: [],
responses: [],
deliveries: [],
url: [],
active: []
}
@@ -118,9 +118,9 @@ export default {
this.success_message = '';
this.errors = {
title: [],
trigger: [],
response: [],
delivery: [],
triggers: [],
responses: [],
deliveries: [],
url: [],
active: [],
};
@@ -131,9 +131,9 @@ export default {
// collect data
let data = {
title: this.title,
trigger: this.trigger,
response: this.response,
delivery: this.delivery,
triggers: this.triggers,
responses: [this.responses],
deliveries: [this.deliveries],
url: this.url,
active: this.active,
};
@@ -148,9 +148,9 @@ export default {
//console.log(error.response.data);
this.error_message = error.response.data.message;
this.errors.title = error.response.data.errors.title;
this.errors.trigger = error.response.data.errors.trigger;
this.errors.response = error.response.data.errors.response;
this.errors.delivery = error.response.data.errors.delivery;
this.errors.triggers = error.response.data.errors.triggers;
this.errors.responses = error.response.data.errors.responses;
this.errors.deliveries = error.response.data.errors.deliveries;
this.errors.url = error.response.data.errors.url;
// enable button again

View File

@@ -54,12 +54,12 @@
<div class="row">
<div class="col-lg-12">
<Title :value=this.title :error="errors.title" v-on:input="title = $event"></Title>
<WebhookTrigger :value=this.trigger :error="errors.trigger"
v-on:input="trigger = $event"></WebhookTrigger>
<WebhookResponse :value=this.response :error="errors.response"
v-on:input="response = $event"></WebhookResponse>
<WebhookDelivery :value=this.delivery :error="errors.delivery"
v-on:input="delivery = $event"></WebhookDelivery>
<WebhookTrigger :value=this.triggers :error="errors.triggers"
v-on:input="triggers = $event"></WebhookTrigger>
<WebhookResponse :value=this.responses :error="errors.responses"
v-on:input="responses = $event"></WebhookResponse>
<WebhookDelivery :value=this.deliveries :error="errors.deliveries"
v-on:input="deliveries = $event"></WebhookDelivery>
<URL :value=this.url :error="errors.url" v-on:input="url = $event"></URL>
<Checkbox :value=this.active :error="errors.active" help="ACTIVE HELP TODO" :title="$t('form.active')"
v-on:input="active = $event"></Checkbox>
@@ -97,17 +97,17 @@ export default {
error_message: '',
success_message: '',
title: '',
trigger: 100,
response: 200,
delivery: 300,
triggers: ["STORE_TRANSACTION"],
responses: "RELEVANT",
deliveries: "JSON",
id: 0,
active: false,
url: '',
errors: {
title: [],
trigger: [],
response: [],
delivery: [],
triggers: [],
responses: [],
deliveries: [],
url: [],
active: []
}
@@ -127,49 +127,9 @@ export default {
// console.log(response.data.data.attributes);
this.title = response.data.data.attributes.title;
this.id = parseInt(response.data.data.id);
// trigger value on content
console.log('Trigger is ' + response.data.data.attributes.trigger);
// TODO does not need to be hard coded.
if ('STORE_TRANSACTION' === response.data.data.attributes.trigger) {
this.trigger = 100;
}
if ('UPDATE_TRANSACTION' === response.data.data.attributes.trigger) {
this.trigger = 110;
}
if ('DESTROY_TRANSACTION' === response.data.data.attributes.trigger) {
this.trigger = 120;
}
if ('STORE_BUDGET' === response.data.data.attributes.trigger) {
this.trigger = 200;
}
if ('UPDATE_BUDGET' === response.data.data.attributes.trigger) {
this.trigger = 210;
}
if ('DESTROY_BUDGET' === response.data.data.attributes.trigger) {
this.trigger = 220;
}
if ('STORE_UPDATE_BUDGET_LIMIT' === response.data.data.attributes.trigger) {
this.trigger = 230;
}
// response value
if ('TRANSACTIONS' === response.data.data.attributes.response) {
this.response = 200;
}
if ('ACCOUNTS' === response.data.data.attributes.response) {
this.response = 210;
}
if ('BUDGET' === response.data.data.attributes.response) {
this.response = 230;
}
if ('NONE' === response.data.data.attributes.response) {
this.response = 220;
}
if ('JSON' === response.data.data.attributes.delivery) {
this.delivery = 300;
}
this.triggers = response.data.data.attributes.triggers;
this.responses = response.data.data.attributes.responses[0];
this.deliveries = response.data.data.attributes.deliveries[0];
this.active = response.data.data.attributes.active;
this.url = response.data.data.attributes.url;
}).catch(error => {
@@ -182,9 +142,9 @@ export default {
this.success_message = '';
this.errors = {
title: [],
trigger: [],
response: [],
delivery: [],
triggers: [],
responses: [],
deliveries: [],
url: [],
active: [],
};
@@ -195,9 +155,9 @@ export default {
// collect data
let data = {
title: this.title,
trigger: this.trigger,
response: this.response,
delivery: this.delivery,
triggers: this.triggers,
responses: [this.responses],
deliveries: [this.deliveries],
url: this.url,
active: this.active,
};
@@ -210,9 +170,9 @@ export default {
this.error_message = error.response.data.message;
this.errors.title = error.response.data.errors.title;
this.errors.trigger = error.response.data.errors.trigger;
this.errors.response = error.response.data.errors.response;
this.errors.delivery = error.response.data.errors.delivery;
this.errors.triggers = error.response.data.errors.trigger;
this.errors.responses = error.response.data.errors.response;
this.errors.deliveries = error.response.data.errors.deliveries;
this.errors.url = error.response.data.errors.url;
// enable button again

View File

@@ -50,12 +50,24 @@
<a :href="'webhooks/show/' + webhook.id">{{ webhook.title }}</a>
</td>
<td>
<span v-if="webhook.active">{{ triggers[webhook.trigger] }}</span>
<span v-if="!webhook.active" class="text-muted"><s>{{ triggers[webhook.trigger] }}</s> ({{
$t('firefly.inactive')
}})</span>
<span v-if="webhook.active">
<ul class="list-unstyled">
<li v-for="trigger in webhook.triggers" :key="trigger">
{{ triggers[trigger] }}
</li>
</ul>
</span>
<span v-if="!webhook.active" class="text-muted">
<ul class="list-unstyled">
<li v-for="trigger in webhook.triggers" :key="trigger">
<s>{{ triggers[trigger] }}</s> ({{$t('firefly.inactive') }})
</li>
</ul>
</span>
</td>
<td>
{{ responses[webhook.responses[0]] }} ({{ deliveries[webhook.deliveries[0]] }})
</td>
<td>{{ responses[webhook.response] }} ({{ deliveries[webhook.delivery] }})</td>
<td>
<em style="cursor:pointer"
v-if="webhook.show_secret" class="fa fa-eye" @click="toggleSecret(webhook)"></em>
@@ -167,9 +179,9 @@ export default {
active: current.attributes.active,
full_url: current.attributes.url,
secret: current.attributes.secret,
trigger: current.attributes.trigger,
response: current.attributes.response,
delivery: current.attributes.delivery,
triggers: current.attributes.triggers,
responses: current.attributes.responses,
deliveries: current.attributes.deliveries,
show_secret: false,
};
if (current.attributes.url.length > 20) {

View File

@@ -40,27 +40,39 @@
<table class="table table-hover" aria-label="A table">
<tbody>
<tr>
<th scope="row" style="width:40%;">Title</th>
<td style="width:40%;"><strong>{{ $t('list.title') }}</strong></td>
<td>{{ title }}</td>
</tr>
<tr>
<th scope="row">{{ $t('list.active') }}</th>
<td style="width:40%;"><strong>{{ $t('list.active') }}</strong></td>
<td>
<em class="fa fa-check text-success" v-if="active"></em>
<em class="fa fa-times text-danger" v-if="!active"></em>
</td>
</tr>
<tr>
<th scope="row">{{ $t('list.trigger') }}</th>
<td> {{ trigger }}</td>
<td style="width:40%;"><strong>{{ $t('list.trigger') }}</strong></td>
<td>
<span v-for="trigger in triggers" :key="trigger">
{{ $t('firefly.webhook_trigger_' + trigger) }}<br>
</span>
</td>
</tr>
<tr>
<th scope="row">{{ $t('list.response') }}</th>
<td> {{ response }}</td>
<td style="width:40%;"><strong>{{ $t('list.response') }}</strong></td>
<td>
<span v-for="response in responses" :key="response">
{{ $t('firefly.webhook_response_' + response) }}
</span>
</td>
</tr>
<tr>
<th scope="row">{{ $t('list.delivery') }}</th>
<td> {{ delivery }}</td>
<td style="width:40%;"><strong>{{ $t('list.delivery') }}</strong></td>
<td>
<span v-for="delivery in deliveries" :key="delivery">
{{ $t('firefly.webhook_delivery_' + delivery) }}
</span>
</td>
</tr>
</tbody>
</table>
@@ -86,12 +98,13 @@
<table class="table table-hover" aria-label="A table">
<tbody>
<tr>
<th scope="row" style="width:40%;">{{ $t('list.url') }}</th>
<td style="width:40%;"><strong>{{ $t('list.url') }}</strong></td>
<td><input type="text" readonly class="form-control" :value=url></td>
</tr>
<tr>
<td>
<td style="width:40%;"><strong>
{{ $t('list.secret') }}
</strong>
</td>
<td>
<em style="cursor:pointer"
@@ -260,11 +273,14 @@ export default {
secret: '',
show_secret: false,
trigger: '',
triggers: [],
loading: true,
response: '',
responses: [],
message_content: '',
message_attempts: [],
delivery: '',
deliveries: [],
messages: [],
active: false,
edit_url: '#',
@@ -369,9 +385,9 @@ export default {
this.title = response.data.data.attributes.title;
this.url = response.data.data.attributes.url;
this.secret = response.data.data.attributes.secret;
this.trigger = this.$t('firefly.webhook_trigger_' + response.data.data.attributes.trigger);
this.response = this.$t('firefly.webhook_response_' + response.data.data.attributes.response);
this.delivery = this.$t('firefly.webhook_delivery_' + response.data.data.attributes.delivery);
this.triggers = response.data.data.attributes.triggers;
this.responses = response.data.data.attributes.responses;
this.deliveries = response.data.data.attributes.deliveries;
this.active = response.data.data.attributes.active;
this.url = response.data.data.attributes.url;

View File

@@ -250,8 +250,8 @@ return [
'webhook_trigger_STORE_UPDATE_BUDGET_LIMIT' => 'After budgeted amount change',
'webhook_response_TRANSACTIONS' => 'Transaction details',
'webhook_response_ACCOUNTS' => 'Account details',
'webhook_response_none_BUDGET' => 'Budget details',
'webhook_response_none_NONE' => 'No details',
'webhook_response_BUDGET' => 'Budget details',
'webhook_response_RELEVANT' => 'Relevant details',
'webhook_response_NONE' => 'No details',
'webhook_delivery_JSON' => 'JSON',
'inspect' => 'Inspect',

View File

@@ -34,6 +34,9 @@ return [
'filter_not_string' => 'Filter ":filter" is expected to be a string of text',
'bad_api_filter' => 'This API endpoint does not support ":filter" as a filter.',
'nog_logged_in' => 'You are not logged in.',
'prohibited' => 'You must not submit anything in field.',
'bad_webhook_combination' => 'Webhook trigger ":trigger" cannot be combined with webhook response ":response".',
'unknown_webhook_trigger' => 'Unknown webhook trigger ":trigger".',
'bad_type_source' => 'Firefly III can\'t determine the transaction type based on this source account.',
'bad_type_destination' => 'Firefly III can\'t determine the transaction type based on this destination account.',
'missing_where' => 'Array is missing "where"-clause',