Clean up code.

app/Api/V1/Controllers/Autocomplete/AccountController.php

@@ -43,6 +43,7 @@ use Illuminate\Support\Facades\Log;
 class AccountController extends Controller
 {
     use AccountFilter;
+
     // this array only exists to test if the constructor will use it properly.
     protected array $accepts = ['application/json', 'application/vnd.api+json'];
 

app/Api/V1/Controllers/Autocomplete/TransactionController.php

@@ -39,11 +39,10 @@ use Illuminate\Support\Collection;
  */
 class TransactionController extends Controller
 {
+    protected array $acceptedRoles = [UserRoleEnum::READ_ONLY];
     private TransactionGroupRepositoryInterface $groupRepository;
     private JournalRepositoryInterface          $repository;
 
-    protected array $acceptedRoles = [UserRoleEnum::READ_ONLY];
-
     /**
      * TransactionController constructor.
      */

app/Api/V1/Controllers/Chart/AccountController.php

@@ -26,8 +26,8 @@ namespace FireflyIII\Api\V1\Controllers\Chart;
 
 use Carbon\Carbon;
 use FireflyIII\Api\V1\Controllers\Controller;
-use FireflyIII\Api\V1\Requests\Data\DateRequest;
 use FireflyIII\Api\V1\Requests\Chart\ChartRequest;
+use FireflyIII\Api\V1\Requests\Data\DateRequest;
 use FireflyIII\Enums\AccountTypeEnum;
 use FireflyIII\Exceptions\FireflyException;
 use FireflyIII\Models\Account;
@@ -48,8 +48,8 @@ class AccountController extends Controller
     use ApiSupport;
     use CollectsAccountsFromFilter;
 
-    private AccountRepositoryInterface $repository;
     private ChartData                  $chartData;
+    private AccountRepositoryInterface $repository;
 
     /**
      * AccountController constructor.
@@ -93,6 +93,47 @@ class AccountController extends Controller
         return response()->json($this->chartData->render());
     }
 
+    /**
+     * @throws FireflyException
+     */
+    private function renderAccountData(array $params, Account $account): void
+    {
+        $currency     = $this->repository->getAccountCurrency($account);
+        if (null === $currency) {
+            $currency = $this->default;
+        }
+        $currentSet   = [
+            'label'                   => $account->name,
+
+            // the currency that belongs to the account.
+            'currency_id'             => (string) $currency->id,
+            'currency_code'           => $currency->code,
+            'currency_symbol'         => $currency->symbol,
+            'currency_decimal_places' => $currency->decimal_places,
+
+            // the default currency of the user (could be the same!)
+            'date'                    => $params['start']->toAtomString(),
+            'start'                   => $params['start']->toAtomString(),
+            'end'                     => $params['end']->toAtomString(),
+            'period'                  => '1D',
+            'entries'                 => [],
+        ];
+        $currentStart = clone $params['start'];
+        $range        = Steam::finalAccountBalanceInRange($account, $params['start'], clone $params['end'], $this->convertToNative);
+
+        $previous     = array_values($range)[0]['balance'];
+        while ($currentStart <= $params['end']) {
+            $format                        = $currentStart->format('Y-m-d');
+            $label                         = $currentStart->toAtomString();
+            $balance                       = array_key_exists($format, $range) ? $range[$format]['balance'] : $previous;
+            $previous                      = $balance;
+
+            $currentStart->addDay();
+            $currentSet['entries'][$label] = $balance;
+        }
+        $this->chartData->add($currentSet);
+    }
+
     /**
      * This endpoint is documented at:
      * https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/charts/getChartAccountOverview
@@ -162,45 +203,4 @@ class AccountController extends Controller
 
         return response()->json($chartData);
     }
-
-    /**
-     * @throws FireflyException
-     */
-    private function renderAccountData(array $params, Account $account): void
-    {
-        $currency     = $this->repository->getAccountCurrency($account);
-        if (null === $currency) {
-            $currency = $this->default;
-        }
-        $currentSet   = [
-            'label'                          => $account->name,
-
-            // the currency that belongs to the account.
-            'currency_id'                    => (string) $currency->id,
-            'currency_code'                  => $currency->code,
-            'currency_symbol'                => $currency->symbol,
-            'currency_decimal_places'        => $currency->decimal_places,
-
-            // the default currency of the user (could be the same!)
-            'date'                           => $params['start']->toAtomString(),
-            'start'                          => $params['start']->toAtomString(),
-            'end'                            => $params['end']->toAtomString(),
-            'period'                         => '1D',
-            'entries'                        => [],
-        ];
-        $currentStart = clone $params['start'];
-        $range        = Steam::finalAccountBalanceInRange($account, $params['start'], clone $params['end'], $this->convertToNative);
-
-        $previous     = array_values($range)[0]['balance'];
-        while ($currentStart <= $params['end']) {
-            $format                        = $currentStart->format('Y-m-d');
-            $label                         = $currentStart->toAtomString();
-            $balance                       = array_key_exists($format, $range) ? $range[$format]['balance'] : $previous;
-            $previous                      = $balance;
-
-            $currentStart->addDay();
-            $currentSet['entries'][$label] = $balance;
-        }
-        $this->chartData->add($currentSet);
-    }
 }

app/Api/V1/Controllers/Controller.php

@@ -40,7 +40,6 @@ use Illuminate\Foundation\Bus\DispatchesJobs;
 use Illuminate\Foundation\Validation\ValidatesRequests;
 use Illuminate\Pagination\LengthAwarePaginator;
 use Illuminate\Routing\Controller as BaseController;
-use Illuminate\Support\Collection;
 use League\Fractal\Manager;
 use League\Fractal\Pagination\IlluminatePaginatorAdapter;
 use League\Fractal\Resource\Collection as FractalCollection;
@@ -64,13 +63,13 @@ abstract class Controller extends BaseController
 
     protected const string CONTENT_TYPE            = 'application/vnd.api+json';
     protected const string JSON_CONTENT_TYPE       = 'application/json';
+    protected array               $accepts         = ['application/json', 'application/vnd.api+json'];
 
     /** @var array<int, string> */
     protected array               $allowedSort;
-    protected ParameterBag $parameters;
     protected bool                $convertToNative = false;
-    protected array $accepts                 = ['application/json', 'application/vnd.api+json'];
     protected TransactionCurrency $nativeCurrency;
+    protected ParameterBag        $parameters;
 
     /**
      * Controller constructor.

app/Api/V1/Controllers/Models/CurrencyExchangeRate/DestroyController.php

@@ -39,10 +39,8 @@ class DestroyController extends Controller
 {
     use ValidatesUserGroupTrait;
 
-    protected array $acceptedRoles   = [UserRoleEnum::OWNER];
-
     public const string RESOURCE_KEY = 'exchange-rates';
-
+    protected array $acceptedRoles   = [UserRoleEnum::OWNER];
     private ExchangeRateRepositoryInterface $repository;
 
     public function __construct()

app/Api/V1/Controllers/Models/Transaction/StoreController.php

@@ -50,9 +50,8 @@ class StoreController extends Controller
 {
     use TransactionFilter;
 
-    private TransactionGroupRepositoryInterface $groupRepository;
-
     protected array $acceptedRoles = [UserRoleEnum::MANAGE_TRANSACTIONS];
+    private TransactionGroupRepositoryInterface $groupRepository;
 
     /**
      * TransactionController constructor.

app/Api/V1/Controllers/Models/TransactionCurrency/DestroyController.php

@@ -27,8 +27,8 @@ namespace FireflyIII\Api\V1\Controllers\Models\TransactionCurrency;
 use FireflyIII\Api\V1\Controllers\Controller;
 use FireflyIII\Exceptions\FireflyException;
 use FireflyIII\Models\TransactionCurrency;
-use FireflyIII\Repositories\User\UserRepositoryInterface;
 use FireflyIII\Repositories\Currency\CurrencyRepositoryInterface;
+use FireflyIII\Repositories\User\UserRepositoryInterface;
 use FireflyIII\User;
 use Illuminate\Http\JsonResponse;
 

app/Api/V1/Requests/Models/CurrencyExchangeRate/StoreRequest.php

@@ -40,16 +40,16 @@ class StoreRequest extends FormRequest
         return $this->getCarbonDate('date');
     }
 
-    public function getRate(): string
-    {
-        return (string) $this->get('rate');
-    }
-
     public function getFromCurrency(): TransactionCurrency
     {
         return TransactionCurrency::where('code', $this->get('from'))->first();
     }
 
+    public function getRate(): string
+    {
+        return (string) $this->get('rate');
+    }
+
     public function getToCurrency(): TransactionCurrency
     {
         return TransactionCurrency::where('code', $this->get('to'))->first();

app/Api/V2/Controllers/Controller.php

@@ -33,7 +33,6 @@ use FireflyIII\Transformers\AbstractTransformer;
 use Illuminate\Database\Eloquent\Model;
 use Illuminate\Pagination\LengthAwarePaginator;
 use Illuminate\Routing\Controller as BaseController;
-use Illuminate\Support\Collection;
 use League\Fractal\Manager;
 use League\Fractal\Pagination\IlluminatePaginatorAdapter;
 use League\Fractal\Resource\Collection as FractalCollection;
@@ -56,8 +55,8 @@ class Controller extends BaseController
 
     protected const string CONTENT_TYPE     = 'application/vnd.api+json';
     protected array        $acceptedRoles   = [UserRoleEnum::READ_ONLY];
-    protected ParameterBag $parameters;
     protected bool         $convertToNative = false;
+    protected ParameterBag $parameters;
 
     public function __construct()
     {

app/Api/V2/Controllers/Transaction/List/TransactionController.php

@@ -114,7 +114,6 @@ class TransactionController extends Controller
 
         return response()
             ->json($this->jsonApiList('transactions', $paginator, new TransactionGroupTransformer()))
-            ->header('Content-Type', self::CONTENT_TYPE)
+            ->header('Content-Type', self::CONTENT_TYPE);
-        ;
     }
 }

app/Console/Commands/Correction/CorrectsAmounts.php

@@ -75,6 +75,65 @@ class CorrectsAmounts extends Command
         return 0;
     }
 
+    private function correctTransfers(): void
+    {
+        /** @var AccountRepositoryInterface $repository */
+        $repository = app(AccountRepositoryInterface::class);
+        $type       = TransactionType::where('type', TransactionTypeEnum::TRANSFER->value)->first();
+        $journals   = TransactionJournal::where('transaction_type_id', $type->id)->get();
+
+        /** @var TransactionJournal $journal */
+        foreach ($journals as $journal) {
+            $repository->setUser($journal->user);
+            $native         = Amount::getNativeCurrencyByUserGroup($journal->userGroup);
+
+            /** @var null|Transaction $source */
+            $source         = $journal->transactions()->where('amount', '<', 0)->first();
+
+            /** @var null|Transaction $destination */
+            $destination    = $journal->transactions()->where('amount', '>', 0)->first();
+            if (null === $source || null === $destination) {
+                continue;
+            }
+            if (null === $source->foreign_currency_id || null === $destination->foreign_currency_id) {
+                continue;
+            }
+            $sourceAccount  = $source->account;
+            $destAccount    = $destination->account;
+            if (null === $sourceAccount || null === $destAccount) {
+                continue;
+            }
+            $sourceCurrency = $repository->getAccountCurrency($sourceAccount) ?? $native;
+            $destCurrency   = $repository->getAccountCurrency($destAccount) ?? $native;
+
+            if ($sourceCurrency->id === $destCurrency->id) {
+                Log::debug('Both accounts have the same currency. Removing foreign currency info.');
+                $source->foreign_currency_id      = null;
+                $source->foreign_amount           = null;
+                $source->save();
+                $destination->foreign_currency_id = null;
+                $destination->foreign_amount      = null;
+                $destination->save();
+
+                continue;
+            }
+
+            // validate source
+            if ($destCurrency->id !== $source->foreign_currency_id) {
+                Log::debug(sprintf('Journal #%d: Transaction #%d refers to "%s" but should refer to "%s".', $journal->id, $source->id, $source->foreignCurrency->code, $destCurrency->code));
+                $source->foreign_currency_id = $destCurrency->id;
+                $source->save();
+            }
+
+            // validate destination:
+            if ($sourceCurrency->id !== $destination->foreign_currency_id) {
+                Log::debug(sprintf('Journal #%d: Transaction #%d refers to "%s" but should refer to "%s".', $journal->id, $destination->id, $destination->foreignCurrency->code, $sourceCurrency->code));
+                $destination->foreign_currency_id = $sourceCurrency->id;
+                $destination->save();
+            }
+        }
+    }
+
     private function fixAutoBudgets(): void
     {
         $count = AutoBudget::where('amount', '<', 0)->update(['amount' => DB::raw('amount * -1')]);
@@ -192,63 +251,4 @@ class CorrectsAmounts extends Command
 
         return false;
     }
-
-    private function correctTransfers(): void
-    {
-        /** @var AccountRepositoryInterface $repository */
-        $repository = app(AccountRepositoryInterface::class);
-        $type       = TransactionType::where('type', TransactionTypeEnum::TRANSFER->value)->first();
-        $journals   = TransactionJournal::where('transaction_type_id', $type->id)->get();
-
-        /** @var TransactionJournal $journal */
-        foreach ($journals as $journal) {
-            $repository->setUser($journal->user);
-            $native         = Amount::getNativeCurrencyByUserGroup($journal->userGroup);
-
-            /** @var null|Transaction $source */
-            $source         = $journal->transactions()->where('amount', '<', 0)->first();
-
-            /** @var null|Transaction $destination */
-            $destination    = $journal->transactions()->where('amount', '>', 0)->first();
-            if (null === $source || null === $destination) {
-                continue;
-            }
-            if (null === $source->foreign_currency_id || null === $destination->foreign_currency_id) {
-                continue;
-            }
-            $sourceAccount  = $source->account;
-            $destAccount    = $destination->account;
-            if (null === $sourceAccount || null === $destAccount) {
-                continue;
-            }
-            $sourceCurrency = $repository->getAccountCurrency($sourceAccount) ?? $native;
-            $destCurrency   = $repository->getAccountCurrency($destAccount) ?? $native;
-
-            if ($sourceCurrency->id === $destCurrency->id) {
-                Log::debug('Both accounts have the same currency. Removing foreign currency info.');
-                $source->foreign_currency_id      = null;
-                $source->foreign_amount           = null;
-                $source->save();
-                $destination->foreign_currency_id = null;
-                $destination->foreign_amount      = null;
-                $destination->save();
-
-                continue;
-            }
-
-            // validate source
-            if ($destCurrency->id !== $source->foreign_currency_id) {
-                Log::debug(sprintf('Journal #%d: Transaction #%d refers to "%s" but should refer to "%s".', $journal->id, $source->id, $source->foreignCurrency->code, $destCurrency->code));
-                $source->foreign_currency_id = $destCurrency->id;
-                $source->save();
-            }
-
-            // validate destination:
-            if ($sourceCurrency->id !== $destination->foreign_currency_id) {
-                Log::debug(sprintf('Journal #%d: Transaction #%d refers to "%s" but should refer to "%s".', $journal->id, $destination->id, $destination->foreignCurrency->code, $sourceCurrency->code));
-                $destination->foreign_currency_id = $sourceCurrency->id;
-                $destination->save();
-            }
-        }
-    }
 }

app/Console/Commands/Correction/CorrectsNativeAmounts.php

@@ -38,8 +38,8 @@ use FireflyIII\Models\PiggyBankEvent;
 use FireflyIII\Models\Transaction;
 use FireflyIII\Models\TransactionCurrency;
 use FireflyIII\Models\UserGroup;
-use FireflyIII\Repositories\UserGroup\UserGroupRepositoryInterface;
 use FireflyIII\Repositories\PiggyBank\PiggyBankRepositoryInterface;
+use FireflyIII\Repositories\UserGroup\UserGroupRepositoryInterface;
 use FireflyIII\Support\Facades\Preferences;
 use FireflyIII\Support\Http\Api\ExchangeRateConverter;
 use Illuminate\Console\Command;

app/Console/Commands/Integrity/ValidatesEnvironmentVariables.php

@@ -30,13 +30,6 @@ class ValidatesEnvironmentVariables extends Command
 {
     use ShowsFriendlyMessages;
 
-    /**
-     * The name and signature of the console command.
-     *
-     * @var string
-     */
-    protected $signature   = 'integrity:validates-environment-variables';
-
     /**
      * The console command description.
      *
@@ -44,6 +37,13 @@ class ValidatesEnvironmentVariables extends Command
      */
     protected $description = 'Makes sure you use the correct variables.';
 
+    /**
+     * The name and signature of the console command.
+     *
+     * @var string
+     */
+    protected $signature   = 'integrity:validates-environment-variables';
+
     /**
      * Execute the console command.
      */

app/Console/Commands/System/OutputsInstructions.php

@@ -172,6 +172,13 @@ class OutputsInstructions extends Command
         }
     }
 
+    private function donationText(): void
+    {
+        $this->boxed('Did you know you can support the development of Firefly III?');
+        $this->boxed('You can donate in many ways, like GitHub Sponsors or Patreon.');
+        $this->boxed('For more information, please visit https://bit.ly/donate-to-Firefly-III');
+    }
+
     /**
      * Render instructions.
      */
@@ -225,11 +232,4 @@ class OutputsInstructions extends Command
         $this->boxed('');
         $this->showLine();
     }
-
-    private function donationText(): void
-    {
-        $this->boxed('Did you know you can support the development of Firefly III?');
-        $this->boxed('You can donate in many ways, like GitHub Sponsors or Patreon.');
-        $this->boxed('For more information, please visit https://bit.ly/donate-to-Firefly-III');
-    }
 }

app/Console/Commands/System/RecalculatesRunningBalance.php

@@ -31,13 +31,6 @@ class RecalculatesRunningBalance extends Command
 {
     use ShowsFriendlyMessages;
 
-    /**
-     * The name and signature of the console command.
-     *
-     * @var string
-     */
-    protected $signature   = 'firefly-iii:refresh-running-balance {--F|force : Force the execution of this command.}';
-
     /**
      * The console command description.
      *
@@ -45,6 +38,13 @@ class RecalculatesRunningBalance extends Command
      */
     protected $description = 'Refreshes all running balances. May take a long time to run if forced.';
 
+    /**
+     * The name and signature of the console command.
+     *
+     * @var string
+     */
+    protected $signature   = 'firefly-iii:refresh-running-balance {--F|force : Force the execution of this command.}';
+
     /**
      * Execute the console command.
      */

app/Console/Commands/Tools/Cron.php

@@ -150,6 +150,23 @@ class Cron extends Command
         }
     }
 
+    private function checkForUpdates(bool $force): void
+    {
+        $updateCheck = new UpdateCheckCronjob();
+        $updateCheck->setForce($force);
+        $updateCheck->fire();
+
+        if ($updateCheck->jobErrored) {
+            $this->friendlyError(sprintf('Error in "update check" cron: %s', $updateCheck->message));
+        }
+        if ($updateCheck->jobFired) {
+            $this->friendlyInfo(sprintf('"Update check" cron fired: %s', $updateCheck->message));
+        }
+        if ($updateCheck->jobSucceeded) {
+            $this->friendlyPositive(sprintf('"Update check" cron ran with success: %s', $updateCheck->message));
+        }
+    }
+
     /**
      * @throws FireflyException
      */
@@ -221,21 +238,4 @@ class Cron extends Command
             $this->friendlyPositive(sprintf('"Send bill warnings" cron ran with success: %s', $autoBudget->message));
         }
     }
-
-    private function checkForUpdates(bool $force): void
-    {
-        $updateCheck = new UpdateCheckCronjob();
-        $updateCheck->setForce($force);
-        $updateCheck->fire();
-
-        if ($updateCheck->jobErrored) {
-            $this->friendlyError(sprintf('Error in "update check" cron: %s', $updateCheck->message));
-        }
-        if ($updateCheck->jobFired) {
-            $this->friendlyInfo(sprintf('"Update check" cron fired: %s', $updateCheck->message));
-        }
-        if ($updateCheck->jobSucceeded) {
-            $this->friendlyPositive(sprintf('"Update check" cron ran with success: %s', $updateCheck->message));
-        }
-    }
 }

app/Console/Commands/Upgrade/UpgradesNativeAmounts.php

@@ -32,6 +32,7 @@ use Illuminate\Support\Facades\Artisan;
 class UpgradesNativeAmounts extends Command
 {
     use ShowsFriendlyMessages;
+
     public const string CONFIG_NAME = '620_native_amounts';
 
     protected $description          = 'Runs the native amounts calculations.';
@@ -61,7 +62,7 @@ class UpgradesNativeAmounts extends Command
     {
         $configVar = app('fireflyconfig')->get(self::CONFIG_NAME, false);
         if (null !== $configVar) {
-            return (bool)$configVar->data;
+            return (bool) $configVar->data;
         }
 
         return false;

app/Events/DestroyedTransactionLink.php

@@ -32,7 +32,9 @@ use Illuminate\Queue\SerializesModels;
  */
 class DestroyedTransactionLink extends Event
 {
-    use SerializesModels; // @phpstan-ignore-line
+    use SerializesModels;
+
+    // @phpstan-ignore-line
 
     /**
      * DestroyedTransactionLink constructor.

app/Events/Security/MFABackupFewLeft.php

@@ -32,6 +32,7 @@ use Illuminate\Queue\SerializesModels;
 class MFABackupFewLeft extends Event
 {
     use SerializesModels;
+
     public User $user;
 
     public function __construct(null|Authenticatable|User $user, public int $count)

app/Events/Security/MFAManyFailedAttempts.php

@@ -32,6 +32,7 @@ use Illuminate\Queue\SerializesModels;
 class MFAManyFailedAttempts extends Event
 {
     use SerializesModels;
+
     public User $user;
 
     public function __construct(null|Authenticatable|User $user, public int $count)

app/Factory/TransactionJournalFactory.php

@@ -39,9 +39,9 @@ use FireflyIII\Repositories\Account\AccountRepositoryInterface;
 use FireflyIII\Repositories\Bill\BillRepositoryInterface;
 use FireflyIII\Repositories\Budget\BudgetRepositoryInterface;
 use FireflyIII\Repositories\Category\CategoryRepositoryInterface;
+use FireflyIII\Repositories\Currency\CurrencyRepositoryInterface;
 use FireflyIII\Repositories\PiggyBank\PiggyBankRepositoryInterface;
 use FireflyIII\Repositories\TransactionType\TransactionTypeRepositoryInterface;
-use FireflyIII\Repositories\Currency\CurrencyRepositoryInterface;
 use FireflyIII\Services\Internal\Destroy\JournalDestroyService;
 use FireflyIII\Services\Internal\Support\JournalServiceTrait;
 use FireflyIII\Support\Facades\FireflyConfig;
@@ -414,18 +414,6 @@ class TransactionJournalFactory
         $this->accountRepository->setUser($this->user);
     }
 
-    public function setUserGroup(UserGroup $userGroup): void
-    {
-        $this->userGroup = $userGroup;
-        $this->currencyRepository->setUserGroup($userGroup);
-        $this->tagFactory->setUserGroup($userGroup);
-        $this->billRepository->setUserGroup($userGroup);
-        $this->budgetRepository->setUserGroup($userGroup);
-        $this->categoryRepository->setUserGroup($userGroup);
-        $this->piggyRepository->setUserGroup($userGroup);
-        $this->accountRepository->setUserGroup($userGroup);
-    }
-
     private function reconciliationSanityCheck(?Account $sourceAccount, ?Account $destinationAccount): array
     {
         app('log')->debug(sprintf('Now in %s', __METHOD__));
@@ -605,4 +593,16 @@ class TransactionJournalFactory
             app('log')->info('Will trigger duplication alert for this journal.');
         }
     }
+
+    public function setUserGroup(UserGroup $userGroup): void
+    {
+        $this->userGroup = $userGroup;
+        $this->currencyRepository->setUserGroup($userGroup);
+        $this->tagFactory->setUserGroup($userGroup);
+        $this->billRepository->setUserGroup($userGroup);
+        $this->budgetRepository->setUserGroup($userGroup);
+        $this->categoryRepository->setUserGroup($userGroup);
+        $this->piggyRepository->setUserGroup($userGroup);
+        $this->accountRepository->setUserGroup($userGroup);
+    }
 }

app/Handlers/Events/UpdatedGroupEventHandler.php

@@ -53,6 +53,55 @@ class UpdatedGroupEventHandler
 
     }
 
+    /**
+     * This method will make sure all source / destination accounts are the same.
+     */
+    public function unifyAccounts(UpdatedTransactionGroup $updatedGroupEvent): void
+    {
+        $group         = $updatedGroupEvent->transactionGroup;
+        if (1 === $group->transactionJournals->count()) {
+            return;
+        }
+
+        // first journal:
+        /** @var null|TransactionJournal $first */
+        $first         = $group->transactionJournals()
+            ->orderBy('transaction_journals.date', 'DESC')
+            ->orderBy('transaction_journals.order', 'ASC')
+            ->orderBy('transaction_journals.id', 'DESC')
+            ->orderBy('transaction_journals.description', 'DESC')
+            ->first()
+        ;
+
+        if (null === $first) {
+            Log::warning(sprintf('Group #%d has no transaction journals.', $group->id));
+
+            return;
+        }
+
+        $all           = $group->transactionJournals()->get()->pluck('id')->toArray();
+
+        /** @var Account $sourceAccount */
+        $sourceAccount = $first->transactions()->where('amount', '<', '0')->first()->account;
+
+        /** @var Account $destAccount */
+        $destAccount   = $first->transactions()->where('amount', '>', '0')->first()->account;
+
+        $type          = $first->transactionType->type;
+        if (TransactionTypeEnum::TRANSFER->value === $type || TransactionTypeEnum::WITHDRAWAL->value === $type) {
+            // set all source transactions to source account:
+            Transaction::whereIn('transaction_journal_id', $all)
+                ->where('amount', '<', 0)->update(['account_id' => $sourceAccount->id])
+            ;
+        }
+        if (TransactionTypeEnum::TRANSFER->value === $type || TransactionTypeEnum::DEPOSIT->value === $type) {
+            // set all destination transactions to destination account:
+            Transaction::whereIn('transaction_journal_id', $all)
+                ->where('amount', '>', 0)->update(['account_id' => $destAccount->id])
+            ;
+        }
+    }
+
     /**
      * This method will check all the rules when a journal is updated.
      */
@@ -119,55 +168,6 @@ class UpdatedGroupEventHandler
         event(new RequestedSendWebhookMessages());
     }
 
-    /**
-     * This method will make sure all source / destination accounts are the same.
-     */
-    public function unifyAccounts(UpdatedTransactionGroup $updatedGroupEvent): void
-    {
-        $group         = $updatedGroupEvent->transactionGroup;
-        if (1 === $group->transactionJournals->count()) {
-            return;
-        }
-
-        // first journal:
-        /** @var null|TransactionJournal $first */
-        $first         = $group->transactionJournals()
-            ->orderBy('transaction_journals.date', 'DESC')
-            ->orderBy('transaction_journals.order', 'ASC')
-            ->orderBy('transaction_journals.id', 'DESC')
-            ->orderBy('transaction_journals.description', 'DESC')
-            ->first()
-        ;
-
-        if (null === $first) {
-            Log::warning(sprintf('Group #%d has no transaction journals.', $group->id));
-
-            return;
-        }
-
-        $all           = $group->transactionJournals()->get()->pluck('id')->toArray();
-
-        /** @var Account $sourceAccount */
-        $sourceAccount = $first->transactions()->where('amount', '<', '0')->first()->account;
-
-        /** @var Account $destAccount */
-        $destAccount   = $first->transactions()->where('amount', '>', '0')->first()->account;
-
-        $type          = $first->transactionType->type;
-        if (TransactionTypeEnum::TRANSFER->value === $type || TransactionTypeEnum::WITHDRAWAL->value === $type) {
-            // set all source transactions to source account:
-            Transaction::whereIn('transaction_journal_id', $all)
-                ->where('amount', '<', 0)->update(['account_id' => $sourceAccount->id])
-            ;
-        }
-        if (TransactionTypeEnum::TRANSFER->value === $type || TransactionTypeEnum::DEPOSIT->value === $type) {
-            // set all destination transactions to destination account:
-            Transaction::whereIn('transaction_journal_id', $all)
-                ->where('amount', '>', 0)->update(['account_id' => $destAccount->id])
-            ;
-        }
-    }
-
     private function updateRunningBalance(UpdatedTransactionGroup $event): void
     {
         Log::debug(__METHOD__);

app/Handlers/Observer/AccountObserver.php

@@ -29,8 +29,8 @@ use FireflyIII\Models\Attachment;
 use FireflyIII\Models\Transaction;
 use FireflyIII\Models\TransactionGroup;
 use FireflyIII\Models\TransactionJournal;
-use FireflyIII\Repositories\Attachment\AttachmentRepositoryInterface;
 use FireflyIII\Repositories\Account\AccountRepositoryInterface;
+use FireflyIII\Repositories\Attachment\AttachmentRepositoryInterface;
 use FireflyIII\Support\Facades\Amount;
 use FireflyIII\Support\Http\Api\ExchangeRateConverter;
 use Illuminate\Support\Facades\DB;

app/Handlers/Observer/AutoBudgetObserver.php

@@ -37,12 +37,6 @@ class AutoBudgetObserver
         $this->updateNativeAmount($autoBudget);
     }
 
-    public function updated(AutoBudget $autoBudget): void
-    {
-        Log::debug('Observe "updated" of an auto budget.');
-        $this->updateNativeAmount($autoBudget);
-    }
-
     private function updateNativeAmount(AutoBudget $autoBudget): void
     {
         if (!Amount::convertToNative($autoBudget->budget->user)) {
@@ -59,4 +53,10 @@ class AutoBudgetObserver
         $autoBudget->saveQuietly();
         Log::debug('Auto budget native amount is updated.');
     }
+
+    public function updated(AutoBudget $autoBudget): void
+    {
+        Log::debug('Observe "updated" of an auto budget.');
+        $this->updateNativeAmount($autoBudget);
+    }
 }

app/Handlers/Observer/AvailableBudgetObserver.php

@@ -37,12 +37,6 @@ class AvailableBudgetObserver
         $this->updateNativeAmount($availableBudget);
     }
 
-    public function updated(AvailableBudget $availableBudget): void
-    {
-        // Log::debug('Observe "updated" of an available budget.');
-        $this->updateNativeAmount($availableBudget);
-    }
-
     private function updateNativeAmount(AvailableBudget $availableBudget): void
     {
         if (!Amount::convertToNative($availableBudget->user)) {
@@ -61,4 +55,10 @@ class AvailableBudgetObserver
         $availableBudget->saveQuietly();
         Log::debug('Available budget native amount is updated.');
     }
+
+    public function updated(AvailableBudget $availableBudget): void
+    {
+        // Log::debug('Observe "updated" of an available budget.');
+        $this->updateNativeAmount($availableBudget);
+    }
 }

app/Handlers/Observer/BillObserver.php

@@ -41,25 +41,6 @@ class BillObserver
         $this->updateNativeAmount($bill);
     }
 
-    public function deleting(Bill $bill): void
-    {
-        $repository = app(AttachmentRepositoryInterface::class);
-        $repository->setUser($bill->user);
-
-        //        app('log')->debug('Observe "deleting" of a bill.');
-        /** @var Attachment $attachment */
-        foreach ($bill->attachments()->get() as $attachment) {
-            $repository->destroy($attachment);
-        }
-        $bill->notes()->delete();
-    }
-
-    public function updated(Bill $bill): void
-    {
-        //        Log::debug('Observe "updated" of a bill.');
-        $this->updateNativeAmount($bill);
-    }
-
     private function updateNativeAmount(Bill $bill): void
     {
         if (!Amount::convertToNative($bill->user)) {
@@ -78,4 +59,23 @@ class BillObserver
         $bill->saveQuietly();
         Log::debug('Bill native amounts are updated.');
     }
+
+    public function deleting(Bill $bill): void
+    {
+        $repository = app(AttachmentRepositoryInterface::class);
+        $repository->setUser($bill->user);
+
+        //        app('log')->debug('Observe "deleting" of a bill.');
+        /** @var Attachment $attachment */
+        foreach ($bill->attachments()->get() as $attachment) {
+            $repository->destroy($attachment);
+        }
+        $bill->notes()->delete();
+    }
+
+    public function updated(Bill $bill): void
+    {
+        //        Log::debug('Observe "updated" of a bill.');
+        $this->updateNativeAmount($bill);
+    }
 }

app/Handlers/Observer/BudgetLimitObserver.php

@@ -37,12 +37,6 @@ class BudgetLimitObserver
         $this->updateNativeAmount($budgetLimit);
     }
 
-    public function updated(BudgetLimit $budgetLimit): void
-    {
-        Log::debug('Observe "updated" of a budget limit.');
-        $this->updateNativeAmount($budgetLimit);
-    }
-
     private function updateNativeAmount(BudgetLimit $budgetLimit): void
     {
         if (!Amount::convertToNative($budgetLimit->budget->user)) {
@@ -61,4 +55,10 @@ class BudgetLimitObserver
         $budgetLimit->saveQuietly();
         Log::debug('Budget limit native amounts are updated.');
     }
+
+    public function updated(BudgetLimit $budgetLimit): void
+    {
+        Log::debug('Observe "updated" of a budget limit.');
+        $this->updateNativeAmount($budgetLimit);
+    }
 }

app/Handlers/Observer/PiggyBankEventObserver.php

@@ -37,12 +37,6 @@ class PiggyBankEventObserver
         $this->updateNativeAmount($event);
     }
 
-    public function updated(PiggyBankEvent $event): void
-    {
-        Log::debug('Observe "updated" of a piggy bank event.');
-        $this->updateNativeAmount($event);
-    }
-
     private function updateNativeAmount(PiggyBankEvent $event): void
     {
         $user                 = $event->piggyBank->accounts()->first()?->user;
@@ -65,4 +59,10 @@ class PiggyBankEventObserver
         $event->saveQuietly();
         Log::debug('Piggy bank event native amount is updated.');
     }
+
+    public function updated(PiggyBankEvent $event): void
+    {
+        Log::debug('Observe "updated" of a piggy bank event.');
+        $this->updateNativeAmount($event);
+    }
 }

app/Handlers/Observer/PiggyBankObserver.php

@@ -41,6 +41,26 @@ class PiggyBankObserver
         $this->updateNativeAmount($piggyBank);
     }
 
+    private function updateNativeAmount(PiggyBank $piggyBank): void
+    {
+        $group                           = $piggyBank->accounts()->first()?->user->userGroup;
+        if (null === $group) {
+            Log::debug(sprintf('No account(s) yet for piggy bank #%d.', $piggyBank->id));
+
+            return;
+        }
+        $userCurrency                    = app('amount')->getNativeCurrencyByUserGroup($group);
+        $piggyBank->native_target_amount = null;
+        if ($piggyBank->transactionCurrency->id !== $userCurrency->id) {
+            $converter                       = new ExchangeRateConverter();
+            $converter->setIgnoreSettings(true);
+            $converter->setUserGroup($group);
+            $piggyBank->native_target_amount = $converter->convert($piggyBank->transactionCurrency, $userCurrency, today(), $piggyBank->target_amount);
+        }
+        $piggyBank->saveQuietly();
+        Log::debug('Piggy bank native target amount is updated.');
+    }
+
     /**
      * Also delete related objects.
      */
@@ -67,24 +87,4 @@ class PiggyBankObserver
         Log::debug('Observe "updated" of a piggy bank.');
         $this->updateNativeAmount($piggyBank);
     }
-
-    private function updateNativeAmount(PiggyBank $piggyBank): void
-    {
-        $group                           = $piggyBank->accounts()->first()?->user->userGroup;
-        if (null === $group) {
-            Log::debug(sprintf('No account(s) yet for piggy bank #%d.', $piggyBank->id));
-
-            return;
-        }
-        $userCurrency                    = app('amount')->getNativeCurrencyByUserGroup($group);
-        $piggyBank->native_target_amount = null;
-        if ($piggyBank->transactionCurrency->id !== $userCurrency->id) {
-            $converter                       = new ExchangeRateConverter();
-            $converter->setIgnoreSettings(true);
-            $converter->setUserGroup($group);
-            $piggyBank->native_target_amount = $converter->convert($piggyBank->transactionCurrency, $userCurrency, today(), $piggyBank->target_amount);
-        }
-        $piggyBank->saveQuietly();
-        Log::debug('Piggy bank native target amount is updated.');
-    }
 }

app/Handlers/Observer/TransactionObserver.php

@@ -48,24 +48,6 @@ class TransactionObserver
         $this->updateNativeAmount($transaction);
     }
 
-    public function deleting(?Transaction $transaction): void
-    {
-        app('log')->debug('Observe "deleting" of a transaction.');
-        $transaction?->transactionJournal?->delete();
-    }
-
-    public function updated(Transaction $transaction): void
-    {
-        //        Log::debug('Observe "updated" of a transaction.');
-        if (true === config('firefly.feature_flags.running_balance_column') && true === self::$recalculate) {
-            if (1 === bccomp($transaction->amount, '0')) {
-                Log::debug('Trigger recalculateForJournal');
-                AccountBalanceCalculator::recalculateForJournal($transaction->transactionJournal);
-            }
-        }
-        $this->updateNativeAmount($transaction);
-    }
-
     private function updateNativeAmount(Transaction $transaction): void
     {
         if (!Amount::convertToNative($transaction->transactionJournal->user)) {
@@ -92,4 +74,22 @@ class TransactionObserver
         $transaction->saveQuietly();
         Log::debug('Transaction native amounts are updated.');
     }
+
+    public function deleting(?Transaction $transaction): void
+    {
+        app('log')->debug('Observe "deleting" of a transaction.');
+        $transaction?->transactionJournal?->delete();
+    }
+
+    public function updated(Transaction $transaction): void
+    {
+        //        Log::debug('Observe "updated" of a transaction.');
+        if (true === config('firefly.feature_flags.running_balance_column') && true === self::$recalculate) {
+            if (1 === bccomp($transaction->amount, '0')) {
+                Log::debug('Trigger recalculateForJournal');
+                AccountBalanceCalculator::recalculateForJournal($transaction->transactionJournal);
+            }
+        }
+        $this->updateNativeAmount($transaction);
+    }
 }

app/Helpers/Collector/Extensions/AccountCollection.php

@@ -36,6 +36,89 @@ use Illuminate\Support\Facades\Log;
  */
 trait AccountCollection
 {
+    #[\Override]
+    public function accountBalanceIs(string $direction, string $operator, string $value): GroupCollectorInterface
+    {
+        Log::warning(sprintf('GroupCollector will be SLOW: accountBalanceIs: "%s" "%s" "%s"', $direction, $operator, $value));
+
+        /**
+         * @param int   $index
+         * @param array $object
+         *
+         * @return bool
+         */
+        $filter              = static function (array $object) use ($direction, $operator, $value): bool {
+            /** @var array $transaction */
+            foreach ($object['transactions'] as $transaction) {
+                $key       = sprintf('%s_account_id', $direction);
+                $accountId = $transaction[$key] ?? 0;
+                if (0 === $accountId) {
+                    return false;
+                }
+
+                // in theory, this could lead to finding other users accounts.
+                /** @var null|Account $account */
+                $account   = Account::find($accountId);
+                if (null === $account) {
+                    continue;
+                }
+                // the balance must be found BEFORE the transaction date.
+                // so sub one second. This is not perfect, but works well enough.
+                $date      = clone $transaction['date'];
+                $date->subSecond();
+                Log::debug(sprintf('accountBalanceIs: Call finalAccountBalance with date/time "%s"', $date->toIso8601String()));
+                $balance   = Steam::finalAccountBalance($account, $date);
+                $result    = bccomp((string) $balance['balance'], $value);
+                Log::debug(sprintf('"%s" vs "%s" is %d', $balance['balance'], $value, $result));
+
+                switch ($operator) {
+                    default:
+                        Log::error(sprintf('GroupCollector: accountBalanceIs: unknown operator "%s"', $operator));
+
+                        return false;
+
+                    case '==':
+                        Log::debug('Expect result to be 0 (equal)');
+
+                        return 0 === $result;
+
+                    case '!=':
+                        Log::debug('Expect result to be -1 or 1 (not equal)');
+
+                        return 0 !== $result;
+
+                    case '>':
+                        Log::debug('Expect result to be 1 (greater then)');
+
+                        return 1 === $result;
+
+                    case '>=':
+                        Log::debug('Expect result to be 0 or 1 (greater then or equal)');
+
+                        return -1 !== $result;
+
+                    case '<':
+                        Log::debug('Expect result to be -1 (less than)');
+
+                        return -1 === $result;
+
+                    case '<=':
+                        Log::debug('Expect result to be -1 or 0 (less than or equal)');
+
+                        return 1 !== $result;
+                }
+                // if($balance['balance'] $operator $value) {
+
+                // }
+            }
+
+            return false;
+        };
+        $this->postFilters[] = $filter;
+
+        return $this;
+    }
+
     /**
      * These accounts must not be included.
      */
@@ -231,87 +314,4 @@ trait AccountCollection
 
         return $this;
     }
-
-    #[\Override]
-    public function accountBalanceIs(string $direction, string $operator, string $value): GroupCollectorInterface
-    {
-        Log::warning(sprintf('GroupCollector will be SLOW: accountBalanceIs: "%s" "%s" "%s"', $direction, $operator, $value));
-
-        /**
-         * @param int   $index
-         * @param array $object
-         *
-         * @return bool
-         */
-        $filter              = static function (array $object) use ($direction, $operator, $value): bool {
-            /** @var array $transaction */
-            foreach ($object['transactions'] as $transaction) {
-                $key       = sprintf('%s_account_id', $direction);
-                $accountId = $transaction[$key] ?? 0;
-                if (0 === $accountId) {
-                    return false;
-                }
-
-                // in theory, this could lead to finding other users accounts.
-                /** @var null|Account $account */
-                $account   = Account::find($accountId);
-                if (null === $account) {
-                    continue;
-                }
-                // the balance must be found BEFORE the transaction date.
-                // so sub one second. This is not perfect, but works well enough.
-                $date      = clone $transaction['date'];
-                $date->subSecond();
-                Log::debug(sprintf('accountBalanceIs: Call finalAccountBalance with date/time "%s"', $date->toIso8601String()));
-                $balance   = Steam::finalAccountBalance($account, $date);
-                $result    = bccomp((string) $balance['balance'], $value);
-                Log::debug(sprintf('"%s" vs "%s" is %d', $balance['balance'], $value, $result));
-
-                switch ($operator) {
-                    default:
-                        Log::error(sprintf('GroupCollector: accountBalanceIs: unknown operator "%s"', $operator));
-
-                        return false;
-
-                    case '==':
-                        Log::debug('Expect result to be 0 (equal)');
-
-                        return 0 === $result;
-
-                    case '!=':
-                        Log::debug('Expect result to be -1 or 1 (not equal)');
-
-                        return 0 !== $result;
-
-                    case '>':
-                        Log::debug('Expect result to be 1 (greater then)');
-
-                        return 1 === $result;
-
-                    case '>=':
-                        Log::debug('Expect result to be 0 or 1 (greater then or equal)');
-
-                        return -1 !== $result;
-
-                    case '<':
-                        Log::debug('Expect result to be -1 (less than)');
-
-                        return -1 === $result;
-
-                    case '<=':
-                        Log::debug('Expect result to be -1 or 0 (less than or equal)');
-
-                        return 1 !== $result;
-                }
-                // if($balance['balance'] $operator $value) {
-
-                // }
-            }
-
-            return false;
-        };
-        $this->postFilters[] = $filter;
-
-        return $this;
-    }
 }

app/Helpers/Collector/Extensions/CollectorProperties.php

@@ -37,6 +37,7 @@ trait CollectorProperties
 
     /** @var array<int, string> */
     public array    $sorting;
+    private array   $booleanFields;
     private ?int    $endRow;
     private bool    $expandGroupSearch;
     private array   $fields;
@@ -55,7 +56,6 @@ trait CollectorProperties
     private HasMany $query;
     private ?int    $startRow;
     private array   $stringFields;
-    private array   $booleanFields;
     /*
      * This array is used to collect ALL tags the user may search for (using 'setTags').
      * This way the user can call 'setTags' multiple times and get a joined result.

app/Helpers/Collector/Extensions/MetaCollection.php

@@ -29,12 +29,12 @@ use FireflyIII\Models\Bill;
 use FireflyIII\Models\Budget;
 use FireflyIII\Models\Category;
 use FireflyIII\Models\Tag;
+use FireflyIII\Models\TransactionJournal;
 use Illuminate\Database\Eloquent\Builder;
 use Illuminate\Database\Eloquent\Builder as EloquentBuilder;
 use Illuminate\Database\Query\JoinClause;
 use Illuminate\Support\Collection;
 use Illuminate\Support\Facades\Log;
-use FireflyIII\Models\TransactionJournal;
 
 /**
  * Trait MetaCollection

app/Helpers/Collector/GroupCollector.php

@@ -900,16 +900,6 @@ class GroupCollector implements GroupCollectorInterface
         return $this;
     }
 
-    /**
-     * Limit results to a specific currency, only normal one.
-     */
-    public function setNormalCurrency(TransactionCurrency $currency): GroupCollectorInterface
-    {
-        $this->query->where('source.transaction_currency_id', $currency->id);
-
-        return $this;
-    }
-
     public function setEndRow(int $endRow): self
     {
         $this->endRow = $endRow;
@@ -957,6 +947,16 @@ class GroupCollector implements GroupCollectorInterface
         return $this;
     }
 
+    /**
+     * Limit results to a specific currency, only normal one.
+     */
+    public function setNormalCurrency(TransactionCurrency $currency): GroupCollectorInterface
+    {
+        $this->query->where('source.transaction_currency_id', $currency->id);
+
+        return $this;
+    }
+
     /**
      * Set the page to get.
      */
@@ -1168,8 +1168,7 @@ class GroupCollector implements GroupCollectorInterface
             // include budget ID + name (if any)
             ->withBudgetInformation()
             // include bill ID + name (if any)
-            ->withBillInformation()
+            ->withBillInformation();
-        ;
 
         return $this;
     }

app/Helpers/Collector/GroupCollectorInterface.php

@@ -41,6 +41,8 @@ use Illuminate\Support\Collection;
  */
 interface GroupCollectorInterface
 {
+    public function accountBalanceIs(string $direction, string $operator, string $value): self;
+
     /**
      * Get transactions with a specific amount.
      */
@@ -457,11 +459,6 @@ interface GroupCollectorInterface
      */
     public function setCurrency(TransactionCurrency $currency): self;
 
-    /**
-     * Limit results to a specific currency, either foreign or normal one.
-     */
-    public function setNormalCurrency(TransactionCurrency $currency): self;
-
     /**
      * Set destination accounts.
      */
@@ -526,6 +523,11 @@ interface GroupCollectorInterface
      */
     public function setMetaDateRange(Carbon $start, Carbon $end, string $field): self;
 
+    /**
+     * Limit results to a specific currency, either foreign or normal one.
+     */
+    public function setNormalCurrency(TransactionCurrency $currency): self;
+
     /**
      * Define which accounts can NOT be part of the source and destination transactions.
      */
@@ -737,6 +739,4 @@ interface GroupCollectorInterface
     public function yearIs(string $year): self;
 
     public function yearIsNot(string $year): self;
-
-    public function accountBalanceIs(string $direction, string $operator, string $value): self;
 }

app/Helpers/Report/PopupReport.php

@@ -29,8 +29,8 @@ use FireflyIII\Models\Account;
 use FireflyIII\Models\Budget;
 use FireflyIII\Models\Category;
 use FireflyIII\Repositories\Account\AccountRepositoryInterface;
-use FireflyIII\Repositories\Journal\JournalRepositoryInterface;
 use FireflyIII\Repositories\Currency\CurrencyRepositoryInterface;
+use FireflyIII\Repositories\Journal\JournalRepositoryInterface;
 use Illuminate\Support\Collection;
 
 /**

app/Http/Controllers/Account/IndexController.php

@@ -121,6 +121,16 @@ class IndexController extends Controller
         return view('accounts.index', compact('objectType', 'inactivePage', 'subTitleIcon', 'subTitle', 'page', 'accounts'));
     }
 
+    private function subtract(array $startBalances, array $endBalances): array
+    {
+        $result = [];
+        foreach ($endBalances as $key => $value) {
+            $result[$key] = bcsub((string) $value, $startBalances[$key] ?? '0');
+        }
+
+        return $result;
+    }
+
     /**
      * Show list of accounts.
      *
@@ -199,14 +209,4 @@ class IndexController extends Controller
 
         return view('accounts.index', compact('objectType', 'inactiveCount', 'subTitleIcon', 'subTitle', 'page', 'accounts'));
     }
-
-    private function subtract(array $startBalances, array $endBalances): array
-    {
-        $result = [];
-        foreach ($endBalances as $key => $value) {
-            $result[$key] = bcsub((string) $value, $startBalances[$key] ?? '0');
-        }
-
-        return $result;
-    }
 }

app/Http/Controllers/Account/ShowController.php

@@ -33,7 +33,6 @@ use FireflyIII\Repositories\Account\AccountRepositoryInterface;
 use FireflyIII\Support\Debug\Timer;
 use FireflyIII\Support\Facades\Steam;
 use FireflyIII\Support\Http\Controllers\PeriodOverview;
-use FireflyIII\Support\JsonApi\Enrichments\TransactionGroupEnrichment;
 use Illuminate\Contracts\View\Factory;
 use Illuminate\Http\RedirectResponse;
 use Illuminate\Http\Request;

app/Http/Controllers/Chart/AccountController.php

@@ -35,7 +35,6 @@ use FireflyIII\Models\TransactionCurrency;
 use FireflyIII\Repositories\Account\AccountRepositoryInterface;
 use FireflyIII\Repositories\Currency\CurrencyRepositoryInterface;
 use FireflyIII\Support\CacheProperties;
-use FireflyIII\Support\Facades\Amount;
 use FireflyIII\Support\Facades\Steam;
 use FireflyIII\Support\Http\Controllers\AugumentData;
 use FireflyIII\Support\Http\Controllers\ChartGeneration;
@@ -535,6 +534,17 @@ class AccountController extends Controller
         return response()->json($data);
     }
 
+    private function updateChartKeys(array $array, array $balances): array
+    {
+        foreach (array_keys($balances) as $key) {
+            $array[$key] ??= [
+                'key' => $key,
+            ];
+        }
+
+        return $array;
+    }
+
     /**
      * Shows the balances for a given set of dates and accounts.
      *
@@ -676,15 +686,4 @@ class AccountController extends Controller
 
         return response()->json($data);
     }
-
-    private function updateChartKeys(array $array, array $balances): array
-    {
-        foreach (array_keys($balances) as $key) {
-            $array[$key] ??= [
-                'key' => $key,
-            ];
-        }
-
-        return $array;
-    }
 }

app/Http/Controllers/Chart/BudgetController.php

@@ -38,7 +38,6 @@ use FireflyIII\Repositories\Budget\NoBudgetRepositoryInterface;
 use FireflyIII\Repositories\Budget\OperationsRepositoryInterface;
 use FireflyIII\Support\CacheProperties;
 use FireflyIII\Support\Chart\Budget\FrontpageChartGenerator;
-use FireflyIII\Support\Facades\Amount;
 use FireflyIII\Support\Http\Controllers\AugumentData;
 use FireflyIII\Support\Http\Controllers\DateCalculation;
 use Illuminate\Http\JsonResponse;

app/Http/Controllers/Controller.php

@@ -51,11 +51,10 @@ abstract class Controller extends BaseController
 
     // fails on PHP < 8.4
     public protected(set) string $name;
-
-    protected string $dateTimeFormat;
-    protected string $monthAndDayFormat;
     protected bool                 $convertToNative = false;
+    protected string               $dateTimeFormat;
     protected ?TransactionCurrency $defaultCurrency;
+    protected string               $monthAndDayFormat;
     protected string               $monthFormat;
     protected string               $redirectUrl     = '/';
 
@@ -120,14 +119,14 @@ abstract class Controller extends BaseController
                 $this->monthAndDayFormat = (string) trans('config.month_and_day_js', [], $locale);
                 $this->dateTimeFormat    = (string) trans('config.date_time_js', [], $locale);
                 $darkMode                = 'browser';
-                $this->defaultCurrency   =null;
+                $this->defaultCurrency   = null;
                 // get shown-intro-preference:
                 if (auth()->check()) {
                     $this->defaultCurrency = Amount::getNativeCurrency();
                     $language              = Steam::getLanguage();
                     $locale                = Steam::getLocale();
                     $darkMode              = app('preferences')->get('darkMode', 'browser')->data;
-                    $this->convertToNative =Amount::convertToNative();
+                    $this->convertToNative = Amount::convertToNative();
                     $page                  = $this->getPageName();
                     $shownDemo             = $this->hasSeenDemo();
                     View::share('language', $language);

app/Http/Controllers/DebugController.php

@@ -25,6 +25,7 @@ declare(strict_types=1);
 namespace FireflyIII\Http\Controllers;
 
 use Carbon\Carbon;
+use Exception;
 use FireflyIII\Enums\AccountTypeEnum;
 use FireflyIII\Enums\TransactionTypeEnum;
 use FireflyIII\Exceptions\FireflyException;
@@ -65,110 +66,6 @@ class DebugController extends Controller
         $this->middleware(IsDemoUser::class)->except(['displayError']);
     }
 
-    public function routes(Request $request): never
-    {
-        if (!auth()->user()->hasRole('owner')) {
-            throw new NotFoundHttpException();
-        }
-
-        /** @var iterable $routes */
-        $routes = Route::getRoutes();
-
-        if ('true' === $request->get('api')) {
-            $collection = [];
-            $i          = 0;
-
-            echo 'PATHS="';
-
-            /** @var \Illuminate\Routing\Route $route */
-            foreach ($routes as $route) {
-                ++$i;
-                // skip API and other routes.
-                if (!str_starts_with($route->uri(), 'api/v1')
-                ) {
-                    continue;
-                }
-                // skip non GET routes
-                if (!in_array('GET', $route->methods(), true)) {
-                    continue;
-                }
-                // no name route:
-                if (null === $route->getName()) {
-                    var_dump($route);
-
-                    exit;
-                }
-
-                echo substr($route->uri(), 3);
-                if (0 === $i % 5) {
-                    echo '"<br>PATHS="${PATHS},';
-                }
-                if (0 !== $i % 5) {
-                    echo ',';
-                }
-            }
-
-            exit;
-        }
-
-
-
-        $return = [];
-
-        /** @var \Illuminate\Routing\Route $route */
-        foreach ($routes as $route) {
-            // skip API and other routes.
-            if (
-                str_starts_with($route->uri(), 'api')
-                || str_starts_with($route->uri(), '_debugbar')
-                || str_starts_with($route->uri(), '_ignition')
-                || str_starts_with($route->uri(), 'oauth')
-                || str_starts_with($route->uri(), 'chart')
-                || str_starts_with($route->uri(), 'v1/jscript')
-                || str_starts_with($route->uri(), 'v2/jscript')
-                || str_starts_with($route->uri(), 'json')
-                || str_starts_with($route->uri(), 'sanctum')
-            ) {
-                continue;
-            }
-            // skip non GET routes
-            if (!in_array('GET', $route->methods(), true)) {
-                continue;
-            }
-            // no name route:
-            if (null === $route->getName()) {
-                var_dump($route);
-
-                exit;
-            }
-            if (!str_contains($route->uri(), '{')) {
-
-                $return[$route->getName()] = route($route->getName());
-
-                continue;
-            }
-            $params                    = [];
-            foreach ($route->parameterNames() as $name) {
-                $params[] = $this->getParameter($name);
-            }
-            $return[$route->getName()] = route($route->getName(), $params);
-        }
-        $count  = 0;
-        echo '<hr>';
-        echo '<h1>Routes</h1>';
-        echo sprintf('<h2>%s</h2>', $count);
-        foreach ($return as $name => $path) {
-            echo sprintf('<a href="%1$s">%2$s</a><br>', $path, $name).PHP_EOL;
-            ++$count;
-            if (0 === $count % 10) {
-                echo '<hr>';
-                echo sprintf('<h2>%s</h2>', $count);
-            }
-        }
-
-        exit;
-    }
-
     /**
      * Show all possible errors.
      *
@@ -442,19 +339,107 @@ class DebugController extends Controller
         return implode(' ', $flags);
     }
 
-    /**
+    public function routes(Request $request): never
-     * Flash all types of messages.
-     *
-     * @return Redirector|RedirectResponse
-     */
-    public function testFlash(Request $request)
     {
-        $request->session()->flash('success', 'This is a success message.');
+        if (!auth()->user()->hasRole('owner')) {
-        $request->session()->flash('info', 'This is an info message.');
+            throw new NotFoundHttpException();
-        $request->session()->flash('warning', 'This is a warning.');
+        }
-        $request->session()->flash('error', 'This is an error!');
 
-        return redirect(route('home'));
+        /** @var iterable $routes */
+        $routes = Route::getRoutes();
+
+        if ('true' === $request->get('api')) {
+            $collection = [];
+            $i          = 0;
+
+            echo 'PATHS="';
+
+            /** @var \Illuminate\Routing\Route $route */
+            foreach ($routes as $route) {
+                ++$i;
+                // skip API and other routes.
+                if (!str_starts_with($route->uri(), 'api/v1')
+                ) {
+                    continue;
+                }
+                // skip non GET routes
+                if (!in_array('GET', $route->methods(), true)) {
+                    continue;
+                }
+                // no name route:
+                if (null === $route->getName()) {
+                    var_dump($route);
+
+                    exit;
+                }
+
+                echo substr($route->uri(), 3);
+                if (0 === $i % 5) {
+                    echo '"<br>PATHS="${PATHS},';
+                }
+                if (0 !== $i % 5) {
+                    echo ',';
+                }
+            }
+
+            exit;
+        }
+
+
+        $return = [];
+
+        /** @var \Illuminate\Routing\Route $route */
+        foreach ($routes as $route) {
+            // skip API and other routes.
+            if (
+                str_starts_with($route->uri(), 'api')
+                || str_starts_with($route->uri(), '_debugbar')
+                || str_starts_with($route->uri(), '_ignition')
+                || str_starts_with($route->uri(), 'oauth')
+                || str_starts_with($route->uri(), 'chart')
+                || str_starts_with($route->uri(), 'v1/jscript')
+                || str_starts_with($route->uri(), 'v2/jscript')
+                || str_starts_with($route->uri(), 'json')
+                || str_starts_with($route->uri(), 'sanctum')
+            ) {
+                continue;
+            }
+            // skip non GET routes
+            if (!in_array('GET', $route->methods(), true)) {
+                continue;
+            }
+            // no name route:
+            if (null === $route->getName()) {
+                var_dump($route);
+
+                exit;
+            }
+            if (!str_contains($route->uri(), '{')) {
+
+                $return[$route->getName()] = route($route->getName());
+
+                continue;
+            }
+            $params                    = [];
+            foreach ($route->parameterNames() as $name) {
+                $params[] = $this->getParameter($name);
+            }
+            $return[$route->getName()] = route($route->getName(), $params);
+        }
+        $count  = 0;
+        echo '<hr>';
+        echo '<h1>Routes</h1>';
+        echo sprintf('<h2>%s</h2>', $count);
+        foreach ($return as $name => $path) {
+            echo sprintf('<a href="%1$s">%2$s</a><br>', $path, $name).PHP_EOL;
+            ++$count;
+            if (0 === $count % 10) {
+                echo '<hr>';
+                echo sprintf('<h2>%s</h2>', $count);
+            }
+        }
+
+        exit;
     }
 
     private function getParameter(string $name): string
@@ -582,4 +567,19 @@ class DebugController extends Controller
 
         }
     }
+
+    /**
+     * Flash all types of messages.
+     *
+     * @return Redirector|RedirectResponse
+     */
+    public function testFlash(Request $request)
+    {
+        $request->session()->flash('success', 'This is a success message.');
+        $request->session()->flash('info', 'This is an info message.');
+        $request->session()->flash('warning', 'This is a warning.');
+        $request->session()->flash('error', 'This is an error!');
+
+        return redirect(route('home'));
+    }
 }

app/Http/Controllers/JavascriptController.php

@@ -142,7 +142,6 @@ class JavascriptController extends Controller
 
         return response()
             ->view('v2.javascript.variables', $data)
-            ->header('Content-Type', 'text/javascript')
+            ->header('Content-Type', 'text/javascript');
-        ;
     }
 }

app/Http/Controllers/TransactionCurrency/CreateController.php

@@ -27,8 +27,8 @@ namespace FireflyIII\Http\Controllers\TransactionCurrency;
 use FireflyIII\Exceptions\FireflyException;
 use FireflyIII\Http\Controllers\Controller;
 use FireflyIII\Http\Requests\CurrencyFormRequest;
-use FireflyIII\Repositories\User\UserRepositoryInterface;
 use FireflyIII\Repositories\Currency\CurrencyRepositoryInterface;
+use FireflyIII\Repositories\User\UserRepositoryInterface;
 use FireflyIII\User;
 use Illuminate\Contracts\View\Factory;
 use Illuminate\Http\RedirectResponse;

app/Http/Controllers/TransactionCurrency/DeleteController.php

@@ -26,8 +26,8 @@ namespace FireflyIII\Http\Controllers\TransactionCurrency;
 
 use FireflyIII\Http\Controllers\Controller;
 use FireflyIII\Models\TransactionCurrency;
-use FireflyIII\Repositories\User\UserRepositoryInterface;
 use FireflyIII\Repositories\Currency\CurrencyRepositoryInterface;
+use FireflyIII\Repositories\User\UserRepositoryInterface;
 use FireflyIII\User;
 use Illuminate\Contracts\View\Factory;
 use Illuminate\Http\RedirectResponse;

app/Http/Controllers/TransactionCurrency/EditController.php

@@ -27,8 +27,8 @@ namespace FireflyIII\Http\Controllers\TransactionCurrency;
 use FireflyIII\Http\Controllers\Controller;
 use FireflyIII\Http\Requests\CurrencyFormRequest;
 use FireflyIII\Models\TransactionCurrency;
-use FireflyIII\Repositories\User\UserRepositoryInterface;
 use FireflyIII\Repositories\Currency\CurrencyRepositoryInterface;
+use FireflyIII\Repositories\User\UserRepositoryInterface;
 use FireflyIII\User;
 use Illuminate\Contracts\View\Factory;
 use Illuminate\Http\RedirectResponse;

app/Http/Controllers/TransactionCurrency/IndexController.php

@@ -26,8 +26,8 @@ namespace FireflyIII\Http\Controllers\TransactionCurrency;
 
 use FireflyIII\Http\Controllers\Controller;
 use FireflyIII\Models\TransactionCurrency;
-use FireflyIII\Repositories\User\UserRepositoryInterface;
 use FireflyIII\Repositories\Currency\CurrencyRepositoryInterface;
+use FireflyIII\Repositories\User\UserRepositoryInterface;
 use FireflyIII\User;
 use Illuminate\Contracts\View\Factory;
 use Illuminate\Http\Request;

app/Http/Middleware/InterestingMessage.php

@@ -94,15 +94,6 @@ class InterestingMessage
         return null !== $transactionGroupId && null !== $message;
     }
 
-    private function userGroupMessage(Request $request): bool
-    {
-        // get parameters from request.
-        $transactionGroupId = $request->get('user_group_id');
-        $message            = $request->get('message');
-
-        return null !== $transactionGroupId && null !== $message;
-    }
-
     private function handleGroupMessage(Request $request): void
     {
         // get parameters from request.
@@ -141,13 +132,13 @@ class InterestingMessage
         }
     }
 
-    private function accountMessage(Request $request): bool
+    private function userGroupMessage(Request $request): bool
     {
         // get parameters from request.
-        $accountId = $request->get('account_id');
+        $transactionGroupId = $request->get('user_group_id');
         $message            = $request->get('message');
 
-        return null !== $accountId && null !== $message;
+        return null !== $transactionGroupId && null !== $message;
     }
 
     private function handleUserGroupMessage(Request $request): void
@@ -188,6 +179,15 @@ class InterestingMessage
         }
     }
 
+    private function accountMessage(Request $request): bool
+    {
+        // get parameters from request.
+        $accountId = $request->get('account_id');
+        $message   = $request->get('message');
+
+        return null !== $accountId && null !== $message;
+    }
+
     private function handleAccountMessage(Request $request): void
     {
         // get parameters from request.

app/Http/Middleware/TrustProxies.php

@@ -32,7 +32,8 @@ use Symfony\Component\HttpFoundation\Request;
 class TrustProxies extends Middleware
 {
     // After...
-    protected $headers = Request::HEADER_X_FORWARDED_FOR
+    protected $headers
+        = Request::HEADER_X_FORWARDED_FOR
         | Request::HEADER_X_FORWARDED_HOST
         | Request::HEADER_X_FORWARDED_PORT
         | Request::HEADER_X_FORWARDED_PROTO

app/Mail/InvitationMail.php

@@ -35,6 +35,7 @@ class InvitationMail extends Mailable
 {
     use Queueable;
     use SerializesModels;
+
     public string $host;
 
     /**

app/Mail/ReportNewJournalsMail.php

@@ -40,6 +40,7 @@ class ReportNewJournalsMail extends Mailable
 {
     use Queueable;
     use SerializesModels;
+
     public array $transformed;
 
     /**

app/Models/AutoBudget.php

@@ -24,6 +24,7 @@ declare(strict_types=1);
 
 namespace FireflyIII\Models;
 
+use Deprecated;
 use FireflyIII\Support\Models\ReturnsIntegerIdTrait;
 use Illuminate\Database\Eloquent\Casts\Attribute;
 use Illuminate\Database\Eloquent\Model;

app/Models/AvailableBudget.php

@@ -95,10 +95,11 @@ class AvailableBudget extends Model
         );
     }
 
-    protected function transactionCurrencyId(): Attribute
+    protected function endDate(): Attribute
     {
         return Attribute::make(
-            get: static fn ($value) => (int) $value,
+            get: fn (string $value) => Carbon::parse($value),
+            set: fn (Carbon $value) => $value->format('Y-m-d'),
         );
     }
 
@@ -110,11 +111,10 @@ class AvailableBudget extends Model
         );
     }
 
-    protected function endDate(): Attribute
+    protected function transactionCurrencyId(): Attribute
     {
         return Attribute::make(
-            get: fn (string $value) => Carbon::parse($value),
+            get: static fn ($value) => (int) $value,
-            set: fn (Carbon $value) => $value->format('Y-m-d'),
         );
     }
 }

app/Models/GroupMembership.php

@@ -36,7 +36,8 @@ class GroupMembership extends Model
     use ReturnsIntegerIdTrait;
     use ReturnsIntegerUserIdTrait;
 
-    protected $casts    = [
+    protected $casts
+                        = [
             'created_at'    => 'datetime',
             'updated_at'    => 'datetime',
             'user_id'       => 'integer',

app/Models/RecurrenceRepetition.php

@@ -24,6 +24,7 @@ declare(strict_types=1);
 
 namespace FireflyIII\Models;
 
+use Deprecated;
 use FireflyIII\Support\Models\ReturnsIntegerIdTrait;
 use Illuminate\Database\Eloquent\Casts\Attribute;
 use Illuminate\Database\Eloquent\Model;

app/Models/TransactionCurrency.php

@@ -37,8 +37,8 @@ class TransactionCurrency extends Model
     use ReturnsIntegerIdTrait;
     use SoftDeletes;
 
-    public ?bool $userGroupNative  = null;
     public ?bool $userGroupEnabled = null;
+    public ?bool $userGroupNative  = null;
     protected $casts
                                    = [
             'created_at'     => 'datetime',

app/Models/TransactionJournal.php

@@ -114,11 +114,6 @@ class TransactionJournal extends Model
         return $this->belongsTo(User::class);
     }
 
-    public function userGroup(): BelongsTo
-    {
-        return $this->belongsTo(UserGroup::class);
-    }
-
     public function attachments(): MorphMany
     {
         return $this->morphMany(Attachment::class, 'attachable');
@@ -246,6 +241,11 @@ class TransactionJournal extends Model
         return $this->hasMany(Transaction::class);
     }
 
+    public function userGroup(): BelongsTo
+    {
+        return $this->belongsTo(UserGroup::class);
+    }
+
     protected function order(): Attribute
     {
         return Attribute::make(

app/Models/TransactionType.php

@@ -23,6 +23,7 @@ declare(strict_types=1);
 
 namespace FireflyIII\Models;
 
+use Deprecated;
 use FireflyIII\Enums\TransactionTypeEnum;
 use FireflyIII\Support\Models\ReturnsIntegerIdTrait;
 use Illuminate\Database\Eloquent\Model;

app/Policies/AccountPolicy.php

@@ -40,6 +40,14 @@ class AccountPolicy
         return $this->view($user, $account);
     }
 
+    /**
+     * TODO needs better authentication, also for group.
+     */
+    public function view(User $user, Account $account): bool
+    {
+        return auth()->check() && $user->id === $account->user_id;
+    }
+
     /**
      * Everybody can do this, but selection should limit to user.
      */
@@ -57,12 +65,4 @@ class AccountPolicy
     {
         return $this->view($user, $account);
     }
-
-    /**
-     * TODO needs better authentication, also for group.
-     */
-    public function view(User $user, Account $account): bool
-    {
-        return auth()->check() && $user->id === $account->user_id;
-    }
 }

app/Providers/CurrencyServiceProvider.php

@@ -24,8 +24,8 @@ declare(strict_types=1);
 namespace FireflyIII\Providers;
 
 use FireflyIII\Repositories\Currency\CurrencyRepository;
-use FireflyIII\Repositories\Currency\CurrencyRepositoryInterface;
 use FireflyIII\Repositories\Currency\CurrencyRepository as GroupCurrencyRepository;
+use FireflyIII\Repositories\Currency\CurrencyRepositoryInterface;
 use FireflyIII\Repositories\Currency\CurrencyRepositoryInterface as GroupCurrencyRepositoryInterface;
 use FireflyIII\Repositories\ExchangeRate\ExchangeRateRepository;
 use FireflyIII\Repositories\ExchangeRate\ExchangeRateRepositoryInterface;

app/Providers/SearchServiceProvider.php

@@ -23,8 +23,8 @@ declare(strict_types=1);
 
 namespace FireflyIII\Providers;
 
-use FireflyIII\Support\Search\QueryParser\GdbotsQueryParser;
 use FireflyIII\Support\Search\OperatorQuerySearch;
+use FireflyIII\Support\Search\QueryParser\GdbotsQueryParser;
 use FireflyIII\Support\Search\QueryParser\QueryParser;
 use FireflyIII\Support\Search\QueryParser\QueryParserInterface;
 use FireflyIII\Support\Search\SearchInterface;

app/Repositories/Account/AccountRepository.php

@@ -533,6 +533,38 @@ class AccountRepository implements AccountRepositoryInterface, UserGroupInterfac
         return null;
     }
 
+    #[\Override]
+    public function periodCollection(Account $account, Carbon $start, Carbon $end): array
+    {
+        return $account->transactions()
+            ->leftJoin('transaction_journals', 'transaction_journals.id', '=', 'transactions.transaction_journal_id')
+            ->leftJoin('transaction_types', 'transaction_types.id', '=', 'transaction_journals.transaction_type_id')
+            ->leftJoin('transaction_currencies', 'transaction_currencies.id', '=', 'transactions.transaction_currency_id')
+            ->leftJoin('transaction_currencies as foreign_currencies', 'foreign_currencies.id', '=', 'transactions.foreign_currency_id')
+            ->where('transaction_journals.date', '>=', $start)
+            ->where('transaction_journals.date', '<=', $end)
+            ->get([
+                // currencies
+                'transaction_currencies.id as currency_id',
+                'transaction_currencies.code as currency_code',
+                'transaction_currencies.name as currency_name',
+                'transaction_currencies.symbol as currency_symbol',
+                'transaction_currencies.decimal_places as currency_decimal_places',
+
+                // foreign
+                'foreign_currencies.id as foreign_currency_id',
+                'foreign_currencies.code as foreign_currency_code',
+                'foreign_currencies.name as foreign_currency_name',
+                'foreign_currencies.symbol as foreign_currency_symbol',
+                'foreign_currencies.decimal_places as foreign_currency_decimal_places',
+
+                // fields
+                'transaction_journals.date', 'transaction_types.type', 'transaction_journals.transaction_currency_id', 'transactions.amount'])
+            ->toArray()
+        ;
+
+    }
+
     public function resetAccountOrder(): void
     {
         $sets = [
@@ -650,36 +682,4 @@ class AccountRepository implements AccountRepositoryInterface, UserGroupInterfac
 
         return $factory->create($data);
     }
-
-    #[\Override]
-    public function periodCollection(Account $account, Carbon $start, Carbon $end): array
-    {
-        return $account->transactions()
-            ->leftJoin('transaction_journals', 'transaction_journals.id', '=', 'transactions.transaction_journal_id')
-            ->leftJoin('transaction_types', 'transaction_types.id', '=', 'transaction_journals.transaction_type_id')
-            ->leftJoin('transaction_currencies', 'transaction_currencies.id', '=', 'transactions.transaction_currency_id')
-            ->leftJoin('transaction_currencies as foreign_currencies', 'foreign_currencies.id', '=', 'transactions.foreign_currency_id')
-            ->where('transaction_journals.date', '>=', $start)
-            ->where('transaction_journals.date', '<=', $end)
-            ->get([
-                // currencies
-                'transaction_currencies.id as currency_id',
-                'transaction_currencies.code as currency_code',
-                'transaction_currencies.name as currency_name',
-                'transaction_currencies.symbol as currency_symbol',
-                'transaction_currencies.decimal_places as currency_decimal_places',
-
-                // foreign
-                'foreign_currencies.id as foreign_currency_id',
-                'foreign_currencies.code as foreign_currency_code',
-                'foreign_currencies.name as foreign_currency_name',
-                'foreign_currencies.symbol as foreign_currency_symbol',
-                'foreign_currencies.decimal_places as foreign_currency_decimal_places',
-
-                // fields
-                'transaction_journals.date', 'transaction_types.type', 'transaction_journals.transaction_currency_id', 'transactions.amount'])
-            ->toArray()
-        ;
-
-    }
 }

app/Repositories/Account/AccountRepositoryInterface.php

@@ -71,8 +71,6 @@ interface AccountRepositoryInterface
 
     public function findByName(string $name, array $types): ?Account;
 
-    public function periodCollection(Account $account, Carbon $start, Carbon $end): array;
-
     public function getAccountBalances(Account $account): Collection;
 
     public function getAccountCurrency(Account $account): ?TransactionCurrency;
@@ -151,6 +149,8 @@ interface AccountRepositoryInterface
      */
     public function oldestJournalDate(Account $account): ?Carbon;
 
+    public function periodCollection(Account $account, Carbon $start, Carbon $end): array;
+
     /**
      * Reset order types of the mentioned accounts.
      */

app/Repositories/Webhook/WebhookRepository.php

@@ -79,8 +79,7 @@ class WebhookRepository implements WebhookRepositoryInterface, UserGroupInterfac
             ->where('webhook_messages.errored', 0)
             ->get(['webhook_messages.*'])
             ->filter(
-                static fn (WebhookMessage $message)
+                static fn (WebhookMessage $message) // @phpstan-ignore-line
-                    // @phpstan-ignore-line
                 => $message->webhookAttempts()->count() <= 2
             )->splice(0, 3)
         ;

app/Rules/BelongsUser.php

@@ -82,8 +82,6 @@ class BelongsUser implements ValidationRule
     {
 
 
-
-
         $count = PiggyBank::leftJoin('account_piggy_bank', 'account_piggy_bank.piggy_bank_id', '=', 'piggy_banks.id')
             ->leftJoin('accounts', 'accounts.id', '=', 'account_piggy_bank.account_id')
             ->where('piggy_banks.id', '=', $value)
@@ -104,32 +102,6 @@ class BelongsUser implements ValidationRule
         return $count > 0;
     }
 
-    protected function countField(string $class, string $field, string $value): int
-    {
-        $value   = trim($value);
-        $objects = [];
-        // get all objects belonging to user:
-        if (PiggyBank::class === $class) {
-            $objects = PiggyBank::leftJoin('accounts', 'accounts.id', '=', 'piggy_banks.account_id')
-                ->where('accounts.user_id', '=', auth()->user()->id)->get(['piggy_banks.*'])
-            ;
-        }
-        if (PiggyBank::class !== $class) {
-            $objects = $class::where('user_id', '=', auth()->user()->id)->get();
-        }
-        $count   = 0;
-        foreach ($objects as $object) {
-            $objectValue = trim((string) $object->{$field}); // @phpstan-ignore-line
-            app('log')->debug(sprintf('Comparing object "%s" with value "%s"', $objectValue, $value));
-            if ($objectValue === $value) {
-                ++$count;
-                app('log')->debug(sprintf('Hit! Count is now %d', $count));
-            }
-        }
-
-        return $count;
-    }
-
     private function validateBillId(int $value): bool
     {
         if (0 === $value) {
@@ -158,6 +130,32 @@ class BelongsUser implements ValidationRule
         return 1 === $count;
     }
 
+    protected function countField(string $class, string $field, string $value): int
+    {
+        $value   = trim($value);
+        $objects = [];
+        // get all objects belonging to user:
+        if (PiggyBank::class === $class) {
+            $objects = PiggyBank::leftJoin('accounts', 'accounts.id', '=', 'piggy_banks.account_id')
+                ->where('accounts.user_id', '=', auth()->user()->id)->get(['piggy_banks.*'])
+            ;
+        }
+        if (PiggyBank::class !== $class) {
+            $objects = $class::where('user_id', '=', auth()->user()->id)->get();
+        }
+        $count   = 0;
+        foreach ($objects as $object) {
+            $objectValue = trim((string) $object->{$field}); // @phpstan-ignore-line
+            app('log')->debug(sprintf('Comparing object "%s" with value "%s"', $objectValue, $value));
+            if ($objectValue === $value) {
+                ++$count;
+                app('log')->debug(sprintf('Hit! Count is now %d', $count));
+            }
+        }
+
+        return $count;
+    }
+
     private function validateBudgetId(int $value): bool
     {
         if (0 === $value) {

app/Services/Internal/Support/JournalServiceTrait.php

@@ -286,7 +286,6 @@ trait JournalServiceTrait
             }
 
 
-
             // $data['name'] = $data['name'] ?? '(no name)';
 
             $account   = $this->accountRepository->store(

app/Support/Amount.php

@@ -48,61 +48,6 @@ class Amount
         return $this->formatFlat($format->symbol, $format->decimal_places, $amount, $coloured);
     }
 
-    /**
-     * Experimental function to see if we can quickly and quietly get the amount from a journal.
-     * This depends on the user's default currency and the wish to have it converted.
-     */
-    public function getAmountFromJournal(array $journal): string
-    {
-        $convertToNative = $this->convertToNative();
-        $currency        = $this->getNativeCurrency();
-        $field           = $convertToNative && $currency->id !== $journal['currency_id'] ? 'native_amount' : 'amount';
-        $amount          = $journal[$field] ?? '0';
-        // Log::debug(sprintf('Field is %s, amount is %s', $field, $amount));
-        // fallback, the transaction has a foreign amount in $currency.
-        if ($convertToNative && null !== $journal['foreign_amount'] && $currency->id === (int) $journal['foreign_currency_id']) {
-            $amount = $journal['foreign_amount'];
-            // Log::debug(sprintf('Overruled, amount is now %s', $amount));
-        }
-
-        return (string) $amount;
-    }
-
-    public function convertToNative(?User $user = null): bool
-    {
-        if (null === $user) {
-            return true === Preferences::get('convert_to_native', false)->data && true === config('cer.enabled');
-            //            Log::debug(sprintf('convertToNative [a]: %s', var_export($result, true)));
-        }
-
-        return true === Preferences::getForUser($user, 'convert_to_native', false)->data && true === config('cer.enabled');
-        // Log::debug(sprintf('convertToNative [b]: %s', var_export($result, true)));
-    }
-
-    /**
-     * Experimental function to see if we can quickly and quietly get the amount from a journal.
-     * This depends on the user's default currency and the wish to have it converted.
-     */
-    public function getAmountFromJournalObject(TransactionJournal $journal): string
-    {
-        $convertToNative   = $this->convertToNative();
-        $currency          = $this->getNativeCurrency();
-        $field             = $convertToNative && $currency->id !== $journal->transaction_currency_id ? 'native_amount' : 'amount';
-
-        /** @var null|Transaction $sourceTransaction */
-        $sourceTransaction = $journal->transactions()->where('amount', '<', 0)->first();
-        if (null === $sourceTransaction) {
-            return '0';
-        }
-        $amount            = $sourceTransaction->{$field} ?? '0';
-        if ((int) $sourceTransaction->foreign_currency_id === $currency->id) {
-            // use foreign amount instead!
-            $amount = (string) $sourceTransaction->foreign_amount; // hard coded to be foreign amount.
-        }
-
-        return $amount;
-    }
-
     /**
      * This method will properly format the given number, in color or "black and white",
      * as a currency, given two things: the currency required and the current locale.
@@ -147,20 +92,35 @@ class Amount
         return TransactionCurrency::orderBy('code', 'ASC')->get();
     }
 
-    public function getCurrencies(): Collection
+    /**
+     * Experimental function to see if we can quickly and quietly get the amount from a journal.
+     * This depends on the user's default currency and the wish to have it converted.
+     */
+    public function getAmountFromJournal(array $journal): string
     {
-        /** @var User $user */
+        $convertToNative = $this->convertToNative();
-        $user = auth()->user();
+        $currency        = $this->getNativeCurrency();
-
+        $field           = $convertToNative && $currency->id !== $journal['currency_id'] ? 'native_amount' : 'amount';
-        return $user->currencies()->orderBy('code', 'ASC')->get();
+        $amount          = $journal[$field] ?? '0';
+        // Log::debug(sprintf('Field is %s, amount is %s', $field, $amount));
+        // fallback, the transaction has a foreign amount in $currency.
+        if ($convertToNative && null !== $journal['foreign_amount'] && $currency->id === (int) $journal['foreign_currency_id']) {
+            $amount = $journal['foreign_amount'];
+            // Log::debug(sprintf('Overruled, amount is now %s', $amount));
         }
 
-    /**
+        return (string) $amount;
-     * @deprecated
+    }
-     */
+
-    public function getDefaultCurrency(): TransactionCurrency
+    public function convertToNative(?User $user = null): bool
     {
-        return $this->getNativeCurrency();
+        if (null === $user) {
+            return true === Preferences::get('convert_to_native', false)->data && true === config('cer.enabled');
+            //            Log::debug(sprintf('convertToNative [a]: %s', var_export($result, true)));
+        }
+
+        return true === Preferences::getForUser($user, 'convert_to_native', false)->data && true === config('cer.enabled');
+        // Log::debug(sprintf('convertToNative [b]: %s', var_export($result, true)));
     }
 
     public function getNativeCurrency(): TransactionCurrency
@@ -176,14 +136,6 @@ class Amount
         return $this->getSystemCurrency();
     }
 
-    /**
-     * @deprecated
-     */
-    public function getDefaultCurrencyByUserGroup(UserGroup $userGroup): TransactionCurrency
-    {
-        return $this->getNativeCurrencyByUserGroup($userGroup);
-    }
-
     public function getNativeCurrencyByUserGroup(UserGroup $userGroup): TransactionCurrency
     {
         $cache  = new CacheProperties();
@@ -210,6 +162,46 @@ class Amount
         return TransactionCurrency::where('code', 'EUR')->first();
     }
 
+    /**
+     * Experimental function to see if we can quickly and quietly get the amount from a journal.
+     * This depends on the user's default currency and the wish to have it converted.
+     */
+    public function getAmountFromJournalObject(TransactionJournal $journal): string
+    {
+        $convertToNative   = $this->convertToNative();
+        $currency          = $this->getNativeCurrency();
+        $field             = $convertToNative && $currency->id !== $journal->transaction_currency_id ? 'native_amount' : 'amount';
+
+        /** @var null|Transaction $sourceTransaction */
+        $sourceTransaction = $journal->transactions()->where('amount', '<', 0)->first();
+        if (null === $sourceTransaction) {
+            return '0';
+        }
+        $amount            = $sourceTransaction->{$field} ?? '0';
+        if ((int) $sourceTransaction->foreign_currency_id === $currency->id) {
+            // use foreign amount instead!
+            $amount = (string) $sourceTransaction->foreign_amount; // hard coded to be foreign amount.
+        }
+
+        return $amount;
+    }
+
+    public function getCurrencies(): Collection
+    {
+        /** @var User $user */
+        $user = auth()->user();
+
+        return $user->currencies()->orderBy('code', 'ASC')->get();
+    }
+
+    /**
+     * @deprecated
+     */
+    public function getDefaultCurrency(): TransactionCurrency
+    {
+        return $this->getNativeCurrency();
+    }
+
     /**
      * @deprecated use getDefaultCurrencyByUserGroup instead
      */
@@ -218,6 +210,14 @@ class Amount
         return $this->getDefaultCurrencyByUserGroup($user->userGroup);
     }
 
+    /**
+     * @deprecated
+     */
+    public function getDefaultCurrencyByUserGroup(UserGroup $userGroup): TransactionCurrency
+    {
+        return $this->getNativeCurrencyByUserGroup($userGroup);
+    }
+
     /**
      * This method returns the correct format rules required by accounting.js,
      * the library used to format amounts in charts.

app/Support/Chart/Budget/FrontpageChartGenerator.php

@@ -39,14 +39,14 @@ use Illuminate\Support\Facades\Log;
  */
 class FrontpageChartGenerator
 {
+    public bool                                     $convertToNative = false;
+    public TransactionCurrency                      $default;
     protected OperationsRepositoryInterface         $opsRepository;
     private readonly BudgetLimitRepositoryInterface $blRepository;
     private readonly BudgetRepositoryInterface      $budgetRepository;
     private Carbon                                  $end;
     private string                                  $monthAndDayFormat;
     private Carbon                                  $start;
-    public bool                             $convertToNative = false;
-    public TransactionCurrency              $default;
 
     /**
      * FrontpageChartGenerator constructor.

app/Support/Chart/Category/FrontpageChartGenerator.php

@@ -43,13 +43,13 @@ class FrontpageChartGenerator
 {
     use AugumentData;
 
+    public bool                           $convertToNative = false;
+    public TransactionCurrency            $defaultCurrency;
     private AccountRepositoryInterface    $accountRepos;
     private array                         $currencies;
     private NoCategoryRepositoryInterface $noCatRepos;
     private OperationsRepositoryInterface $opsRepos;
     private CategoryRepositoryInterface   $repository;
-    public bool                             $convertToNative = false;
-    public TransactionCurrency              $defaultCurrency;
 
     /**
      * FrontpageChartGenerator constructor.

app/Support/Export/ExportDataGenerator.php

@@ -586,6 +586,14 @@ class ExportDataGenerator
         return $string;
     }
 
+    /**
+     * @SuppressWarnings("PHPMD.UnusedFormalParameter")
+     */
+    public function get(string $key, mixed $default = null): mixed
+    {
+        return null;
+    }
+
     /**
      * @throws CannotInsertRecord
      * @throws Exception
@@ -717,14 +725,6 @@ class ExportDataGenerator
         return $string;
     }
 
-    /**
-     * @SuppressWarnings("PHPMD.UnusedFormalParameter")
-     */
-    public function get(string $key, mixed $default = null): mixed
-    {
-        return null;
-    }
-
     /**
      * @throws CannotInsertRecord
      * @throws Exception

app/Support/Http/Api/ExchangeRateConverter.php

@@ -53,11 +53,6 @@ class ExchangeRateConverter
         }
     }
 
-    public function setUserGroup(UserGroup $userGroup): void
-    {
-        $this->userGroup = $userGroup;
-    }
-
     /**
      * @throws FireflyException
      */
@@ -284,6 +279,11 @@ class ExchangeRateConverter
         $this->ignoreSettings = $ignoreSettings;
     }
 
+    public function setUserGroup(UserGroup $userGroup): void
+    {
+        $this->userGroup = $userGroup;
+    }
+
     public function summarize(): void
     {
         if (false === $this->enabled()) {

app/Support/Http/Controllers/PeriodOverview.php

@@ -35,7 +35,6 @@ use FireflyIII\Repositories\Account\AccountRepositoryInterface;
 use FireflyIII\Repositories\Journal\JournalRepositoryInterface;
 use FireflyIII\Support\CacheProperties;
 use FireflyIII\Support\Debug\Timer;
-use Illuminate\Support\Collection;
 
 /**
  * Trait PeriodOverview.
@@ -66,8 +65,8 @@ use Illuminate\Support\Collection;
  */
 trait PeriodOverview
 {
-    protected JournalRepositoryInterface $journalRepos;
     protected AccountRepositoryInterface $accountRepository;
+    protected JournalRepositoryInterface $journalRepos;
 
     /**
      * This method returns "period entries", so nov-2015, dec-2015, etc etc (this depends on the users session range)
@@ -124,6 +123,25 @@ trait PeriodOverview
         return $entries;
     }
 
+    private function filterTransactionsByType(TransactionTypeEnum $type, array $transactions, Carbon $start, Carbon $end): array
+    {
+        $result = [];
+
+        /**
+         * @var int   $index
+         * @var array $item
+         */
+        foreach ($transactions as $index => $item) {
+            $date = Carbon::parse($item['date']);
+            if ($item['type'] === $type->value && $date >= $start && $date <= $end) {
+                $result[] = $item;
+                unset($transactions[$index]);
+            }
+        }
+
+        return [$transactions, $result];
+    }
+
     private function filterTransfers(string $direction, array $transactions, Carbon $start, Carbon $end): array
     {
         $result = [];
@@ -149,76 +167,6 @@ trait PeriodOverview
         return [$transactions, $result];
     }
 
-    private function filterTransactionsByType(TransactionTypeEnum $type, array $transactions, Carbon $start, Carbon $end): array
-    {
-        $result = [];
-
-        /**
-         * @var int   $index
-         * @var array $item
-         */
-        foreach ($transactions as $index => $item) {
-            $date = Carbon::parse($item['date']);
-            if ($item['type'] === $type->value && $date >= $start && $date <= $end) {
-                $result[] = $item;
-                unset($transactions[$index]);
-            }
-        }
-
-        return [$transactions, $result];
-    }
-
-    /**
-     * Filter a list of journals by a set of dates, and then group them by currency.
-     */
-    private function filterJournalsByDate(array $array, Carbon $start, Carbon $end): array
-    {
-        $result = [];
-
-        /** @var array $journal */
-        foreach ($array as $journal) {
-            if ($journal['date'] <= $end && $journal['date'] >= $start) {
-                $result[] = $journal;
-            }
-        }
-
-        return $result;
-    }
-
-    /**
-     * Return only transactions where $account is the source.
-     */
-    private function filterTransferredAway(Account $account, array $journals): array
-    {
-        $return = [];
-
-        /** @var array $journal */
-        foreach ($journals as $journal) {
-            if ($account->id === (int) $journal['source_account_id']) {
-                $return[] = $journal;
-            }
-        }
-
-        return $return;
-    }
-
-    /**
-     * Return only transactions where $account is the source.
-     */
-    private function filterTransferredIn(Account $account, array $journals): array
-    {
-        $return = [];
-
-        /** @var array $journal */
-        foreach ($journals as $journal) {
-            if ($account->id === (int) $journal['destination_account_id']) {
-                $return[] = $journal;
-            }
-        }
-
-        return $return;
-    }
-
     private function groupByCurrency(array $journals): array
     {
         $return = [];
@@ -340,6 +288,23 @@ trait PeriodOverview
         return $entries;
     }
 
+    /**
+     * Filter a list of journals by a set of dates, and then group them by currency.
+     */
+    private function filterJournalsByDate(array $array, Carbon $start, Carbon $end): array
+    {
+        $result = [];
+
+        /** @var array $journal */
+        foreach ($array as $journal) {
+            if ($journal['date'] <= $end && $journal['date'] >= $start) {
+                $result[] = $journal;
+            }
+        }
+
+        return $result;
+    }
+
     /**
      * Same as above, but for lists that involve transactions without a budget.
      *
@@ -614,4 +579,38 @@ trait PeriodOverview
 
         return $entries;
     }
+
+    /**
+     * Return only transactions where $account is the source.
+     */
+    private function filterTransferredAway(Account $account, array $journals): array
+    {
+        $return = [];
+
+        /** @var array $journal */
+        foreach ($journals as $journal) {
+            if ($account->id === (int) $journal['source_account_id']) {
+                $return[] = $journal;
+            }
+        }
+
+        return $return;
+    }
+
+    /**
+     * Return only transactions where $account is the source.
+     */
+    private function filterTransferredIn(Account $account, array $journals): array
+    {
+        $return = [];
+
+        /** @var array $journal */
+        foreach ($journals as $journal) {
+            if ($account->id === (int) $journal['destination_account_id']) {
+                $return[] = $journal;
+            }
+        }
+
+        return $return;
+    }
 }

app/Support/JsonApi/Enrichments/AccountEnrichment.php

@@ -34,7 +34,6 @@ use FireflyIII\Models\Location;
 use FireflyIII\Models\Note;
 use FireflyIII\Models\TransactionCurrency;
 use FireflyIII\Models\UserGroup;
-use FireflyIII\Support\Facades\Balance;
 use FireflyIII\Support\Facades\Steam;
 use FireflyIII\User;
 use Illuminate\Database\Eloquent\Model;
@@ -48,19 +47,18 @@ use Illuminate\Support\Facades\Log;
  */
 class AccountEnrichment implements EnrichmentInterface
 {
-    private Collection $collection;
-
-    private User                $user;
-    private UserGroup           $userGroup;
-    private TransactionCurrency $native;
     private array               $accountIds;
     private array               $accountTypeIds;
     private array               $accountTypes;
+    private Collection $collection;
     private array               $currencies;
-    private array               $meta;
-    private array               $openingBalances;
-    private array               $notes;
     private array               $locations;
+    private array               $meta;
+    private TransactionCurrency $native;
+    private array               $notes;
+    private array               $openingBalances;
+    private User                $user;
+    private UserGroup           $userGroup;
 
     public function __construct()
     {
@@ -109,6 +107,17 @@ class AccountEnrichment implements EnrichmentInterface
         return $this->collection;
     }
 
+    private function collectAccountIds(): void
+    {
+        /** @var Account $account */
+        foreach ($this->collection as $account) {
+            $this->accountIds[]     = (int) $account->id;
+            $this->accountTypeIds[] = (int) $account->account_type_id;
+        }
+        $this->accountIds     = array_unique($this->accountIds);
+        $this->accountTypeIds = array_unique($this->accountTypeIds);
+    }
+
     private function getAccountTypes(): void
     {
         $types = AccountType::whereIn('id', $this->accountTypeIds)->get();
@@ -119,15 +128,97 @@ class AccountEnrichment implements EnrichmentInterface
         }
     }
 
-    private function collectAccountIds(): void
+    private function collectMetaData(): void
     {
-        /** @var Account $account */
+        $set                 = AccountMeta::whereIn('name', ['is_multi_currency', 'include_net_worth', 'currency_id', 'account_role', 'account_number', 'BIC', 'liability_direction', 'interest', 'interest_period', 'current_debt'])
-        foreach ($this->collection as $account) {
+            ->whereIn('account_id', $this->accountIds)
-            $this->accountIds[]     = (int) $account->id;
+            ->get(['account_meta.id', 'account_meta.account_id', 'account_meta.name', 'account_meta.data'])->toArray()
-            $this->accountTypeIds[] = (int) $account->account_type_id;
+        ;
+
+        /** @var array $entry */
+        foreach ($set as $entry) {
+            $this->meta[(int) $entry['account_id']][$entry['name']] = (string) $entry['data'];
+            if ('currency_id' === $entry['name']) {
+                $this->currencies[(int) $entry['data']] = true;
             }
-        $this->accountIds     = array_unique($this->accountIds);
+        }
-        $this->accountTypeIds = array_unique($this->accountTypeIds);
+        $currencies          = TransactionCurrency::whereIn('id', array_keys($this->currencies))->get();
+        foreach ($currencies as $currency) {
+            $this->currencies[(int) $currency->id] = $currency;
+        }
+        $this->currencies[0] = $this->native;
+        foreach ($this->currencies as $id => $currency) {
+            if (true === $currency) {
+                throw new FireflyException(sprintf('Currency #%d not found.', $id));
+            }
+        }
+    }
+
+    private function collectNotes(): void
+    {
+        $notes = Note::query()->whereIn('noteable_id', $this->accountIds)
+            ->whereNotNull('notes.text')
+            ->where('notes.text', '!=', '')
+            ->where('noteable_type', Account::class)->get(['notes.noteable_id', 'notes.text'])->toArray()
+        ;
+        foreach ($notes as $note) {
+            $this->notes[(int) $note['noteable_id']] = (string) $note['text'];
+        }
+        Log::debug(sprintf('Enrich with %d note(s)', count($this->notes)));
+    }
+
+    private function collectLocations(): void
+    {
+        $locations = Location::query()->whereIn('locatable_id', $this->accountIds)
+            ->where('locatable_type', Account::class)->get(['locations.locatable_id', 'locations.latitude', 'locations.longitude', 'locations.zoom_level'])->toArray()
+        ;
+        foreach ($locations as $location) {
+            $this->locations[(int) $location['locatable_id']]
+                = [
+                    'latitude'   => (float) $location['latitude'],
+                    'longitude'  => (float) $location['longitude'],
+                    'zoom_level' => (int) $location['zoom_level'],
+                ];
+        }
+        Log::debug(sprintf('Enrich with %d locations(s)', count($this->locations)));
+    }
+
+    private function collectOpeningBalances(): void
+    {
+        // use new group collector:
+        /** @var GroupCollectorInterface $collector */
+        $collector = app(GroupCollectorInterface::class);
+        $collector
+            ->setUser($this->user)
+            ->setUserGroup($this->userGroup)
+            ->setAccounts($this->collection)
+            ->withAccountInformation()
+            ->setTypes([TransactionTypeEnum::OPENING_BALANCE->value])
+        ;
+        $journals  = $collector->getExtractedJournals();
+        foreach ($journals as $journal) {
+            $this->openingBalances[(int) $journal['source_account_id']]
+                = [
+                    'amount' => Steam::negative($journal['amount']),
+                    'date'   => $journal['date'],
+                ];
+            $this->openingBalances[(int) $journal['destination_account_id']]
+                = [
+                    'amount' => Steam::positive($journal['amount']),
+                    'date'   => $journal['date'],
+                ];
+        }
+    }
+
+    public function setUserGroup(UserGroup $userGroup): void
+    {
+        $this->userGroup = $userGroup;
+    }
+
+    public function setUser(User $user): void
+    {
+        $this->user      = $user;
+        $this->userGroup = $user->userGroup;
     }
 
     private function appendCollectedData(): void
@@ -179,101 +270,8 @@ class AccountEnrichment implements EnrichmentInterface
         });
     }
 
-    private function collectOpeningBalances(): void
-    {
-        // use new group collector:
-        /** @var GroupCollectorInterface $collector */
-        $collector = app(GroupCollectorInterface::class);
-        $collector
-            ->setUser($this->user)
-            ->setUserGroup($this->userGroup)
-            ->setAccounts($this->collection)
-            ->withAccountInformation()
-            ->setTypes([TransactionTypeEnum::OPENING_BALANCE->value])
-        ;
-        $journals  = $collector->getExtractedJournals();
-        foreach ($journals as $journal) {
-            $this->openingBalances[(int) $journal['source_account_id']]
-                   = [
-                       'amount' => Steam::negative($journal['amount']),
-                       'date'   => $journal['date'],
-                   ];
-            $this->openingBalances[(int) $journal['destination_account_id']]
-                   = [
-                       'amount' => Steam::positive($journal['amount']),
-                       'date'   => $journal['date'],
-                   ];
-        }
-    }
-
-    private function collectLocations(): void
-    {
-        $locations = Location::query()->whereIn('locatable_id', $this->accountIds)
-            ->where('locatable_type', Account::class)->get(['locations.locatable_id', 'locations.latitude', 'locations.longitude', 'locations.zoom_level'])->toArray()
-        ;
-        foreach ($locations as $location) {
-            $this->locations[(int) $location['locatable_id']]
-                = [
-                    'latitude'   => (float) $location['latitude'],
-                    'longitude'  => (float) $location['longitude'],
-                    'zoom_level' => (int) $location['zoom_level'],
-                ];
-        }
-        Log::debug(sprintf('Enrich with %d locations(s)', count($this->locations)));
-    }
-
-    private function collectMetaData(): void
-    {
-        $set                 = AccountMeta::whereIn('name', ['is_multi_currency', 'include_net_worth', 'currency_id', 'account_role', 'account_number', 'BIC', 'liability_direction', 'interest', 'interest_period', 'current_debt'])
-            ->whereIn('account_id', $this->accountIds)
-            ->get(['account_meta.id', 'account_meta.account_id', 'account_meta.name', 'account_meta.data'])->toArray()
-        ;
-
-        /** @var array $entry */
-        foreach ($set as $entry) {
-            $this->meta[(int) $entry['account_id']][$entry['name']] = (string) $entry['data'];
-            if ('currency_id' === $entry['name']) {
-                $this->currencies[(int) $entry['data']] = true;
-            }
-        }
-        $currencies          = TransactionCurrency::whereIn('id', array_keys($this->currencies))->get();
-        foreach ($currencies as $currency) {
-            $this->currencies[(int) $currency->id] = $currency;
-        }
-        $this->currencies[0] = $this->native;
-        foreach ($this->currencies as $id => $currency) {
-            if (true === $currency) {
-                throw new FireflyException(sprintf('Currency #%d not found.', $id));
-            }
-        }
-    }
-
-    public function setUserGroup(UserGroup $userGroup): void
-    {
-        $this->userGroup = $userGroup;
-    }
-
-    public function setUser(User $user): void
-    {
-        $this->user      = $user;
-        $this->userGroup = $user->userGroup;
-    }
-
     public function setNative(TransactionCurrency $native): void
     {
         $this->native = $native;
     }
-
-    private function collectNotes(): void
-    {
-        $notes = Note::query()->whereIn('noteable_id', $this->accountIds)
-            ->whereNotNull('notes.text')
-            ->where('notes.text', '!=', '')
-            ->where('noteable_type', Account::class)->get(['notes.noteable_id', 'notes.text'])->toArray()
-        ;
-        foreach ($notes as $note) {
-            $this->notes[(int) $note['noteable_id']] = (string) $note['text'];
-        }
-        Log::debug(sprintf('Enrich with %d note(s)', count($this->notes)));
-    }
 }

app/Support/JsonApi/Enrichments/EnrichmentInterface.php

@@ -35,7 +35,7 @@ interface EnrichmentInterface
 
     public function enrichSingle(array|Model $model): array|Model;
 
-    public function setUserGroup(UserGroup $userGroup): void;
-
     public function setUser(User $user): void;
+
+    public function setUserGroup(UserGroup $userGroup): void;
 }

app/Support/JsonApi/Enrichments/TransactionGroupEnrichment.php

@@ -42,16 +42,16 @@ use Illuminate\Support\Facades\Log;
 
 class TransactionGroupEnrichment implements EnrichmentInterface
 {
-    private Collection $collection;
-    private array      $notes;
-    private array      $tags;
-    private array      $locations;
-    private array      $journalIds;
-    private User       $user; // @phpstan-ignore-line
-    private UserGroup  $userGroup; // @phpstan-ignore-line
-    private array      $metaData;
-    private readonly array      $dateFields;
     private array          $attachmentCount;
+    private Collection     $collection;
+    private readonly array $dateFields;
+    private array          $journalIds;
+    private array          $locations;
+    private array          $metaData;      // @phpstan-ignore-line
+    private array          $notes; // @phpstan-ignore-line
+    private array          $tags;
+    private User           $user;
+    private UserGroup      $userGroup;
 
     public function __construct()
     {
@@ -64,6 +64,20 @@ class TransactionGroupEnrichment implements EnrichmentInterface
         $this->dateFields      = ['interest_date', 'book_date', 'process_date', 'due_date', 'payment_date', 'invoice_date'];
     }
 
+    #[\Override]
+    public function enrichSingle(array|Model $model): array|TransactionGroup
+    {
+        Log::debug(__METHOD__);
+        if (is_array($model)) {
+            $collection = new Collection([$model]);
+            $collection = $this->enrich($collection);
+
+            return $collection->first();
+        }
+
+        throw new FireflyException('Cannot enrich single model.');
+    }
+
     #[\Override]
     public function enrich(Collection $collection): Collection
     {
@@ -83,20 +97,6 @@ class TransactionGroupEnrichment implements EnrichmentInterface
         return $this->collection;
     }
 
-    #[\Override]
-    public function enrichSingle(array|Model $model): array|TransactionGroup
-    {
-        Log::debug(__METHOD__);
-        if (is_array($model)) {
-            $collection = new Collection([$model]);
-            $collection = $this->enrich($collection);
-
-            return $collection->first();
-        }
-
-        throw new FireflyException('Cannot enrich single model.');
-    }
-
     private function collectJournalIds(): void
     {
         /** @var array $group */
@@ -108,17 +108,6 @@ class TransactionGroupEnrichment implements EnrichmentInterface
         $this->journalIds = array_unique($this->journalIds);
     }
 
-    public function setUserGroup(UserGroup $userGroup): void
-    {
-        $this->userGroup = $userGroup;
-    }
-
-    public function setUser(User $user): void
-    {
-        $this->user      = $user;
-        $this->userGroup = $user->userGroup;
-    }
-
     private function collectNotes(): void
     {
         $notes = Note::query()->whereIn('noteable_id', $this->journalIds)
@@ -247,4 +236,15 @@ class TransactionGroupEnrichment implements EnrichmentInterface
             return $item;
         });
     }
+
+    public function setUser(User $user): void
+    {
+        $this->user      = $user;
+        $this->userGroup = $user->userGroup;
+    }
+
+    public function setUserGroup(UserGroup $userGroup): void
+    {
+        $this->userGroup = $userGroup;
+    }
 }

app/Support/Report/Summarizer/TransactionSummarizer.php

@@ -31,9 +31,9 @@ use Illuminate\Support\Facades\Log;
 
 class TransactionSummarizer
 {
-    private User                $user;
-    private TransactionCurrency $default;
     private bool                $convertToNative = false;
+    private TransactionCurrency $default;
+    private User                $user;
 
     public function __construct(?User $user = null)
     {
@@ -163,9 +163,6 @@ class TransactionSummarizer
         $default         = Amount::getNativeCurrencyByUserGroup($this->user->userGroup);
 
 
-
-
-
         Log::debug(sprintf('groupByDirection(array, %s, %s).', $direction, $method));
         foreach ($journals as $journal) {
             // currency

app/Support/Repositories/UserGroup/UserGroupInterface.php

@@ -31,15 +31,15 @@ use Illuminate\Contracts\Auth\Authenticatable;
 
 interface UserGroupInterface
 {
-    public function getUserGroup(): ?UserGroup;
+    public function checkUserGroupAccess(UserRoleEnum $role): bool;
 
     public function getUser(): ?User;
 
-    public function checkUserGroupAccess(UserRoleEnum $role): bool;
+    public function getUserGroup(): ?UserGroup;
-
-    public function setUserGroup(UserGroup $userGroup): void;
 
     public function setUser(null|Authenticatable|User $user): void;
 
+    public function setUserGroup(UserGroup $userGroup): void;
+
     public function setUserGroupById(int $userGroupId): void;
 }

app/Support/Repositories/UserGroup/UserGroupTrait.php

@@ -40,16 +40,6 @@ trait UserGroupTrait
     protected ?User      $user      = null;
     protected ?UserGroup $userGroup = null;
 
-    public function getUserGroup(): ?UserGroup
-    {
-        return $this->userGroup;
-    }
-
-    public function getUser(): ?User
-    {
-        return $this->user;
-    }
-
     public function checkUserGroupAccess(UserRoleEnum $role): bool
     {
         $result = $this->user->hasRoleInGroupOrOwner($this->userGroup, $role);
@@ -63,15 +53,9 @@ trait UserGroupTrait
         return false;
     }
 
-    /**
+    public function getUser(): ?User
-     * TODO This method does not check if the user has access to this particular user group.
-     */
-    public function setUserGroup(UserGroup $userGroup): void
     {
-        if (null === $this->user) {
+        return $this->user;
-            Log::warning(sprintf('User is not set in repository %s', static::class));
-        }
-        $this->userGroup = $userGroup;
     }
 
     /**
@@ -92,6 +76,22 @@ trait UserGroupTrait
         throw new FireflyException(sprintf('Object is of class %s, not User.', $user::class));
     }
 
+    public function getUserGroup(): ?UserGroup
+    {
+        return $this->userGroup;
+    }
+
+    /**
+     * TODO This method does not check if the user has access to this particular user group.
+     */
+    public function setUserGroup(UserGroup $userGroup): void
+    {
+        if (null === $this->user) {
+            Log::warning(sprintf('User is not set in repository %s', static::class));
+        }
+        $this->userGroup = $userGroup;
+    }
+
     /**
      * @throws FireflyException
      */

app/Support/Request/ConvertsDataTypes.php

@@ -326,6 +326,18 @@ trait ConvertsDataTypes
         return $carbon;
     }
 
+    protected function floatFromValue(?string $string): ?float
+    {
+        if (null === $string) {
+            return null;
+        }
+        if ('' === $string) {
+            return null;
+        }
+
+        return (float) $string;
+    }
+
     /**
      * Returns all data in the request, or omits the field if not set,
      * according to the config from the request. This is the way.
@@ -376,18 +388,20 @@ trait ConvertsDataTypes
     }
 
     /**
-     * Parse to integer
+     * Return integer value, or NULL when it's not set.
      */
-    protected function integerFromValue(?string $string): ?int
+    protected function nullableInteger(string $field): ?int
     {
-        if (null === $string) {
+        if (false === $this->has($field)) {
-            return null;
-        }
-        if ('' === $string) {
             return null;
         }
 
-        return (int) $string;
+        $value = (string) $this->get($field);
+        if ('' === $value) {
+            return null;
+        }
+
+        return (int) $value;
     }
 
     protected function parseAccounts(mixed $array): array
@@ -419,7 +433,10 @@ trait ConvertsDataTypes
         return $return;
     }
 
-    protected function floatFromValue(?string $string): ?float
+    /**
+     * Parse to integer
+     */
+    protected function integerFromValue(?string $string): ?int
     {
         if (null === $string) {
             return null;
@@ -428,23 +445,6 @@ trait ConvertsDataTypes
             return null;
         }
 
-        return (float) $string;
+        return (int) $string;
-    }
-
-    /**
-     * Return integer value, or NULL when it's not set.
-     */
-    protected function nullableInteger(string $field): ?int
-    {
-        if (false === $this->has($field)) {
-            return null;
-        }
-
-        $value = (string) $this->get($field);
-        if ('' === $value) {
-            return null;
-        }
-
-        return (int) $value;
     }
 }

app/Support/Search/OperatorQuerySearch.php

@@ -37,14 +37,14 @@ use FireflyIII\Repositories\Account\AccountRepositoryInterface;
 use FireflyIII\Repositories\Bill\BillRepositoryInterface;
 use FireflyIII\Repositories\Budget\BudgetRepositoryInterface;
 use FireflyIII\Repositories\Category\CategoryRepositoryInterface;
-use FireflyIII\Repositories\Tag\TagRepositoryInterface;
 use FireflyIII\Repositories\Currency\CurrencyRepositoryInterface;
-use FireflyIII\Support\Search\QueryParser\QueryParserInterface;
+use FireflyIII\Repositories\Tag\TagRepositoryInterface;
-use FireflyIII\Support\Search\QueryParser\Node;
-use FireflyIII\Support\Search\QueryParser\FieldNode;
-use FireflyIII\Support\Search\QueryParser\StringNode;
-use FireflyIII\Support\Search\QueryParser\NodeGroup;
 use FireflyIII\Support\ParseDateString;
+use FireflyIII\Support\Search\QueryParser\FieldNode;
+use FireflyIII\Support\Search\QueryParser\Node;
+use FireflyIII\Support\Search\QueryParser\NodeGroup;
+use FireflyIII\Support\Search\QueryParser\QueryParserInterface;
+use FireflyIII\Support\Search\QueryParser\StringNode;
 use FireflyIII\User;
 use Illuminate\Pagination\LengthAwarePaginator;
 use Illuminate\Support\Collection;
@@ -122,16 +122,6 @@ class OperatorQuerySearch implements SearchInterface
         return implode(' ', $this->words);
     }
 
-    public function getWords(): array
-    {
-        return $this->words;
-    }
-
-    public function getExcludedWords(): array
-    {
-        return $this->prohibitedWords;
-    }
-
     /**
      * @throws FireflyException
      */
@@ -202,15 +192,6 @@ class OperatorQuerySearch implements SearchInterface
         }
     }
 
-    private function handleNodeGroup(NodeGroup $node, bool $flipProhibitedFlag): void
-    {
-        $prohibited = $node->isProhibited($flipProhibitedFlag);
-
-        foreach ($node->getNodes() as $subNode) {
-            $this->handleSearchNode($subNode, $prohibited);
-        }
-    }
-
     private function handleStringNode(StringNode $node, bool $flipProhibitedFlag): void
     {
         $string     = $node->getValue();
@@ -2775,6 +2756,15 @@ class OperatorQuerySearch implements SearchInterface
         }
     }
 
+    private function handleNodeGroup(NodeGroup $node, bool $flipProhibitedFlag): void
+    {
+        $prohibited = $node->isProhibited($flipProhibitedFlag);
+
+        foreach ($node->getNodes() as $subNode) {
+            $this->handleSearchNode($subNode, $prohibited);
+        }
+    }
+
     public function searchTime(): float
     {
         return microtime(true) - $this->startTime;
@@ -2835,6 +2825,16 @@ class OperatorQuerySearch implements SearchInterface
         }
     }
 
+    public function getWords(): array
+    {
+        return $this->words;
+    }
+
+    public function getExcludedWords(): array
+    {
+        return $this->prohibitedWords;
+    }
+
     public function setDate(Carbon $date): void
     {
         $this->date = $date;

app/Support/Search/QueryParser/GdbotsQueryParser.php

@@ -26,9 +26,9 @@ declare(strict_types=1);
 namespace FireflyIII\Support\Search\QueryParser;
 
 use FireflyIII\Exceptions\FireflyException;
-use Gdbots\QueryParser\QueryParser as BaseQueryParser;
-use Gdbots\QueryParser\Node as GdbotsNode;
 use Gdbots\QueryParser\Enum\BoolOperator;
+use Gdbots\QueryParser\Node as GdbotsNode;
+use Gdbots\QueryParser\QueryParser as BaseQueryParser;
 use Illuminate\Support\Facades\Log;
 
 class GdbotsQueryParser implements QueryParserInterface

app/Support/Search/QueryParser/Node.php

@@ -34,28 +34,6 @@ abstract class Node
 {
     protected bool $prohibited;
 
-    /**
-     * Returns the prohibited status of the node, optionally inverted based on flipFlag
-     *
-     * Flipping is used when a node is inside a NodeGroup that has a prohibited status itself, causing inversion of the
-     * query parts inside
-     *
-     * @param bool $flipFlag When true, inverts the prohibited status
-     *
-     * @return bool The (potentially inverted) prohibited status
-     */
-    public function isProhibited(bool $flipFlag): bool
-    {
-        if ($flipFlag) {
-            // Log::debug(sprintf('This %s is (flipped) now prohibited: %s',get_class($this), var_export(!$this->prohibited, true)));
-            return !$this->prohibited;
-        }
-
-        // Log::debug(sprintf('This %s is (not flipped) now prohibited: %s',get_class($this), var_export($this->prohibited, true)));
-        return $this->prohibited;
-
-    }
-
     public function equals(self $compare): bool
     {
         if ($compare->isProhibited(false) !== $this->isProhibited(false)) {
@@ -87,4 +65,26 @@ abstract class Node
 
         return true;
     }
+
+    /**
+     * Returns the prohibited status of the node, optionally inverted based on flipFlag
+     *
+     * Flipping is used when a node is inside a NodeGroup that has a prohibited status itself, causing inversion of the
+     * query parts inside
+     *
+     * @param bool $flipFlag When true, inverts the prohibited status
+     *
+     * @return bool The (potentially inverted) prohibited status
+     */
+    public function isProhibited(bool $flipFlag): bool
+    {
+        if ($flipFlag) {
+            // Log::debug(sprintf('This %s is (flipped) now prohibited: %s',get_class($this), var_export(!$this->prohibited, true)));
+            return !$this->prohibited;
+        }
+
+        // Log::debug(sprintf('This %s is (not flipped) now prohibited: %s',get_class($this), var_export($this->prohibited, true)));
+        return $this->prohibited;
+
+    }
 }

app/Support/Search/QueryParser/QueryParser.php

@@ -34,8 +34,8 @@ use Illuminate\Support\Facades\Log;
  */
 class QueryParser implements QueryParserInterface
 {
-    private string $query;
     private int    $position = 0;
+    private string $query;
 
     public function parse(string $query): NodeGroup
     {

app/Support/Search/SearchInterface.php

@@ -33,6 +33,8 @@ use Illuminate\Support\Collection;
  */
 interface SearchInterface
 {
+    public function getExcludedWords(): array;
+
     public function getInvalidOperators(): array;
 
     public function getModifiers(): Collection;
@@ -43,8 +45,6 @@ interface SearchInterface
 
     public function getWordsAsString(): string;
 
-    public function getExcludedWords(): array;
-
     public function hasModifiers(): bool;
 
     public function parseQuery(string $query): void;

app/Support/Steam.php

@@ -40,21 +40,154 @@ use Illuminate\Support\Str;
  */
 class Steam
 {
-    public function getAccountCurrency(Account $account): ?TransactionCurrency
+    /**
+     * https://stackoverflow.com/questions/1642614/how-to-ceil-floor-and-round-bcmath-numbers
+     */
+    public function bcround(?string $number, int $precision = 0): string
     {
-        $type   = $account->accountType->type;
+        if (null === $number) {
-        $list   = config('firefly.valid_currency_account_types');
+            return '0';
-
-        // return null if not in this list.
-        if (!in_array($type, $list, true)) {
-            return null;
         }
-        $result = $account->accountMeta()->where('name', 'currency_id')->first();
+        if ('' === trim($number)) {
-        if (null === $result) {
+            return '0';
-            return null;
+        }
+        // if the number contains "E", it's in scientific notation, so we need to convert it to a normal number first.
+        if (false !== stripos($number, 'e')) {
+            $number = sprintf('%.12f', $number);
         }
 
-        return TransactionCurrency::find((int) $result->data);
+        // Log::debug(sprintf('Trying bcround("%s",%d)', $number, $precision));
+        if (str_contains($number, '.')) {
+            if ('-' !== $number[0]) {
+                return bcadd($number, '0.'.str_repeat('0', $precision).'5', $precision);
+            }
+
+            return bcsub($number, '0.'.str_repeat('0', $precision).'5', $precision);
+        }
+
+        return $number;
+    }
+
+    public function filterAccountBalances(array $total, Account $account, bool $convertToNative, ?TransactionCurrency $currency = null): array
+    {
+        Log::debug(sprintf('filterAccountBalances(#%d)', $account->id));
+        $return = [];
+        foreach ($total as $key => $value) {
+            $return[$key] = $this->filterAccountBalance($value, $account, $convertToNative, $currency);
+        }
+        Log::debug(sprintf('end of filterAccountBalances(#%d)', $account->id));
+
+        return $return;
+    }
+
+    public function filterAccountBalance(array $set, Account $account, bool $convertToNative, ?TransactionCurrency $currency = null): array
+    {
+        Log::debug(sprintf('filterAccountBalance(#%d)', $account->id), $set);
+        if (0 === count($set)) {
+            Log::debug(sprintf('Return empty array for account #%d', $account->id));
+
+            return [];
+        }
+        $defaultCurrency = app('amount')->getNativeCurrency();
+        if ($convertToNative) {
+            if ($defaultCurrency->id === $currency?->id) {
+                Log::debug(sprintf('Unset [%s] for account #%d (no longer unset "native_balance")', $defaultCurrency->code, $account->id));
+                unset($set[$defaultCurrency->code]);
+            }
+            // todo rethink this logic.
+            if (null !== $currency && $defaultCurrency->id !== $currency->id) {
+                Log::debug(sprintf('Unset balance for account #%d', $account->id));
+                unset($set['balance']);
+            }
+
+            if (null === $currency) {
+                Log::debug(sprintf('Unset balance for account #%d', $account->id));
+                unset($set['balance']);
+            }
+        }
+
+        if (!$convertToNative) {
+            if (null === $currency) {
+                Log::debug(sprintf('Unset native_balance and make defaultCurrency balance the balance for account #%d', $account->id));
+                $set['balance'] = $set[$defaultCurrency->code] ?? '0';
+                unset($set[$defaultCurrency->code]);
+            }
+
+            if (null !== $currency) {
+                Log::debug(sprintf('Unset [%s] + [%s] balance for account #%d', $defaultCurrency->code, $currency->code, $account->id));
+                unset($set[$defaultCurrency->code], $set[$currency->code]);
+            }
+        }
+
+        // put specific value first in array.
+        if (array_key_exists('native_balance', $set)) {
+            $set = ['native_balance' => $set['native_balance']] + $set;
+        }
+        if (array_key_exists('balance', $set)) {
+            $set = ['balance' => $set['balance']] + $set;
+        }
+        Log::debug(sprintf('Return #%d', $account->id), $set);
+
+        return $set;
+    }
+
+    public function filterSpaces(string $string): string
+    {
+        $search = [
+            "\u{0001}", // start of heading
+            "\u{0002}", // start of text
+            "\u{0003}", // end of text
+            "\u{0004}", // end of transmission
+            "\u{0005}", // enquiry
+            "\u{0006}", // ACK
+            "\u{0007}", // BEL
+            "\u{0008}", // backspace
+            "\u{000E}", // shift out
+            "\u{000F}", // shift in
+            "\u{0010}", // data link escape
+            "\u{0011}", // DC1
+            "\u{0012}", // DC2
+            "\u{0013}", // DC3
+            "\u{0014}", // DC4
+            "\u{0015}", // NAK
+            "\u{0016}", // SYN
+            "\u{0017}", // ETB
+            "\u{0018}", // CAN
+            "\u{0019}", // EM
+            "\u{001A}", // SUB
+            "\u{001B}", // escape
+            "\u{001C}", // file separator
+            "\u{001D}", // group separator
+            "\u{001E}", // record separator
+            "\u{001F}", // unit separator
+            "\u{007F}", // DEL
+            "\u{00A0}", // non-breaking space
+            "\u{1680}", // ogham space mark
+            "\u{180E}", // mongolian vowel separator
+            "\u{2000}", // en quad
+            "\u{2001}", // em quad
+            "\u{2002}", // en space
+            "\u{2003}", // em space
+            "\u{2004}", // three-per-em space
+            "\u{2005}", // four-per-em space
+            "\u{2006}", // six-per-em space
+            "\u{2007}", // figure space
+            "\u{2008}", // punctuation space
+            "\u{2009}", // thin space
+            "\u{200A}", // hair space
+            "\u{200B}", // zero width space
+            "\u{202F}", // narrow no-break space
+            "\u{3000}", // ideographic space
+            "\u{FEFF}", // zero width no -break space
+            "\x20", // plain old normal space,
+            ' ',
+        ];
+
+        // clear zalgo text
+        $string = \Safe\preg_replace('/(\pM{2})\pM+/u', '\1', $string);
+        $string = \Safe\preg_replace('/\s+/', '', $string);
+
+        return str_replace($search, '', $string);
     }
 
     public function finalAccountBalanceInRange(Account $account, Carbon $start, Carbon $end, bool $convertToNative): array
@@ -178,104 +311,6 @@ class Steam
         return $balances;
     }
 
-    public function finalAccountsBalance(Collection $accounts, Carbon $date): array
-    {
-        Log::debug(sprintf('finalAccountsBalance: Call finalAccountBalance with date/time "%s"', $date->toIso8601String()));
-        $balances = [];
-        foreach ($accounts as $account) {
-            $balances[$account->id] = $this->finalAccountBalance($account, $date);
-        }
-
-        return $balances;
-    }
-
-    /**
-     * https://stackoverflow.com/questions/1642614/how-to-ceil-floor-and-round-bcmath-numbers
-     */
-    public function bcround(?string $number, int $precision = 0): string
-    {
-        if (null === $number) {
-            return '0';
-        }
-        if ('' === trim($number)) {
-            return '0';
-        }
-        // if the number contains "E", it's in scientific notation, so we need to convert it to a normal number first.
-        if (false !== stripos($number, 'e')) {
-            $number = sprintf('%.12f', $number);
-        }
-
-        // Log::debug(sprintf('Trying bcround("%s",%d)', $number, $precision));
-        if (str_contains($number, '.')) {
-            if ('-' !== $number[0]) {
-                return bcadd($number, '0.'.str_repeat('0', $precision).'5', $precision);
-            }
-
-            return bcsub($number, '0.'.str_repeat('0', $precision).'5', $precision);
-        }
-
-        return $number;
-    }
-
-    public function filterSpaces(string $string): string
-    {
-        $search = [
-            "\u{0001}", // start of heading
-            "\u{0002}", // start of text
-            "\u{0003}", // end of text
-            "\u{0004}", // end of transmission
-            "\u{0005}", // enquiry
-            "\u{0006}", // ACK
-            "\u{0007}", // BEL
-            "\u{0008}", // backspace
-            "\u{000E}", // shift out
-            "\u{000F}", // shift in
-            "\u{0010}", // data link escape
-            "\u{0011}", // DC1
-            "\u{0012}", // DC2
-            "\u{0013}", // DC3
-            "\u{0014}", // DC4
-            "\u{0015}", // NAK
-            "\u{0016}", // SYN
-            "\u{0017}", // ETB
-            "\u{0018}", // CAN
-            "\u{0019}", // EM
-            "\u{001A}", // SUB
-            "\u{001B}", // escape
-            "\u{001C}", // file separator
-            "\u{001D}", // group separator
-            "\u{001E}", // record separator
-            "\u{001F}", // unit separator
-            "\u{007F}", // DEL
-            "\u{00A0}", // non-breaking space
-            "\u{1680}", // ogham space mark
-            "\u{180E}", // mongolian vowel separator
-            "\u{2000}", // en quad
-            "\u{2001}", // em quad
-            "\u{2002}", // en space
-            "\u{2003}", // em space
-            "\u{2004}", // three-per-em space
-            "\u{2005}", // four-per-em space
-            "\u{2006}", // six-per-em space
-            "\u{2007}", // figure space
-            "\u{2008}", // punctuation space
-            "\u{2009}", // thin space
-            "\u{200A}", // hair space
-            "\u{200B}", // zero width space
-            "\u{202F}", // narrow no-break space
-            "\u{3000}", // ideographic space
-            "\u{FEFF}", // zero width no -break space
-            "\x20", // plain old normal space,
-            ' ',
-        ];
-
-        // clear zalgo text
-        $string = \Safe\preg_replace('/(\pM{2})\pM+/u', '\1', $string);
-        $string = \Safe\preg_replace('/\s+/', '', $string);
-
-        return str_replace($search, '', $string);
-    }
-
     /**
      * Returns smaller than or equal to, so be careful with END OF DAY.
      *
@@ -365,67 +400,21 @@ class Steam
         return $final;
     }
 
-    public function filterAccountBalances(array $total, Account $account, bool $convertToNative, ?TransactionCurrency $currency = null): array
+    public function getAccountCurrency(Account $account): ?TransactionCurrency
     {
-        Log::debug(sprintf('filterAccountBalances(#%d)', $account->id));
+        $type   = $account->accountType->type;
-        $return = [];
+        $list   = config('firefly.valid_currency_account_types');
-        foreach ($total as $key => $value) {
-            $return[$key] = $this->filterAccountBalance($value, $account, $convertToNative, $currency);
-        }
-        Log::debug(sprintf('end of filterAccountBalances(#%d)', $account->id));
 
-        return $return;
+        // return null if not in this list.
+        if (!in_array($type, $list, true)) {
+            return null;
+        }
+        $result = $account->accountMeta()->where('name', 'currency_id')->first();
+        if (null === $result) {
+            return null;
         }
 
-    public function filterAccountBalance(array $set, Account $account, bool $convertToNative, ?TransactionCurrency $currency = null): array
+        return TransactionCurrency::find((int) $result->data);
-    {
-        Log::debug(sprintf('filterAccountBalance(#%d)', $account->id), $set);
-        if (0 === count($set)) {
-            Log::debug(sprintf('Return empty array for account #%d', $account->id));
-
-            return [];
-        }
-        $defaultCurrency = app('amount')->getNativeCurrency();
-        if ($convertToNative) {
-            if ($defaultCurrency->id === $currency?->id) {
-                Log::debug(sprintf('Unset [%s] for account #%d (no longer unset "native_balance")', $defaultCurrency->code, $account->id));
-                unset($set[$defaultCurrency->code]);
-            }
-            // todo rethink this logic.
-            if (null !== $currency && $defaultCurrency->id !== $currency->id) {
-                Log::debug(sprintf('Unset balance for account #%d', $account->id));
-                unset($set['balance']);
-            }
-
-            if (null === $currency) {
-                Log::debug(sprintf('Unset balance for account #%d', $account->id));
-                unset($set['balance']);
-            }
-        }
-
-        if (!$convertToNative) {
-            if (null === $currency) {
-                Log::debug(sprintf('Unset native_balance and make defaultCurrency balance the balance for account #%d', $account->id));
-                $set['balance'] = $set[$defaultCurrency->code] ?? '0';
-                unset($set[$defaultCurrency->code]);
-            }
-
-            if (null !== $currency) {
-                Log::debug(sprintf('Unset [%s] + [%s] balance for account #%d', $defaultCurrency->code, $currency->code, $account->id));
-                unset($set[$defaultCurrency->code], $set[$currency->code]);
-            }
-        }
-
-        // put specific value first in array.
-        if (array_key_exists('native_balance', $set)) {
-            $set = ['native_balance' => $set['native_balance']] + $set;
-        }
-        if (array_key_exists('balance', $set)) {
-            $set = ['balance' => $set['balance']] + $set;
-        }
-        Log::debug(sprintf('Return #%d', $account->id), $set);
-
-        return $set;
     }
 
     private function groupAndSumTransactions(array $array, string $group, string $field): array
@@ -440,6 +429,34 @@ class Steam
         return $return;
     }
 
+    private function convertAllBalances(array $others, TransactionCurrency $native, Carbon $date): string
+    {
+        $total     = '0';
+        $converter = new ExchangeRateConverter();
+        foreach ($others as $key => $amount) {
+            $currency = TransactionCurrency::where('code', $key)->first();
+            if (null === $currency) {
+                continue;
+            }
+            $current  = $converter->convert($currency, $native, $date, $amount);
+            Log::debug(sprintf('Convert %s %s to %s %s', $currency->code, $amount, $native->code, $current));
+            $total    = bcadd($current, $total);
+        }
+
+        return $total;
+    }
+
+    public function finalAccountsBalance(Collection $accounts, Carbon $date): array
+    {
+        Log::debug(sprintf('finalAccountsBalance: Call finalAccountBalance with date/time "%s"', $date->toIso8601String()));
+        $balances = [];
+        foreach ($accounts as $account) {
+            $balances[$account->id] = $this->finalAccountBalance($account, $date);
+        }
+
+        return $balances;
+    }
+
     /**
      * @throws FireflyException
      */
@@ -665,21 +682,4 @@ class Steam
 
         return $amount;
     }
-
-    private function convertAllBalances(array $others, TransactionCurrency $native, Carbon $date): string
-    {
-        $total     = '0';
-        $converter = new ExchangeRateConverter();
-        foreach ($others as $key => $amount) {
-            $currency = TransactionCurrency::where('code', $key)->first();
-            if (null === $currency) {
-                continue;
-            }
-            $current  = $converter->convert($currency, $native, $date, $amount);
-            Log::debug(sprintf('Convert %s %s to %s %s', $currency->code, $amount, $native->code, $current));
-            $total    = bcadd($current, $total);
-        }
-
-        return $total;
-    }
 }

app/Support/Twig/AmountFormat.php

@@ -105,31 +105,6 @@ class AmountFormat extends AbstractExtension
         );
     }
 
-    /**
-     * Use the code to format a currency.
-     */
-    protected function formatAmountByCode(): TwigFunction
-    {
-        // formatAmountByCode
-        return new TwigFunction(
-            'formatAmountByCode',
-            static function (string $amount, string $code, ?bool $coloured = null): string {
-                $coloured ??= true;
-
-                /** @var null|TransactionCurrency $currency */
-                $currency = TransactionCurrency::whereCode($code)->first();
-                if (null === $currency) {
-                    Log::error(sprintf('Could not find currency with code "%s". Fallback to native currency.', $code));
-                    $currency = Amount::getNativeCurrency();
-                    Log::error(sprintf('Fallback currency is "%s".', $currency->code));
-                }
-
-                return app('amount')->formatAnything($currency, $amount, $coloured);
-            },
-            ['is_safe' => ['html']]
-        );
-    }
-
     /**
      * Will format the amount by the currency related to the given account.
      */
@@ -165,4 +140,29 @@ class AmountFormat extends AbstractExtension
             ['is_safe' => ['html']]
         );
     }
+
+    /**
+     * Use the code to format a currency.
+     */
+    protected function formatAmountByCode(): TwigFunction
+    {
+        // formatAmountByCode
+        return new TwigFunction(
+            'formatAmountByCode',
+            static function (string $amount, string $code, ?bool $coloured = null): string {
+                $coloured ??= true;
+
+                /** @var null|TransactionCurrency $currency */
+                $currency = TransactionCurrency::whereCode($code)->first();
+                if (null === $currency) {
+                    Log::error(sprintf('Could not find currency with code "%s". Fallback to native currency.', $code));
+                    $currency = Amount::getNativeCurrency();
+                    Log::error(sprintf('Fallback currency is "%s".', $currency->code));
+                }
+
+                return app('amount')->formatAnything($currency, $amount, $coloured);
+            },
+            ['is_safe' => ['html']]
+        );
+    }
 }

app/TransactionRules/Actions/UpdatePiggyBank.php

@@ -140,6 +140,29 @@ class UpdatePiggyBank implements ActionInterface
         return $repository->findByName($name);
     }
 
+    private function getAccounts(TransactionJournal $journal): array
+    {
+        return [
+            'source'      => $journal->transactions()->where('amount', '<', '0')->first()?->account,
+            'destination' => $journal->transactions()->where('amount', '>', '0')->first()?->account,
+        ];
+    }
+
+    private function isConnected(PiggyBank $piggyBank, ?Account $link): bool
+    {
+        if (null === $link) {
+            return false;
+        }
+        foreach ($piggyBank->accounts as $account) {
+            if ($account->id === $link->id) {
+                return true;
+            }
+        }
+        Log::debug(sprintf('Piggy bank is not connected to account #%d "%s"', $link->id, $link->name));
+
+        return false;
+    }
+
     private function removeAmount(PiggyBank $piggyBank, array $array, TransactionJournal $journal, Account $account, string $amount): void
     {
         $repository = app(PiggyBankRepositoryInterface::class);
@@ -208,27 +231,4 @@ class UpdatePiggyBank implements ActionInterface
 
         $repository->addAmount($piggyBank, $account, $amount, $journal);
     }
-
-    private function getAccounts(TransactionJournal $journal): array
-    {
-        return [
-            'source'      => $journal->transactions()->where('amount', '<', '0')->first()?->account,
-            'destination' => $journal->transactions()->where('amount', '>', '0')->first()?->account,
-        ];
-    }
-
-    private function isConnected(PiggyBank $piggyBank, ?Account $link): bool
-    {
-        if (null === $link) {
-            return false;
-        }
-        foreach ($piggyBank->accounts as $account) {
-            if ($account->id === $link->id) {
-                return true;
-            }
-        }
-        Log::debug(sprintf('Piggy bank is not connected to account #%d "%s"', $link->id, $link->name));
-
-        return false;
-    }
 }

app/Transformers/AccountTransformer.php

@@ -40,9 +40,9 @@ use Symfony\Component\HttpFoundation\ParameterBag;
  */
 class AccountTransformer extends AbstractTransformer
 {
-    protected AccountRepositoryInterface $repository;
     protected bool                       $convertToNative;
     protected TransactionCurrency        $native;
+    protected AccountRepositoryInterface $repository;
 
     /**
      * AccountTransformer constructor.

app/Transformers/AvailableBudgetTransformer.php

@@ -36,11 +36,11 @@ use FireflyIII\Support\Facades\Amount;
  */
 class AvailableBudgetTransformer extends AbstractTransformer
 {
+    private readonly bool                          $convertToNative;
+    private readonly TransactionCurrency           $default;
     private readonly NoBudgetRepositoryInterface   $noBudgetRepository;
     private readonly OperationsRepositoryInterface $opsRepository;
     private readonly BudgetRepositoryInterface     $repository;
-    private readonly TransactionCurrency           $default;
-    private readonly bool $convertToNative;
 
     /**
      * CurrencyTransformer constructor.

app/Transformers/BillTransformer.php

@@ -41,9 +41,9 @@ use Illuminate\Support\Collection;
 class BillTransformer extends AbstractTransformer
 {
     private readonly BillDateCalculator      $calculator;
-    private readonly BillRepositoryInterface $repository;
-    private readonly TransactionCurrency     $default;
     private readonly bool                    $convertToNative;
+    private readonly TransactionCurrency     $default;
+    private readonly BillRepositoryInterface $repository;
 
     /**
      * BillTransformer constructor.

app/Transformers/BudgetLimitTransformer.php

@@ -41,9 +41,8 @@ class BudgetLimitTransformer extends AbstractTransformer
         = [
             'budget',
         ];
-
-    protected TransactionCurrency $default;
     protected bool                $convertToNative;
+    protected TransactionCurrency $default;
 
     public function __construct()
     {

app/Transformers/BudgetTransformer.php

@@ -38,10 +38,10 @@ use Symfony\Component\HttpFoundation\ParameterBag;
  */
 class BudgetTransformer extends AbstractTransformer
 {
-    private readonly OperationsRepositoryInterface $opsRepository;
-    private readonly BudgetRepositoryInterface     $repository;
     private readonly bool                          $convertToNative;
     private readonly TransactionCurrency           $default;
+    private readonly OperationsRepositoryInterface $opsRepository;
+    private readonly BudgetRepositoryInterface     $repository;
 
     /**
      * BudgetTransformer constructor.

app/Transformers/CategoryTransformer.php

@@ -36,10 +36,10 @@ use Illuminate\Support\Collection;
  */
 class CategoryTransformer extends AbstractTransformer
 {
+    private readonly bool                          $convertToNative;
+    private readonly TransactionCurrency           $default;
     private readonly OperationsRepositoryInterface $opsRepository;
     private readonly CategoryRepositoryInterface   $repository;
-    private readonly TransactionCurrency           $default;
-    private readonly bool                          $convertToNative;
 
     /**
      * CategoryTransformer constructor.

app/Transformers/TransactionGroupTransformer.php

@@ -231,12 +231,6 @@ class TransactionGroupTransformer extends AbstractTransformer
         return null;
     }
 
-    private function getLocation(TransactionJournal $journal): ?Location
-    {
-        /** @var null|Location */
-        return $journal->locations()->first();
-    }
-
     /**
      * @throws FireflyException
      */
@@ -526,4 +520,10 @@ class TransactionGroupTransformer extends AbstractTransformer
 
         return $array;
     }
+
+    private function getLocation(TransactionJournal $journal): ?Location
+    {
+        /** @var null|Location */
+        return $journal->locations()->first();
+    }
 }

app/Transformers/V2/AccountTransformer.php

@@ -44,13 +44,13 @@ class AccountTransformer extends AbstractTransformer
     private array               $accountMeta;
     private array               $accountTypes;
     private array               $balanceDifferences;
+    private array               $balances;
     private array               $convertedBalances;
     private array               $currencies;
     private TransactionCurrency $default;
     private array               $fullTypes;
     private array               $lastActivity;
     private array               $objectGroups;
-    private array $balances;
 
     /**
      * This method collects meta-data for one or all accounts in the transformer's collection.

app/Transformers/V2/TransactionGroupTransformer.php

@@ -53,12 +53,12 @@ class TransactionGroupTransformer extends AbstractTransformer
     private array                 $currencies   = [];
     private TransactionCurrency   $default; // collection of all currencies for this transformer.
     private array                 $journals     = [];
-    private array                 $objects      = [];
+    private array $meta                         = [];
 
     //    private array                 $currencies        = [];
     //    private array                 $transactionTypes  = [];
-    private array                 $meta         = [];
     private array $notes                        = [];
+    private array                 $objects      = [];
     //    private array                 $locations         = [];
     private array $tags                         = [];
     //    private array                 $amounts           = [];

app/Validation/FireflyValidator.php

@@ -857,8 +857,7 @@ class FireflyValidator extends Validator
                 ->where('trigger', $trigger)
                 ->where('response', $response)
                 ->where('delivery', $delivery)
-                ->where('url', $url)->count()
+                ->where('url', $url)->count();
-            ;
         }
 
         return false;