kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-11-21 00:50:07 +00:00
Code Issues Projects Releases Wiki Activity

Various code cleanup.

Browse Source
This commit is contained in:
James Cole
2021-04-07 05:55:51 +02:00
parent cb746200fa
commit 0846d4898f
11 changed files with 56 additions and 162 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
app/Repositories/TransactionGroup/TransactionGroupRepository.php
View File

@@ -112,7 +112,7 @@ class TransactionGroupRepository implements TransactionGroupRepositoryInterface
$result[$journalId] = $result[$journalId] ?? [];
$current = $attachment->toArray();
$current['file_exists'] = true;
$current['journal_title'] = $attachment->attachable->description;
$current['journal_title'] = $attachment->attachable->description; // @phpstan-ignore-line
$result[$journalId][] = $current;
}
@@ -246,7 +246,7 @@ class TransactionGroupRepository implements TransactionGroupRepositoryInterface
*/
public function getNoteText(int $journalId): ?string
{
/** @var Note $note */
/** @var Note|null $note */
$note = Note
::where('noteable_id', $journalId)
->where('noteable_type', TransactionJournal::class)
@@ -269,6 +269,7 @@ class TransactionGroupRepository implements TransactionGroupRepositoryInterface
{
$return = [];
$journals = $group->transactionJournals->pluck('id')->toArray();
$currency = app('amount')->getDefaultCurrencyByUser($this->user);
$data = PiggyBankEvent
::whereIn('transaction_journal_id', $journals)
->with('piggyBank', 'piggyBank.account')
@@ -357,12 +358,12 @@ class TransactionGroupRepository implements TransactionGroupRepositoryInterface
return $factory->create($data);
} catch (DuplicateTransactionException $e) {
Log::warning('Group repository caught group factory with a duplicate exception!');
throw new DuplicateTransactionException($e->getMessage());
throw new DuplicateTransactionException($e->getMessage(),0, $e);
} catch (FireflyException $e) {
Log::warning('Group repository caught group factory with an exception!');
Log::error($e->getMessage());
Log::error($e->getTraceAsString());
throw new FireflyException($e->getMessage());
throw new FireflyException($e->getMessage(),0, $e);
}
}