kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-10-20 11:33:59 +00:00
Code Issues Projects Releases Wiki Activity

Code cleanup.

Browse Source
This commit is contained in:
James Cole
2018-02-21 20:34:48 +01:00
parent b4157e8ce0
commit 085eb650e7
2 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
app/Services/Internal/Update/AccountUpdateService.php
View File

@@ -29,8 +29,6 @@ use FireflyIII\Factory\AccountMetaFactory;
use FireflyIII\Models\Account; use FireflyIII\Models\Account;
use FireflyIII\Models\AccountMeta; use FireflyIII\Models\AccountMeta;
use FireflyIII\Models\AccountType; use FireflyIII\Models\AccountType;
use FireflyIII\Models\Transaction;
use FireflyIII\Models\TransactionJournal;
use FireflyIII\Services\Internal\Support\AccountServiceTrait; use FireflyIII\Services\Internal\Support\AccountServiceTrait;
use Log; use Log;
@@ -128,5 +126,4 @@ class AccountUpdateService
} }
} }

3
app/Services/Internal/Update/TransactionUpdateService.php
View File

@@ -311,7 +311,7 @@ class TransactionUpdateService
* TODO method is duplicated * TODO method is duplicated
* *
* @param Transaction $transaction * @param Transaction $transaction
* @param string|null $amount * @param string|null $amount
*/ */
protected function setForeignAmount(Transaction $transaction, ?string $amount): void protected function setForeignAmount(Transaction $transaction, ?string $amount): void
{ {
@@ -330,6 +330,7 @@ class TransactionUpdateService
if (is_null($currency)) { if (is_null($currency)) {
$transaction->foreign_currency_id = null; $transaction->foreign_currency_id = null;
$transaction->save(); $transaction->save();
return; return;
} }
$transaction->foreign_currency_id = $currency->id; $transaction->foreign_currency_id = $currency->id;