kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-10-13 16:00:13 +00:00
Code Issues Projects Releases Wiki Activity

Fix some scrutiniser issues.

Browse Source
This commit is contained in:
James Cole
2017-01-14 18:52:52 +01:00
parent cc0057cc56
commit 0b5cab99cf
3 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
app/Http/Controllers/BudgetController.php
View File

@@ -278,8 +278,6 @@ class BudgetController extends Controller
throw new FireflyException('This budget limit is not part of this budget.'); throw new FireflyException('This budget limit is not part of this budget.');
} }
/** @var AccountRepositoryInterface $accountRepository */
$accountRepository = app(AccountRepositoryInterface::class);
$page = intval($request->get('page')) == 0 ? 1 : intval($request->get('page')); $page = intval($request->get('page')) == 0 ? 1 : intval($request->get('page'));
$pageSize = intval(Preferences::get('transactionPageSize', 50)->data); $pageSize = intval(Preferences::get('transactionPageSize', 50)->data);
$subTitle = trans( $subTitle = trans(
@@ -289,7 +287,6 @@ class BudgetController extends Controller
'end' => $budgetLimit->end_date->formatLocalized($this->monthAndDayFormat), 'end' => $budgetLimit->end_date->formatLocalized($this->monthAndDayFormat),
] ]
); );
$accounts = $accountRepository->getAccountsByType([AccountType::DEFAULT, AccountType::ASSET, AccountType::CASH]);
// collector: // collector:
/** @var JournalCollectorInterface $collector */ /** @var JournalCollectorInterface $collector */

2
app/Http/Controllers/TagController.php
View File

@@ -230,6 +230,8 @@ class TagController extends Controller
public function show(Request $request, JournalCollectorInterface $collector, Tag $tag, string $moment = '') public function show(Request $request, JournalCollectorInterface $collector, Tag $tag, string $moment = '')
{ {
$range = Preferences::get('viewRange', '1M')->data; $range = Preferences::get('viewRange', '1M')->data;
$start = new Carbon;
$end = new Carbon;
if (strlen($moment) > 0) { if (strlen($moment) > 0) {
try { try {

2
app/Repositories/ExportJob/ExportJobRepositoryInterface.php
View File

@@ -50,7 +50,7 @@ interface ExportJobRepositoryInterface
/** /**
* @param string $key * @param string $key
* *
* @return ExportJob|null * @return ExportJob
*/ */
public function findByKey(string $key): ExportJob; public function findByKey(string $key): ExportJob;