kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-10-12 15:35:15 +00:00
Code Issues Projects Releases Wiki Activity

Expand test cases for transaction creation through the API.

Browse Source
This commit is contained in:
James Cole
2018-02-18 19:55:35 +01:00
parent 77aced6734
commit 0b61c16eb0
4 changed files with 689 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
app/Api/V1/Requests/TransactionRequest.php
View File

@@ -90,9 +90,9 @@ class TransactionRequest extends Request
'category_id' => isset($transaction['category_id']) ? intval($transaction['category_id']) : null,
'category_name' => $transaction['category_name'] ?? null,
'source_id' => isset($transaction['source_id']) ? intval($transaction['source_id']) : null,
'source_name' => $transaction['source_name'] ?? null,
'source_name' => isset($transaction['source_name']) ? strval($transaction['source_name']) : null,
'destination_id' => isset($transaction['destination_id']) ? intval($transaction['destination_id']) : null,
'destination_name' => $transaction['destination_name'] ?? null,
'destination_name' => isset($transaction['destination_name']) ? strval($transaction['destination_name']) : null,
'reconciled' => $transaction['reconciled'] ?? false,
'identifier' => $index,
];
@@ -356,11 +356,8 @@ class TransactionRequest extends Request
// we ignore the account name at this point.
return;
}
$account = $repository->findByName($accountName, [$type]);
if (is_null($account)) {
$validator->errors()->add($nameField, trans('validation.belongs_user'));
}
// not having an opposing account by this name is NOT a problem.
return;
}