kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-10-12 15:35:15 +00:00
Code Issues Projects Releases Wiki Activity

Last code optimization before release.

Browse Source
This commit is contained in:
James Cole
2018-07-28 10:45:16 +02:00
parent d35470a79e
commit 0c7b652a70
42 changed files with 217 additions and 301 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/TransactionRules/Triggers/AbstractTrigger.php
View File

@@ -72,7 +72,7 @@ class AbstractTrigger
*
* @return AbstractTrigger
*/
public static function makeFromTrigger(RuleTrigger $trigger)
public static function makeFromTrigger(RuleTrigger $trigger): AbstractTrigger
{
$self = new static;
$self->trigger = $trigger;
@@ -91,7 +91,7 @@ class AbstractTrigger
*
* @return AbstractTrigger
*/
public static function makeFromTriggerValue(string $triggerValue)
public static function makeFromTriggerValue(string $triggerValue): AbstractTrigger
{
$self = new static;
$self->triggerValue = $triggerValue;

2
app/TransactionRules/Triggers/NotesContain.php
View File

@@ -74,7 +74,7 @@ final class NotesContain extends AbstractTrigger implements TriggerInterface
{
$search = strtolower(trim($this->triggerValue));
if (0 === \strlen($search)) {
if ('' === $search) {
Log::debug(sprintf('RuleTrigger NotesContain for journal #%d: "%s" is empty, return false.', $journal->id, $search));
return false;

2
app/TransactionRules/Triggers/NotesEmpty.php
View File

@@ -68,7 +68,7 @@ final class NotesEmpty extends AbstractTrigger implements TriggerInterface
$text = $note->text;
}
if (0 === \strlen($text)) {
if ('' === $text) {
Log::debug(sprintf('RuleTrigger NotesEmpty for journal #%d: strlen is 0, return true.', $journal->id));
return true;