kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-09-23 22:35:03 +00:00
Code Issues Projects Releases Wiki Activity

Better message for issue #247

Browse Source
This commit is contained in:
James Cole
2016-04-29 17:26:59 +02:00
parent f266b92ef1
commit 0ef3d0cf03
1 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
app/Support/Models/TransactionJournalSupport.php
View File

@@ -12,12 +12,14 @@ namespace FireflyIII\Support\Models;
use Carbon\Carbon; use Carbon\Carbon;
use FireflyIII\Exceptions\FireflyException;
use FireflyIII\Models\Account; use FireflyIII\Models\Account;
use FireflyIII\Models\Transaction; use FireflyIII\Models\Transaction;
use FireflyIII\Models\TransactionJournal; use FireflyIII\Models\TransactionJournal;
use FireflyIII\Support\CacheProperties; use FireflyIII\Support\CacheProperties;
use Illuminate\Database\Eloquent\Builder; use Illuminate\Database\Eloquent\Builder;
use Illuminate\Database\Eloquent\Model; use Illuminate\Database\Eloquent\Model;
use Log;
/** /**
* Class TransactionJournalSupport * Class TransactionJournalSupport
@@ -43,7 +45,11 @@ class TransactionJournalSupport extends Model
} }
$transaction = $journal->transactions->sortByDesc('amount')->first(); $transaction = $journal->transactions->sortByDesc('amount')->first();
$amount = $transaction->amount; if (is_null($transaction)) {
Log::error('Transaction journal #' . $journal->id . ' has ZERO transactions (or they have been deleted).');
throw new FireflyException('Transaction journal #' . $journal->id . ' has ZERO transactions. Visit this page for a solution: https://git.io/vwPFY');
}
$amount = $transaction->amount;
if ($journal->isWithdrawal()) { if ($journal->isWithdrawal()) {
$amount = bcmul($amount, '-1'); $amount = bcmul($amount, '-1');
} }