From 110228e65e1cec41694b09df3f614468b5e00b3d Mon Sep 17 00:00:00 2001 From: James Cole Date: Sat, 6 Jan 2024 07:49:50 +0100 Subject: [PATCH] Fix phpstan issue. --- app/Helpers/Collector/GroupCollector.php | 3 ++- app/Transformers/V2/TransactionGroupTransformer.php | 7 ++++++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/app/Helpers/Collector/GroupCollector.php b/app/Helpers/Collector/GroupCollector.php index 4bff2bdc52..4b5201e6bb 100644 --- a/app/Helpers/Collector/GroupCollector.php +++ b/app/Helpers/Collector/GroupCollector.php @@ -1055,6 +1055,7 @@ class GroupCollector implements GroupCollectorInterface ->orderBy('transaction_journals.order', 'ASC') ->orderBy('transaction_journals.id', 'DESC') ->orderBy('transaction_journals.description', 'DESC') - ->orderBy('source.amount', 'DESC'); + ->orderBy('source.amount', 'DESC') + ; } } diff --git a/app/Transformers/V2/TransactionGroupTransformer.php b/app/Transformers/V2/TransactionGroupTransformer.php index a40310df33..6dc8716957 100644 --- a/app/Transformers/V2/TransactionGroupTransformer.php +++ b/app/Transformers/V2/TransactionGroupTransformer.php @@ -68,7 +68,7 @@ class TransactionGroupTransformer extends AbstractTransformer { $collectForObjects = false; - /** @var array $object */ + /** @var array|TransactionGroup $object */ foreach ($objects as $object) { if (is_array($object)) { $this->collectForArray($object); @@ -147,6 +147,11 @@ class TransactionGroupTransformer extends AbstractTransformer return $return; } + /** + * @throws FireflyException + * + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) + */ private function transformJournal(TransactionJournal $journal): array { $id = $journal->id;