Reformat various code.

2025-11-16 14:48:11 +00:00 · 2022-03-29 15:10:05 +02:00
parent 60786461a9
commit 123693096c
134 changed files with 336 additions and 141 deletions
--- a/app/Http/Controllers/Account/CreateController.php
+++ b/app/Http/Controllers/Account/CreateController.php
@@ -137,6 +137,8 @@ class CreateController extends Controller
     *
     * @return RedirectResponse|Redirector
     * @throws FireflyException
+     * @throws \Psr\Container\ContainerExceptionInterface
+     * @throws \Psr\Container\NotFoundExceptionInterface
     */
    public function store(AccountFormRequest $request)
    {
--- a/app/Http/Controllers/Account/IndexController.php
+++ b/app/Http/Controllers/Account/IndexController.php
@@ -74,6 +74,9 @@ class IndexController extends Controller
     *
     * @return Factory|View
     * @throws FireflyException
+     * @throws \JsonException
+     * @throws \Psr\Container\ContainerExceptionInterface
+     * @throws \Psr\Container\NotFoundExceptionInterface
     */
    public function inactive(Request $request, string $objectType)
    {
@@ -128,7 +131,10 @@ class IndexController extends Controller
     * @param string  $objectType
     *
     * @return Factory|View
-     * @throws Exception
+     * @throws FireflyException
+     * @throws \JsonException
+     * @throws \Psr\Container\ContainerExceptionInterface
+     * @throws \Psr\Container\NotFoundExceptionInterface
     */
    public function index(Request $request, string $objectType)
    {
--- a/app/Http/Controllers/Account/ReconcileController.php
+++ b/app/Http/Controllers/Account/ReconcileController.php
@@ -86,7 +86,10 @@ class ReconcileController extends Controller
     * @param Carbon|null $end
     *
     * @return Factory|RedirectResponse|Redirector|View
-     * @throws Exception
+     * @throws FireflyException
+     * @throws \JsonException
+     * @throws \Psr\Container\ContainerExceptionInterface
+     * @throws \Psr\Container\NotFoundExceptionInterface
     */
    public function reconcile(Account $account, Carbon $start = null, Carbon $end = null)
    {
--- a/app/Http/Controllers/Account/ShowController.php
+++ b/app/Http/Controllers/Account/ShowController.php
@@ -83,8 +83,10 @@ class ShowController extends Controller
     * @param Carbon|null $end
     *
     * @return RedirectResponse|Redirector|Factory|View
-     * @throws Exception
-     *
+     * @throws \FireflyIII\Exceptions\FireflyException
+     * @throws \JsonException
+     * @throws \Psr\Container\ContainerExceptionInterface
+     * @throws \Psr\Container\NotFoundExceptionInterface
     */
    public function show(Request $request, Account $account, Carbon $start = null, Carbon $end = null)
    {
@@ -164,8 +166,10 @@ class ShowController extends Controller
     * @param Account $account
     *
     * @return RedirectResponse|Redirector|Factory|View
-     * @throws Exception
-     *
+     * @throws \FireflyIII\Exceptions\FireflyException
+     * @throws \JsonException
+     * @throws \Psr\Container\ContainerExceptionInterface
+     * @throws \Psr\Container\NotFoundExceptionInterface
     */
    public function showAll(Request $request, Account $account)
    {
--- a/app/Http/Controllers/Admin/ConfigurationController.php
+++ b/app/Http/Controllers/Admin/ConfigurationController.php
@@ -61,6 +61,8 @@ class ConfigurationController extends Controller
     *
     * @return Factory|View
     * @throws FireflyException
+     * @throws \Psr\Container\ContainerExceptionInterface
+     * @throws \Psr\Container\NotFoundExceptionInterface
     */
    public function index()
    {
--- a/app/Http/Controllers/Admin/HomeController.php
+++ b/app/Http/Controllers/Admin/HomeController.php
@@ -55,6 +55,8 @@ class HomeController extends Controller
     *
     * @return Factory|View
     * @throws FireflyException
+     * @throws \Psr\Container\ContainerExceptionInterface
+     * @throws \Psr\Container\NotFoundExceptionInterface
     */
    public function index()
    {
--- a/app/Http/Controllers/Admin/UpdateController.php
+++ b/app/Http/Controllers/Admin/UpdateController.php
@@ -61,6 +61,8 @@ class UpdateController extends Controller
     *
     * @return Factory|View
     * @throws FireflyException
+     * @throws \Psr\Container\ContainerExceptionInterface
+     * @throws \Psr\Container\NotFoundExceptionInterface
     */
    public function index()
    {
--- a/app/Http/Controllers/Auth/ForgotPasswordController.php
+++ b/app/Http/Controllers/Auth/ForgotPasswordController.php
@@ -110,6 +110,8 @@ class ForgotPasswordController extends Controller
     *
     * @return Factory|View
     * @throws FireflyException
+     * @throws \Psr\Container\ContainerExceptionInterface
+     * @throws \Psr\Container\NotFoundExceptionInterface
     */
    public function showLinkRequestForm()
    {
--- a/app/Http/Controllers/Auth/LoginController.php
+++ b/app/Http/Controllers/Auth/LoginController.php
@@ -203,6 +203,8 @@ class LoginController extends Controller
     *
     * @return Factory|Application|View|Redirector|RedirectResponse
     * @throws FireflyException
+     * @throws \Psr\Container\ContainerExceptionInterface
+     * @throws \Psr\Container\NotFoundExceptionInterface
     */
    public function showLoginForm(Request $request)
    {
--- a/app/Http/Controllers/Auth/RegisterController.php
+++ b/app/Http/Controllers/Auth/RegisterController.php
@@ -109,6 +109,7 @@ class RegisterController extends Controller

    /**
     * @return bool
+     * @throws FireflyException
     */
    protected function allowedToRegister(): bool
    {
@@ -136,7 +137,9 @@ class RegisterController extends Controller
     * @param Request $request
     *
     * @return Factory|View
+     * @throws ContainerExceptionInterface
     * @throws FireflyException
+     * @throws NotFoundExceptionInterface
     */
    public function showRegistrationForm(Request $request)
    {
--- a/app/Http/Controllers/Auth/ResetPasswordController.php
+++ b/app/Http/Controllers/Auth/ResetPasswordController.php
@@ -123,6 +123,8 @@ class ResetPasswordController extends Controller
     *
     * @return Factory|View
     * @throws FireflyException
+     * @throws \Psr\Container\ContainerExceptionInterface
+     * @throws \Psr\Container\NotFoundExceptionInterface
     */
    public function showResetForm(Request $request, $token = null)
    {
--- a/app/Http/Controllers/Bill/IndexController.php
+++ b/app/Http/Controllers/Bill/IndexController.php
@@ -146,6 +146,8 @@ class IndexController extends Controller
     *
     * @return array
     * @throws FireflyException
+     * @throws \Psr\Container\ContainerExceptionInterface
+     * @throws \Psr\Container\NotFoundExceptionInterface
     */
    private function getSums(array $bills): array
    {
--- a/app/Http/Controllers/Bill/ShowController.php
+++ b/app/Http/Controllers/Bill/ShowController.php
@@ -123,7 +123,9 @@ class ShowController extends Controller
     * @param Bill    $bill
     *
     * @return Factory|View
-     * @throws FireflyException
+     * @throws \FireflyIII\Exceptions\FireflyException
+     * @throws \Psr\Container\ContainerExceptionInterface
+     * @throws \Psr\Container\NotFoundExceptionInterface
     */
    public function show(Request $request, Bill $bill)
    {
--- a/app/Http/Controllers/Budget/AvailableBudgetController.php
+++ b/app/Http/Controllers/Budget/AvailableBudgetController.php
@@ -171,6 +171,8 @@ class AvailableBudgetController extends Controller
     * @param Request $request
     *
     * @return RedirectResponse|Redirector
+     * @throws \Psr\Container\ContainerExceptionInterface
+     * @throws \Psr\Container\NotFoundExceptionInterface
     */
    public function store(Request $request)
    {
--- a/app/Http/Controllers/Budget/IndexController.php
+++ b/app/Http/Controllers/Budget/IndexController.php
@@ -92,6 +92,9 @@ class IndexController extends Controller
     *
     * @return Factory|View
     * @throws FireflyException
+     * @throws \JsonException
+     * @throws \Psr\Container\ContainerExceptionInterface
+     * @throws \Psr\Container\NotFoundExceptionInterface
     */
    public function index(Request $request, Carbon $start = null, Carbon $end = null)
    {
--- a/app/Http/Controllers/Budget/ShowController.php
+++ b/app/Http/Controllers/Budget/ShowController.php
@@ -79,6 +79,9 @@ class ShowController extends Controller
     *
     * @return Factory|View
     * @throws FireflyException
+     * @throws \JsonException
+     * @throws \Psr\Container\ContainerExceptionInterface
+     * @throws \Psr\Container\NotFoundExceptionInterface
     */
    public function noBudget(Request $request, Carbon $start = null, Carbon $end = null)
    {
@@ -115,6 +118,8 @@ class ShowController extends Controller
     *
     * @return Factory|View
     * @throws FireflyException
+     * @throws \Psr\Container\ContainerExceptionInterface
+     * @throws \Psr\Container\NotFoundExceptionInterface
     */
    public function noBudgetAll(Request $request)
    {
@@ -144,6 +149,9 @@ class ShowController extends Controller
     *
     * @return Factory|View
     * @throws FireflyException
+     * @throws \JsonException
+     * @throws \Psr\Container\ContainerExceptionInterface
+     * @throws \Psr\Container\NotFoundExceptionInterface
     */
    public function show(Request $request, Budget $budget)
    {
@@ -179,6 +187,9 @@ class ShowController extends Controller
     *
     * @return Factory|View
     * @throws FireflyException
+     * @throws \JsonException
+     * @throws \Psr\Container\ContainerExceptionInterface
+     * @throws \Psr\Container\NotFoundExceptionInterface
     */
    public function showByBudgetLimit(Request $request, Budget $budget, BudgetLimit $budgetLimit)
    {
--- a/app/Http/Controllers/Category/IndexController.php
+++ b/app/Http/Controllers/Category/IndexController.php
@@ -68,6 +68,8 @@ class IndexController extends Controller
     *
     * @return Factory|View
     * @throws FireflyException
+     * @throws \Psr\Container\ContainerExceptionInterface
+     * @throws \Psr\Container\NotFoundExceptionInterface
     */
    public function index(Request $request)
    {
--- a/app/Http/Controllers/Category/NoCategoryController.php
+++ b/app/Http/Controllers/Category/NoCategoryController.php
@@ -76,6 +76,9 @@ class NoCategoryController extends Controller
     *
     * @return Factory|View
     * @throws FireflyException
+     * @throws \JsonException
+     * @throws \Psr\Container\ContainerExceptionInterface
+     * @throws \Psr\Container\NotFoundExceptionInterface
     */
    public function show(Request $request, Carbon $start = null, Carbon $end = null)
    {
@@ -114,6 +117,8 @@ class NoCategoryController extends Controller
     *
     * @return Factory|View
     * @throws FireflyException
+     * @throws \Psr\Container\ContainerExceptionInterface
+     * @throws \Psr\Container\NotFoundExceptionInterface
     */
    public function showAll(Request $request)
    {
--- a/app/Http/Controllers/Category/ShowController.php
+++ b/app/Http/Controllers/Category/ShowController.php
@@ -78,6 +78,9 @@ class ShowController extends Controller
     *
     * @return Factory|View
     * @throws FireflyException
+     * @throws \JsonException
+     * @throws \Psr\Container\ContainerExceptionInterface
+     * @throws \Psr\Container\NotFoundExceptionInterface
     */
    public function show(Request $request, Category $category, Carbon $start = null, Carbon $end = null)
    {
@@ -118,6 +121,8 @@ class ShowController extends Controller
     *
     * @return Factory|View
     * @throws FireflyException
+     * @throws \Psr\Container\ContainerExceptionInterface
+     * @throws \Psr\Container\NotFoundExceptionInterface
     */
    public function showAll(Request $request, Category $category)
    {
--- a/app/Http/Controllers/Chart/AccountController.php
+++ b/app/Http/Controllers/Chart/AccountController.php
@@ -175,6 +175,7 @@ class AccountController extends Controller
     * @param Account                    $account
     *
     * @return JsonResponse
+     * @throws JsonException
     */
    public function expenseBudgetAll(AccountRepositoryInterface $repository, Account $account): JsonResponse
    {
@@ -192,7 +193,6 @@ class AccountController extends Controller
     * @param Carbon  $end
     *
     * @return JsonResponse
-     * @throws JsonException
     */
    public function expenseBudget(Account $account, Carbon $start, Carbon $end): JsonResponse
    {
@@ -250,6 +250,7 @@ class AccountController extends Controller
     * @param Account                    $account
     *
     * @return JsonResponse
+     * @throws JsonException
     */
    public function expenseCategoryAll(AccountRepositoryInterface $repository, Account $account): JsonResponse
    {
@@ -267,7 +268,6 @@ class AccountController extends Controller
     * @param Carbon  $end
     *
     * @return JsonResponse
-     * @throws JsonException
     */
    public function expenseCategory(Account $account, Carbon $start, Carbon $end): JsonResponse
    {
@@ -323,6 +323,9 @@ class AccountController extends Controller
     *
     * @return JsonResponse
     * @throws FireflyException
+     * @throws JsonException
+     * @throws \Psr\Container\ContainerExceptionInterface
+     * @throws \Psr\Container\NotFoundExceptionInterface
     */
    public function frontpage(AccountRepositoryInterface $repository): JsonResponse
    {
@@ -348,6 +351,7 @@ class AccountController extends Controller
     * @param Account                    $account
     *
     * @return JsonResponse
+     * @throws JsonException
     */
    public function incomeCategoryAll(AccountRepositoryInterface $repository, Account $account): JsonResponse
    {
@@ -365,7 +369,6 @@ class AccountController extends Controller
     * @param Carbon  $end
     *
     * @return JsonResponse
-     * @throws JsonException
     */
    public function incomeCategory(Account $account, Carbon $start, Carbon $end): JsonResponse
    {
@@ -517,11 +520,13 @@ class AccountController extends Controller
     *
     * See reference nr. 55
     *
-     * @param Carbon     $start
-     * @param Carbon     $end
     * @param Collection $accounts
     *
+     * @param Carbon     $start
+     * @param Carbon     $end
     * @return JsonResponse
+     * @throws FireflyException
+     * @throws JsonException
     */
    public function report(Collection $accounts, Carbon $start, Carbon $end): JsonResponse
    {
--- a/app/Http/Controllers/Chart/BillController.php
+++ b/app/Http/Controllers/Chart/BillController.php
@@ -58,7 +58,6 @@ class BillController extends Controller
     * @param BillRepositoryInterface $repository
     *
     * @return JsonResponse
-     * @throws JsonException
     */
    public function frontpage(BillRepositoryInterface $repository): JsonResponse
    {
@@ -104,7 +103,7 @@ class BillController extends Controller
     * @param Bill $bill
     *
     * @return JsonResponse
-     * @throws JsonException
+     * @throws \FireflyIII\Exceptions\FireflyException
     */
    public function single(Bill $bill): JsonResponse
    {
--- a/app/Http/Controllers/Chart/BudgetController.php
+++ b/app/Http/Controllers/Chart/BudgetController.php
@@ -85,7 +85,6 @@ class BudgetController extends Controller
     * @param Budget $budget
     *
     * @return JsonResponse
-     * @throws JsonException
     */
    public function budget(Budget $budget): JsonResponse
    {
@@ -154,7 +153,6 @@ class BudgetController extends Controller
     * @return JsonResponse
     *
     * @throws FireflyException
-     * @throws JsonException
     */
    public function budgetLimit(Budget $budget, BudgetLimit $budgetLimit): JsonResponse
    {
@@ -205,7 +203,6 @@ class BudgetController extends Controller
     * @param BudgetLimit|null $budgetLimit
     *
     * @return JsonResponse
-     * @throws JsonException
     */
    public function expenseAsset(Budget $budget, ?BudgetLimit $budgetLimit = null): JsonResponse
    {
@@ -274,7 +271,6 @@ class BudgetController extends Controller
     * @param BudgetLimit|null $budgetLimit
     *
     * @return JsonResponse
-     * @throws JsonException
     */
    public function expenseCategory(Budget $budget, ?BudgetLimit $budgetLimit = null): JsonResponse
    {
@@ -339,7 +335,6 @@ class BudgetController extends Controller
     * @param BudgetLimit|null $budgetLimit
     *
     * @return JsonResponse
-     * @throws JsonException
     */
    public function expenseExpense(Budget $budget, ?BudgetLimit $budgetLimit = null): JsonResponse
    {
@@ -403,7 +398,6 @@ class BudgetController extends Controller
     * Shows a budget list with spent/left/overspent.
     *
     * @return JsonResponse
-     * @throws JsonException
     */
    public function frontpage(): JsonResponse
    {
@@ -441,7 +435,6 @@ class BudgetController extends Controller
     * @param Carbon              $end
     *
     * @return JsonResponse
-     * @throws JsonException
     */
    public function period(Budget $budget, TransactionCurrency $currency, Collection $accounts, Carbon $start, Carbon $end): JsonResponse
    {
@@ -517,7 +510,6 @@ class BudgetController extends Controller
     * @param Carbon              $end
     *
     * @return JsonResponse
-     * @throws JsonException
     */
    public function periodNoBudget(TransactionCurrency $currency, Collection $accounts, Carbon $start, Carbon $end): JsonResponse
    {
--- a/app/Http/Controllers/Chart/CategoryController.php
+++ b/app/Http/Controllers/Chart/CategoryController.php
@@ -71,7 +71,8 @@ class CategoryController extends Controller
     *
     * @return JsonResponse
     * @throws FireflyException
-     * @throws JsonException
+     * @throws \Psr\Container\ContainerExceptionInterface
+     * @throws \Psr\Container\NotFoundExceptionInterface
     */
    public function all(Category $category): JsonResponse
    {
@@ -118,7 +119,6 @@ class CategoryController extends Controller
     * See reference nr. 60
     *
     * @return JsonResponse
-     * @throws JsonException
     */
    public function frontPage(): JsonResponse
    {
@@ -151,7 +151,6 @@ class CategoryController extends Controller
     * @param Carbon     $end
     *
     * @return JsonResponse
-     * @throws JsonException
     */
    public function reportPeriod(Category $category, Collection $accounts, Carbon $start, Carbon $end): JsonResponse
    {
@@ -267,7 +266,6 @@ class CategoryController extends Controller
     * @param Carbon     $end
     *
     * @return JsonResponse
-     * @throws JsonException
     */
    public function reportPeriodNoCategory(Collection $accounts, Carbon $start, Carbon $end): JsonResponse
    {
@@ -295,7 +293,8 @@ class CategoryController extends Controller
     *
     * @return JsonResponse
     * @throws FireflyException
-     * @throws JsonException
+     * @throws \Psr\Container\ContainerExceptionInterface
+     * @throws \Psr\Container\NotFoundExceptionInterface
     */
    public function specificPeriod(Category $category, Carbon $date): JsonResponse
    {
--- a/app/Http/Controllers/Chart/PiggyBankController.php
+++ b/app/Http/Controllers/Chart/PiggyBankController.php
@@ -64,7 +64,7 @@ class PiggyBankController extends Controller
     * @param PiggyBank                    $piggyBank
     *
     * @return JsonResponse
-     * @throws JsonException
+     * @throws \FireflyIII\Exceptions\FireflyException
     */
    public function history(PiggyBankRepositoryInterface $repository, PiggyBank $piggyBank): JsonResponse
    {
--- a/app/Http/Controllers/Chart/ReportController.php
+++ b/app/Http/Controllers/Chart/ReportController.php
@@ -69,7 +69,7 @@ class ReportController extends Controller
     * @param Carbon     $end
     *
     * @return JsonResponse
-     * @throws JsonException
+     * @throws \FireflyIII\Exceptions\FireflyException
     */
    public function netWorth(Collection $accounts, Carbon $start, Carbon $end): JsonResponse
    {
--- a/app/Http/Controllers/Chart/TransactionController.php
+++ b/app/Http/Controllers/Chart/TransactionController.php
@@ -57,7 +57,6 @@ class TransactionController extends Controller
     * @param Carbon $end
     *
     * @return JsonResponse
-     * @throws JsonException
     */
    public function budgets(Carbon $start, Carbon $end)
    {
@@ -102,7 +101,6 @@ class TransactionController extends Controller
     *
     * @return JsonResponse
     * @throws FireflyException
-     * @throws JsonException
     */
    public function categories(string $objectType, Carbon $start, Carbon $end)
    {
@@ -161,7 +159,6 @@ class TransactionController extends Controller
     *
     * @return JsonResponse
     * @throws FireflyException
-     * @throws JsonException
     */
    public function destinationAccounts(string $objectType, Carbon $start, Carbon $end)
    {
@@ -219,7 +216,6 @@ class TransactionController extends Controller
     *
     * @return JsonResponse
     * @throws FireflyException
-     * @throws JsonException
     */
    public function sourceAccounts(string $objectType, Carbon $start, Carbon $end)
    {
--- a/app/Http/Controllers/CurrencyController.php
+++ b/app/Http/Controllers/CurrencyController.php
@@ -208,9 +208,8 @@ class CurrencyController extends Controller
    }

    /**
-     * @param Request             $request
-     * @param TransactionCurrency $currency
-     *
+     * @param Request $request
+     * @return JsonResponse
     * @throws FireflyException
     */
    public function disableCurrency(Request $request): JsonResponse
@@ -312,8 +311,7 @@ class CurrencyController extends Controller
    }

    /**
-     * @param TransactionCurrency $currency
-     *
+     * @param Request $request
     * @return RedirectResponse|Redirector
     */
    public function enableCurrency(Request $request)
@@ -341,6 +339,8 @@ class CurrencyController extends Controller
     *
     * @return Factory|View
     * @throws FireflyException
+     * @throws \Psr\Container\ContainerExceptionInterface
+     * @throws \Psr\Container\NotFoundExceptionInterface
     */
    public function index(Request $request)
    {
--- a/app/Http/Controllers/HomeController.php
+++ b/app/Http/Controllers/HomeController.php
@@ -99,6 +99,7 @@ class HomeController extends Controller
     * @param AccountRepositoryInterface $repository
     *
     * @return mixed
+     * @throws \FireflyIII\Exceptions\FireflyException
     */
    public function index(AccountRepositoryInterface $repository): mixed
    {
--- a/app/Http/Controllers/JavascriptController.php
+++ b/app/Http/Controllers/JavascriptController.php
@@ -48,6 +48,8 @@ class JavascriptController extends Controller
     *
     * @return Response
     * @throws FireflyException
+     * @throws \Psr\Container\ContainerExceptionInterface
+     * @throws \Psr\Container\NotFoundExceptionInterface
     */
    public function accounts(AccountRepositoryInterface $repository, CurrencyRepositoryInterface $currencyRepository): Response
    {
@@ -107,6 +109,9 @@ class JavascriptController extends Controller
     *
     * @return Response
     * @throws FireflyException
+     * @throws \JsonException
+     * @throws \Psr\Container\ContainerExceptionInterface
+     * @throws \Psr\Container\NotFoundExceptionInterface
     */
    public function variables(Request $request, AccountRepositoryInterface $repository, CurrencyRepositoryInterface $currencyRepository): Response
    {
--- a/app/Http/Controllers/Json/BoxController.php
+++ b/app/Http/Controllers/Json/BoxController.php
@@ -52,7 +52,6 @@ class BoxController extends Controller
     * 2) if the user has no available amount set this period: spent per day
     *
     * @return JsonResponse
-     * @throws JsonException
     */
    public function available(): JsonResponse
    {
@@ -131,7 +130,6 @@ class BoxController extends Controller
     * @param CurrencyRepositoryInterface $repository
     *
     * @return JsonResponse
-     * @throws JsonException
     */
    public function balance(CurrencyRepositoryInterface $repository): JsonResponse
    {
--- a/app/Http/Controllers/Json/ReconcileController.php
+++ b/app/Http/Controllers/Json/ReconcileController.php
@@ -76,12 +76,14 @@ class ReconcileController extends Controller
    /**
     * Overview of reconciliation.
     *
-     * @param Request $request
-     * @param Account $account
-     * @param Carbon  $start
-     * @param Carbon  $end
+     * @param Request      $request
+     * @param Account|null $account
+     * @param Carbon|null  $start
+     * @param Carbon|null  $end
     *
     * @return JsonResponse
+     * @throws FireflyException
+     * @throws JsonException
     */
    public function overview(Request $request, Account $account = null, Carbon $start = null, Carbon $end = null): JsonResponse
    {
@@ -216,9 +218,9 @@ class ReconcileController extends Controller
    /**
     * Returns a list of transactions in a modal.
     *
-     * @param Account $account
-     * @param Carbon  $start
-     * @param Carbon  $end
+     * @param Account     $account
+     * @param Carbon|null $start
+     * @param Carbon|null $end
     *
     * @return JsonResponse
     * @throws FireflyException
--- a/app/Http/Controllers/Json/RecurrenceController.php
+++ b/app/Http/Controllers/Json/RecurrenceController.php
@@ -143,6 +143,9 @@ class RecurrenceController extends Controller
     * @param Request $request
     *
     * @return JsonResponse
+     * @throws FireflyException
+     * @throws \Psr\Container\ContainerExceptionInterface
+     * @throws \Psr\Container\NotFoundExceptionInterface
     */
    public function suggest(Request $request): JsonResponse
    {
--- a/app/Http/Controllers/PiggyBank/IndexController.php
+++ b/app/Http/Controllers/PiggyBank/IndexController.php
@@ -74,6 +74,8 @@ class IndexController extends Controller
     * @param Request $request
     *
     * @return Factory|View
+     * @throws \FireflyIII\Exceptions\FireflyException
+     * @throws \JsonException
     */
    public function index(Request $request)
    {
--- a/app/Http/Controllers/PreferencesController.php
+++ b/app/Http/Controllers/PreferencesController.php
@@ -66,6 +66,8 @@ class PreferencesController extends Controller
     *
     * @return Factory|View
     * @throws FireflyException
+     * @throws \Psr\Container\ContainerExceptionInterface
+     * @throws \Psr\Container\NotFoundExceptionInterface
     */
    public function index(AccountRepositoryInterface $repository)
    {
@@ -147,6 +149,8 @@ class PreferencesController extends Controller
     *
     * @return RedirectResponse|Redirector
     * @throws FireflyException
+     * @throws \Psr\Container\ContainerExceptionInterface
+     * @throws \Psr\Container\NotFoundExceptionInterface
     */
    public function postIndex(Request $request)
    {
--- a/app/Http/Controllers/ProfileController.php
+++ b/app/Http/Controllers/ProfileController.php
@@ -147,6 +147,8 @@ class ProfileController extends Controller
     * @throws IncompatibleWithGoogleAuthenticatorException
     * @throws InvalidCharactersException
     * @throws SecretKeyTooShortException
+     * @throws \Psr\Container\ContainerExceptionInterface
+     * @throws \Psr\Container\NotFoundExceptionInterface
     */
    public function code(Request $request)
    {
@@ -314,6 +316,8 @@ class ProfileController extends Controller
     *
     * @return Factory|View
     * @throws FireflyException
+     * @throws \Psr\Container\ContainerExceptionInterface
+     * @throws \Psr\Container\NotFoundExceptionInterface
     */
    public function index()
    {
@@ -479,6 +483,8 @@ class ProfileController extends Controller
     *
     * @return RedirectResponse|Redirector
     * @throws FireflyException
+     * @throws \Psr\Container\ContainerExceptionInterface
+     * @throws \Psr\Container\NotFoundExceptionInterface
     */
    public function postCode(TokenFormRequest $request)
    {
@@ -523,6 +529,8 @@ class ProfileController extends Controller
     * @param string $mfaCode
     *
     * @throws FireflyException
+     * @throws \Psr\Container\ContainerExceptionInterface
+     * @throws \Psr\Container\NotFoundExceptionInterface
     */
    private function addToMFAHistory(string $mfaCode): void
    {
--- a/app/Http/Controllers/Recurring/IndexController.php
+++ b/app/Http/Controllers/Recurring/IndexController.php
@@ -75,7 +75,8 @@ class IndexController extends Controller
     *
     * @return Factory|View
     * @throws FireflyException
-     *
+     * @throws \Psr\Container\ContainerExceptionInterface
+     * @throws \Psr\Container\NotFoundExceptionInterface
     */
    public function index(Request $request)
    {
--- a/app/Http/Controllers/Report/AccountController.php
+++ b/app/Http/Controllers/Report/AccountController.php
@@ -45,7 +45,6 @@ class AccountController extends Controller
     * @param Carbon     $end
     *
     * @return mixed|string
-     * @throws JsonException
     */
    public function general(Collection $accounts, Carbon $start, Carbon $end)
    {
--- a/app/Http/Controllers/Report/BillController.php
+++ b/app/Http/Controllers/Report/BillController.php
@@ -43,7 +43,6 @@ class BillController extends Controller
     * @param Carbon     $end
     *
     * @return mixed|string
-     * @throws JsonException
     */
    public function overview(Collection $accounts, Carbon $start, Carbon $end)
    {   // chart properties for cache:
--- a/app/Http/Controllers/Report/OperationsController.php
+++ b/app/Http/Controllers/Report/OperationsController.php
@@ -67,7 +67,6 @@ class OperationsController extends Controller
     * @param Carbon     $end
     *
     * @return mixed|string
-     * @throws JsonException
     */
    public function expenses(Collection $accounts, Carbon $start, Carbon $end)
    {
@@ -103,7 +102,6 @@ class OperationsController extends Controller
     * @param Carbon     $end
     *
     * @return string
-     * @throws JsonException
     */
    public function income(Collection $accounts, Carbon $start, Carbon $end): string
    {
@@ -139,7 +137,6 @@ class OperationsController extends Controller
     * @param Carbon     $end
     *
     * @return mixed|string
-     * @throws JsonException
     */
    public function operations(Collection $accounts, Carbon $start, Carbon $end)
    {
--- a/app/Http/Controllers/ReportController.php
+++ b/app/Http/Controllers/ReportController.php
@@ -262,6 +262,8 @@ class ReportController extends Controller
     *
     * @return Factory|View
     * @throws FireflyException
+     * @throws \Psr\Container\ContainerExceptionInterface
+     * @throws \Psr\Container\NotFoundExceptionInterface
     */
    public function index(AccountRepositoryInterface $repository)
    {
--- a/app/Http/Controllers/Rule/CreateController.php
+++ b/app/Http/Controllers/Rule/CreateController.php
@@ -96,7 +96,7 @@ class CreateController extends Controller
            $operators = $search->getOperators()->toArray();
            if ('' !== $words) {
                session()->flash('warning', trans('firefly.rule_from_search_words', ['string' => $words]));
-                array_push($operators, ['type' => 'description_contains', 'value' => $words]);
+                $operators[] = ['type' => 'description_contains', 'value' => $words];
            }
            $oldTriggers = $this->parseFromOperators($operators);
        }
@@ -236,8 +236,7 @@ class CreateController extends Controller
    }

    /**
-     * @param Rule $rule
-     *
+     * @param Request $request
     * @return JsonResponse
     */
    public function duplicate(Request $request): JsonResponse
--- a/app/Http/Controllers/Rule/EditController.php
+++ b/app/Http/Controllers/Rule/EditController.php
@@ -93,7 +93,7 @@ class EditController extends Controller
            $operators = $search->getOperators()->toArray();
            if ('' !== $words) {
                session()->flash('warning', trans('firefly.rule_from_search_words', ['string' => $words]));
-                array_push($operators, ['type' => 'description_contains', 'value' => $words]);
+                $operators[] = ['type' => 'description_contains', 'value' => $words];
            }
            $oldTriggers = $this->parseFromOperators($operators);
        }
--- a/app/Http/Controllers/TagController.php
+++ b/app/Http/Controllers/TagController.php
@@ -230,6 +230,8 @@ class TagController extends Controller
     *
     * @return Factory|View
     * @throws FireflyException
+     * @throws \Psr\Container\ContainerExceptionInterface
+     * @throws \Psr\Container\NotFoundExceptionInterface
     */
    public function show(Request $request, Tag $tag, Carbon $start = null, Carbon $end = null)
    {
@@ -273,6 +275,8 @@ class TagController extends Controller
     *
     * @return Factory|View
     * @throws FireflyException
+     * @throws \Psr\Container\ContainerExceptionInterface
+     * @throws \Psr\Container\NotFoundExceptionInterface
     */
    public function showAll(Request $request, Tag $tag)
    {
--- a/app/Http/Controllers/Transaction/CreateController.php
+++ b/app/Http/Controllers/Transaction/CreateController.php
@@ -100,6 +100,9 @@ class CreateController extends Controller
     *
     * @return Factory|View
     * @throws FireflyException
+     * @throws \JsonException
+     * @throws \Psr\Container\ContainerExceptionInterface
+     * @throws \Psr\Container\NotFoundExceptionInterface
     */
    public function create(?string $objectType)
    {
--- a/app/Http/Controllers/Transaction/IndexController.php
+++ b/app/Http/Controllers/Transaction/IndexController.php
@@ -73,7 +73,9 @@ class IndexController extends Controller
     * @param Carbon|null $end
     *
     * @return Factory|View
-     * @throws Exception
+     * @throws \FireflyIII\Exceptions\FireflyException
+     * @throws \Psr\Container\ContainerExceptionInterface
+     * @throws \Psr\Container\NotFoundExceptionInterface
     */
    public function index(Request $request, string $objectType, Carbon $start = null, Carbon $end = null)
    {
@@ -130,7 +132,9 @@ class IndexController extends Controller
     * @param string  $objectType
     *
     * @return Factory|View
-     * @throws Exception
+     * @throws \FireflyIII\Exceptions\FireflyException
+     * @throws \Psr\Container\ContainerExceptionInterface
+     * @throws \Psr\Container\NotFoundExceptionInterface
     */
    public function indexAll(Request $request, string $objectType)
    {
--- a/app/Http/Controllers/Transaction/LinkController.php
+++ b/app/Http/Controllers/Transaction/LinkController.php
@@ -153,8 +153,7 @@ class LinkController extends Controller
    /**
     * Switch link from A <> B to B <> A.
     *
-     * @param TransactionJournalLink $link
-     *
+     * @param Request $request
     * @return RedirectResponse|Redirector
     */
    public function switchLink(Request $request)