From 1305fafd380a746c65b61d539a8de5d39eaad0c3 Mon Sep 17 00:00:00 2001
From: James Cole <james@firefly-iii.org>
Date: Fri, 15 Aug 2025 07:50:13 +0200
Subject: [PATCH] Add multi-currency for budget chart

---
 .../V1/Controllers/Chart/BudgetController.php | 60 +++++++++++++++----
 1 file changed, 47 insertions(+), 13 deletions(-)

diff --git a/app/Api/V1/Controllers/Chart/BudgetController.php b/app/Api/V1/Controllers/Chart/BudgetController.php
index 59add4b2af..ae0fca6dab 100644
--- a/app/Api/V1/Controllers/Chart/BudgetController.php
+++ b/app/Api/V1/Controllers/Chart/BudgetController.php
@@ -110,10 +110,12 @@ class BudgetController extends Controller
     private function processBudget(Budget $budget, Carbon $start, Carbon $end): array
     {
         // get all limits:
-        $limits   = $this->blRepository->getBudgetLimits($budget, $start, $end);
-        $rows     = [];
-        $spent    = $this->opsRepository->listExpenses($start, $end, null, new Collection([$budget]));
-        $expenses = $this->processExpenses($budget->id, $spent, $start, $end);
+        $limits     = $this->blRepository->getBudgetLimits($budget, $start, $end);
+        $rows       = [];
+        $spent      = $this->opsRepository->listExpenses($start, $end, null, new Collection([$budget]));
+        $expenses   = $this->processExpenses($budget->id, $spent, $start, $end);
+        $converter  = new ExchangeRateConverter();
+        $currencies = [$this->primaryCurrency->id => $this->primaryCurrency,];
 
         /**
          * @var int $currencyId
@@ -122,6 +124,13 @@ class BudgetController extends Controller
         foreach ($expenses as $currencyId => $row) {
             // budgeted, left and overspent are now 0.
             $limit = $this->filterLimit($currencyId, $limits);
+
+            // primary currency entries
+            $row['pc_budgeted']  = '0';
+            $row['pc_spent']      = '0';
+            $row['pc_left']      = '0';
+            $row['pc_overspent'] = '0';
+
             if (null !== $limit) {
                 $row['budgeted']  = $limit->amount;
                 $row['left']      = bcsub($row['budgeted'], bcmul($row['spent'], '-1'));
@@ -129,6 +138,21 @@ class BudgetController extends Controller
                 $row['left']      = 1 === bccomp($row['left'], '0') ? $row['left'] : '0';
                 $row['overspent'] = 1 === bccomp($row['overspent'], '0') ? $row['overspent'] : '0';
             }
+
+            // convert data if necessary.
+            if (true === $this->convertToPrimary && $currencyId !== $this->primaryCurrency->id) {
+                $currencies[$currencyId] ??= TransactionCurrency::find($currencyId);
+                $row['pc_budgeted']      = $converter->convert($currencies[$currencyId], $this->primaryCurrency, $start, $row['budgeted']);
+                $row['pc_spent']         = $converter->convert($currencies[$currencyId], $this->primaryCurrency, $start, $row['spent']);
+                $row['pc_left']         = $converter->convert($currencies[$currencyId], $this->primaryCurrency, $start, $row['left']);
+                $row['pc_overspent']         = $converter->convert($currencies[$currencyId], $this->primaryCurrency, $start, $row['overspent']);
+            }
+            if (true === $this->convertToPrimary && $currencyId === $this->primaryCurrency->id) {
+                $row['pc_budgeted']      = $row['budgeted'];
+                $row['pc_spent']         = $row['spent'];
+                $row['pc_left']          = $row['left'];
+                $row['pc_overspent']     = $row['overspent'];
+            }
             $rows[] = $row;
         }
 
@@ -145,23 +169,33 @@ class BudgetController extends Controller
             $current  = [
                 'label'                   => $budget->name,
                 'currency_id'             => (string)$row['currency_id'],
-                'currency_code'           => $row['currency_code'],
                 'currency_name'           => $row['currency_name'],
+                'currency_code'           => $row['currency_code'],
                 'currency_decimal_places' => $row['currency_decimal_places'],
-                'period'                  => null,
-                'date'                    => $row['start'],
-                'start_date'              => $row['start'],
-                'end_date'                => $row['end'],
-                'yAxisID'                 => 0,
-                'type'                    => 'bar',
-                'entries'                 => [
+
+                'primary_currency_id'             => (string)$this->primaryCurrency->id,
+                'primary_currency_name'           => $this->primaryCurrency->name,
+                'primary_currency_code'           => $this->primaryCurrency->code,
+                'primary_currency_symbol'         => $this->primaryCurrency->symbol,
+                'primary_currency_decimal_places' => $this->primaryCurrency->decimal_places,
+
+                'period'     => null,
+                'date'       => $row['start'],
+                'start_date' => $row['start'],
+                'end_date'   => $row['end'],
+                'yAxisID'    => 0,
+                'type'       => 'bar',
+                'entries'    => [
                     'budgeted'  => $row['budgeted'],
                     'spent'     => $row['spent'],
                     'left'      => $row['left'],
                     'overspent' => $row['overspent'],
                 ],
                 'pc_entries' => [
-
+                    'budgeted'  => $row['pc_budgeted'],
+                    'spent'     => '0',
+                    'left'      => '0',
+                    'overspent' => '0',
                 ],
             ];
             $return[] = $current;