kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-10-12 15:35:15 +00:00
Code Issues Projects Releases Wiki Activity

Test more rule actions.

Browse Source
This commit is contained in:
James Cole
2020-08-23 09:21:50 +02:00
parent febe60b3d1
commit 139b3ffab4
19 changed files with 184 additions and 276 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
tests/Unit/TransactionRules/Actions/AppendDescriptionTest.php
View File

@@ -45,7 +45,7 @@ class AppendDescriptionTest extends TestCase
/**
* @covers \FireflyIII\TransactionRules\Actions\AppendDescription
*/
public function testActExistingTag(): void
public function testAct(): void
{
/** @var TransactionJournal $journal */
$journal = $this->user()->transactionJournals()->where('description', 'Rule action test transaction.')->first();

3
tests/Unit/TransactionRules/Actions/ConvertToTransferTest.php
View File

@@ -37,9 +37,6 @@ use Tests\TestCase;
/**
*
* Class ConvertToTransferTest
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.TooManyPublicMethods)
*/
class ConvertToTransferTest extends TestCase
{

3
tests/Unit/TransactionRules/Actions/ConvertToWithdrawalTest.php
View File

@@ -38,9 +38,6 @@ use Tests\TestCase;
/**
*
* Class ConvertToWithdrawalTest
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.TooManyPublicMethods)
*/
class ConvertToWithdrawalTest extends TestCase
{

41
tests/Unit/TransactionRules/Actions/PrependDescriptionTest.php
View File

@@ -24,47 +24,40 @@ namespace Tests\Unit\TransactionRules\Actions;
use FireflyIII\Models\RuleAction;
use FireflyIII\Models\TransactionJournal;
use FireflyIII\TransactionRules\Actions\AppendDescription;
use FireflyIII\TransactionRules\Actions\PrependDescription;
use Tests\TestCase;
/**
* Class PrependDescriptionTest
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.TooManyPublicMethods)
*/
class PrependDescriptionTest extends TestCase
{
/**
* Set up test
*/
public function setUp(): void
{
self::markTestIncomplete('Incomplete for refactor.');
return;
}
/**
* @covers \FireflyIII\TransactionRules\Actions\PrependDescription
*/
public function testAct(): void
{
// get journal, give fixed description
$description = 'text' . $this->randomInt();
$prepend = 'prepend' . $this->randomInt();
$journal = $this->getRandomWithdrawal();
$journal->description = $description;
$journal->save();
/** @var TransactionJournal $journal */
$journal = $this->user()->transactionJournals()->where('description', 'Rule action test transaction.')->first();
$original = $journal->description;
$array = [
'transaction_journal_id' => $journal->id,
'description' => $original,
];
// fire the action:
$ruleAction = new RuleAction;
$ruleAction->action_value = $prepend;
$ruleAction->action_value = 'PREPEND';
$action = new PrependDescription($ruleAction);
$result = $action->act($journal);
$result = $action->actOnArray($array);
$this->assertTrue($result);
$journal = TransactionJournal::find($journal->id);
// assert result
$this->assertEquals($prepend . $description, $journal->description);
$journal = TransactionJournal::find($journal->id);
$this->assertEquals(sprintf('%s%s', $ruleAction->action_value, $original), $journal->description);
$journal->description = $original;
$journal->save();
}
}

64
tests/Unit/TransactionRules/Actions/PrependNotesTest.php
View File

@@ -27,74 +27,40 @@ use FireflyIII\Models\RuleAction;
use FireflyIII\Models\TransactionJournal;
use FireflyIII\TransactionRules\Actions\PrependNotes;
use Tests\TestCase;
use DB;
/**
* Class PrependNotesTest
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.TooManyPublicMethods)
* TODO doesnt test if prepends or appends.
*/
class PrependNotesTest extends TestCase
{
/**
* Set up test
*/
public function setUp(): void
{
self::markTestIncomplete('Incomplete for refactor.');
return;
}
/**
* @covers \FireflyIII\TransactionRules\Actions\PrependNotes
*/
public function testAct(): void
{
// give journal some notes.
$journal = $this->getRandomWithdrawal();
$note = $journal->notes()->first();
$start = 'Default note text';
$toPrepend = 'This is prepended';
if (null === $note) {
$note = new Note();
$note->noteable()->associate($journal);
}
$note->text = $start;
$note->save();
$journal = $this->user()->transactionJournals()->where('description','Rule action note test transaction.')->first();
// make sure all notes deleted:
DB::table('notes')->where('noteable_id', $journal->id)->where('noteable_type', TransactionJournal::class)->delete();
// array for action:
$array = [
'transaction_journal_id' => $journal->id
];
$toAppend = 'Text to append to note.';
// fire the action:
$ruleAction = new RuleAction;
$ruleAction->action_value = $toPrepend;
$ruleAction->action_value = $toAppend;
$action = new PrependNotes($ruleAction);
$result = $action->act($journal);
$result = $action->actOnArray($array);
$this->assertTrue($result);
$newNote = $journal->notes()->first();
$this->assertEquals($toPrepend . $start, $newNote->text);
$this->assertEquals($toAppend, $newNote->text);
}
/**
* @covers \FireflyIII\TransactionRules\Actions\PrependNotes
*/
public function testActNewNote(): void
{
// give journal some notes.
$journal = $this->getRandomWithdrawal();
$note = $journal->notes()->first();
if (null !== $note) {
$note->forceDelete();
}
$toPrepend = 'This is appended';
// fire the action:
$ruleAction = new RuleAction;
$ruleAction->action_value = $toPrepend;
$action = new PrependNotes($ruleAction);
$result = $action->act($journal);
$this->assertTrue($result);
$newNote = $journal->notes()->first();
$this->assertEquals($toPrepend, $newNote->text);
}
}

33
tests/Unit/TransactionRules/Actions/RemoveAllTagsTest.php
View File

@@ -22,48 +22,37 @@ declare(strict_types=1);
namespace Tests\Unit\TransactionRules\Actions;
use DB;
use FireflyIII\Models\RuleAction;
use FireflyIII\Models\TransactionJournal;
use FireflyIII\TransactionRules\Actions\RemoveAllTags;
use Tests\TestCase;
/**
* Class RemoveAllTagsTest
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.TooManyPublicMethods)
*/
class RemoveAllTagsTest extends TestCase
{
/**
* Set up test
*/
public function setUp(): void
{
self::markTestIncomplete('Incomplete for refactor.');
return;
}
/**
* @covers \FireflyIII\TransactionRules\Actions\RemoveAllTags
*/
public function testAct(): void
{
// find journal with at least one tag
$journalIds = DB::table('tag_transaction_journal')->get(['transaction_journal_id'])->pluck('transaction_journal_id')->toArray();
$journalId = (int)$journalIds[0];
/** @var TransactionJournal $journal */
$journal = TransactionJournal::find($journalId);
// find journal
$withdrawal = $this->getRandomWithdrawal();
$tag = $this->getRandomTag();
$withdrawal->tags()->sync([$tag->id]);
$array = [
'transaction_journal_id' => $withdrawal->id,
];
// fire the action:
$ruleAction = new RuleAction;
$ruleAction->action_value = null;
$action = new RemoveAllTags($ruleAction);
$result = $action->act($journal);
$result = $action->actOnArray($array);
$this->assertTrue($result);
$this->assertEquals(0, $journal->tags()->count());
$this->assertEquals(0, $withdrawal->tags()->count());
}
}

63
tests/Unit/TransactionRules/Actions/RemoveTagTest.php
View File

@@ -22,74 +22,39 @@ declare(strict_types=1);
namespace Tests\Unit\TransactionRules\Actions;
use DB;
use FireflyIII\Models\RuleAction;
use FireflyIII\Models\TransactionJournal;
use FireflyIII\TransactionRules\Actions\RemoveTag;
use Tests\TestCase;
/**
* Class RemoveTagTest
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.TooManyPublicMethods)
*/
class RemoveTagTest extends TestCase
{
/**
* Set up test
*/
public function setUp(): void
{
self::markTestIncomplete('Incomplete for refactor.');
return;
}
/**
* @covers \FireflyIII\TransactionRules\Actions\RemoveTag
*/
public function testAct(): void
{
{ // find journal
$withdrawal = $this->getRandomWithdrawal();
$tag = $this->getRandomTag();
$withdrawal->tags()->sync([$tag->id]);
$array = [
'transaction_journal_id' => $withdrawal->id,
'user_id' => 1,
];
// find journal with at least one tag
$journalIds = DB::table('tag_transaction_journal')->get(['transaction_journal_id'])->pluck('transaction_journal_id')->toArray();
$journalId = (int)$journalIds[0];
/** @var TransactionJournal $journal */
$journal = TransactionJournal::find($journalId);
$originalCount = $journal->tags()->count();
$firstTag = $journal->tags()->first();
// fire the action:
$ruleAction = new RuleAction;
$ruleAction->action_value = $firstTag->tag;
$ruleAction->action_value = $tag->tag;
$action = new RemoveTag($ruleAction);
$result = $action->act($journal);
$result = $action->actOnArray($array);
$this->assertTrue($result);
foreach ($journal->tags()->get() as $tag) {
$this->assertNotEquals($firstTag->id, $tag->id);
}
$this->assertEquals($originalCount - 1, $journal->tags()->count());
$this->assertEquals(0, $withdrawal->tags()->count());
}
/**
* @covers \FireflyIII\TransactionRules\Actions\RemoveTag
*/
public function testActNoTag(): void
{
// get journal, link al tags:
/** @var TransactionJournal $journal */
$journal = $this->getRandomWithdrawal();
$tags = $journal->user->tags()->get();
$journal->tags()->sync($tags->pluck('id')->toArray());
$this->assertEquals($tags->count(), $journal->tags()->get()->count());
// fire the action:
$ruleAction = new RuleAction;
$ruleAction->action_value = $this->randomInt() . 'nosuchtag';
$action = new RemoveTag($ruleAction);
$result = $action->act($journal);
$this->assertTrue($result);
$this->assertEquals($tags->count(), $journal->tags()->count());
}
}

60
tests/Unit/TransactionRules/Actions/SetBudgetTest.php
View File

@@ -30,21 +30,9 @@ use Tests\TestCase;
/**
* Class SetBudgetTest
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.TooManyPublicMethods)
*/
class SetBudgetTest extends TestCase
{
/**
* Set up test
*/
public function setUp(): void
{
self::markTestIncomplete('Incomplete for refactor.');
return;
}
/**
* @covers \FireflyIII\TransactionRules\Actions\SetBudget
@@ -52,9 +40,15 @@ class SetBudgetTest extends TestCase
public function testAct(): void
{
// get journal, remove all budgets
$journal = $this->getRandomWithdrawal();
$journal = $this->user()->transactionJournals()->where('description','Groceries with no budget')->first();
$budget = $this->getRandomBudget();
$array = [
'user_id' => $this->user()->id,
'transaction_journal_id' => $journal->id,
'transaction_type_type' => $journal->transactionType->type,
];
$journal->budgets()->sync([]);
$this->assertEquals(0, $journal->budgets()->count());
@@ -62,50 +56,12 @@ class SetBudgetTest extends TestCase
$ruleAction = new RuleAction;
$ruleAction->action_value = $budget->name;
$action = new SetBudget($ruleAction);
$result = $action->act($journal);
$result = $action->actOnArray($array);
$this->assertTrue($result);
$this->assertEquals(1, $journal->budgets()->count());
}
/**
* @covers \FireflyIII\TransactionRules\Actions\SetBudget
*/
public function testActNull(): void
{
// get journal, remove all budgets
$journal = $this->getRandomWithdrawal();
$journal->budgets()->sync([]);
$this->assertEquals(0, $journal->budgets()->count());
// fire the action:
$ruleAction = new RuleAction;
$ruleAction->action_value = 'non-existing budget #' . $this->randomInt();
$action = new SetBudget($ruleAction);
$result = $action->act($journal);
$this->assertFalse($result);
$this->assertEquals(0, $journal->budgets()->count());
}
/**
* @covers \FireflyIII\TransactionRules\Actions\SetBudget
*/
public function testActDeposit(): void
{
// get journal, remove all budgets
$journal = $this->getRandomDeposit();
$budget = $this->getRandomBudget();
$journal->budgets()->detach();
$this->assertEquals(0, $journal->budgets()->count());
// fire the action:
$ruleAction = new RuleAction;
$ruleAction->action_value = $budget->name;
$action = new SetBudget($ruleAction);
$result = $action->act($journal);
$this->assertTrue($result);
$this->assertEquals(0, $journal->budgets()->count());
}
}

54
tests/Unit/TransactionRules/Actions/SetCategoryTest.php
View File

@@ -29,70 +29,36 @@ use Tests\TestCase;
/**
* Class SetCategoryTest
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.TooManyPublicMethods)
*/
class SetCategoryTest extends TestCase
{
/**
* Set up test
*/
public function setUp(): void
{
self::markTestIncomplete('Incomplete for refactor.');
return;
}
/**
* @covers \FireflyIII\TransactionRules\Actions\SetCategory
*/
public function testAct(): void
{
// get journal, remove all budgets
$journal = $this->getRandomWithdrawal();
$category = $this->getRandomCategory();
$journal = $this->user()->transactionJournals()->where('description','Groceries with no category')->first();
$category = $this->getRandomCategory();
$factory = $this->mock(CategoryFactory::class);
$factory->shouldReceive('setUser');
$factory->shouldReceive('findOrCreate')->andReturn($category);
$array = [
'user_id' => $this->user()->id,
'transaction_journal_id' => $journal->id,
'transaction_type_type' => $journal->transactionType->type,
];
$journal->categories()->detach();
$journal->budgets()->sync([]);
$this->assertEquals(0, $journal->categories()->count());
// fire the action:
$ruleAction = new RuleAction;
$ruleAction->action_value = $category->name;
$action = new SetCategory($ruleAction);
$result = $action->act($journal);
$result = $action->actOnArray($array);
$this->assertTrue($result);
$this->assertEquals(1, $journal->categories()->count());
}
/**
* @covers \FireflyIII\TransactionRules\Actions\SetCategory
*/
public function testActNull(): void
{
$factory = $this->mock(CategoryFactory::class);
$factory->shouldReceive('setUser');
$factory->shouldReceive('findOrCreate')->andReturnNull();
// get journal, remove all budgets
$journal = $this->getRandomWithdrawal();
$category = $this->getRandomCategory();
$journal->categories()->detach();
$this->assertEquals(0, $journal->categories()->count());
// fire the action:
$ruleAction = new RuleAction;
$ruleAction->action_value = $category->name;
$action = new SetCategory($ruleAction);
$result = $action->act($journal);
$this->assertFalse($result);
$journal->categories()->sync([]);
$this->assertEquals(0, $journal->categories()->count());
}
}

3
tests/Unit/TransactionRules/Actions/SetDescriptionTest.php
View File

@@ -29,9 +29,6 @@ use Tests\TestCase;
/**
* Class SetDescriptionTest
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.TooManyPublicMethods)
*/
class SetDescriptionTest extends TestCase
{

3
tests/Unit/TransactionRules/Actions/SetDestinationAccountTest.php
View File

@@ -35,9 +35,6 @@ use Tests\TestCase;
* Try split journal
*
* Class SetDestinationAccountTest
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.TooManyPublicMethods)
*/
class SetDestinationAccountTest extends TestCase
{

3
tests/Unit/TransactionRules/Actions/SetNotesTest.php
View File

@@ -30,9 +30,6 @@ use Tests\TestCase;
/**
* Class SetNotesTest
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.TooManyPublicMethods)
*/
class SetNotesTest extends TestCase
{

3
tests/Unit/TransactionRules/Actions/SetSourceAccountTest.php
View File

@@ -33,9 +33,6 @@ use Tests\TestCase;
/**
* Class SetSourceAccountTest
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.TooManyPublicMethods)
*/
class SetSourceAccountTest extends TestCase
{