kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-10-12 15:35:15 +00:00
Code Issues Projects Releases Wiki Activity

Code cleanup

Browse Source
This commit is contained in:
James Cole
2018-04-28 06:23:13 +02:00
parent 6f0e1c79ac
commit 13b78bdc20
218 changed files with 621 additions and 681 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/Factory/BudgetFactory.php
View File

@@ -47,7 +47,7 @@ class BudgetFactory
$budgetId = (int)$budgetId;
$budgetName = (string)$budgetName;
if (strlen($budgetName) === 0 && $budgetId === 0) {
if (\strlen($budgetName) === 0 && $budgetId === 0) {
return null;
}
@@ -60,7 +60,7 @@ class BudgetFactory
}
}
if (strlen($budgetName) > 0) {
if (\strlen($budgetName) > 0) {
$budget = $this->findByName($budgetName);
if (null !== $budget) {
return $budget;

4
app/Factory/CategoryFactory.php
View File

@@ -71,7 +71,7 @@ class CategoryFactory
Log::debug(sprintf('Going to find category with ID %d and name "%s"', $categoryId, $categoryName));
if (strlen($categoryName) === 0 && $categoryId === 0) {
if (\strlen($categoryName) === 0 && $categoryId === 0) {
return null;
}
// first by ID:
@@ -83,7 +83,7 @@ class CategoryFactory
}
}
if (strlen($categoryName) > 0) {
if (\strlen($categoryName) > 0) {
$category = $this->findByName($categoryName);
if (null !== $category) {
return $category;

4
app/Factory/PiggyBankFactory.php
View File

@@ -45,7 +45,7 @@ class PiggyBankFactory
{
$piggyBankId = (int)$piggyBankId;
$piggyBankName = (string)$piggyBankName;
if (strlen($piggyBankName) === 0 && $piggyBankId === 0) {
if (\strlen($piggyBankName) === 0 && $piggyBankId === 0) {
return null;
}
// first find by ID:
@@ -58,7 +58,7 @@ class PiggyBankFactory
}
// then find by name:
if (strlen($piggyBankName) > 0) {
if (\strlen($piggyBankName) > 0) {
/** @var PiggyBank $piggyBank */
$piggyBank = $this->findByName($piggyBankName);
if (null !== $piggyBank) {

4
app/Factory/TransactionCurrencyFactory.php
View File

@@ -68,7 +68,7 @@ class TransactionCurrencyFactory
$currencyCode = (string)$currencyCode;
$currencyId = (int)$currencyId;
if (strlen($currencyCode) === 0 && (int)$currencyId === 0) {
if (\strlen($currencyCode) === 0 && (int)$currencyId === 0) {
return null;
}
@@ -80,7 +80,7 @@ class TransactionCurrencyFactory
}
}
// then by code:
if (strlen($currencyCode) > 0) {
if (\strlen($currencyCode) > 0) {
$currency = TransactionCurrency::whereCode($currencyCode)->first();
if (null !== $currency) {
return $currency;