kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-10-12 15:35:15 +00:00
Code Issues Projects Releases Wiki Activity

Code cleanup before release.

Browse Source
This commit is contained in:
James Cole
2018-03-29 19:01:47 +02:00
parent 40266c6821
commit 170d23d768
76 changed files with 181 additions and 171 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/Import/Routine/BunqRoutine.php
View File

@@ -226,8 +226,6 @@ class BunqRoutine implements RoutineInterface
$config['stage'] = 'registered';
$this->setConfig($config);
$this->addStep();
return;
}
/**
@@ -319,6 +317,8 @@ class BunqRoutine implements RoutineInterface
* @param string $expectedType
*
* @return Account
* @throws \FireflyIII\Exceptions\FireflyException
* @throws FireflyException
*/
private function convertToAccount(LabelMonetaryAccount $party, string $expectedType): Account
{

2
app/Import/Routine/FileRoutine.php
View File

@@ -266,8 +266,6 @@ class FileRoutine implements RoutineInterface
private function setExtendedStatus(array $extended): void
{
$this->repository->setExtendedStatus($this->job, $extended);
return;
}
/**

9
app/Import/Routine/SpectreRoutine.php
View File

@@ -343,8 +343,6 @@ class SpectreRoutine implements RoutineInterface
$this->setConfig($config);
$this->setStatus('configuring');
$this->addStep();
return;
}
/**
@@ -468,7 +466,7 @@ class SpectreRoutine implements RoutineInterface
// various meta fields:
$importJournal->setValue(['role' => 'category-name', 'value' => $transaction->getCategory()]);
$importJournal->setValue(['role' => 'note', 'value' => $notes]);
$importJournal->setValue(['role' => 'tags-comma', 'value' => join(',', $tags)]);
$importJournal->setValue(['role' => 'tags-comma', 'value' => implode(',', $tags)]);
$collection->push($importJournal);
}
}
@@ -521,7 +519,6 @@ class SpectreRoutine implements RoutineInterface
$this->setStatus('finished');
$this->addStep();
return;
}
/**
@@ -538,7 +535,7 @@ class SpectreRoutine implements RoutineInterface
/** @var array $accountArray */
foreach ($accounts as $accountArray) {
$account = new Account($accountArray);
$importId = intval($config['accounts-mapped'][$account->getid()] ?? 0);
$importId = intval($config['accounts-mapped'][$account->getId()] ?? 0);
$doImport = 0 !== $importId ? true : false;
if (!$doImport) {
Log::debug(sprintf('Will NOT import from Spectre account #%d ("%s")', $account->getId(), $account->getName()));
@@ -571,7 +568,6 @@ class SpectreRoutine implements RoutineInterface
{
$this->repository->setConfiguration($this->job, $config);
return;
}
/**
@@ -583,7 +579,6 @@ class SpectreRoutine implements RoutineInterface
{
$this->repository->setExtendedStatus($this->job, $extended);
return;
}
/**