Fix issue #637 with cash accounts.

app/Http/Controllers/Transaction/ConvertController.php

@@ -182,6 +182,12 @@ class ConvertController extends Controller
                 break;
             case TransactionType::DEPOSIT . '-' . TransactionType::WITHDRAWAL: // three
             case TransactionType::TRANSFER . '-' . TransactionType::WITHDRAWAL: // five
+                if ($data['destination_account_expense'] === '') {
+                    // destination is a cash account.
+                    $destination = $accountRepository->getCashAccount();
+
+                    return $destination;
+                }
                 $data        = [
                     'name'           => $data['destination_account_expense'],
                     'accountType'    => 'expense',
@@ -221,6 +227,14 @@ class ConvertController extends Controller
                 throw new FireflyException('Cannot handle ' . $joined); // @codeCoverageIgnore
             case TransactionType::WITHDRAWAL . '-' . TransactionType::DEPOSIT: // one
             case TransactionType::TRANSFER . '-' . TransactionType::DEPOSIT: // six
+
+                if ($data['source_account_revenue'] === '') {
+                    // destination is a cash account.
+                    $destination = $accountRepository->getCashAccount();
+
+                    return $destination;
+                }
+
                 $data   = [
                     'name'           => $data['source_account_revenue'],
                     'accountType'    => 'revenue',

app/Repositories/Account/AccountRepository.php

@@ -250,6 +250,19 @@ class AccountRepository implements AccountRepositoryInterface
         return $result;
     }
 
+    /**
+     * @return Account
+     */
+    public function getCashAccount(): Account
+    {
+        $type    = AccountType::where('type', AccountType::CASH)->first();
+        $account = Account::firstOrCreateEncrypted(
+            ['user_id' => $this->user->id, 'account_type_id' => $type->id, 'name' => 'Cash account', 'active' => 1]
+        );
+
+        return $account;
+    }
+
     /**
      * Returns the date of the very last transaction in this account.
      *

app/Repositories/Account/AccountRepositoryInterface.php

@@ -36,6 +36,11 @@ interface AccountRepositoryInterface
      */
     public function count(array $types): int;
 
+    /**
+     * @return Account
+     */
+    public function getCashAccount(): Account;
+
     /**
      * Moved here from account CRUD.
      *

resources/views/transactions/convert.twig

@@ -23,12 +23,23 @@
                         {# in case of withdrawal #}
                         {% if sourceType.type == "Withdrawal" %}
                             {{ ExpandedForm.staticText('source_account_asset', '<a href="'~route('accounts.show',[sourceAccount.id])~'">'~sourceAccount.name~'</a>') }}
-                            {{ ExpandedForm.staticText('destination_account_expense', '<a href="'~route('accounts.show',[destinationAccount.id])~'">'~destinationAccount.name~'</a>') }}
+                            {# if destination is cash, show (cash) #}
+                            {% if destinationAccount.accountType.type == "Cash account" %}
+                                {{ ExpandedForm.staticText('destination_account_expense', '<span class="text-success">(cash)</a>') }}
+                            {% else %}
+                                {{ ExpandedForm.staticText('destination_account_expense', '<a href="'~route('accounts.show',[destinationAccount.id])~'">'~destinationAccount.name~'</a>') }}
+                            {% endif %}
+
                         {% endif %}
 
                         {# in case of deposit #}
                         {% if sourceType.type == "Deposit" %}
-                            {{ ExpandedForm.staticText('source_account_revenue', '<a href="'~route('accounts.show',[sourceAccount.id])~'">'~sourceAccount.name~'</a>') }}
+                            {# if source is cash, show (cash) #}
+                            {% if sourceAccount.accountType.type == "Cash account" %}
+                                {{ ExpandedForm.staticText('source_account_revenue', '<span class="text-success">(cash)</a>') }}
+                            {% else %}
+                                {{ ExpandedForm.staticText('source_account_revenue', '<a href="'~route('accounts.show',[sourceAccount.id])~'">'~sourceAccount.name~'</a>') }}
+                            {% endif %}
                             {{ ExpandedForm.staticText('destination_account_asset', '<a href="'~route('accounts.show',[destinationAccount.id])~'">'~destinationAccount.name~'</a>') }}
                         {% endif %}
 
@@ -55,8 +66,11 @@
                                     {{ 'convert_please_set_revenue_source'|_ }}
                                 </em>
                             </p>
-
+                            {% if destinationAccount.accountType.type == "Cash account" %}
-                            {{ ExpandedForm.text('source_account_revenue', destinationAccount.name) }}
+                                {{ ExpandedForm.text('source_account_revenue', '') }}
+                            {% else %}
+                                {{ ExpandedForm.text('source_account_revenue', destinationAccount.name) }}
+                            {% endif %}
                         {% endif %}
 
                         {# TWO #}
@@ -103,7 +117,11 @@
 
                                 </em>
                             </p>
-                            {{ ExpandedForm.text('destination_account_expense', destinationAccount.name) }}
+                            {% if sourceAccount.accountType.type == "Cash account" %}
+                                {{ ExpandedForm.text('destination_account_expense', '') }}
+                            {% else %}
+                                {{ ExpandedForm.text('destination_account_expense', destinationAccount.name) }}
+                            {% endif %}
 
                         {% endif %}