kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-10-12 15:35:15 +00:00
Code Issues Projects Releases Wiki Activity

Final set of php8.4 changes.

Browse Source
This commit is contained in:
James Cole
2025-05-04 13:50:20 +02:00
parent 51e86448c7
commit 194d22ad90
58 changed files with 151 additions and 157 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
tests/integration/Api/About/AboutControllerTest.php
View File

@@ -40,6 +40,7 @@ final class AboutControllerTest extends TestCase
use RefreshDatabase;
private $user;
#[\Override]
protected function setUp(): void
{
parent::setUp();

5
tests/integration/Api/Autocomplete/BillControllerTest.php
View File

@@ -44,6 +44,7 @@ final class BillControllerTest extends TestCase
*/
use RefreshDatabase;
#[\Override]
protected function createAuthenticatedUser(): User
{
$userGroup = UserGroup::create(['title' => 'Test Group']);
@@ -65,8 +66,8 @@ final class BillControllerTest extends TestCase
'user_id' => $user->id,
'name' => 'Bill '.$i,
'user_group_id' => $user->user_group_id,
'amount_min' => rand(1, 100), // random amount
'amount_max' => rand(101, 200), // random amount
'amount_min' => random_int(1, 100), // random amount
'amount_max' => random_int(101, 200), // random amount
'match' => 'MIGRATED_TO_RULES',
'date' => '2024-01-01',
'repeat_freq' => 'monthly',

1
tests/integration/Api/Autocomplete/BudgetControllerTest.php
View File

@@ -44,6 +44,7 @@ final class BudgetControllerTest extends TestCase
*/
use RefreshDatabase;
#[\Override]
protected function createAuthenticatedUser(): User
{
$userGroup = UserGroup::create(['title' => 'Test Group']);

1
tests/integration/Api/Autocomplete/CategoryControllerTest.php
View File

@@ -44,6 +44,7 @@ final class CategoryControllerTest extends TestCase
*/
use RefreshDatabase;
#[\Override]
protected function createAuthenticatedUser(): User
{
$userGroup = UserGroup::create(['title' => 'Test Group']);

1
tests/integration/Api/Autocomplete/CurrencyControllerTest.php
View File

@@ -44,6 +44,7 @@ final class CurrencyControllerTest extends TestCase
*/
use RefreshDatabase;
#[\Override]
protected function createAuthenticatedUser(): User
{
$userGroup = UserGroup::create(['title' => 'Test Group']);

1
tests/integration/Api/Autocomplete/ObjectGroupControllerTest.php
View File

@@ -44,6 +44,7 @@ final class ObjectGroupControllerTest extends TestCase
*/
use RefreshDatabase;
#[\Override]
protected function createAuthenticatedUser(): User
{
$userGroup = UserGroup::create(['title' => 'Test Group']);

2
tests/integration/Support/Models/BillDateCalculatorTest.php
View File

@@ -37,7 +37,7 @@ use Tests\integration\TestCase;
*/
final class BillDateCalculatorTest extends TestCase
{
private BillDateCalculator $calculator;
private readonly BillDateCalculator $calculator;
public function __construct(string $name)
{

10
tests/unit/Support/Calendar/CalculatorProvider.php
View File

@@ -30,17 +30,11 @@ use Tests\unit\Support\Calendar\Periodicity\IntervalProvider;
readonly class CalculatorProvider
{
public IntervalProvider $intervalProvider;
public string $label;
public Periodicity $periodicity;
public int $skip;
private function __construct(IntervalProvider $intervalProvider, Periodicity $periodicity, int $skip = 0)
private function __construct(public IntervalProvider $intervalProvider, public Periodicity $periodicity, public int $skip = 0)
{
$this->skip = $skip;
$this->intervalProvider = $intervalProvider;
$this->periodicity = $periodicity;
$this->label = "{$periodicity->name} {$intervalProvider->label}";
$this->label = "{$this->periodicity->name} {$this->intervalProvider->label}";
}
public static function providePeriodicityWithSkippedIntervals(): \Generator

8
tests/unit/Support/Calendar/Periodicity/IntervalProvider.php
View File

@@ -28,14 +28,10 @@ use Carbon\Carbon;
readonly class IntervalProvider
{
public Carbon $epoch;
public Carbon $expected;
public string $label;
public function __construct(Carbon $epoch, Carbon $expected)
public function __construct(public Carbon $epoch, public Carbon $expected)
{
$this->epoch = $epoch;
$this->expected = $expected;
$this->label = "given {$epoch->toDateString()} expects {$expected->toDateString()}";
$this->label = "given {$this->epoch->toDateString()} expects {$this->expected->toDateString()}";
}
}

2
tests/unit/Support/NavigationAddPeriodTest.php
View File

@@ -40,7 +40,7 @@ use Tests\integration\TestCase;
*/
final class NavigationAddPeriodTest extends TestCase
{
private Navigation $navigation;
private readonly Navigation $navigation;
public function __construct(string $name)
{

2
tests/unit/Support/NavigationEndOfPeriodTest.php
View File

@@ -39,7 +39,7 @@ use Tests\integration\TestCase;
*/
final class NavigationEndOfPeriodTest extends TestCase
{
private Navigation $navigation;
private readonly Navigation $navigation;
public function __construct(string $name)
{

2
tests/unit/Support/NavigationPreferredCarbonFormatByPeriodTest.php
View File

@@ -38,7 +38,7 @@ use Tests\integration\TestCase;
*/
final class NavigationPreferredCarbonFormatByPeriodTest extends TestCase
{
private Navigation $navigation;
private readonly Navigation $navigation;
public function __construct(string $name)
{

2
tests/unit/Support/NavigationPreferredCarbonFormatTest.php
View File

@@ -39,7 +39,7 @@ use Tests\integration\TestCase;
*/
final class NavigationPreferredCarbonFormatTest extends TestCase
{
private Navigation $navigation;
private readonly Navigation $navigation;
public function __construct(string $name)
{

2
tests/unit/Support/NavigationPreferredEndOfPeriodTest.php
View File

@@ -39,7 +39,7 @@ use Tests\integration\TestCase;
*/
final class NavigationPreferredEndOfPeriodTest extends TestCase
{
private Navigation $navigation;
private readonly Navigation $navigation;
public function __construct(string $name)
{

2
tests/unit/Support/NavigationPreferredRangeFormatTest.php
View File

@@ -39,7 +39,7 @@ use Tests\integration\TestCase;
*/
final class NavigationPreferredRangeFormatTest extends TestCase
{
private Navigation $navigation;
private readonly Navigation $navigation;
public function __construct(string $name)
{

2
tests/unit/Support/NavigationPreferredSqlFormatTest.php
View File

@@ -39,7 +39,7 @@ use Tests\integration\TestCase;
*/
final class NavigationPreferredSqlFormatTest extends TestCase
{
private Navigation $navigation;
private readonly Navigation $navigation;
public function __construct(string $name)
{

2
tests/unit/Support/NavigationStartOfPeriodTest.php
View File

@@ -40,7 +40,7 @@ use Tests\integration\TestCase;
*/
final class NavigationStartOfPeriodTest extends TestCase
{
private Navigation $navigation;
private readonly Navigation $navigation;
public function __construct(string $name)
{