Code cleanup

2025-10-12 15:35:15 +00:00 · 2019-08-17 10:48:28 +02:00
parent c235e42d6c
commit 1974d5f1e3
272 changed files with 818 additions and 7 deletions
--- a/tests/Unit/Console/Commands/Correction/CreateAccessTokensTest.php
+++ b/tests/Unit/Console/Commands/Correction/CreateAccessTokensTest.php
@@ -32,6 +32,9 @@ use Tests\TestCase;

 /**
 * Class CreateAccessTokensTest
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
+ * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+ * @SuppressWarnings(PHPMD.TooManyPublicMethods)
 */
 class CreateAccessTokensTest extends TestCase
 {
--- a/tests/Unit/Console/Commands/Correction/CreateLinkTypesTest.php
+++ b/tests/Unit/Console/Commands/Correction/CreateLinkTypesTest.php
@@ -28,6 +28,9 @@ use Tests\TestCase;

 /**
 * Class CreateLinkTypesTest
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
+ * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+ * @SuppressWarnings(PHPMD.TooManyPublicMethods)
 */
 class CreateLinkTypesTest extends TestCase
 {
--- a/tests/Unit/Console/Commands/Correction/DeleteEmptyGroupsTest.php
+++ b/tests/Unit/Console/Commands/Correction/DeleteEmptyGroupsTest.php
@@ -28,6 +28,9 @@ use Tests\TestCase;

 /**
 * Class DeleteEmptyGroupsTest
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
+ * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+ * @SuppressWarnings(PHPMD.TooManyPublicMethods)
 */
 class DeleteEmptyGroupsTest extends TestCase
 {
--- a/tests/Unit/Console/Commands/Correction/DeleteEmptyJournalsTest.php
+++ b/tests/Unit/Console/Commands/Correction/DeleteEmptyJournalsTest.php
@@ -27,6 +27,13 @@ use FireflyIII\Models\TransactionJournal;
 use Log;
 use Tests\TestCase;

+/**
+ * Class DeleteEmptyJournalsTest
+ *
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
+ * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+ * @SuppressWarnings(PHPMD.TooManyPublicMethods)
+ */
 class DeleteEmptyJournalsTest extends TestCase
 {
    /**
--- a/tests/Unit/Console/Commands/Correction/DeleteOrphanedTransactionsTest.php
+++ b/tests/Unit/Console/Commands/Correction/DeleteOrphanedTransactionsTest.php
@@ -30,6 +30,9 @@ use Tests\TestCase;

 /**
 * Class DeleteOrphanedTransactionsTest
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
+ * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+ * @SuppressWarnings(PHPMD.TooManyPublicMethods)
 */
 class DeleteOrphanedTransactionsTest extends TestCase
 {
--- a/tests/Unit/Console/Commands/Correction/DeleteZeroAmountTest.php
+++ b/tests/Unit/Console/Commands/Correction/DeleteZeroAmountTest.php
@@ -29,6 +29,9 @@ use Tests\TestCase;

 /**
 * Class DeleteZeroAmountTest
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
+ * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+ * @SuppressWarnings(PHPMD.TooManyPublicMethods)
 */
 class DeleteZeroAmountTest extends TestCase
 {
--- a/tests/Unit/Console/Commands/Correction/EnableCurrenciesTest.php
+++ b/tests/Unit/Console/Commands/Correction/EnableCurrenciesTest.php
@@ -29,6 +29,9 @@ use Tests\TestCase;

 /**
 * Class EnableCurrenciesTest
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
+ * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+ * @SuppressWarnings(PHPMD.TooManyPublicMethods)
 */
 class EnableCurrenciesTest extends TestCase
 {
--- a/tests/Unit/Console/Commands/Correction/FixAccountTypesTest.php
+++ b/tests/Unit/Console/Commands/Correction/FixAccountTypesTest.php
@@ -32,6 +32,9 @@ use Tests\TestCase;

 /**
 * Class FixAccountTypesTest
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
+ * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+ * @SuppressWarnings(PHPMD.TooManyPublicMethods)
 */
 class FixAccountTypesTest extends TestCase
 {
--- a/tests/Unit/Console/Commands/Correction/FixPiggiesTest.php
+++ b/tests/Unit/Console/Commands/Correction/FixPiggiesTest.php
@@ -29,6 +29,9 @@ use Tests\TestCase;

 /**
 * Class FixPiggiesTest
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
+ * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+ * @SuppressWarnings(PHPMD.TooManyPublicMethods)
 */
 class FixPiggiesTest extends TestCase
 {
--- a/tests/Unit/Console/Commands/Correction/FixUnevenAmountTest.php
+++ b/tests/Unit/Console/Commands/Correction/FixUnevenAmountTest.php
@@ -30,6 +30,9 @@ use Tests\TestCase;

 /**
 * Class FixUnevenAmountTest
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
+ * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+ * @SuppressWarnings(PHPMD.TooManyPublicMethods)
 */
 class FixUnevenAmountTest extends TestCase
 {
--- a/tests/Unit/Console/Commands/Correction/RemoveBillsTest.php
+++ b/tests/Unit/Console/Commands/Correction/RemoveBillsTest.php
@@ -28,6 +28,9 @@ use Tests\TestCase;

 /**
 * Class RemoveBillsTest
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
+ * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+ * @SuppressWarnings(PHPMD.TooManyPublicMethods)
 */
 class RemoveBillsTest extends TestCase
 {
--- a/tests/Unit/Console/Commands/Correction/RenameMetaFieldsTest.php
+++ b/tests/Unit/Console/Commands/Correction/RenameMetaFieldsTest.php
@@ -28,6 +28,9 @@ use Tests\TestCase;

 /**
 * Class RenameMetaFieldsTest
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
+ * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+ * @SuppressWarnings(PHPMD.TooManyPublicMethods)
 */
 class RenameMetaFieldsTest extends TestCase
 {
--- a/tests/Unit/Console/Commands/Correction/TransferBudgetsTest.php
+++ b/tests/Unit/Console/Commands/Correction/TransferBudgetsTest.php
@@ -27,6 +27,9 @@ use Tests\TestCase;

 /**
 * Class TransferBudgetsTest
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
+ * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+ * @SuppressWarnings(PHPMD.TooManyPublicMethods)
 */
 class TransferBudgetsTest extends TestCase
 {
--- a/tests/Unit/Console/Commands/DecryptDatabaseTest.php
+++ b/tests/Unit/Console/Commands/DecryptDatabaseTest.php
@@ -32,6 +32,9 @@ use Tests\TestCase;

 /**
 * Class DecryptDatabaseTest
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
+ * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+ * @SuppressWarnings(PHPMD.TooManyPublicMethods)
 */
 class DecryptDatabaseTest extends TestCase
 {
--- a/tests/Unit/Console/Commands/Import/CreateCSVImportTest.php
+++ b/tests/Unit/Console/Commands/Import/CreateCSVImportTest.php
@@ -37,6 +37,9 @@ use Tests\TestCase;

 /**
 * Class CreateCSVImportTest
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
+ * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+ * @SuppressWarnings(PHPMD.TooManyPublicMethods)
 */
 class CreateCSVImportTest extends TestCase
 {
--- a/tests/Unit/Console/Commands/Integrity/ReportEmptyObjectsTest.php
+++ b/tests/Unit/Console/Commands/Integrity/ReportEmptyObjectsTest.php
@@ -31,6 +31,9 @@ use Tests\TestCase;

 /**
 * Class ReportEmptyObjectsTest
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
+ * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+ * @SuppressWarnings(PHPMD.TooManyPublicMethods)
 */
 class ReportEmptyObjectsTest extends TestCase
 {
--- a/tests/Unit/Console/Commands/Integrity/ReportSumTest.php
+++ b/tests/Unit/Console/Commands/Integrity/ReportSumTest.php
@@ -30,6 +30,9 @@ use Tests\TestCase;

 /**
 * Class ReportSumTest
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
+ * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+ * @SuppressWarnings(PHPMD.TooManyPublicMethods)
 */
 class ReportSumTest extends TestCase
 {
--- a/tests/Unit/Console/Commands/Tools/ApplyRulesTest.php
+++ b/tests/Unit/Console/Commands/Tools/ApplyRulesTest.php
@@ -38,6 +38,9 @@ use Tests\TestCase;

 /**
 * Class ApplyRulesTest
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
+ * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+ * @SuppressWarnings(PHPMD.TooManyPublicMethods)
 */
 class ApplyRulesTest extends TestCase
 {
--- a/tests/Unit/Console/Commands/Upgrade/AccountCurrenciesTest.php
+++ b/tests/Unit/Console/Commands/Upgrade/AccountCurrenciesTest.php
@@ -38,6 +38,9 @@ use Tests\TestCase;

 /**
 * Class AccountCurrenciesTest
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
+ * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+ * @SuppressWarnings(PHPMD.TooManyPublicMethods)
 */
 class AccountCurrenciesTest extends TestCase
 {
--- a/tests/Unit/Console/Commands/Upgrade/BackToJournalsTest.php
+++ b/tests/Unit/Console/Commands/Upgrade/BackToJournalsTest.php
@@ -32,6 +32,9 @@ use Tests\TestCase;

 /**
 * Class BackToJournalsTest
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
+ * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+ * @SuppressWarnings(PHPMD.TooManyPublicMethods)
 */
 class BackToJournalsTest extends TestCase
 {
--- a/tests/Unit/Console/Commands/Upgrade/BudgetLimitCurrencyTest.php
+++ b/tests/Unit/Console/Commands/Upgrade/BudgetLimitCurrencyTest.php
@@ -31,6 +31,9 @@ use Tests\TestCase;

 /**
 * Class BudgetLimitCurrencyTest
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
+ * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+ * @SuppressWarnings(PHPMD.TooManyPublicMethods)
 */
 class BudgetLimitCurrencyTest extends TestCase
 {
--- a/tests/Unit/Console/Commands/Upgrade/CCLiabilitiesTest.php
+++ b/tests/Unit/Console/Commands/Upgrade/CCLiabilitiesTest.php
@@ -31,6 +31,9 @@ use Tests\TestCase;

 /**
 * Class CCLiabilitiesTest
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
+ * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+ * @SuppressWarnings(PHPMD.TooManyPublicMethods)
 */
 class CCLiabilitiesTest extends TestCase
 {
--- a/tests/Unit/Console/Commands/Upgrade/MigrateAttachmentsTest.php
+++ b/tests/Unit/Console/Commands/Upgrade/MigrateAttachmentsTest.php
@@ -32,6 +32,9 @@ use Tests\TestCase;

 /**
 * Class MigrateAttachmentsTest
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
+ * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+ * @SuppressWarnings(PHPMD.TooManyPublicMethods)
 */
 class MigrateAttachmentsTest extends TestCase
 {
--- a/tests/Unit/Console/Commands/Upgrade/MigrateJournalNotesTest.php
+++ b/tests/Unit/Console/Commands/Upgrade/MigrateJournalNotesTest.php
@@ -30,6 +30,9 @@ use Tests\TestCase;

 /**
 * Class MigrateJournalNotesTest
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
+ * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+ * @SuppressWarnings(PHPMD.TooManyPublicMethods)
 */
 class MigrateJournalNotesTest extends TestCase
 {
--- a/tests/Unit/Console/Commands/Upgrade/MigrateToGroupsTest.php
+++ b/tests/Unit/Console/Commands/Upgrade/MigrateToGroupsTest.php
@@ -38,6 +38,9 @@ use Tests\TestCase;

 /**
 * Class MigrateToGroupsTest
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
+ * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+ * @SuppressWarnings(PHPMD.TooManyPublicMethods)
 */
 class MigrateToGroupsTest extends TestCase
 {
--- a/tests/Unit/Console/Commands/Upgrade/MigrateToRulesTest.php
+++ b/tests/Unit/Console/Commands/Upgrade/MigrateToRulesTest.php
@@ -38,6 +38,9 @@ use Tests\TestCase;

 /**
 * Class MigrateToRulesTest
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
+ * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+ * @SuppressWarnings(PHPMD.TooManyPublicMethods)
 */
 class MigrateToRulesTest extends TestCase
 {
--- a/tests/Unit/Console/Commands/Upgrade/OtherCurrenciesCorrectionsTest.php
+++ b/tests/Unit/Console/Commands/Upgrade/OtherCurrenciesCorrectionsTest.php
@@ -38,6 +38,9 @@ use Tests\TestCase;

 /**
 * Class OtherCurrenciesCorrectionsTest
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
+ * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+ * @SuppressWarnings(PHPMD.TooManyPublicMethods)
 */
 class OtherCurrenciesCorrectionsTest extends TestCase
 {
--- a/tests/Unit/Console/Commands/Upgrade/RenameAccountMetaTest.php
+++ b/tests/Unit/Console/Commands/Upgrade/RenameAccountMetaTest.php
@@ -30,6 +30,9 @@ use Tests\TestCase;

 /**
 * Class RenameAccountMetaTest
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
+ * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+ * @SuppressWarnings(PHPMD.TooManyPublicMethods)
 */
 class RenameAccountMetaTest extends TestCase
 {
--- a/tests/Unit/Console/Commands/Upgrade/TransactionIdentifierTest.php
+++ b/tests/Unit/Console/Commands/Upgrade/TransactionIdentifierTest.php
@@ -34,6 +34,9 @@ use Tests\TestCase;

 /**
 * Class TransactionIdentifierTest
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
+ * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+ * @SuppressWarnings(PHPMD.TooManyPublicMethods)
 */
 class TransactionIdentifierTest extends TestCase
 {
--- a/tests/Unit/Console/Commands/Upgrade/TransferCurrenciesCorrectionsTest.php
+++ b/tests/Unit/Console/Commands/Upgrade/TransferCurrenciesCorrectionsTest.php
@@ -38,6 +38,9 @@ use Tests\TestCase;

 /**
 * Class TransferCurrenciesCorrectionsTest
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
+ * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+ * @SuppressWarnings(PHPMD.TooManyPublicMethods)
 */
 class TransferCurrenciesCorrectionsTest extends TestCase
 {