mirror of
https://github.com/firefly-iii/firefly-iii.git
synced 2025-09-29 18:20:01 +00:00
Improve test coverage, mark as deprecated.
This commit is contained in:
@@ -1,346 +0,0 @@
|
||||
<?php
|
||||
/**
|
||||
* CsvProcessorTest.php
|
||||
* Copyright (c) 2018 thegrumpydictator@gmail.com
|
||||
*
|
||||
* This file is part of Firefly III.
|
||||
*
|
||||
* Firefly III is free software: you can redistribute it and/or modify
|
||||
* it under the terms of the GNU General Public License as published by
|
||||
* the Free Software Foundation, either version 3 of the License, or
|
||||
* (at your option) any later version.
|
||||
*
|
||||
* Firefly III is distributed in the hope that it will be useful,
|
||||
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||||
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||||
* GNU General Public License for more details.
|
||||
*
|
||||
* You should have received a copy of the GNU General Public License
|
||||
* along with Firefly III. If not, see <http://www.gnu.org/licenses/>.
|
||||
*/
|
||||
|
||||
declare(strict_types=1);
|
||||
|
||||
namespace Tests\Unit\Import\FileProcessor;
|
||||
|
||||
use FireflyIII\Import\FileProcessor\CsvProcessor;
|
||||
use FireflyIII\Import\Specifics\AbnAmroDescription;
|
||||
use FireflyIII\Models\ImportJob;
|
||||
use FireflyIII\Repositories\Account\AccountRepositoryInterface;
|
||||
use FireflyIII\Repositories\Bill\BillRepositoryInterface;
|
||||
use FireflyIII\Repositories\Budget\BudgetRepositoryInterface;
|
||||
use FireflyIII\Repositories\Category\CategoryRepositoryInterface;
|
||||
use FireflyIII\Repositories\Currency\CurrencyRepositoryInterface;
|
||||
use FireflyIII\Repositories\ImportJob\ImportJobRepositoryInterface;
|
||||
use Mockery;
|
||||
use Tests\TestCase;
|
||||
|
||||
/**
|
||||
* Class CsvProcessorTest
|
||||
*/
|
||||
class CsvProcessorTest extends TestCase
|
||||
{
|
||||
/**
|
||||
* @covers \FireflyIII\Import\FileProcessor\CsvProcessor::__construct
|
||||
* @covers \FireflyIII\Import\FileProcessor\CsvProcessor::getObjects
|
||||
* @expectedException \FireflyIII\Exceptions\FireflyException
|
||||
* @expectedExceptionMessage Cannot call getObjects() without a job.
|
||||
*/
|
||||
public function testGetObjectsNoJob()
|
||||
{
|
||||
$processor = new CsvProcessor();
|
||||
$processor->getObjects();
|
||||
}
|
||||
|
||||
/**
|
||||
* @covers \FireflyIII\Import\FileProcessor\CsvProcessor::run
|
||||
* @covers \FireflyIII\Import\FileProcessor\CsvProcessor::getImportArray
|
||||
* @covers \FireflyIII\Import\FileProcessor\CsvProcessor::getObjects
|
||||
* @covers \FireflyIII\Import\FileProcessor\CsvProcessor::setJob
|
||||
* @covers \FireflyIII\Import\FileProcessor\CsvProcessor::importRow
|
||||
* @covers \FireflyIII\Import\FileProcessor\CsvProcessor::specifics
|
||||
* @covers \FireflyIII\Import\FileProcessor\CsvProcessor::getRowHash
|
||||
* @covers \FireflyIII\Import\FileProcessor\CsvProcessor::annotateValue
|
||||
* @expectedException \FireflyIII\Exceptions\FireflyException
|
||||
* @expectedExceptionMessage "bad-role" is not a valid role.
|
||||
*/
|
||||
public function testRunBadRole()
|
||||
{
|
||||
$accountRepos = $this->mock(AccountRepositoryInterface::class);
|
||||
$budRepos = $this->mock(BudgetRepositoryInterface::class);
|
||||
$jobRepos = $this->mock(ImportJobRepositoryInterface::class);
|
||||
$catRepos = $this->mock(CategoryRepositoryInterface::class);
|
||||
$billRepos = $this->mock(BillRepositoryInterface::class);
|
||||
$currencyRepos = $this->mock(CurrencyRepositoryInterface::class);
|
||||
|
||||
$accountRepos->shouldReceive('setUser');
|
||||
$budRepos->shouldReceive('setUser');
|
||||
$catRepos->shouldReceive('setUser');
|
||||
$billRepos->shouldReceive('setUser');
|
||||
|
||||
// data
|
||||
$config = [
|
||||
'column-roles' => [
|
||||
0 => 'bad-role',
|
||||
],
|
||||
];
|
||||
$extended = ['steps' => 0, 'done' => 0];
|
||||
$job = $this->getJob($config);
|
||||
$csvFile = '20170101,-12.34,"Some description"';
|
||||
|
||||
// mock stuff
|
||||
|
||||
$jobRepos->shouldReceive('setUser')->withArgs([Mockery::any()])->once();
|
||||
$jobRepos->shouldReceive('getConfiguration')->andReturn($config);
|
||||
$jobRepos->shouldReceive('uploadFileContents')->withArgs([Mockery::any()])->andReturn($csvFile)->once();
|
||||
$jobRepos->shouldReceive('addStepsDone')->twice();
|
||||
|
||||
// mock stuff for this single row:
|
||||
$jobRepos->shouldReceive('countByHash')->once()->withArgs([Mockery::any()])->andReturn(0);
|
||||
|
||||
$processor = new CsvProcessor();
|
||||
$processor->setJob($job);
|
||||
$processor->run();
|
||||
}
|
||||
|
||||
/**
|
||||
* @covers \FireflyIII\Import\FileProcessor\CsvProcessor::run
|
||||
* @covers \FireflyIII\Import\FileProcessor\CsvProcessor::getImportArray
|
||||
* @covers \FireflyIII\Import\FileProcessor\CsvProcessor::getObjects
|
||||
* @covers \FireflyIII\Import\FileProcessor\CsvProcessor::setJob
|
||||
*/
|
||||
public function testRunBasic()
|
||||
{
|
||||
// data
|
||||
$config = [];
|
||||
$job = $this->getJob($config);
|
||||
$csvFile = '';
|
||||
$extended = ['steps' => 0, 'done' => 0];
|
||||
|
||||
// mock stuff
|
||||
$repository = $this->mock(ImportJobRepositoryInterface::class);
|
||||
$repository->shouldReceive('setUser')->withArgs([Mockery::any()])->once();
|
||||
$repository->shouldReceive('getConfiguration')->andReturn($config);
|
||||
$repository->shouldReceive('uploadFileContents')->withArgs([Mockery::any()])->andReturn($csvFile)->once();
|
||||
// $repository->shouldReceive('getExtendedStatus')->once()->andReturn([]);
|
||||
// $repository->shouldReceive('setExtendedStatus')->once()->andReturn($job);
|
||||
$repository->shouldReceive('addStepsDone')->times(3);
|
||||
|
||||
$processor = new CsvProcessor();
|
||||
$processor->setJob($job);
|
||||
$processor->run();
|
||||
|
||||
$objects = $processor->getObjects();
|
||||
$this->assertCount(0, $objects);
|
||||
}
|
||||
|
||||
/**
|
||||
* @covers \FireflyIII\Import\FileProcessor\CsvProcessor::run
|
||||
* @covers \FireflyIII\Import\FileProcessor\CsvProcessor::getImportArray
|
||||
* @covers \FireflyIII\Import\FileProcessor\CsvProcessor::getObjects
|
||||
* @covers \FireflyIII\Import\FileProcessor\CsvProcessor::setJob
|
||||
* @covers \FireflyIII\Import\FileProcessor\CsvProcessor::importRow
|
||||
* @covers \FireflyIII\Import\FileProcessor\CsvProcessor::specifics
|
||||
* @covers \FireflyIII\Import\FileProcessor\CsvProcessor::getRowHash
|
||||
* @covers \FireflyIII\Import\FileProcessor\CsvProcessor::annotateValue
|
||||
* @covers \FireflyIII\Import\FileProcessor\CsvProcessor::rowAlreadyImported
|
||||
*/
|
||||
public function testRunExisting()
|
||||
{
|
||||
// data
|
||||
$config = [];
|
||||
$job = $this->getJob($config);
|
||||
$csvFile = '20170101,-12.34,"Some description"';
|
||||
$extended = ['steps' => 0, 'done' => 0];
|
||||
|
||||
// mock stuff
|
||||
$repository = $this->mock(ImportJobRepositoryInterface::class);
|
||||
$repository->shouldReceive('setUser')->withArgs([Mockery::any()])->once();
|
||||
$repository->shouldReceive('getConfiguration')->andReturn($config);
|
||||
$repository->shouldReceive('uploadFileContents')->withArgs([Mockery::any()])->andReturn($csvFile)->once();
|
||||
// $repository->shouldReceive('getExtendedStatus')->once()->andReturn([]); // twice for update errors.
|
||||
// $repository->shouldReceive('setExtendedStatus')->once()->andReturn($job);
|
||||
//$repository->shouldReceive('addStepsDone')->times(3);
|
||||
|
||||
// mock stuff for this single row:
|
||||
$repository->shouldReceive('countByHash')->once()->withArgs([Mockery::any()])->andReturn(1);
|
||||
$repository->shouldReceive('addStepsDone')->times(3)->withArgs([Mockery::any(), 1]);
|
||||
$repository->shouldReceive('addError')->once()->withArgs([Mockery::any(), 0, 'Row #0 has already been imported.']);
|
||||
$processor = new CsvProcessor();
|
||||
$processor->setJob($job);
|
||||
$processor->run();
|
||||
|
||||
$objects = $processor->getObjects();
|
||||
$this->assertCount(0, $objects);
|
||||
}
|
||||
|
||||
/**
|
||||
* @covers \FireflyIII\Import\FileProcessor\CsvProcessor::run
|
||||
* @covers \FireflyIII\Import\FileProcessor\CsvProcessor::getImportArray
|
||||
* @covers \FireflyIII\Import\FileProcessor\CsvProcessor::getObjects
|
||||
* @covers \FireflyIII\Import\FileProcessor\CsvProcessor::setJob
|
||||
* @covers \FireflyIII\Import\FileProcessor\CsvProcessor::importRow
|
||||
* @covers \FireflyIII\Import\FileProcessor\CsvProcessor::specifics
|
||||
* @covers \FireflyIII\Import\FileProcessor\CsvProcessor::getRowHash
|
||||
* @covers \FireflyIII\Import\FileProcessor\CsvProcessor::annotateValue
|
||||
* @covers \FireflyIII\Import\FileProcessor\CsvProcessor::rowAlreadyImported
|
||||
* @expectedException \FireflyIII\Exceptions\FireflyException
|
||||
* @expectedExceptionMessage "GoodBankDescription" is not a valid class name
|
||||
*/
|
||||
public function testRunInvalidSpecific()
|
||||
{
|
||||
// data
|
||||
$config = [
|
||||
'specifics' => ['GoodBankDescription' => 1],
|
||||
];
|
||||
$job = $this->getJob($config);
|
||||
$csvFile = '20170101,-12.34,descr';
|
||||
$extended = ['steps' => 0, 'done' => 0];
|
||||
|
||||
// mock stuff
|
||||
$repository = $this->mock(ImportJobRepositoryInterface::class);
|
||||
$repository->shouldReceive('setUser')->withArgs([Mockery::any()])->once();
|
||||
$repository->shouldReceive('getConfiguration')->andReturn($config);
|
||||
$repository->shouldReceive('uploadFileContents')->withArgs([Mockery::any()])->andReturn($csvFile)->once();
|
||||
// $repository->shouldReceive('getExtendedStatus')->once()->andReturn([]);
|
||||
// $repository->shouldReceive('setExtendedStatus')->once()->andReturn($job);
|
||||
// mock stuff for this single row:
|
||||
$repository->shouldReceive('countByHash')->once()->withArgs([Mockery::any()])->andReturn(0);
|
||||
$repository->shouldReceive('addStepsDone')->times(2)->withArgs([Mockery::any(), 1]);
|
||||
|
||||
// mock specific:
|
||||
$processor = new CsvProcessor();
|
||||
$processor->setJob($job);
|
||||
$processor->run();
|
||||
}
|
||||
|
||||
/**
|
||||
* @covers \FireflyIII\Import\FileProcessor\CsvProcessor::run
|
||||
* @expectedException \FireflyIII\Exceptions\FireflyException
|
||||
* @expectedExceptionMessage Cannot call run() without a job.
|
||||
*/
|
||||
public function testRunNoJob()
|
||||
{
|
||||
|
||||
$processor = new CsvProcessor();
|
||||
$processor->run();
|
||||
}
|
||||
|
||||
/**
|
||||
* @covers \FireflyIII\Import\FileProcessor\CsvProcessor::run
|
||||
* @covers \FireflyIII\Import\FileProcessor\CsvProcessor::getImportArray
|
||||
* @covers \FireflyIII\Import\FileProcessor\CsvProcessor::getObjects
|
||||
* @covers \FireflyIII\Import\FileProcessor\CsvProcessor::setJob
|
||||
* @covers \FireflyIII\Import\FileProcessor\CsvProcessor::importRow
|
||||
* @covers \FireflyIII\Import\FileProcessor\CsvProcessor::specifics
|
||||
* @covers \FireflyIII\Import\FileProcessor\CsvProcessor::getRowHash
|
||||
* @covers \FireflyIII\Import\FileProcessor\CsvProcessor::annotateValue
|
||||
* @covers \FireflyIII\Import\FileProcessor\CsvProcessor::rowAlreadyImported
|
||||
*/
|
||||
public function testRunSingle()
|
||||
{
|
||||
$accountRepos = $this->mock(AccountRepositoryInterface::class);
|
||||
$budRepos = $this->mock(BudgetRepositoryInterface::class);
|
||||
$jobRepos = $this->mock(ImportJobRepositoryInterface::class);
|
||||
$catRepos = $this->mock(CategoryRepositoryInterface::class);
|
||||
$billRepos = $this->mock(BillRepositoryInterface::class);
|
||||
$currencyRepos = $this->mock(CurrencyRepositoryInterface::class);
|
||||
|
||||
$accountRepos->shouldReceive('setUser');
|
||||
$budRepos->shouldReceive('setUser');
|
||||
$catRepos->shouldReceive('setUser');
|
||||
$billRepos->shouldReceive('setUser');
|
||||
|
||||
// data
|
||||
$config = [];
|
||||
$job = $this->getJob($config);
|
||||
$csvFile = '20170101,-12.34,"Some description"';
|
||||
$extended = ['steps' => 0, 'done' => 0];
|
||||
|
||||
// mock stuff
|
||||
$jobRepos->shouldReceive('setUser')->withArgs([Mockery::any()])->once();
|
||||
$jobRepos->shouldReceive('getConfiguration')->andReturn($config);
|
||||
$jobRepos->shouldReceive('uploadFileContents')->withArgs([Mockery::any()])->andReturn($csvFile)->once();
|
||||
|
||||
// mock stuff for this single row:
|
||||
$jobRepos->shouldReceive('countByHash')->once()->withArgs([Mockery::any()])->andReturn(0);
|
||||
$jobRepos->shouldReceive('addStepsDone')->times(3)->withArgs([Mockery::any(), 1]);
|
||||
$processor = new CsvProcessor();
|
||||
$processor->setJob($job);
|
||||
$processor->run();
|
||||
|
||||
$objects = $processor->getObjects();
|
||||
$this->assertCount(1, $objects);
|
||||
}
|
||||
|
||||
/**
|
||||
* @covers \FireflyIII\Import\FileProcessor\CsvProcessor::run
|
||||
* @covers \FireflyIII\Import\FileProcessor\CsvProcessor::getImportArray
|
||||
* @covers \FireflyIII\Import\FileProcessor\CsvProcessor::getObjects
|
||||
* @covers \FireflyIII\Import\FileProcessor\CsvProcessor::setJob
|
||||
* @covers \FireflyIII\Import\FileProcessor\CsvProcessor::importRow
|
||||
* @covers \FireflyIII\Import\FileProcessor\CsvProcessor::specifics
|
||||
* @covers \FireflyIII\Import\FileProcessor\CsvProcessor::getRowHash
|
||||
* @covers \FireflyIII\Import\FileProcessor\CsvProcessor::annotateValue
|
||||
* @covers \FireflyIII\Import\FileProcessor\CsvProcessor::rowAlreadyImported
|
||||
*/
|
||||
public function testRunSpecific()
|
||||
{
|
||||
$accountRepos = $this->mock(AccountRepositoryInterface::class);
|
||||
$budRepos = $this->mock(BudgetRepositoryInterface::class);
|
||||
$jobRepos = $this->mock(ImportJobRepositoryInterface::class);
|
||||
$catRepos = $this->mock(CategoryRepositoryInterface::class);
|
||||
$billRepos = $this->mock(BillRepositoryInterface::class);
|
||||
$currencyRepos = $this->mock(CurrencyRepositoryInterface::class);
|
||||
|
||||
$accountRepos->shouldReceive('setUser');
|
||||
$budRepos->shouldReceive('setUser');
|
||||
$catRepos->shouldReceive('setUser');
|
||||
$billRepos->shouldReceive('setUser');
|
||||
|
||||
// data
|
||||
$config = [
|
||||
'specifics' => ['AbnAmroDescription' => 1],
|
||||
];
|
||||
$job = $this->getJob($config);
|
||||
$csvFile = '20170101,-12.34,descr';
|
||||
$row = explode(',', $csvFile);
|
||||
$extended = ['steps' => 0, 'done' => 0];
|
||||
|
||||
// mock stuff
|
||||
$jobRepos->shouldReceive('setUser')->withArgs([Mockery::any()])->once();
|
||||
$jobRepos->shouldReceive('getConfiguration')->andReturn($config);
|
||||
$jobRepos->shouldReceive('uploadFileContents')->withArgs([Mockery::any()])->andReturn($csvFile)->once();
|
||||
// mock stuff for this single row:
|
||||
$jobRepos->shouldReceive('countByHash')->once()->withArgs([Mockery::any()])->andReturn(0);
|
||||
$jobRepos->shouldReceive('addStepsDone')->times(3)->withArgs([Mockery::any(), 1]);
|
||||
|
||||
// mock specific:
|
||||
$specific = $this->mock(AbnAmroDescription::class);
|
||||
$specific->shouldReceive('run')->once()->andReturn($row);
|
||||
|
||||
$processor = new CsvProcessor();
|
||||
$processor->setJob($job);
|
||||
$processor->run();
|
||||
|
||||
$objects = $processor->getObjects();
|
||||
$this->assertCount(1, $objects);
|
||||
}
|
||||
|
||||
/**
|
||||
* @param array $config
|
||||
*
|
||||
* @return ImportJob
|
||||
*/
|
||||
protected function getJob(array $config): ImportJob
|
||||
{
|
||||
$job = new ImportJob;
|
||||
$job->file_type = 'file';
|
||||
$job->status = 'new';
|
||||
$job->key = 'x' . random_int(1, 100000);
|
||||
$job->user()->associate($this->user());
|
||||
$job->configuration = $config;
|
||||
|
||||
return $job;
|
||||
}
|
||||
}
|
@@ -24,6 +24,7 @@ declare(strict_types=1);
|
||||
namespace tests\Unit\Import\Specifics;
|
||||
|
||||
|
||||
use FireflyIII\Import\Specifics\RabobankDescription;
|
||||
use Tests\TestCase;
|
||||
|
||||
/**
|
||||
@@ -31,9 +32,44 @@ use Tests\TestCase;
|
||||
*/
|
||||
class RabobankDescriptionTest extends TestCase
|
||||
{
|
||||
/**
|
||||
* Default behaviour
|
||||
* @covers \FireflyIII\Import\Specifics\RabobankDescription
|
||||
*/
|
||||
public function testRunBasic(): void
|
||||
{
|
||||
$this->assertTrue(true);
|
||||
$row = ['','','','','','','','','','',''];
|
||||
|
||||
$parser = new RabobankDescription;
|
||||
$result = $parser->run($row);
|
||||
$this->assertEquals($row, $result);
|
||||
}
|
||||
|
||||
/**
|
||||
* No opposite name or iban
|
||||
* @covers \FireflyIII\Import\Specifics\RabobankDescription
|
||||
*/
|
||||
public function testRunUseDescription(): void
|
||||
{
|
||||
$row = ['','','','','','','','','','','Hello'];
|
||||
|
||||
$parser = new RabobankDescription;
|
||||
$result = $parser->run($row);
|
||||
$this->assertEquals('Hello', $result[6]);
|
||||
$this->assertEquals('', $result[10]);
|
||||
}
|
||||
|
||||
/**
|
||||
* Has opposite name or iban
|
||||
* @covers \FireflyIII\Import\Specifics\RabobankDescription
|
||||
*/
|
||||
public function testRunUseFilledIn(): void
|
||||
{
|
||||
$row = ['','','','','','ABC','','','','',''];
|
||||
|
||||
$parser = new RabobankDescription;
|
||||
$result = $parser->run($row);
|
||||
$this->assertEquals($row, $result);
|
||||
}
|
||||
|
||||
}
|
72
tests/Unit/Import/Specifics/SnsDescriptionTest.php
Normal file
72
tests/Unit/Import/Specifics/SnsDescriptionTest.php
Normal file
@@ -0,0 +1,72 @@
|
||||
<?php
|
||||
/**
|
||||
* SnsDescriptionTest.php
|
||||
* Copyright (c) 2018 thegrumpydictator@gmail.com
|
||||
*
|
||||
* This file is part of Firefly III.
|
||||
*
|
||||
* Firefly III is free software: you can redistribute it and/or modify
|
||||
* it under the terms of the GNU General Public License as published by
|
||||
* the Free Software Foundation, either version 3 of the License, or
|
||||
* (at your option) any later version.
|
||||
*
|
||||
* Firefly III is distributed in the hope that it will be useful,
|
||||
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||||
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||||
* GNU General Public License for more details.
|
||||
*
|
||||
* You should have received a copy of the GNU General Public License
|
||||
* along with Firefly III. If not, see <http://www.gnu.org/licenses/>.
|
||||
*/
|
||||
|
||||
declare(strict_types=1);
|
||||
|
||||
namespace Tests\Unit\Import\Specifics;
|
||||
|
||||
|
||||
use FireflyIII\Import\Specifics\SnsDescription;
|
||||
use Tests\TestCase;
|
||||
|
||||
/**
|
||||
* Class SnsDescriptionTest
|
||||
*/
|
||||
class SnsDescriptionTest extends TestCase
|
||||
{
|
||||
/**
|
||||
* @covers \FireflyIII\Import\Specifics\SnsDescription
|
||||
*/
|
||||
public function testRunBasic(): void
|
||||
{
|
||||
$row = ['a', 'b', 'c'];
|
||||
|
||||
$parser = new SnsDescription;
|
||||
$result = $parser->run($row);
|
||||
$this->assertEquals($row, $result);
|
||||
}
|
||||
|
||||
/**
|
||||
* @covers \FireflyIII\Import\Specifics\SnsDescription
|
||||
*/
|
||||
public function testRunNoQuotes(): void
|
||||
{
|
||||
$row = ['a', 'b', 'c', 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 'Some text'];
|
||||
|
||||
$parser = new SnsDescription;
|
||||
$result = $parser->run($row);
|
||||
$this->assertEquals($row, $result);
|
||||
$this->assertEquals('Some text', $result[17]);
|
||||
}
|
||||
|
||||
/**
|
||||
* @covers \FireflyIII\Import\Specifics\SnsDescription
|
||||
*/
|
||||
public function testRunQuotes(): void
|
||||
{
|
||||
$row = ['a', 'b', 'c', 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, '\'Some text\''];
|
||||
|
||||
$parser = new SnsDescription;
|
||||
$result = $parser->run($row);
|
||||
$this->assertEquals('Some text', $result[17]);
|
||||
}
|
||||
|
||||
}
|
493
tests/Unit/Import/Storage/ImportArrayStorageTest.php
Normal file
493
tests/Unit/Import/Storage/ImportArrayStorageTest.php
Normal file
@@ -0,0 +1,493 @@
|
||||
<?php
|
||||
/**
|
||||
* ImportArrayStorageTest.php
|
||||
* Copyright (c) 2018 thegrumpydictator@gmail.com
|
||||
*
|
||||
* This file is part of Firefly III.
|
||||
*
|
||||
* Firefly III is free software: you can redistribute it and/or modify
|
||||
* it under the terms of the GNU General Public License as published by
|
||||
* the Free Software Foundation, either version 3 of the License, or
|
||||
* (at your option) any later version.
|
||||
*
|
||||
* Firefly III is distributed in the hope that it will be useful,
|
||||
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||||
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||||
* GNU General Public License for more details.
|
||||
*
|
||||
* You should have received a copy of the GNU General Public License
|
||||
* along with Firefly III. If not, see <http://www.gnu.org/licenses/>.
|
||||
*/
|
||||
|
||||
declare(strict_types=1);
|
||||
|
||||
namespace tests\Unit\Import\Storage;
|
||||
|
||||
use Carbon\Carbon;
|
||||
use FireflyIII\Exceptions\FireflyException;
|
||||
use FireflyIII\Helpers\Collector\JournalCollectorInterface;
|
||||
use FireflyIII\Helpers\Filter\InternalTransferFilter;
|
||||
use FireflyIII\Import\Storage\ImportArrayStorage;
|
||||
use FireflyIII\Models\ImportJob;
|
||||
use FireflyIII\Models\Rule;
|
||||
use FireflyIII\Models\TransactionJournalMeta;
|
||||
use FireflyIII\Models\TransactionType;
|
||||
use FireflyIII\Repositories\ImportJob\ImportJobRepositoryInterface;
|
||||
use FireflyIII\Repositories\Journal\JournalRepositoryInterface;
|
||||
use FireflyIII\Repositories\Rule\RuleRepositoryInterface;
|
||||
use FireflyIII\Repositories\Tag\TagRepositoryInterface;
|
||||
use Illuminate\Support\Collection;
|
||||
use Mockery;
|
||||
use Tests\TestCase;
|
||||
|
||||
/**
|
||||
* Class ImportArrayStorageTest
|
||||
*/
|
||||
class ImportArrayStorageTest extends TestCase
|
||||
{
|
||||
|
||||
/**
|
||||
* Very basic storage routine. Doesn't call store()
|
||||
*
|
||||
* @covers \FireflyIII\Import\Storage\ImportArrayStorage
|
||||
*/
|
||||
public function testBasic(): void
|
||||
{
|
||||
// make fake job
|
||||
$job = new ImportJob;
|
||||
$job->user()->associate($this->user());
|
||||
$job->key = 'a_storage' . random_int(1, 1000);
|
||||
$job->status = 'new';
|
||||
$job->stage = 'new';
|
||||
$job->provider = 'fake';
|
||||
$job->file_type = '';
|
||||
$job->configuration = [];
|
||||
$job->transactions = [];
|
||||
$job->save();
|
||||
|
||||
// mock stuff
|
||||
$repository = $this->mock(ImportJobRepositoryInterface::class);
|
||||
$journalRepos = $this->mock(JournalRepositoryInterface::class);
|
||||
|
||||
// mock calls:
|
||||
$repository->shouldReceive('setUser')->once();
|
||||
$journalRepos->shouldReceive('setUser')->once();
|
||||
|
||||
$storage = new ImportArrayStorage;
|
||||
$storage->setJob($job);
|
||||
}
|
||||
|
||||
/**
|
||||
* Two withdrawals, one of which is duplicated.
|
||||
*
|
||||
* @covers \FireflyIII\Import\Storage\ImportArrayStorage
|
||||
*/
|
||||
public function testBasicStoreIsDouble(): void
|
||||
{
|
||||
// make fake job
|
||||
$transactions = [$this->singleWithdrawal(), $this->singleWithdrawal()];
|
||||
$job = new ImportJob;
|
||||
$job->user()->associate($this->user());
|
||||
$job->key = 'a_storage' . random_int(1, 1000);
|
||||
$job->status = 'new';
|
||||
$job->stage = 'new';
|
||||
$job->provider = 'fake';
|
||||
$job->file_type = '';
|
||||
$job->configuration = ['apply-rules' => true];
|
||||
$job->transactions = $transactions;
|
||||
$job->save();
|
||||
|
||||
// get some stuff:
|
||||
$tag = $this->user()->tags()->inRandomOrder()->first();
|
||||
$journal = $this->user()->transactionJournals()->inRandomOrder()->first();
|
||||
$ruleOne = new Rule;
|
||||
$ruleOne->stop_processing = false;
|
||||
$ruleTwo = new Rule;
|
||||
$ruleTwo->stop_processing = true;
|
||||
$meta = new TransactionJournalMeta;
|
||||
$meta->transaction_journal_id = 3;
|
||||
|
||||
// mock stuff
|
||||
$repository = $this->mock(ImportJobRepositoryInterface::class);
|
||||
$collector = $this->mock(JournalCollectorInterface::class);
|
||||
$tagRepos = $this->mock(TagRepositoryInterface::class);
|
||||
$ruleRepos = $this->mock(RuleRepositoryInterface::class);
|
||||
$journalRepos = $this->mock(JournalRepositoryInterface::class);
|
||||
|
||||
// mock calls:
|
||||
$repository->shouldReceive('setUser')->once();
|
||||
$repository->shouldReceive('setStatus')->withAnyArgs();
|
||||
$ruleRepos->shouldReceive('setUser')->once();
|
||||
$tagRepos->shouldReceive('setUser')->once();
|
||||
$tagRepos->shouldReceive('store')->once()->andReturn($tag);
|
||||
$repository->shouldReceive('setTag')->once();
|
||||
$ruleRepos->shouldReceive('getForImport')->andReturn(new Collection([$ruleOne, $ruleTwo]));
|
||||
$journalRepos->shouldReceive('setUser')->once();
|
||||
$journalRepos->shouldReceive('store')->once()->andReturn($journal);
|
||||
$journalRepos->shouldReceive('findByHash')->andReturn(null, $meta)->twice();
|
||||
$repository->shouldReceive('addErrorMessage')->once()
|
||||
->withArgs([Mockery::any(), 'Entry #1 ("' . $transactions[1]['description'] . '") could not be imported. It already exists.']);
|
||||
|
||||
$storage = new ImportArrayStorage;
|
||||
$storage->setJob($job);
|
||||
$result = new Collection;
|
||||
try {
|
||||
$result = $storage->store();
|
||||
} catch (FireflyException $e) {
|
||||
$this->assertTrue(false, $e->getMessage());
|
||||
}
|
||||
$this->assertCount(1, $result);
|
||||
}
|
||||
|
||||
/**
|
||||
* Very basic storage routine. Call store with no data.
|
||||
*
|
||||
* @covers \FireflyIII\Import\Storage\ImportArrayStorage
|
||||
*/
|
||||
public function testBasicStoreNothing(): void
|
||||
{
|
||||
// make fake job
|
||||
$job = new ImportJob;
|
||||
$job->user()->associate($this->user());
|
||||
$job->key = 'a_storage' . random_int(1, 1000);
|
||||
$job->status = 'new';
|
||||
$job->stage = 'new';
|
||||
$job->provider = 'fake';
|
||||
$job->file_type = '';
|
||||
$job->configuration = [];
|
||||
$job->transactions = [];
|
||||
$job->save();
|
||||
|
||||
// mock stuff
|
||||
$repository = $this->mock(ImportJobRepositoryInterface::class);
|
||||
$journalRepos = $this->mock(JournalRepositoryInterface::class);
|
||||
|
||||
// mock calls:
|
||||
$repository->shouldReceive('setUser')->once();
|
||||
$repository->shouldReceive('setStatus')->withAnyArgs();
|
||||
$journalRepos->shouldReceive('setUser')->once();
|
||||
|
||||
$storage = new ImportArrayStorage;
|
||||
$storage->setJob($job);
|
||||
$result = new Collection;
|
||||
try {
|
||||
$result = $storage->store();
|
||||
} catch (FireflyException $e) {
|
||||
$this->assertTrue(false, $e->getMessage());
|
||||
}
|
||||
$this->assertCount(0, $result);
|
||||
}
|
||||
|
||||
/**
|
||||
* Call store with no data, also assume rules.
|
||||
*
|
||||
* @covers \FireflyIII\Import\Storage\ImportArrayStorage
|
||||
*/
|
||||
public function testBasicStoreNothingWithRules(): void
|
||||
{
|
||||
// make fake job
|
||||
$job = new ImportJob;
|
||||
$job->user()->associate($this->user());
|
||||
$job->key = 'a_storage' . random_int(1, 1000);
|
||||
$job->status = 'new';
|
||||
$job->stage = 'new';
|
||||
$job->provider = 'fake';
|
||||
$job->file_type = '';
|
||||
$job->configuration = ['apply-rules' => true];
|
||||
$job->transactions = [];
|
||||
$job->save();
|
||||
|
||||
// mock stuff
|
||||
$repository = $this->mock(ImportJobRepositoryInterface::class);
|
||||
$collector = $this->mock(JournalCollectorInterface::class);
|
||||
$tagRepos = $this->mock(TagRepositoryInterface::class);
|
||||
$ruleRepos = $this->mock(RuleRepositoryInterface::class);
|
||||
$journalRepos = $this->mock(JournalRepositoryInterface::class);
|
||||
|
||||
// mock calls:
|
||||
$repository->shouldReceive('setUser')->once();
|
||||
$repository->shouldReceive('setStatus')->withAnyArgs();
|
||||
$ruleRepos->shouldReceive('setUser')->once();
|
||||
$ruleRepos->shouldReceive('getForImport')->andReturn(new Collection);
|
||||
$journalRepos->shouldReceive('setUser')->once();
|
||||
|
||||
$storage = new ImportArrayStorage;
|
||||
$storage->setJob($job);
|
||||
$result = new Collection;
|
||||
try {
|
||||
$result = $storage->store();
|
||||
} catch (FireflyException $e) {
|
||||
$this->assertTrue(false, $e->getMessage());
|
||||
}
|
||||
$this->assertCount(0, $result);
|
||||
}
|
||||
|
||||
/**
|
||||
* @covers \FireflyIII\Import\Storage\ImportArrayStorage
|
||||
*/
|
||||
public function testBasicStoreSingleWithNoRules(): void
|
||||
{
|
||||
// make fake job
|
||||
$job = new ImportJob;
|
||||
$job->user()->associate($this->user());
|
||||
$job->key = 'a_storage' . random_int(1, 1000);
|
||||
$job->status = 'new';
|
||||
$job->stage = 'new';
|
||||
$job->provider = 'fake';
|
||||
$job->file_type = '';
|
||||
$job->configuration = ['apply-rules' => true];
|
||||
$job->transactions = [$this->singleWithdrawal()];
|
||||
$job->save();
|
||||
|
||||
// get some stuff:
|
||||
$tag = $this->user()->tags()->inRandomOrder()->first();
|
||||
$journal = $this->user()->transactionJournals()->inRandomOrder()->first();
|
||||
|
||||
// mock stuff
|
||||
$repository = $this->mock(ImportJobRepositoryInterface::class);
|
||||
$collector = $this->mock(JournalCollectorInterface::class);
|
||||
$tagRepos = $this->mock(TagRepositoryInterface::class);
|
||||
$ruleRepos = $this->mock(RuleRepositoryInterface::class);
|
||||
$journalRepos = $this->mock(JournalRepositoryInterface::class);
|
||||
|
||||
// mock calls:
|
||||
$repository->shouldReceive('setUser')->once();
|
||||
$repository->shouldReceive('setStatus')->withAnyArgs();
|
||||
$ruleRepos->shouldReceive('setUser')->once();
|
||||
$tagRepos->shouldReceive('setUser')->once();
|
||||
$tagRepos->shouldReceive('store')->once()->andReturn($tag);
|
||||
$repository->shouldReceive('setTag')->once();
|
||||
$ruleRepos->shouldReceive('getForImport')->andReturn(new Collection);
|
||||
$journalRepos->shouldReceive('setUser')->once();
|
||||
$journalRepos->shouldReceive('store')->once()->andReturn($journal);
|
||||
$journalRepos->shouldReceive('findByHash')->andReturn(null)->once();
|
||||
|
||||
$storage = new ImportArrayStorage;
|
||||
$storage->setJob($job);
|
||||
$result = new Collection;
|
||||
try {
|
||||
$result = $storage->store();
|
||||
} catch (FireflyException $e) {
|
||||
$this->assertTrue(false, $e->getMessage());
|
||||
}
|
||||
$this->assertCount(1, $result);
|
||||
}
|
||||
|
||||
/**
|
||||
* @covers \FireflyIII\Import\Storage\ImportArrayStorage
|
||||
*/
|
||||
public function testBasicStoreSingleWithRules(): void
|
||||
{
|
||||
// make fake job
|
||||
$job = new ImportJob;
|
||||
$job->user()->associate($this->user());
|
||||
$job->key = 'a_storage' . random_int(1, 1000);
|
||||
$job->status = 'new';
|
||||
$job->stage = 'new';
|
||||
$job->provider = 'fake';
|
||||
$job->file_type = '';
|
||||
$job->configuration = ['apply-rules' => true];
|
||||
$job->transactions = [$this->singleWithdrawal()];
|
||||
$job->save();
|
||||
|
||||
// get some stuff:
|
||||
$tag = $this->user()->tags()->inRandomOrder()->first();
|
||||
$journal = $this->user()->transactionJournals()->inRandomOrder()->first();
|
||||
$ruleOne = new Rule;
|
||||
$ruleOne->stop_processing = false;
|
||||
$ruleTwo = new Rule;
|
||||
$ruleTwo->stop_processing = true;
|
||||
|
||||
// mock stuff
|
||||
$repository = $this->mock(ImportJobRepositoryInterface::class);
|
||||
$collector = $this->mock(JournalCollectorInterface::class);
|
||||
$tagRepos = $this->mock(TagRepositoryInterface::class);
|
||||
$ruleRepos = $this->mock(RuleRepositoryInterface::class);
|
||||
$journalRepos = $this->mock(JournalRepositoryInterface::class);
|
||||
|
||||
// mock calls:
|
||||
$repository->shouldReceive('setUser')->once();
|
||||
$repository->shouldReceive('setStatus')->withAnyArgs();
|
||||
$ruleRepos->shouldReceive('setUser')->once();
|
||||
$tagRepos->shouldReceive('setUser')->once();
|
||||
$tagRepos->shouldReceive('store')->once()->andReturn($tag);
|
||||
$repository->shouldReceive('setTag')->once();
|
||||
$ruleRepos->shouldReceive('getForImport')->andReturn(new Collection([$ruleOne, $ruleTwo]));
|
||||
$journalRepos->shouldReceive('setUser')->once();
|
||||
$journalRepos->shouldReceive('store')->once()->andReturn($journal);
|
||||
$journalRepos->shouldReceive('findByHash')->andReturn(null)->once();
|
||||
|
||||
$storage = new ImportArrayStorage;
|
||||
$storage->setJob($job);
|
||||
$result = new Collection;
|
||||
try {
|
||||
$result = $storage->store();
|
||||
} catch (FireflyException $e) {
|
||||
$this->assertTrue(false, $e->getMessage());
|
||||
}
|
||||
$this->assertCount(1, $result);
|
||||
}
|
||||
|
||||
/**
|
||||
* @covers \FireflyIII\Import\Storage\ImportArrayStorage
|
||||
*/
|
||||
public function testBasicStoreTransferWithRules(): void
|
||||
{
|
||||
// make fake job
|
||||
$job = new ImportJob;
|
||||
$job->user()->associate($this->user());
|
||||
$job->key = 'a_storage' . random_int(1, 1000);
|
||||
$job->status = 'new';
|
||||
$job->stage = 'new';
|
||||
$job->provider = 'fake';
|
||||
$job->file_type = '';
|
||||
$job->configuration = ['apply-rules' => true];
|
||||
$job->transactions = [$this->singleTransfer(), $this->singleWithdrawal()];
|
||||
$job->save();
|
||||
|
||||
// get a transfer:
|
||||
$transfer = $this->user()->transactionJournals()
|
||||
->inRandomOrder()->where('transaction_type_id', 3)
|
||||
->first();
|
||||
|
||||
// get some stuff:
|
||||
$tag = $this->user()->tags()->inRandomOrder()->first();
|
||||
$journal = $this->user()->transactionJournals()->inRandomOrder()->first();
|
||||
$ruleOne = new Rule;
|
||||
$ruleOne->stop_processing = false;
|
||||
$ruleTwo = new Rule;
|
||||
$ruleTwo->stop_processing = true;
|
||||
|
||||
// mock stuff
|
||||
$repository = $this->mock(ImportJobRepositoryInterface::class);
|
||||
$collector = $this->mock(JournalCollectorInterface::class);
|
||||
$tagRepos = $this->mock(TagRepositoryInterface::class);
|
||||
$ruleRepos = $this->mock(RuleRepositoryInterface::class);
|
||||
$journalRepos = $this->mock(JournalRepositoryInterface::class);
|
||||
|
||||
// mock calls:
|
||||
$repository->shouldReceive('setUser')->once();
|
||||
$repository->shouldReceive('setStatus')->withAnyArgs();
|
||||
$ruleRepos->shouldReceive('setUser')->once();
|
||||
$tagRepos->shouldReceive('setUser')->once();
|
||||
$tagRepos->shouldReceive('store')->once()->andReturn($tag);
|
||||
$repository->shouldReceive('setTag')->once();
|
||||
$ruleRepos->shouldReceive('getForImport')->andReturn(new Collection([$ruleOne, $ruleTwo]));
|
||||
$journalRepos->shouldReceive('setUser')->once();
|
||||
$journalRepos->shouldReceive('store')->twice()->andReturn($journal);
|
||||
$journalRepos->shouldReceive('findByHash')->andReturn(null)->twice();
|
||||
|
||||
// mock collector so it will return some transfers:
|
||||
$collector->shouldReceive('setAllAssetAccounts')->once()->andReturnSelf();
|
||||
$collector->shouldReceive('setTypes')->withArgs([[TransactionType::TRANSFER]])->once()->andReturnSelf();
|
||||
$collector->shouldReceive('withOpposingAccount')->once()->andReturnSelf();
|
||||
$collector->shouldReceive('removeFilter')->withArgs([InternalTransferFilter::class])->once()->andReturnSelf();
|
||||
$collector->shouldReceive('getJournals')->andReturn(new Collection([$transfer]));
|
||||
|
||||
$storage = new ImportArrayStorage;
|
||||
$storage->setJob($job);
|
||||
$result = new Collection;
|
||||
try {
|
||||
$result = $storage->store();
|
||||
} catch (FireflyException $e) {
|
||||
$this->assertTrue(false, $e->getMessage());
|
||||
}
|
||||
$this->assertCount(2, $result);
|
||||
}
|
||||
|
||||
/**
|
||||
* @return array
|
||||
*/
|
||||
private function singleTransfer(): array
|
||||
{
|
||||
return
|
||||
[
|
||||
'type' => 'transfer',
|
||||
'date' => Carbon::create()->format('Y-m-d'),
|
||||
'tags' => '',
|
||||
'user' => $this->user()->id,
|
||||
|
||||
// all custom fields:
|
||||
'internal_reference' => null,
|
||||
'notes' => null,
|
||||
|
||||
// journal data:
|
||||
'description' => 'Some TEST transfer #' . random_int(1, 10000),
|
||||
'piggy_bank_id' => null,
|
||||
'piggy_bank_name' => null,
|
||||
'bill_id' => null,
|
||||
'bill_name' => null,
|
||||
|
||||
// transaction data:
|
||||
'transactions' => [
|
||||
[
|
||||
'currency_id' => null,
|
||||
'currency_code' => 'EUR',
|
||||
'description' => null,
|
||||
'amount' => random_int(500, 5000) / 100,
|
||||
'budget_id' => null,
|
||||
'budget_name' => null,
|
||||
'category_id' => null,
|
||||
'category_name' => null,
|
||||
'source_id' => 1,
|
||||
'source_name' => null,
|
||||
'destination_id' => 2,
|
||||
'destination_name' => null,
|
||||
'foreign_currency_id' => null,
|
||||
'foreign_currency_code' => null,
|
||||
'foreign_amount' => null,
|
||||
'reconciled' => false,
|
||||
'identifier' => 0,
|
||||
],
|
||||
],
|
||||
];
|
||||
}
|
||||
|
||||
/**
|
||||
* @return array
|
||||
*/
|
||||
private function singleWithdrawal(): array
|
||||
{
|
||||
return
|
||||
[
|
||||
'type' => 'withdrawal',
|
||||
'date' => Carbon::create()->format('Y-m-d'),
|
||||
'tags' => '',
|
||||
'user' => $this->user()->id,
|
||||
|
||||
// all custom fields:
|
||||
'internal_reference' => null,
|
||||
'notes' => null,
|
||||
|
||||
// journal data:
|
||||
'description' => 'Some TEST withdrawal #' . random_int(1, 10000),
|
||||
'piggy_bank_id' => null,
|
||||
'piggy_bank_name' => null,
|
||||
'bill_id' => null,
|
||||
'bill_name' => null,
|
||||
|
||||
// transaction data:
|
||||
'transactions' => [
|
||||
[
|
||||
'currency_id' => null,
|
||||
'currency_code' => 'EUR',
|
||||
'description' => null,
|
||||
'amount' => random_int(500, 5000) / 100,
|
||||
'budget_id' => null,
|
||||
'budget_name' => null,
|
||||
'category_id' => null,
|
||||
'category_name' => null,
|
||||
'source_id' => null,
|
||||
'source_name' => 'Checking Account',
|
||||
'destination_id' => null,
|
||||
'destination_name' => 'Random TEST expense account #' . random_int(1, 10000),
|
||||
'foreign_currency_id' => null,
|
||||
'foreign_currency_code' => null,
|
||||
'foreign_amount' => null,
|
||||
'reconciled' => false,
|
||||
'identifier' => 0,
|
||||
],
|
||||
],
|
||||
];
|
||||
}
|
||||
}
|
Reference in New Issue
Block a user