Refactor upgrade and verify commands.

app/Console/Commands/Correction/CorrectDatabase.php

@@ -0,0 +1,81 @@
+<?php
+/**
+ * CorrectDatabase.php
+ * Copyright (c) 2019 thegrumpydictator@gmail.com
+ *
+ * This file is part of Firefly III.
+ *
+ * Firefly III is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * Firefly III is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with Firefly III. If not, see <http://www.gnu.org/licenses/>.
+ */
+
+declare(strict_types=1);
+
+namespace FireflyIII\Console\Commands\Correction;
+
+
+use Artisan;
+use Illuminate\Console\Command;
+use Schema;
+
+/**
+ * Class CorrectDatabase
+ */
+class CorrectDatabase extends Command
+{
+    /**
+     * The console command description.
+     *
+     * @var string
+     */
+    protected $description = 'Will correct the integrity of your database, of necessary.';
+    /**
+     * The name and signature of the console command.
+     *
+     * @var string
+     */
+    protected $signature = 'firefly-iii:correct-database';
+
+    /**
+     * Execute the console command.
+     */
+    public function handle(): int
+    {
+        // if table does not exist, return false
+        if (!Schema::hasTable('users')) {
+            return 1;
+        }
+        $commands = [
+            'firefly-iii:fix-piggies',
+            'firefly-iii:create-link-types',
+            'firefly-iii:create-access-tokens',
+            'firefly-iii:remove-bills',
+            'firefly-iii:enable-currencies',
+            'firefly-iii:fix-transfer-budgets',
+            'firefly-iii:fix-uneven-amount',
+            'firefly-iii:delete-zero-amount',
+            'firefly-iii:delete-orphaned-transactions',
+            'firefly-iii:delete-empty-journals',
+            'firefly-iii:delete-empty-groups',
+            'firefly-iii:fix-account-types',
+        ];
+        foreach ($commands as $command) {
+            $this->line(sprintf('Now executing %s', $command));
+            Artisan::call($command);
+            $result = Artisan::output();
+            echo $result;
+        }
+
+        return 0;
+    }
+}

app/Console/Commands/Correction/CorrectionSkeleton.php.stub

@@ -0,0 +1,57 @@
+<?php
+/**
+ * VerifySkeleton.php
+ * Copyright (c) 2019 thegrumpydictator@gmail.com
+ *
+ * This file is part of Firefly III.
+ *
+ * Firefly III is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * Firefly III is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with Firefly III. If not, see <http://www.gnu.org/licenses/>.
+ */
+
+namespace FireflyIII\Console\Commands\Correction;
+
+use Illuminate\Console\Command;
+
+/**
+ * Class CorrectionSkeleton
+ */
+class CorrectionSkeleton extends Command
+{
+    /**
+     * The console command description.
+     *
+     * @var string
+     */
+    protected $description = 'DESCRIPTION HERE';
+    /**
+     * The name and signature of the console command.
+     *
+     * @var string
+     */
+    protected $signature = 'firefly-iii:CORR_COMMAND';
+
+    /**
+     * Execute the console command.
+     *
+     * @return int
+     */
+    public function handle(): int
+    {
+        //
+        $this->warn('Congrats, you found the skeleton command. Boo!');
+
+
+        return 0;
+    }
+}

app/Console/Commands/Correction/CreateAccessTokens.php

@@ -0,0 +1,72 @@
+<?php
+/**
+ * CreateAccessTokens.php
+ * Copyright (c) 2019 thegrumpydictator@gmail.com
+ *
+ * This file is part of Firefly III.
+ *
+ * Firefly III is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * Firefly III is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with Firefly III. If not, see <http://www.gnu.org/licenses/>.
+ */
+
+namespace FireflyIII\Console\Commands\Correction;
+
+use Exception;
+use FireflyIII\User;
+use Illuminate\Console\Command;
+
+/**
+ * Class CreateAccessTokens
+ */
+class CreateAccessTokens extends Command
+{
+    /**
+     * The console command description.
+     *
+     * @var string
+     */
+    protected $description = 'Creates user access tokens.';
+    /**
+     * The name and signature of the console command.
+     *
+     * @var string
+     */
+    protected $signature = 'firefly-iii:create-access-tokens';
+
+    /**
+     * Execute the console command.
+     *
+     * @return int
+     * @throws Exception
+     */
+    public function handle(): int
+    {
+        $count = 0;
+        $users = User::get();
+        /** @var User $user */
+        foreach ($users as $user) {
+            $pref = app('preferences')->getForUser($user, 'access_token', null);
+            if (null === $pref) {
+                $token = $user->generateAccessToken();
+                app('preferences')->setForUser($user, 'access_token', $token);
+                $this->line(sprintf('Generated access token for user %s', $user->email));
+                ++$count;
+            }
+        }
+        if (0 === $count) {
+            $this->info('All access tokens OK!');
+        }
+
+        return 0;
+    }
+}

app/Console/Commands/Correction/CreateLinkTypes.php

@@ -0,0 +1,79 @@
+<?php
+/**
+ * CreateLinkTypes.php
+ * Copyright (c) 2019 thegrumpydictator@gmail.com
+ *
+ * This file is part of Firefly III.
+ *
+ * Firefly III is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * Firefly III is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with Firefly III. If not, see <http://www.gnu.org/licenses/>.
+ */
+
+namespace FireflyIII\Console\Commands\Correction;
+
+use FireflyIII\Models\LinkType;
+use Illuminate\Console\Command;
+
+/**
+ * Class CreateLinkTypes. Created all link types in case a migration hasn't fired.
+ */
+class CreateLinkTypes extends Command
+{
+    /**
+     * The console command description.
+     *
+     * @var string
+     */
+    protected $description = 'Creates all link types.';
+    /**
+     * The name and signature of the console command.
+     *
+     * @var string
+     */
+    protected $signature = 'firefly-iii:create-link-types';
+
+    /**
+     * Execute the console command.
+     *
+     * @return mixed
+     */
+    public function handle(): int
+    {
+        //
+        $count = 0;
+        $set   = [
+            'Related'       => ['relates to', 'relates to'],
+            'Refund'        => ['(partially) refunds', 'is (partially) refunded by'],
+            'Paid'          => ['(partially) pays for', 'is (partially) paid for by'],
+            'Reimbursement' => ['(partially) reimburses', 'is (partially) reimbursed by'],
+        ];
+        foreach ($set as $name => $values) {
+            $link = LinkType::where('name', $name)->where('outward', $values[0])->where('inward', $values[1])->first();
+            if (null === $link) {
+                $link          = new LinkType;
+                $link->name    = $name;
+                $link->outward = $values[0];
+                $link->inward  = $values[1];
+                ++$count;
+                $this->line(sprintf('Created missing link type "%s"', $name));
+            }
+            $link->editable = false;
+            $link->save();
+        }
+        if (0 === $count) {
+            $this->info('All link types OK!');
+        }
+
+        return 0;
+    }
+}

app/Console/Commands/Correction/DeleteEmptyGroups.php

@@ -0,0 +1,68 @@
+<?php
+/**
+ * DeleteEmptyGroups.php
+ * Copyright (c) 2019 thegrumpydictator@gmail.com
+ *
+ * This file is part of Firefly III.
+ *
+ * Firefly III is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * Firefly III is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with Firefly III. If not, see <http://www.gnu.org/licenses/>.
+ */
+
+namespace FireflyIII\Console\Commands\Correction;
+
+use Exception;
+use FireflyIII\Models\TransactionGroup;
+use FireflyIII\Models\TransactionJournal;
+use Illuminate\Console\Command;
+
+/**
+ * Class DeleteEmptyGroups
+ */
+class DeleteEmptyGroups extends Command
+{
+    /**
+     * The console command description.
+     *
+     * @var string
+     */
+    protected $description = 'Delete empty transaction groups.';
+    /**
+     * The name and signature of the console command.
+     *
+     * @var string
+     */
+    protected $signature = 'firefly-iii:delete-empty-groups';
+
+    /**
+     * Execute the console command.
+     *
+     * @throws Exception;
+     * @return mixed
+     */
+    public function handle(): int
+    {
+        //
+        $groups = array_unique(TransactionJournal::get(['transaction_group_id'])->pluck('transaction_group_id')->toArray());
+        $count  = TransactionGroup::whereNull('deleted_at')->whereNotIn('id', $groups)->count();
+        if (0 === $count) {
+            $this->info('No empty groups.');
+        }
+        if ($count > 0) {
+            $this->info(sprintf('Deleted %d empty groups.', $count));
+            TransactionGroup::whereNull('deleted_at')->whereNotIn('id', $groups)->delete();
+        }
+
+        return 0;
+    }
+}

app/Console/Commands/Correction/DeleteEmptyJournals.php

@@ -0,0 +1,115 @@
+<?php
+/**
+ * DeleteEmptyJournals.php
+ * Copyright (c) 2019 thegrumpydictator@gmail.com
+ *
+ * This file is part of Firefly III.
+ *
+ * Firefly III is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * Firefly III is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with Firefly III. If not, see <http://www.gnu.org/licenses/>.
+ */
+
+namespace FireflyIII\Console\Commands\Correction;
+
+use DB;
+use FireflyIII\Models\Transaction;
+use FireflyIII\Models\TransactionJournal;
+use Illuminate\Console\Command;
+
+/**
+ * Class DeleteEmptyJournals
+ */
+class DeleteEmptyJournals extends Command
+{
+    /**
+     * The console command description.
+     *
+     * @var string
+     */
+    protected $description = 'Delete empty and uneven transaction journals.';
+    /**
+     * The name and signature of the console command.
+     *
+     * @var string
+     */
+    protected $signature = 'firefly-iii:delete-empty-journals';
+
+    /**
+     * Execute the console command.
+     *
+     * @return int
+     */
+    public function handle(): int
+    {
+        $this->deleteUnevenJournals();
+        $this->deleteEmptyJournals();
+
+
+        return 0;
+    }
+
+    private function deleteEmptyJournals(): void
+    {
+
+        $count = 0;
+        $set   = TransactionJournal::leftJoin('transactions', 'transactions.transaction_journal_id', '=', 'transaction_journals.id')
+                                   ->groupBy('transaction_journals.id')
+                                   ->whereNull('transactions.transaction_journal_id')
+                                   ->get(['transaction_journals.id']);
+
+        foreach ($set as $entry) {
+            TransactionJournal::find($entry->id)->delete();
+            $this->info(sprintf('Deleted empty transaction #%d', $entry->id));
+            ++$count;
+        }
+        if (0 === $count) {
+            $this->info('No empty transactions.');
+        }
+    }
+
+    /**
+     * Delete transactions and their journals if they have an uneven number of transactions.
+     */
+    private function deleteUnevenJournals(): void
+    {
+        /**
+         * select count(transactions.transaction_journal_id) as the_count, transactions.transaction_journal_id from transactions
+         *
+         * where transactions.deleted_at is null
+         *
+         * group by transactions.transaction_journal_id
+         * having the_count in ()
+         */
+
+        $set   = Transaction
+            ::whereNull('deleted_at')
+            ->having('the_count', '!=', '2')
+            ->groupBy('transactions.transaction_journal_id')
+            ->get([DB::raw('COUNT(transactions.transaction_journal_id) as the_count'), 'transaction_journal_id']);
+        $total = 0;
+        foreach ($set as $row) {
+            $count = (int)$row->the_count;
+            if (1 === $count % 2) {
+                // uneven number, delete journal and transactions:
+                TransactionJournal::find((int)$row->transaction_journal_id)->delete();
+                Transaction::where('transaction_journal_id', (int)$row->transaction_journal_id)->delete();
+                $this->info(sprintf('Deleted transaction #%d because it had an uneven number of transactions.', $row->transaction_journal_id));
+                $total++;
+            }
+        }
+        if (0 === $total) {
+            $this->info('No uneven transactions.');
+        }
+    }
+
+}

app/Console/Commands/Correction/DeleteOrphanedTransactions.php

@@ -0,0 +1,126 @@
+<?php
+/**
+ * DeleteOrphanedTransactions.php
+ * Copyright (c) 2019 thegrumpydictator@gmail.com
+ *
+ * This file is part of Firefly III.
+ *
+ * Firefly III is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * Firefly III is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with Firefly III. If not, see <http://www.gnu.org/licenses/>.
+ */
+
+namespace FireflyIII\Console\Commands\Correction;
+
+use Exception;
+use FireflyIII\Models\Transaction;
+use FireflyIII\Models\TransactionJournal;
+use Illuminate\Console\Command;
+use stdClass;
+
+/**
+ * Deletes transactions where the journal has been deleted.
+ */
+class DeleteOrphanedTransactions extends Command
+{
+    /**
+     * The console command description.
+     *
+     * @var string
+     */
+    protected $description = 'Deletes orphaned transactions.';
+    /**
+     * The name and signature of the console command.
+     *
+     * @var string
+     */
+    protected $signature = 'firefly-iii:delete-orphaned-transactions';
+
+    /**
+     * Execute the console command.
+     *
+     * @return int
+     * @throws Exception
+     */
+    public function handle(): int
+    {
+        $this->deleteOrphanedTransactions();
+        $this->deleteFromOrphanedAccounts();
+
+
+        return 0;
+    }
+
+    /**
+     *
+     */
+    private function deleteFromOrphanedAccounts(): void
+    {
+        $set
+               = Transaction
+            ::leftJoin('accounts', 'transactions.account_id', '=', 'accounts.id')
+            ->whereNotNull('accounts.deleted_at')
+            ->get(['transactions.*']);
+        $count = 0;
+        /** @var Transaction $transaction */
+        foreach ($set as $transaction) {
+            // delete journals
+            $journal = TransactionJournal::find((int)$transaction->transaction_journal_id);
+            if ($journal) {
+                $journal->delete();
+            }
+            Transaction::where('transaction_journal_id', (int)$transaction->transaction_journal_id)->delete();
+            $this->line(
+                sprintf('Deleted transaction #%d because account #%d was already deleted.', $transaction->transaction_journal_id, $transaction->account_id)
+            );
+            $count++;
+        }
+        if(0===$count) {
+            $this->info('No orphaned accounts.');
+        }
+    }
+
+    /**
+     * @throws Exception
+     */
+    private function deleteOrphanedTransactions(): void
+    {
+        $count = 0;
+        $set   = Transaction
+            ::leftJoin('transaction_journals', 'transactions.transaction_journal_id', '=', 'transaction_journals.id')
+            ->whereNotNull('transaction_journals.deleted_at')
+            ->whereNull('transactions.deleted_at')
+            ->whereNotNull('transactions.id')
+            ->get(
+                [
+                    'transaction_journals.id as journal_id',
+                    'transactions.id as transaction_id',
+                ]
+            );
+        /** @var stdClass $entry */
+        foreach ($set as $entry) {
+            $transaction = Transaction::find((int)$entry->transaction_id);
+            $transaction->delete();
+            $this->info(
+                sprintf(
+                    'Transaction #%d (part of deleted journal #%d) has been deleted as well.',
+                    $entry->transaction_id,
+                    $entry->journal_id
+                )
+            );
+            ++$count;
+        }
+        if (0 === $count) {
+            $this->info('No orphaned transactions.');
+        }
+    }
+}

app/Console/Commands/Correction/DeleteZeroAmount.php

@@ -0,0 +1,71 @@
+<?php
+/**
+ * DeleteZeroAmount.php
+ * Copyright (c) 2019 thegrumpydictator@gmail.com
+ *
+ * This file is part of Firefly III.
+ *
+ * Firefly III is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * Firefly III is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with Firefly III. If not, see <http://www.gnu.org/licenses/>.
+ */
+
+namespace FireflyIII\Console\Commands\Correction;
+
+use FireflyIII\Models\TransactionJournal;
+use FireflyIII\Models\Transaction;
+use Illuminate\Console\Command;
+use Illuminate\Support\Collection;
+use Exception;
+
+/**
+ * Class DeleteZeroAmount
+ */
+class DeleteZeroAmount extends Command
+{
+    /**
+     * The console command description.
+     *
+     * @var string
+     */
+    protected $description = 'Delete transactions with zero amount.';
+    /**
+     * The name and signature of the console command.
+     *
+     * @var string
+     */
+    protected $signature = 'firefly-iii:delete-zero-amount';
+
+    /**
+     * Execute the console command.
+     * @throws Exception
+     * @return int
+     */
+    public function handle(): int
+    {
+        $set = Transaction::where('amount', 0)->get(['transaction_journal_id'])->pluck('transaction_journal_id')->toArray();
+        $set = array_unique($set);
+        /** @var Collection $journals */
+        $journals = TransactionJournal::whereIn('id', $set)->get();
+        /** @var TransactionJournal $journal */
+        foreach ($journals as $journal) {
+            $this->info(sprintf('Deleted transaction #%d because the amount is zero (0.00).', $journal->id));
+            $journal->delete();
+            Transaction::where('transaction_journal_id', $journal->id)->delete();
+        }
+        if (0 === $journals->count()) {
+            $this->info('No zero-amount transactions.');
+        }
+
+        return 0;
+    }
+}

app/Console/Commands/Correction/EnableCurrencies.php

@@ -0,0 +1,96 @@
+<?php
+/**
+ * EnableCurrencies.php
+ * Copyright (c) 2019 thegrumpydictator@gmail.com
+ *
+ * This file is part of Firefly III.
+ *
+ * Firefly III is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * Firefly III is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with Firefly III. If not, see <http://www.gnu.org/licenses/>.
+ */
+
+namespace FireflyIII\Console\Commands\Correction;
+
+use FireflyIII\Models\AccountMeta;
+use FireflyIII\Models\BudgetLimit;
+use FireflyIII\Models\Transaction;
+use FireflyIII\Models\TransactionCurrency;
+use FireflyIII\Models\TransactionJournal;
+use Illuminate\Console\Command;
+use Illuminate\Support\Collection;
+
+/**
+ * Class EnableCurrencies
+ */
+class EnableCurrencies extends Command
+{
+    /**
+     * The console command description.
+     *
+     * @var string
+     */
+    protected $description = 'Enables all currencies in use.';
+    /**
+     * The name and signature of the console command.
+     *
+     * @var string
+     */
+    protected $signature = 'firefly-iii:enable-currencies';
+
+    /**
+     * Execute the console command.
+     *
+     * @return mixed
+     */
+    public function handle(): int
+    {
+        $found = [];
+        // get all meta entries
+        /** @var Collection $meta */
+        $meta = AccountMeta::where('name', 'currency_id')->groupBy('data')->get(['data']);
+        foreach ($meta as $entry) {
+            $found[] = (int)$entry->data;
+        }
+
+        // get all from journals:
+        /** @var Collection $journals */
+        $journals = TransactionJournal::groupBy('transaction_currency_id')->get(['transaction_currency_id']);
+        foreach ($journals as $entry) {
+            $found[] = (int)$entry->transaction_currency_id;
+        }
+
+        // get all from transactions
+        /** @var Collection $transactions */
+        $transactions = Transaction::groupBy('transaction_currency_id')->get(['transaction_currency_id']);
+        foreach ($transactions as $entry) {
+            $found[] = (int)$entry->transaction_currency_id;
+        }
+
+        // get all from budget limits
+        /** @var Collection $limits */
+        $limits = BudgetLimit::groupBy('transaction_currency_id')->get(['transaction_currency_id']);
+        foreach ($limits as $entry) {
+            $found[] = (int)$entry->transaction_currency_id;
+        }
+
+        $found = array_unique($found);
+        $this->info(sprintf('%d different currencies are currently in use.', count($found)));
+        $disabled = TransactionCurrency::whereIn('id', $found)->where('enabled', false)->count();
+        if ($disabled > 0) {
+            $this->info(sprintf('%d were still disabled. This has been corrected.', $disabled));
+        }
+        TransactionCurrency::whereIn('id', $found)->update(['enabled' => true]);
+
+        return 0;
+    }
+}

app/Console/Commands/Correction/FixAccountTypes.php

@@ -0,0 +1,113 @@
+<?php
+/**
+ * FixAccountTypes.php
+ * Copyright (c) 2019 thegrumpydictator@gmail.com
+ *
+ * This file is part of Firefly III.
+ *
+ * Firefly III is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * Firefly III is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with Firefly III. If not, see <http://www.gnu.org/licenses/>.
+ */
+
+namespace FireflyIII\Console\Commands\Correction;
+
+use FireflyIII\Models\Account;
+use FireflyIII\Models\TransactionJournal;
+use Illuminate\Console\Command;
+
+/**
+ * Class FixAccountTypes
+ */
+class FixAccountTypes extends Command
+{
+    /**
+     * The console command description.
+     *
+     * @var string
+     */
+    protected $description = 'Make sure all journals have the correct from/to account types.';
+    /**
+     * The name and signature of the console command.
+     *
+     * @var string
+     */
+    protected $signature = 'firefly-iii:fix-account-types';
+    /** @var array */
+    private $expected;
+
+    /**
+     * Execute the console command.
+     *
+     * @return int
+     */
+    public function handle(): int
+    {
+        $this->expected = config('firefly.source_dests');
+        $journals       = TransactionJournal::get();
+        foreach ($journals as $journal) {
+            $this->inspectJournal($journal);
+        }
+
+        return 0;
+    }
+
+    private function getDestinationAccount(TransactionJournal $journal): Account
+    {
+        return $journal->transactions()->where('amount', '>', 0)->first()->account;
+    }
+
+    /**
+     * @param TransactionJournal $journal
+     *
+     * @return Account
+     */
+    private function getSourceAccount(TransactionJournal $journal): Account
+    {
+        return $journal->transactions()->where('amount', '<', 0)->first()->account;
+    }
+
+    /**
+     * @param TransactionJournal $journal
+     */
+    private function inspectJournal(TransactionJournal $journal): void
+    {
+        $count = $journal->transactions()->count();
+        if (2 !== $count) {
+            $this->info(sprintf('Cannot inspect journal #%d because it does not have 2 transactions, but %d', $journal->id, $count));
+
+            return;
+        }
+        $type                   = $journal->transactionType->type;
+        $sourceAccount          = $this->getSourceAccount($journal);
+        $sourceAccountType      = $sourceAccount->accountType->type;
+        $destinationAccount     = $this->getDestinationAccount($journal);
+        $destinationAccountType = $destinationAccount->accountType->type;
+        if (!isset($this->expected[$type])) {
+            $this->info(sprintf('No source/destination info for transaction type %s.', $type));
+
+            return;
+        }
+        if (!isset($this->expected[$type][$sourceAccountType])) {
+            $this->info(sprintf('The source of %s #%d cannot be of type "%s".', $type, $journal->id, $sourceAccountType));
+            $this->info(sprintf('The destination of %s #%d probably cannot be of type "%s".', $type, $journal->id, $destinationAccountType));
+
+            // TODO think of a way to fix the problem.
+            return;
+        }
+        $expectedTypes = $this->expected[$type][$sourceAccountType];
+        if (!\in_array($destinationAccountType, $expectedTypes, true)) {
+            $this->info(sprintf('The destination of %s #%d cannot be of type "%s".', $type, $journal->id, $destinationAccountType));
+            // TODO think of a way to fix the problem.
+        }
+    }
+}

app/Console/Commands/Correction/FixPiggies.php

@@ -0,0 +1,82 @@
+<?php
+/**
+ * FixPiggies.php
+ * Copyright (c) 2019 thegrumpydictator@gmail.com
+ *
+ * This file is part of Firefly III.
+ *
+ * Firefly III is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * Firefly III is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with Firefly III. If not, see <http://www.gnu.org/licenses/>.
+ */
+
+namespace FireflyIII\Console\Commands\Correction;
+
+use FireflyIII\Models\PiggyBankEvent;
+use FireflyIII\Models\TransactionJournal;
+use FireflyIII\Models\TransactionType;
+use Illuminate\Console\Command;
+
+/**
+ * Report (and fix) piggy banks. Make sure there are only transfers linked to piggy bank events.
+ *
+ * Class FixPiggies
+ */
+class FixPiggies extends Command
+{
+    /**
+     * The console command description.
+     *
+     * @var string
+     */
+    protected $description = 'Fixes common issues with piggy banks.';
+    /**
+     * The name and signature of the console command.
+     *
+     * @var string
+     */
+    protected $signature = 'firefly-iii:fix-piggies';
+
+    /**
+     * Execute the console command.
+     *
+     * @return mixed
+     */
+    public function handle(): int
+    {
+        $set = PiggyBankEvent::with(['PiggyBank', 'TransactionJournal', 'TransactionJournal.TransactionType'])->get();
+        $set->each(
+            function (PiggyBankEvent $event) {
+                if (null === $event->transaction_journal_id) {
+                    return true;
+                }
+                /** @var TransactionJournal $journal */
+                $journal = $event->transactionJournal()->first();
+                if (null === $journal) {
+                    return true;
+                }
+
+                $type = $journal->transactionType->type;
+                if (TransactionType::TRANSFER !== $type) {
+                    $event->transaction_journal_id = null;
+                    $event->save();
+                    $this->line(sprintf('Piggy bank #%d was referenced by an invalid event. This has been fixed.', $event->piggy_bank_id));
+                }
+
+                return true;
+            }
+        );
+        $this->line(sprintf('Verified the content of %d piggy bank events.', $set->count()));
+
+        return 0;
+    }
+}

app/Console/Commands/Correction/FixUnevenAmount.php

@@ -0,0 +1,99 @@
+<?php
+/**
+ * FixUnevenAmount.php
+ * Copyright (c) 2019 thegrumpydictator@gmail.com
+ *
+ * This file is part of Firefly III.
+ *
+ * Firefly III is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * Firefly III is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with Firefly III. If not, see <http://www.gnu.org/licenses/>.
+ */
+
+namespace FireflyIII\Console\Commands\Correction;
+
+use DB;
+use FireflyIII\Models\Transaction;
+use FireflyIII\Models\TransactionJournal;
+use Illuminate\Console\Command;
+use stdClass;
+
+/**
+ * Class FixUnevenAmount
+ */
+class FixUnevenAmount extends Command
+{
+    /**
+     * The console command description.
+     *
+     * @var string
+     */
+    protected $description = 'Fix journals with uneven amounts.';
+    /**
+     * The name and signature of the console command.
+     *
+     * @var string
+     */
+    protected $signature = 'firefly-iii:fix-uneven-amount';
+
+    /**
+     * Execute the console command.
+     *
+     * @return int
+     */
+    public function handle(): int
+    {
+
+        $count = 0;
+        // get invalid journals
+        $journals = DB::table('transactions')
+                      ->groupBy('transaction_journal_id')
+                      ->whereNull('deleted_at')
+                      ->get(['transaction_journal_id', DB::raw('SUM(amount) AS the_sum')]);
+        /** @var stdClass $entry */
+        foreach ($journals as $entry) {
+            if (0 !== bccomp((string)$entry->the_sum, '0')) {
+                $this->fixJournal((int)$entry->transaction_journal_id);
+                $count++;
+            }
+        }
+        if (0 === $count) {
+            $this->info('Amount integrity OK!');
+        }
+
+        return 0;
+    }
+
+    /**
+     * @param int $param
+     */
+    private function fixJournal(int $param): void
+    {
+        // one of the transactions is bad.
+        $journal = TransactionJournal::find($param);
+        if (!$journal) {
+            return;
+        }
+        /** @var Transaction $source */
+        $source = $journal->transactions()->where('amount', '<', 0)->first();
+        $amount = bcmul('-1', (string)$source->amount);
+
+        // fix amount of destination:
+        /** @var Transaction $destination */
+        $destination         = $journal->transactions()->where('amount', '>', 0)->first();
+        $destination->amount = $amount;
+        $destination->save();
+
+        $this->line(sprintf('Corrected amount in transaction #%d', $param));
+
+    }
+}

app/Console/Commands/Correction/RemoveBills.php

@@ -0,0 +1,71 @@
+<?php
+/**
+ * RemoveBills.php
+ * Copyright (c) 2019 thegrumpydictator@gmail.com
+ *
+ * This file is part of Firefly III.
+ *
+ * Firefly III is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * Firefly III is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with Firefly III. If not, see <http://www.gnu.org/licenses/>.
+ */
+
+namespace FireflyIII\Console\Commands\Correction;
+
+use FireflyIII\Models\TransactionJournal;
+use FireflyIII\Models\TransactionType;
+use Illuminate\Console\Command;
+
+/**
+ * Class RemoveBills
+ */
+class RemoveBills extends Command
+{
+    /**
+     * The console command description.
+     *
+     * @var string
+     */
+    protected $description = 'Remove bills from transactions that shouldn\'t have one.';
+    /**
+     * The name and signature of the console command.
+     *
+     * @var string
+     */
+    protected $signature = 'firefly-iii:remove-bills';
+
+    /**
+     * Execute the console command.
+     *
+     * @return mixed
+     */
+    public function handle(): int
+    {
+        /** @var TransactionType $withdrawal */
+        $withdrawal = TransactionType::where('type', TransactionType::WITHDRAWAL)->first();
+        $journals   = TransactionJournal::whereNotNull('bill_id')->where('transaction_type_id', '!=', $withdrawal->id)->get();
+        /** @var TransactionJournal $journal */
+        foreach ($journals as $journal) {
+            $this->line(sprintf('Transaction journal #%d should not be linked to bill #%d.', $journal->id, $journal->bill_id));
+            $journal->bill_id = null;
+            $journal->save();
+        }
+        if (0 === $journals->count()) {
+            $this->info('All transactions have correct bill information.');
+        }
+        if ($journals->count() > 0) {
+            $this->info('Fixed all transactions so they have correct bill information.');
+        }
+
+        return 0;
+    }
+}

app/Console/Commands/Correction/TransferBudgets.php

@@ -0,0 +1,71 @@
+<?php
+/**
+ * TransferBudgets.php
+ * Copyright (c) 2019 thegrumpydictator@gmail.com
+ *
+ * This file is part of Firefly III.
+ *
+ * Firefly III is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * Firefly III is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with Firefly III. If not, see <http://www.gnu.org/licenses/>.
+ */
+
+namespace FireflyIII\Console\Commands\Correction;
+
+use FireflyIII\Models\TransactionJournal;
+use FireflyIII\Models\TransactionType;
+use Illuminate\Console\Command;
+
+/**
+ * Class TransferBudgets
+ */
+class TransferBudgets extends Command
+{
+    /**
+     * The console command description.
+     *
+     * @var string
+     */
+    protected $description = 'Removes budgets from transfers.';
+    /**
+     * The name and signature of the console command.
+     *
+     * @var string
+     */
+    protected $signature = 'firefly-iii:fix-transfer-budgets';
+
+    /**
+     * Execute the console command.
+     *
+     * @return int
+     */
+    public function handle(): int
+    {
+        $set   = TransactionJournal::distinct()
+                                   ->leftJoin('transaction_types', 'transaction_types.id', '=', 'transaction_journals.transaction_type_id')
+                                   ->leftJoin('budget_transaction_journal', 'transaction_journals.id', '=', 'budget_transaction_journal.transaction_journal_id')
+                                   ->whereNotIn('transaction_types.type', [TransactionType::WITHDRAWAL])
+                                   ->whereNotNull('budget_transaction_journal.budget_id')->get(['transaction_journals.*']);
+        $count = 0;
+        /** @var TransactionJournal $entry */
+        foreach ($set as $entry) {
+            $this->info(sprintf('Transaction #%d is a %s, so has no longer a budget.', $entry->id, $entry->transactionType->type));
+            $entry->budgets()->sync([]);
+            $count++;
+        }
+        if (0 === $count) {
+            $this->info('No invalid budget/journal entries.');
+        }
+
+        return 0;
+    }
+}