kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-10-25 21:16:47 +00:00
Code Issues Projects Releases Wiki Activity

Fix all level 2 issues.

Browse Source
This commit is contained in:
James Cole
2023-11-05 09:40:45 +01:00
parent 9002365e6d
commit 1b978d41e0
32 changed files with 53 additions and 56 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/Console/Commands/Correction/DeleteOrphanedTransactions.php
View File

@@ -145,7 +145,7 @@ class DeleteOrphanedTransactions extends Command
foreach ($set as $transaction) {
// delete journals
$journal = TransactionJournal::find((int)$transaction->transaction_journal_id);
if ($journal) {
if (null !== $journal) {
$journal->delete();
}
Transaction::where('transaction_journal_id', (int)$transaction->transaction_journal_id)->delete();

2
app/Console/Commands/Correction/FixUnevenAmount.php
View File

@@ -95,7 +95,7 @@ class FixUnevenAmount extends Command
{
// one of the transactions is bad.
$journal = TransactionJournal::find($param);
if (!$journal) {
if (null === $journal) {
return;
}
/** @var Transaction|null $source */

2
app/Console/Commands/Upgrade/UpgradeLiabilitiesEight.php
View File

@@ -205,7 +205,7 @@ class UpgradeLiabilitiesEight extends Command
$source = $openingJournal->transactions()->where('amount', '<', 0)->first();
/** @var Transaction|null $dest */
$dest = $openingJournal->transactions()->where('amount', '>', 0)->first();
if ($source && $dest) {
if (null !== $source && null !== $dest) {
$sourceId = $source->account_id;
$destId = $dest->account_id;
$dest->account_id = $sourceId;