diff --git a/app/Http/Controllers/Auth/LoginController.php b/app/Http/Controllers/Auth/LoginController.php index df48047cb6..da65e6494a 100644 --- a/app/Http/Controllers/Auth/LoginController.php +++ b/app/Http/Controllers/Auth/LoginController.php @@ -24,7 +24,7 @@ declare(strict_types=1); namespace FireflyIII\Http\Controllers\Auth; use FireflyIII\User; -use Cookie; +use Illuminate\Support\Facades\Cookie; use FireflyIII\Events\ActuallyLoggedIn; use FireflyIII\Events\Security\UnknownUserAttemptedLogin; use FireflyIII\Events\Security\UserAttemptedLogin; @@ -221,7 +221,7 @@ class LoginController extends Controller * * @throws FireflyException */ - public function showLoginForm(Request $request) + public function showLoginForm(?Request $request = null) { Log::channel('audit')->info('Show login form (1.1).'); @@ -247,8 +247,8 @@ class LoginController extends Controller $allowReset = false; } - $email = $request->old('email'); - $remember = $request->old('remember'); + $email = $request?->old('email'); + $remember = $request?->old('remember'); $storeInCookie = config('google2fa.store_in_cookie', false); if (false !== $storeInCookie) { diff --git a/app/Http/Controllers/Auth/RegisterController.php b/app/Http/Controllers/Auth/RegisterController.php index d058c527ae..5d7f731206 100644 --- a/app/Http/Controllers/Auth/RegisterController.php +++ b/app/Http/Controllers/Auth/RegisterController.php @@ -130,7 +130,7 @@ class RegisterController extends Controller $allowRegistration = false; } if ('web' !== $guard) { - $allowRegistration = false; + return false; } return $allowRegistration; @@ -175,7 +175,7 @@ class RegisterController extends Controller * * @throws FireflyException */ - public function showRegistrationForm(Request $request) + public function showRegistrationForm(?Request $request = null) { $isDemoSite = app('fireflyconfig')->get('is_demo_site', config('firefly.configuration.is_demo_site'))->data; $pageTitle = (string) trans('firefly.register_page_title'); @@ -187,7 +187,7 @@ class RegisterController extends Controller return view('error', compact('message')); } - $email = $request->old('email'); + $email = $request?->old('email'); return view('auth.register', compact('isDemoSite', 'email', 'pageTitle')); } diff --git a/app/Http/Requests/CurrencyFormRequest.php b/app/Http/Requests/CurrencyFormRequest.php index b1707e91ce..959678e64c 100644 --- a/app/Http/Requests/CurrencyFormRequest.php +++ b/app/Http/Requests/CurrencyFormRequest.php @@ -70,7 +70,7 @@ class CurrencyFormRequest extends FormRequest $currency = $this->route()->parameter('currency'); if (null !== $currency) { - $rules = [ + return [ 'name' => 'required|max:48|min:1', 'code' => 'required|min:3|max:51', 'symbol' => 'required|min:1|max:51',