kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-10-12 15:35:15 +00:00
Code Issues Projects Releases Wiki Activity

Improve test coverage.

Browse Source
This commit is contained in:
James Cole
2019-07-23 17:33:23 +02:00
parent 1e7e0facf1
commit 226e2f7185
38 changed files with 132 additions and 451 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
tests/Feature/Controllers/Transaction/ConvertControllerTest.php
View File

@@ -179,7 +179,6 @@ class ConvertControllerTest extends TestCase
public function testPostIndexDepositTransfer(): void
{
$this->mockDefaultSession();
$repository = $this->mock(JournalRepositoryInterface::class);
$this->mock(UserRepositoryInterface::class);
$this->mock(AccountRepositoryInterface::class);
$this->mock(RuleGroupRepositoryInterface::class);
@@ -194,7 +193,6 @@ class ConvertControllerTest extends TestCase
$validator->shouldReceive('validateDestination')->atLeast()->once()->andReturn(true);
$repository->shouldReceive('firstNull')->once()->andReturn(new TransactionJournal)->atLeast()->once();
$data = ['source_account_id' => 1];
@@ -210,7 +208,6 @@ class ConvertControllerTest extends TestCase
public function testPostIndexBadSource(): void
{
$this->mockDefaultSession();
$repository = $this->mock(JournalRepositoryInterface::class);
$this->mock(UserRepositoryInterface::class);
$this->mock(AccountRepositoryInterface::class);
$this->mock(RuleGroupRepositoryInterface::class);
@@ -224,7 +221,6 @@ class ConvertControllerTest extends TestCase
$validator->shouldReceive('setTransactionType')->atLeast()->once()->withArgs(['Transfer']);
$validator->shouldReceive('validateSource')->atLeast()->once()->andReturn(false);
$validator->shouldReceive('validateDestination')->atLeast()->once()->andReturn(true);
$repository->shouldReceive('firstNull')->once()->andReturn(new TransactionJournal)->atLeast()->once();
$data = ['source_account_id' => 1];
@@ -241,7 +237,6 @@ class ConvertControllerTest extends TestCase
public function testPostIndexBadDestination(): void
{
$this->mockDefaultSession();
$repository = $this->mock(JournalRepositoryInterface::class);
$this->mock(UserRepositoryInterface::class);
$this->mock(AccountRepositoryInterface::class);
$this->mock(RuleGroupRepositoryInterface::class);
@@ -255,7 +250,6 @@ class ConvertControllerTest extends TestCase
$validator->shouldReceive('setTransactionType')->atLeast()->once()->withArgs(['Transfer']);
$validator->shouldReceive('validateSource')->atLeast()->once()->andReturn(true);
$validator->shouldReceive('validateDestination')->atLeast()->once()->andReturn(false);
$repository->shouldReceive('firstNull')->once()->andReturn(new TransactionJournal)->atLeast()->once();
$data = ['source_account_id' => 1];

2
tests/Feature/Controllers/Transaction/LinkControllerTest.php
View File

@@ -222,7 +222,7 @@ class LinkControllerTest extends TestCase
$repository = $this->mock(LinkTypeRepositoryInterface::class);
$userRepos = $this->mock(UserRepositoryInterface::class);
$journalRepos->shouldReceive('firstNull')->once()->andReturn(new TransactionJournal);
$repository->shouldReceive('switchLink')->andReturn(false);
$this->be($this->user());
$response = $this->get(route('transactions.link.switch', [$link->id]));