diff --git a/app/Http/Controllers/Account/EditController.php b/app/Http/Controllers/Account/EditController.php index 923d95e786..62ca47453c 100644 --- a/app/Http/Controllers/Account/EditController.php +++ b/app/Http/Controllers/Account/EditController.php @@ -75,8 +75,6 @@ class EditController extends Controller * * @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View * - * @SuppressWarnings(PHPMD.CyclomaticComplexity) - * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ public function edit(Request $request, Account $account, AccountRepositoryInterface $repository) { diff --git a/app/Http/Controllers/Account/ShowController.php b/app/Http/Controllers/Account/ShowController.php index 0f6fd1cf8a..1413258a59 100644 --- a/app/Http/Controllers/Account/ShowController.php +++ b/app/Http/Controllers/Account/ShowController.php @@ -39,7 +39,7 @@ use View; /** * Class ShowController * - * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + * */ class ShowController extends Controller { @@ -138,8 +138,6 @@ class ShowController extends Controller * @param Request $request * @param Account $account * @return \Illuminate\Http\RedirectResponse|\Illuminate\Routing\Redirector|View - * - * * @throws Exception */ public function showAll(Request $request, Account $account) diff --git a/app/Http/Controllers/BillController.php b/app/Http/Controllers/BillController.php index 7c002a23a3..5f739eae42 100644 --- a/app/Http/Controllers/BillController.php +++ b/app/Http/Controllers/BillController.php @@ -43,7 +43,7 @@ use Symfony\Component\HttpFoundation\ParameterBag; /** * Class BillController. * - * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + * */ class BillController extends Controller { @@ -339,8 +339,6 @@ class BillController extends Controller * * @return RedirectResponse * - * @SuppressWarnings(PHPMD.CyclomaticComplexity) - * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ public function store(BillFormRequest $request): RedirectResponse { diff --git a/app/Http/Controllers/Budget/AmountController.php b/app/Http/Controllers/Budget/AmountController.php index 5fc6194a91..2f17a2baae 100644 --- a/app/Http/Controllers/Budget/AmountController.php +++ b/app/Http/Controllers/Budget/AmountController.php @@ -25,18 +25,15 @@ namespace FireflyIII\Http\Controllers\Budget; use Carbon\Carbon; -use FireflyIII\Helpers\Collector\GroupCollectorInterface; use FireflyIII\Http\Controllers\Controller; use FireflyIII\Http\Requests\BudgetIncomeRequest; use FireflyIII\Models\Budget; -use FireflyIII\Models\TransactionType; use FireflyIII\Repositories\Budget\BudgetRepositoryInterface; use FireflyIII\Support\Http\Controllers\DateCalculation; use Illuminate\Http\JsonResponse; use Illuminate\Http\RedirectResponse; use Illuminate\Http\Request; use Illuminate\Support\Collection; -use Log; /** * Class AmountController @@ -75,8 +72,6 @@ class AmountController extends Controller * @param Budget $budget * * @return JsonResponse - * - * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ public function amount(Request $request, Budget $budget): JsonResponse { diff --git a/app/Http/Controllers/Budget/IndexController.php b/app/Http/Controllers/Budget/IndexController.php index 6c52b522bd..77dcb37d1d 100644 --- a/app/Http/Controllers/Budget/IndexController.php +++ b/app/Http/Controllers/Budget/IndexController.php @@ -74,8 +74,6 @@ class IndexController extends Controller * @param Carbon|null $end * * @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View - * - * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ public function index(Request $request, Carbon $start = null, Carbon $end = null) { diff --git a/app/Http/Controllers/Category/ShowController.php b/app/Http/Controllers/Category/ShowController.php index 92e55db290..2e27a8c2eb 100644 --- a/app/Http/Controllers/Category/ShowController.php +++ b/app/Http/Controllers/Category/ShowController.php @@ -31,13 +31,12 @@ use FireflyIII\Repositories\Category\CategoryRepositoryInterface; use FireflyIII\Support\Http\Controllers\PeriodOverview; use Illuminate\Http\Request; use Illuminate\Support\Collection; -use Log; /** * * Class ShowController * - * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + * */ class ShowController extends Controller { diff --git a/app/Http/Controllers/Chart/AccountController.php b/app/Http/Controllers/Chart/AccountController.php index 80987ec48f..ecac9a7c21 100644 --- a/app/Http/Controllers/Chart/AccountController.php +++ b/app/Http/Controllers/Chart/AccountController.php @@ -43,9 +43,9 @@ use Log; /** * Class AccountController. * - * @SuppressWarnings(PHPMD.TooManyPublicMethods) - * @SuppressWarnings(PHPMD.ExcessiveClassComplexity) - * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + * + * + * */ class AccountController extends Controller { @@ -436,8 +436,6 @@ class AccountController extends Controller * @param Carbon $end * * @return JsonResponse - * @SuppressWarnings(PHPMD.CyclomaticComplexity) - * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ public function period(Account $account, Carbon $start, Carbon $end): JsonResponse { diff --git a/app/Http/Controllers/Chart/BudgetController.php b/app/Http/Controllers/Chart/BudgetController.php index 96c9822c9a..bd0dc63791 100644 --- a/app/Http/Controllers/Chart/BudgetController.php +++ b/app/Http/Controllers/Chart/BudgetController.php @@ -40,8 +40,8 @@ use Illuminate\Support\Collection; /** * Class BudgetController. * - * @SuppressWarnings(PHPMD.ExcessiveClassComplexity) - * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + * + * * */ class BudgetController extends Controller @@ -181,8 +181,6 @@ class BudgetController extends Controller * @param BudgetLimit|null $budgetLimit * * @return JsonResponse - * - * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function expenseAsset(Budget $budget, ?BudgetLimit $budgetLimit): JsonResponse { @@ -232,8 +230,6 @@ class BudgetController extends Controller * @param BudgetLimit|null $budgetLimit * * @return JsonResponse - * - * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function expenseCategory(Budget $budget, ?BudgetLimit $budgetLimit): JsonResponse { @@ -282,8 +278,6 @@ class BudgetController extends Controller * @param BudgetLimit|null $budgetLimit * * @return JsonResponse - * - * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function expenseExpense(Budget $budget, ?BudgetLimit $budgetLimit): JsonResponse { @@ -333,8 +327,6 @@ class BudgetController extends Controller * * @return JsonResponse * - * @SuppressWarnings(PHPMD.CyclomaticComplexity) - * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ public function frontpage(): JsonResponse { diff --git a/app/Http/Controllers/Chart/BudgetReportController.php b/app/Http/Controllers/Chart/BudgetReportController.php index 8737747923..18186d2a25 100644 --- a/app/Http/Controllers/Chart/BudgetReportController.php +++ b/app/Http/Controllers/Chart/BudgetReportController.php @@ -39,7 +39,7 @@ use Illuminate\Support\Collection; * * Class BudgetReportController * - * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + * */ class BudgetReportController extends Controller { @@ -79,8 +79,6 @@ class BudgetReportController extends Controller * @param string $others * * @return JsonResponse - * - * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function accountExpense(Collection $accounts, Collection $budgets, Carbon $start, Carbon $end, string $others): JsonResponse { @@ -110,8 +108,6 @@ class BudgetReportController extends Controller * @param string $others * * @return JsonResponse - * - * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function budgetExpense(Collection $accounts, Collection $budgets, Carbon $start, Carbon $end, string $others): JsonResponse { @@ -141,8 +137,6 @@ class BudgetReportController extends Controller * * @return JsonResponse * - * @SuppressWarnings(PHPMD.CyclomaticComplexity) - * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ public function mainChart(Collection $accounts, Collection $budgets, Carbon $start, Carbon $end): JsonResponse { diff --git a/app/Http/Controllers/Chart/CategoryController.php b/app/Http/Controllers/Chart/CategoryController.php index 52803ee0d2..7c90d8ae22 100644 --- a/app/Http/Controllers/Chart/CategoryController.php +++ b/app/Http/Controllers/Chart/CategoryController.php @@ -71,8 +71,6 @@ class CategoryController extends Controller * @param Category $category * * @return JsonResponse - * - * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ public function all(CategoryRepositoryInterface $repository, Category $category): JsonResponse { @@ -204,8 +202,6 @@ class CategoryController extends Controller * @param Carbon $end * * @return JsonResponse - * - * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ public function reportPeriod(Category $category, Collection $accounts, Carbon $start, Carbon $end): JsonResponse { @@ -272,8 +268,6 @@ class CategoryController extends Controller * @param Carbon $end * * @return JsonResponse - * - * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ public function reportPeriodNoCategory(Collection $accounts, Carbon $start, Carbon $end): JsonResponse { diff --git a/app/Http/Controllers/Chart/CategoryReportController.php b/app/Http/Controllers/Chart/CategoryReportController.php index a7ea4ee54c..6e55c7dd63 100644 --- a/app/Http/Controllers/Chart/CategoryReportController.php +++ b/app/Http/Controllers/Chart/CategoryReportController.php @@ -74,8 +74,6 @@ class CategoryReportController extends Controller * @param string $others * * @return JsonResponse - * - * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function accountExpense(Collection $accounts, Collection $categories, Carbon $start, Carbon $end, string $others): JsonResponse { @@ -102,8 +100,6 @@ class CategoryReportController extends Controller * @param string $others * * @return JsonResponse - * - * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function accountIncome(Collection $accounts, Collection $categories, Carbon $start, Carbon $end, string $others): JsonResponse { @@ -133,8 +129,6 @@ class CategoryReportController extends Controller * @param string $others * * @return JsonResponse - * - * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function categoryExpense(Collection $accounts, Collection $categories, Carbon $start, Carbon $end, string $others): JsonResponse { @@ -164,7 +158,7 @@ class CategoryReportController extends Controller * @param string $others * * @return JsonResponse - * @SuppressWarnings(PHPMD.ExcessiveParameterList) + * */ public function categoryIncome(Collection $accounts, Collection $categories, Carbon $start, Carbon $end, string $others): JsonResponse { @@ -195,9 +189,7 @@ class CategoryReportController extends Controller * * @return JsonResponse * - * @SuppressWarnings(PHPMD.ExcessiveParameterList) - * @SuppressWarnings(PHPMD.CyclomaticComplexity) - * @SuppressWarnings(PHPMD.ExcessiveMethodLength) + * */ public function mainChart(Collection $accounts, Collection $categories, Carbon $start, Carbon $end): JsonResponse { diff --git a/app/Http/Controllers/Chart/ExpenseReportController.php b/app/Http/Controllers/Chart/ExpenseReportController.php index 6621083e2e..9872ebe8e3 100644 --- a/app/Http/Controllers/Chart/ExpenseReportController.php +++ b/app/Http/Controllers/Chart/ExpenseReportController.php @@ -77,9 +77,7 @@ class ExpenseReportController extends Controller * * @return JsonResponse * - * @SuppressWarnings(PHPMD.ExcessiveMethodLength) - * @SuppressWarnings(PHPMD.CyclomaticComplexity) - * @SuppressWarnings(PHPMD.NPathComplexity) + * */ public function mainChart(Collection $accounts, Collection $expense, Carbon $start, Carbon $end): JsonResponse { diff --git a/app/Http/Controllers/Chart/PiggyBankController.php b/app/Http/Controllers/Chart/PiggyBankController.php index fb94165760..a558e6fbb7 100644 --- a/app/Http/Controllers/Chart/PiggyBankController.php +++ b/app/Http/Controllers/Chart/PiggyBankController.php @@ -63,8 +63,6 @@ class PiggyBankController extends Controller * * @return JsonResponse * - * @SuppressWarnings(PHPMD.CyclomaticComplexity) - * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ public function history(PiggyBankRepositoryInterface $repository, PiggyBank $piggyBank): JsonResponse { diff --git a/app/Http/Controllers/Chart/ReportController.php b/app/Http/Controllers/Chart/ReportController.php index c9fbaecc46..efd50c17da 100644 --- a/app/Http/Controllers/Chart/ReportController.php +++ b/app/Http/Controllers/Chart/ReportController.php @@ -138,8 +138,6 @@ class ReportController extends Controller * @param Carbon $end * * @return \Illuminate\Http\JsonResponse - * - * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ public function operations(Collection $accounts, Carbon $start, Carbon $end): JsonResponse { @@ -200,8 +198,6 @@ class ReportController extends Controller * * @return \Illuminate\Http\JsonResponse * - * @SuppressWarnings(PHPMD.ExcessiveMethodLength) - * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function sum(Collection $accounts, Carbon $start, Carbon $end): JsonResponse { diff --git a/app/Http/Controllers/Chart/TagReportController.php b/app/Http/Controllers/Chart/TagReportController.php index 8b38d2767a..3ef5b78928 100644 --- a/app/Http/Controllers/Chart/TagReportController.php +++ b/app/Http/Controllers/Chart/TagReportController.php @@ -66,8 +66,6 @@ class TagReportController extends Controller * @param string $others * * @return JsonResponse - * - * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function accountExpense(Collection $accounts, Collection $tags, Carbon $start, Carbon $end, string $others): JsonResponse { @@ -97,8 +95,6 @@ class TagReportController extends Controller * @param string $others * * @return JsonResponse - * - * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function accountIncome(Collection $accounts, Collection $tags, Carbon $start, Carbon $end, string $others): JsonResponse { @@ -127,8 +123,6 @@ class TagReportController extends Controller * @param Carbon $end * * @return JsonResponse - * - * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function budgetExpense(Collection $accounts, Collection $tags, Carbon $start, Carbon $end): JsonResponse { @@ -157,8 +151,6 @@ class TagReportController extends Controller * @param Carbon $end * * @return JsonResponse - * - * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function categoryExpense(Collection $accounts, Collection $tags, Carbon $start, Carbon $end): JsonResponse { @@ -188,9 +180,7 @@ class TagReportController extends Controller * * @return JsonResponse * - * @SuppressWarnings(PHPMD.ExcessiveParameterList) - * @SuppressWarnings(PHPMD.CyclomaticComplexity) - * @SuppressWarnings(PHPMD.ExcessiveMethodLength) + * */ public function mainChart(Collection $accounts, Collection $tags, Carbon $start, Carbon $end): JsonResponse { @@ -305,8 +295,6 @@ class TagReportController extends Controller * @param string $others * * @return JsonResponse - * - * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function tagExpense(Collection $accounts, Collection $tags, Carbon $start, Carbon $end, string $others): JsonResponse { @@ -336,8 +324,6 @@ class TagReportController extends Controller * @param string $others * * @return JsonResponse - * - * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function tagIncome(Collection $accounts, Collection $tags, Carbon $start, Carbon $end, string $others): JsonResponse { diff --git a/app/Http/Controllers/Controller.php b/app/Http/Controllers/Controller.php index c5c041a3aa..f676ee4192 100644 --- a/app/Http/Controllers/Controller.php +++ b/app/Http/Controllers/Controller.php @@ -33,7 +33,7 @@ use Route; /** * Class Controller. * - * @SuppressWarnings(PHPMD.NumberOfChildren) + * */ class Controller extends BaseController { diff --git a/app/Http/Controllers/CurrencyController.php b/app/Http/Controllers/CurrencyController.php index 6aa462e6be..ba9129c3b2 100644 --- a/app/Http/Controllers/CurrencyController.php +++ b/app/Http/Controllers/CurrencyController.php @@ -333,8 +333,6 @@ class CurrencyController extends Controller * @param CurrencyFormRequest $request * * @return $this|\Illuminate\Http\RedirectResponse|\Illuminate\Routing\Redirector - * - * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function store(CurrencyFormRequest $request) { diff --git a/app/Http/Controllers/DebugController.php b/app/Http/Controllers/DebugController.php index 8de8555f3d..f95d22aec9 100644 --- a/app/Http/Controllers/DebugController.php +++ b/app/Http/Controllers/DebugController.php @@ -39,7 +39,7 @@ use Route as RouteFacade; /** * Class DebugController * - * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + * */ class DebugController extends Controller { @@ -113,8 +113,6 @@ class DebugController extends Controller * * @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View * - * @SuppressWarnings(PHPMD.CyclomaticComplexity) - * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ public function index(Request $request) { @@ -192,8 +190,6 @@ class DebugController extends Controller * Return all possible routes. * * @return string - * - * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function routes(): string { diff --git a/app/Http/Controllers/Import/IndexController.php b/app/Http/Controllers/Import/IndexController.php index cf4a4eadee..755b854a47 100644 --- a/app/Http/Controllers/Import/IndexController.php +++ b/app/Http/Controllers/Import/IndexController.php @@ -71,8 +71,6 @@ class IndexController extends Controller * * @return \Illuminate\Http\RedirectResponse|\Illuminate\Routing\Redirector * - * @SuppressWarnings(PHPMD.CyclomaticComplexity) - * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ public function create(string $importProvider) { diff --git a/app/Http/Controllers/Import/JobConfigurationController.php b/app/Http/Controllers/Import/JobConfigurationController.php index dac7b2136f..ed921f5092 100644 --- a/app/Http/Controllers/Import/JobConfigurationController.php +++ b/app/Http/Controllers/Import/JobConfigurationController.php @@ -68,8 +68,6 @@ class JobConfigurationController extends Controller * * @throws FireflyException * - * @SuppressWarnings(PHPMD.CyclomaticComplexity) - * */ public function index(ImportJob $importJob) { @@ -119,8 +117,6 @@ class JobConfigurationController extends Controller * @return \Illuminate\Http\RedirectResponse|\Illuminate\Routing\Redirector * * @throws FireflyException - * - * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function post(Request $request, ImportJob $importJob) { diff --git a/app/Http/Controllers/Import/PrerequisitesController.php b/app/Http/Controllers/Import/PrerequisitesController.php index 7a08d0519b..3ae9a1bbc2 100644 --- a/app/Http/Controllers/Import/PrerequisitesController.php +++ b/app/Http/Controllers/Import/PrerequisitesController.php @@ -67,8 +67,6 @@ class PrerequisitesController extends Controller * @param ImportJob $importJob * * @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View - * - * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function index(string $importProvider, ImportJob $importJob = null) { @@ -111,15 +109,13 @@ class PrerequisitesController extends Controller * Whatever storePrerequisites does, it should make sure that the system is ready to continue immediately. So * no extra calls or stuff, except maybe to open a session * - * @see PrerequisitesInterface::storePrerequisites - * * @param Request $request * @param string $importProvider * @param ImportJob $importJob * * @return \Illuminate\Http\RedirectResponse|\Illuminate\Routing\Redirector - * @SuppressWarnings(PHPMD.CyclomaticComplexity) - * @SuppressWarnings(PHPMD.ExcessiveMethodLength) + * @see PrerequisitesInterface::storePrerequisites + * */ public function post(Request $request, string $importProvider, ImportJob $importJob = null) { diff --git a/app/Http/Controllers/Json/AutoCompleteController.php b/app/Http/Controllers/Json/AutoCompleteController.php index 8a42e2e3ab..69f825ffc1 100644 --- a/app/Http/Controllers/Json/AutoCompleteController.php +++ b/app/Http/Controllers/Json/AutoCompleteController.php @@ -43,7 +43,7 @@ use Log; * * TODO autocomplete for transaction types. * - * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + * */ class AutoCompleteController extends Controller { diff --git a/app/Http/Controllers/Json/BoxController.php b/app/Http/Controllers/Json/BoxController.php index ebdd02e6e3..137a3ae21a 100644 --- a/app/Http/Controllers/Json/BoxController.php +++ b/app/Http/Controllers/Json/BoxController.php @@ -52,8 +52,6 @@ class BoxController extends Controller * @param BudgetRepositoryInterface $repository * * @return JsonResponse - * @SuppressWarnings(PHPMD.CyclomaticComplexity) - * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ public function available(BudgetRepositoryInterface $repository): JsonResponse { @@ -110,8 +108,6 @@ class BoxController extends Controller * @param CurrencyRepositoryInterface $repository * * @return JsonResponse - * @SuppressWarnings(PHPMD.CyclomaticComplexity) - * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ public function balance(CurrencyRepositoryInterface $repository): JsonResponse { @@ -237,8 +233,6 @@ class BoxController extends Controller * Total user net worth. * * @return JsonResponse - * @SuppressWarnings(PHPMD.CyclomaticComplexity) - * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ public function netWorth(): JsonResponse { diff --git a/app/Http/Controllers/Json/RecurrenceController.php b/app/Http/Controllers/Json/RecurrenceController.php index 77ef359ae4..ab89502040 100644 --- a/app/Http/Controllers/Json/RecurrenceController.php +++ b/app/Http/Controllers/Json/RecurrenceController.php @@ -63,11 +63,9 @@ class RecurrenceController extends Controller * * @param Request $request * - * @throws FireflyException * @return JsonResponse - * @SuppressWarnings(PHPMD.CyclomaticComplexity) - * @SuppressWarnings(PHPMD.NPathComplexity) - * @SuppressWarnings(PHPMD.ExcessiveMethodLength) + * + * @throws FireflyException */ public function events(Request $request): JsonResponse { diff --git a/app/Http/Controllers/PiggyBankController.php b/app/Http/Controllers/PiggyBankController.php index 1c5880646a..5d4aab08b6 100644 --- a/app/Http/Controllers/PiggyBankController.php +++ b/app/Http/Controllers/PiggyBankController.php @@ -41,8 +41,8 @@ use Symfony\Component\HttpFoundation\ParameterBag; /** * Class PiggyBankController. * - * @SuppressWarnings(PHPMD.TooManyPublicMethods) - * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + * + * */ class PiggyBankController extends Controller { @@ -188,8 +188,6 @@ class PiggyBankController extends Controller * @param PiggyBank $piggyBank * * @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View - * - * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function edit(PiggyBank $piggyBank) { @@ -230,8 +228,6 @@ class PiggyBankController extends Controller * @param Request $request * * @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View - * - * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ public function index(Request $request) { diff --git a/app/Http/Controllers/Popup/ReportController.php b/app/Http/Controllers/Popup/ReportController.php index 25dfe38cb4..15956dd034 100644 --- a/app/Http/Controllers/Popup/ReportController.php +++ b/app/Http/Controllers/Popup/ReportController.php @@ -31,7 +31,7 @@ use Illuminate\Http\Request; /** * Class ReportController. * - * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + * */ class ReportController extends Controller { @@ -43,7 +43,7 @@ class ReportController extends Controller * @param Request $request * * @return JsonResponse - * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * */ public function general(Request $request): JsonResponse { diff --git a/app/Http/Controllers/PreferencesController.php b/app/Http/Controllers/PreferencesController.php index eddb76fb25..7885276fb2 100644 --- a/app/Http/Controllers/PreferencesController.php +++ b/app/Http/Controllers/PreferencesController.php @@ -100,8 +100,6 @@ class PreferencesController extends Controller * * @return \Illuminate\Http\RedirectResponse|\Illuminate\Routing\Redirector * - * @SuppressWarnings(PHPMD.CyclomaticComplexity) - * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ public function postIndex(Request $request) { diff --git a/app/Http/Controllers/ProfileController.php b/app/Http/Controllers/ProfileController.php index 5a37aed511..37e161cd58 100644 --- a/app/Http/Controllers/ProfileController.php +++ b/app/Http/Controllers/ProfileController.php @@ -51,8 +51,8 @@ use PragmaRX\Recovery\Recovery; * Class ProfileController. * * @method Guard guard() - * @SuppressWarnings(PHPMD.CouplingBetweenObjects) - * @SuppressWarnings(PHPMD.TooManyPublicMethods) + * + * */ class ProfileController extends Controller { @@ -438,8 +438,6 @@ class ProfileController extends Controller * @param TokenFormRequest $request * * @return \Illuminate\Http\RedirectResponse|\Illuminate\Routing\Redirector - * - * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function postCode(TokenFormRequest $request) { @@ -524,8 +522,6 @@ class ProfileController extends Controller * @return \Illuminate\Http\RedirectResponse|\Illuminate\Routing\Redirector * * @throws FireflyException - * - * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function undoEmailChange(UserRepositoryInterface $repository, string $token, string $hash) { diff --git a/app/Http/Controllers/Recurring/EditController.php b/app/Http/Controllers/Recurring/EditController.php index e99b900814..e158cdd51c 100644 --- a/app/Http/Controllers/Recurring/EditController.php +++ b/app/Http/Controllers/Recurring/EditController.php @@ -77,8 +77,6 @@ class EditController extends Controller * @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View * @throws \FireflyIII\Exceptions\FireflyException * - * @SuppressWarnings(PHPMD.CyclomaticComplexity) - * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ public function edit(Request $request, Recurrence $recurrence) { diff --git a/app/Http/Controllers/Recurring/IndexController.php b/app/Http/Controllers/Recurring/IndexController.php index b5c7af9859..c3acc0336b 100644 --- a/app/Http/Controllers/Recurring/IndexController.php +++ b/app/Http/Controllers/Recurring/IndexController.php @@ -74,7 +74,7 @@ class IndexController extends Controller * * @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View * @throws \FireflyIII\Exceptions\FireflyException - * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * */ public function index(Request $request) { diff --git a/app/Http/Controllers/ReportController.php b/app/Http/Controllers/ReportController.php index ea05e3f22c..9a1c9b2272 100644 --- a/app/Http/Controllers/ReportController.php +++ b/app/Http/Controllers/ReportController.php @@ -38,7 +38,7 @@ use Log; /** * Class ReportController. * - * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + * */ class ReportController extends Controller { @@ -276,7 +276,7 @@ class ReportController extends Controller * @param string $reportType * * @return mixed - * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * */ public function options(string $reportType) { @@ -310,9 +310,7 @@ class ReportController extends Controller * * @throws \FireflyIII\Exceptions\FireflyException * - * @SuppressWarnings(PHPMD.CyclomaticComplexity) - * @SuppressWarnings(PHPMD.NPathComplexity) - * @SuppressWarnings(PHPMD.ExcessiveMethodLength) + * */ public function postIndex(ReportFormRequest $request) { diff --git a/app/Http/Controllers/Rule/CreateController.php b/app/Http/Controllers/Rule/CreateController.php index af9e56b033..c513838461 100644 --- a/app/Http/Controllers/Rule/CreateController.php +++ b/app/Http/Controllers/Rule/CreateController.php @@ -70,8 +70,6 @@ class CreateController extends Controller * @param RuleGroup $ruleGroup * * @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View - * @SuppressWarnings(PHPMD.ExcessiveMethodLength) - * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function create(Request $request, RuleGroup $ruleGroup = null) { @@ -120,8 +118,6 @@ class CreateController extends Controller * @param Bill $bill * * @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View - * @SuppressWarnings(PHPMD.ExcessiveMethodLength) - * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function createFromBill(Request $request, Bill $bill) { @@ -168,7 +164,7 @@ class CreateController extends Controller * @param RuleFormRequest $request * * @return RedirectResponse|\Illuminate\Routing\Redirector - * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * */ public function store(RuleFormRequest $request) { diff --git a/app/Http/Controllers/Rule/EditController.php b/app/Http/Controllers/Rule/EditController.php index d136c175ee..4e33ddbcaa 100644 --- a/app/Http/Controllers/Rule/EditController.php +++ b/app/Http/Controllers/Rule/EditController.php @@ -70,8 +70,6 @@ class EditController extends Controller * @param Rule $rule * * @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View - * @SuppressWarnings(PHPMD.CyclomaticComplexity) - * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ public function edit(Request $request, Rule $rule) { diff --git a/app/Http/Controllers/Rule/IndexController.php b/app/Http/Controllers/Rule/IndexController.php index 4593b67de6..7bba8ffa4c 100644 --- a/app/Http/Controllers/Rule/IndexController.php +++ b/app/Http/Controllers/Rule/IndexController.php @@ -135,7 +135,6 @@ class IndexController extends Controller * @param Rule $rule * * @return RedirectResponse|\Illuminate\Routing\Redirector - * @SuppressWarnings(PHPMD.ShortMethodName) */ public function up(Rule $rule) { diff --git a/app/Http/Controllers/Rule/SelectController.php b/app/Http/Controllers/Rule/SelectController.php index cf81e5e49a..a37b526533 100644 --- a/app/Http/Controllers/Rule/SelectController.php +++ b/app/Http/Controllers/Rule/SelectController.php @@ -47,7 +47,7 @@ use Throwable; /** * Class SelectController. * - * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + * */ class SelectController extends Controller { @@ -147,8 +147,6 @@ class SelectController extends Controller * * @return JsonResponse * - * @SuppressWarnings(PHPMD.CyclomaticComplexity) - * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ public function testTriggers(TestRuleFormRequest $request): JsonResponse { @@ -216,8 +214,6 @@ class SelectController extends Controller * * @return JsonResponse * - * @SuppressWarnings(PHPMD.CyclomaticComplexity) - * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ public function testTriggersByRule(Rule $rule): JsonResponse { diff --git a/app/Http/Controllers/RuleGroup/EditController.php b/app/Http/Controllers/RuleGroup/EditController.php index e6ab8aacf7..dfe0191bb1 100644 --- a/app/Http/Controllers/RuleGroup/EditController.php +++ b/app/Http/Controllers/RuleGroup/EditController.php @@ -105,7 +105,6 @@ class EditController extends Controller * * @return \Illuminate\Http\RedirectResponse|\Illuminate\Routing\Redirector * - * @SuppressWarnings(PHPMD.ShortMethodName) */ public function up(RuleGroup $ruleGroup) { diff --git a/app/Http/Controllers/TagController.php b/app/Http/Controllers/TagController.php index 0a1ad7a732..798a6b2c45 100644 --- a/app/Http/Controllers/TagController.php +++ b/app/Http/Controllers/TagController.php @@ -31,7 +31,6 @@ use FireflyIII\Repositories\Tag\TagRepositoryInterface; use FireflyIII\Support\Http\Controllers\PeriodOverview; use Illuminate\Http\RedirectResponse; use Illuminate\Http\Request; -use Illuminate\Support\Collection; use Log; /** @@ -177,8 +176,6 @@ class TagController extends Controller * * @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View * - * @SuppressWarnings(PHPMD.ExcessiveMethodLength) - * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function show(Request $request, Tag $tag, Carbon $start = null, Carbon $end = null) { @@ -219,8 +216,6 @@ class TagController extends Controller * * @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View * - * @SuppressWarnings(PHPMD.ExcessiveMethodLength) - * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function showAll(Request $request, Tag $tag) { diff --git a/app/Http/Controllers/Transaction/BulkController.php b/app/Http/Controllers/Transaction/BulkController.php index 83b1d1c9b8..605ae91c2c 100644 --- a/app/Http/Controllers/Transaction/BulkController.php +++ b/app/Http/Controllers/Transaction/BulkController.php @@ -92,8 +92,6 @@ class BulkController extends Controller * @param BulkEditJournalRequest $request * * @return mixed - * @SuppressWarnings(PHPMD.ExcessiveMethodLength) - * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function update(BulkEditJournalRequest $request) { diff --git a/app/Http/Controllers/Transaction/MassController.php b/app/Http/Controllers/Transaction/MassController.php index 219fd48c1f..7fb91b005e 100644 --- a/app/Http/Controllers/Transaction/MassController.php +++ b/app/Http/Controllers/Transaction/MassController.php @@ -42,7 +42,7 @@ use Log; /** * Class MassController. * - * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + * */ class MassController extends Controller { @@ -90,7 +90,7 @@ class MassController extends Controller * @param MassDeleteJournalRequest $request * * @return mixed - * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * */ public function destroy(MassDeleteJournalRequest $request) { diff --git a/app/Http/Middleware/Authenticate.php b/app/Http/Middleware/Authenticate.php index 2c68878759..ec0cfe3d76 100644 --- a/app/Http/Middleware/Authenticate.php +++ b/app/Http/Middleware/Authenticate.php @@ -83,8 +83,6 @@ class Authenticate * @return mixed * @throws AuthenticationException * @throws FireflyException - * @SuppressWarnings(PHPMD.CyclomaticComplexity) - * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ protected function authenticate($request, array $guards) { diff --git a/app/Http/Middleware/Installer.php b/app/Http/Middleware/Installer.php index 732289eaa8..808ff6ccc9 100644 --- a/app/Http/Middleware/Installer.php +++ b/app/Http/Middleware/Installer.php @@ -41,15 +41,13 @@ class Installer /** * Handle an incoming request. * - * @throws FireflyException - * * @param \Illuminate\Http\Request $request * @param \Closure $next * * @return mixed * - * @SuppressWarnings(PHPMD.ExcessiveMethodLength) - * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * + * @throws FireflyException * */ public function handle($request, Closure $next) diff --git a/app/Http/Middleware/Range.php b/app/Http/Middleware/Range.php index b8c4bed70d..73d2f7e1a4 100644 --- a/app/Http/Middleware/Range.php +++ b/app/Http/Middleware/Range.php @@ -118,8 +118,6 @@ class Range /** * Set the range for the current view. - * - * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ private function setRange(): void { diff --git a/app/Http/Requests/RecurrenceFormRequest.php b/app/Http/Requests/RecurrenceFormRequest.php index 5863128db3..ae903cf4e1 100644 --- a/app/Http/Requests/RecurrenceFormRequest.php +++ b/app/Http/Requests/RecurrenceFormRequest.php @@ -56,8 +56,6 @@ class RecurrenceFormRequest extends Request * @return array * @throws FireflyException * - * @SuppressWarnings(PHPMD.ExcessiveMethodLength) - * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function getAll(): array { @@ -225,9 +223,7 @@ class RecurrenceFormRequest extends Request * @return array * @throws FireflyException * - * @SuppressWarnings(PHPMD.ExcessiveMethodLength) - * @SuppressWarnings(PHPMD.CyclomaticComplexity) - * @SuppressWarnings(PHPMD.NPathComplexity) + * */ public function rules(): array { @@ -318,8 +314,6 @@ class RecurrenceFormRequest extends Request * Parses repetition data. * * @return array - * - * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ private function parseRepetitionData(): array { diff --git a/app/Http/Requests/Request.php b/app/Http/Requests/Request.php index d531c6f7a1..27887cc05b 100644 --- a/app/Http/Requests/Request.php +++ b/app/Http/Requests/Request.php @@ -33,7 +33,7 @@ use Log; * * @codeCoverageIgnore * - * @SuppressWarnings(PHPMD.NumberOfChildren) + * */ class Request extends FormRequest { @@ -183,8 +183,6 @@ class Request extends FormRequest * @param string $field * * @return string - * - * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ public function string(string $field): string { diff --git a/app/Http/Requests/RuleFormRequest.php b/app/Http/Requests/RuleFormRequest.php index da90a90ba9..a8c5903c3f 100644 --- a/app/Http/Requests/RuleFormRequest.php +++ b/app/Http/Requests/RuleFormRequest.php @@ -45,8 +45,6 @@ class RuleFormRequest extends Request * * @return array * - * @SuppressWarnings(PHPMD.ExcessiveMethodLength) - * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function getRuleData(): array {