kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-11-17 23:28:20 +00:00
Code Issues Projects Releases Wiki Activity

Fix test that could come up with journals with 0 transactions, and improve test coverage for file routine.

Browse Source
This commit is contained in:
James Cole
2018-05-10 20:05:02 +02:00
parent 6bd23d897f
commit 274162afcd
10 changed files with 655 additions and 400 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
app/Import/JobConfiguration/FileJobConfiguration.php
View File

@@ -48,6 +48,7 @@ class FileJobConfiguration implements JobConfigurationInterface
*/
public function __construct()
{
$this->repository = app(ImportJobRepositoryInterface::class);
}
/**
@@ -57,11 +58,7 @@ class FileJobConfiguration implements JobConfigurationInterface
*/
public function configurationComplete(): bool
{
if ($this->importJob->stage === 'ready_to_run') {
return true;
}
return false;
return $this->importJob->stage === 'ready_to_run';
}
/**
@@ -129,8 +126,7 @@ class FileJobConfiguration implements JobConfigurationInterface
*/
public function setJob(ImportJob $job): void
{
$this->importJob = $job;
$this->repository = app(ImportJobRepositoryInterface::class);
$this->importJob = $job;
$this->repository->setUser($job->user);
}
@@ -156,17 +152,6 @@ class FileJobConfiguration implements JobConfigurationInterface
case 'map':
$class = ConfigureMappingHandler::class;
break;
// case 'upload-config': // has file, needs file config.
// $class = UploadConfig::class;
// break;
// case 'roles': // has configured file, needs roles.
// $class = Roles::class;
// break;
// case 'map': // has roles, needs mapping.
// $class = Map::class;
// break;
// default:
// break;
}
if (!class_exists($class)) {
throw new FireflyException(sprintf('Class %s does not exist in getConfigurationClass().', $class)); // @codeCoverageIgnore