diff --git a/app/Http/Requests/ReportFormRequest.php b/app/Http/Requests/ReportFormRequest.php index 4dcdcc5737..e806760e4c 100644 --- a/app/Http/Requests/ReportFormRequest.php +++ b/app/Http/Requests/ReportFormRequest.php @@ -153,7 +153,6 @@ class ReportFormRequest extends Request */ public function getExpenseList(): Collection { - // fixed /** @var AccountRepositoryInterface $repository */ $repository = app(AccountRepositoryInterface::class); $set = $this->get('exp_rev'); diff --git a/tests/Feature/Controllers/ReportControllerTest.php b/tests/Feature/Controllers/ReportControllerTest.php index 1a274339a7..27789c156a 100644 --- a/tests/Feature/Controllers/ReportControllerTest.php +++ b/tests/Feature/Controllers/ReportControllerTest.php @@ -425,8 +425,14 @@ class ReportControllerTest extends TestCase $userRepos = $this->mock(UserRepositoryInterface::class); $fiscalHelper = $this->mock(FiscalHelperInterface::class); $reportHelper = $this->mock(ReportHelperInterface::class); + $asset = $this->getRandomAsset(); + // find the user's asset account + $accountRepos->shouldReceive('findNull')->withArgs([1])->andReturn($asset)->atLeast()->once(); + + // do not find the exp_rev things. + $accountRepos->shouldReceive('findNull')->withArgs([4])->andReturnNull()->atLeast()->once(); + - $accountRepos->shouldReceive('findNull')->andReturn(null)->times(3); $journalRepos->shouldReceive('firstNull')->once()->andReturn(new TransactionJournal); $data = [