From 2a38c9b4ef440f9d987d256b01540825b4e818f5 Mon Sep 17 00:00:00 2001 From: James Cole Date: Mon, 10 Feb 2020 19:15:35 +0100 Subject: [PATCH] Fix a rare null pointer --- app/Http/Controllers/Json/BoxController.php | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/app/Http/Controllers/Json/BoxController.php b/app/Http/Controllers/Json/BoxController.php index 85da86b9d0..cc47398438 100644 --- a/app/Http/Controllers/Json/BoxController.php +++ b/app/Http/Controllers/Json/BoxController.php @@ -168,10 +168,11 @@ class BoxController extends Controller /** @var array $journal */ foreach ($set as $journal) { $currencyId = (int)$journal['currency_id']; + $amount = $journal['amount'] ?? '0'; $incomes[$currencyId] = $incomes[$currencyId] ?? '0'; - $incomes[$currencyId] = bcadd($incomes[$currencyId], app('steam')->positive($journal['amount'])); + $incomes[$currencyId] = bcadd($incomes[$currencyId], app('steam')->positive($amount)); $sums[$currencyId] = $sums[$currencyId] ?? '0'; - $sums[$currencyId] = bcadd($sums[$currencyId], app('steam')->positive($journal['amount'])); + $sums[$currencyId] = bcadd($sums[$currencyId], app('steam')->positive($amount)); } // collect expenses