mirror of
https://github.com/firefly-iii/firefly-iii.git
synced 2025-11-20 00:20:03 +00:00
Improve test coverage.
This commit is contained in:
James Cole
341
tests/Unit/Console/Commands/Upgrade/AccountCurrenciesTest.php
Normal file
341
tests/Unit/Console/Commands/Upgrade/AccountCurrenciesTest.php
Normal file
@@ -0,0 +1,341 @@
|
||||
<?php
|
||||
/**
|
||||
* AccountCurrenciesTest.php
|
||||
* Copyright (c) 2019 thegrumpydictator@gmail.com
|
||||
*
|
||||
* This file is part of Firefly III.
|
||||
*
|
||||
* Firefly III is free software: you can redistribute it and/or modify
|
||||
* it under the terms of the GNU General Public License as published by
|
||||
* the Free Software Foundation, either version 3 of the License, or
|
||||
* (at your option) any later version.
|
||||
*
|
||||
* Firefly III is distributed in the hope that it will be useful,
|
||||
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||||
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||||
* GNU General Public License for more details.
|
||||
*
|
||||
* You should have received a copy of the GNU General Public License
|
||||
* along with Firefly III. If not, see <http://www.gnu.org/licenses/>.
|
||||
*/
|
||||
|
||||
namespace Tests\Unit\Console\Commands\Upgrade;
|
||||
|
||||
|
||||
use FireflyConfig;
|
||||
use FireflyIII\Models\AccountMeta;
|
||||
use FireflyIII\Models\Configuration;
|
||||
use FireflyIII\Models\Preference;
|
||||
use FireflyIII\Models\Transaction;
|
||||
use FireflyIII\Models\TransactionCurrency;
|
||||
use FireflyIII\Models\TransactionJournal;
|
||||
use FireflyIII\Repositories\Account\AccountRepositoryInterface;
|
||||
use FireflyIII\Repositories\User\UserRepositoryInterface;
|
||||
use Illuminate\Support\Collection;
|
||||
use Log;
|
||||
use Mockery;
|
||||
use Preferences;
|
||||
use Tests\TestCase;
|
||||
|
||||
/**
|
||||
* Class AccountCurrenciesTest
|
||||
*/
|
||||
class AccountCurrenciesTest extends TestCase
|
||||
{
|
||||
/**
|
||||
*
|
||||
*/
|
||||
public function setUp(): void
|
||||
{
|
||||
parent::setUp();
|
||||
Log::info(sprintf('Now in %s.', get_class($this)));
|
||||
}
|
||||
|
||||
/**
|
||||
* Perfect run without opening balance.
|
||||
*
|
||||
* @covers \FireflyIII\Console\Commands\Upgrade\AccountCurrencies
|
||||
*/
|
||||
public function testHandle(): void
|
||||
{
|
||||
$false = new Configuration;
|
||||
$false->data = false;
|
||||
$pref = new Preference;
|
||||
$pref->data = 'EUR';
|
||||
$account = $this->getRandomAsset();
|
||||
$accountRepos = $this->mock(AccountRepositoryInterface::class);
|
||||
$userRepos = $this->mock(UserRepositoryInterface::class);
|
||||
|
||||
// mock calls
|
||||
$accountRepos->shouldReceive('setUser')->atLeast()->once();
|
||||
$accountRepos->shouldReceive('getMetaValue')->atLeast()->once()->andReturn('1');
|
||||
$accountRepos->shouldReceive('getOpeningBalance')->atLeast()->once()->andReturn(null);
|
||||
$accountRepos->shouldReceive('getAccountsByType')->atLeast()->once()->andReturn(new Collection([$account]));
|
||||
$userRepos->shouldReceive('all')->atLeast()->once()->andReturn(new Collection([$this->user()]));
|
||||
|
||||
// check config
|
||||
FireflyConfig::shouldReceive('get')->withArgs(['4780_account_currencies', false])->andReturn($false);
|
||||
FireflyConfig::shouldReceive('set')->withArgs(['4780_account_currencies', true]);
|
||||
|
||||
// check preferences:
|
||||
Preferences::shouldReceive('getForUser')->withArgs([Mockery::any(), 'currencyPreference', 'EUR'])->andReturn($pref);
|
||||
|
||||
$this->artisan('firefly-iii:account-currencies')
|
||||
->expectsOutput('All accounts are OK.')
|
||||
->assertExitCode(0);
|
||||
|
||||
// nothing changed, so nothing to verify.
|
||||
}
|
||||
|
||||
/**
|
||||
* Perfect run without opening balance.
|
||||
*
|
||||
* @covers \FireflyIII\Console\Commands\Upgrade\AccountCurrencies
|
||||
*/
|
||||
public function testHandleNotNull(): void
|
||||
{
|
||||
$false = new Configuration;
|
||||
$false->data = false;
|
||||
$pref = new Preference;
|
||||
$pref->data = 'EUR';
|
||||
$account = $this->getRandomAsset();
|
||||
$accountRepos = $this->mock(AccountRepositoryInterface::class);
|
||||
$userRepos = $this->mock(UserRepositoryInterface::class);
|
||||
$journal = $this->getRandomWithdrawal();
|
||||
|
||||
// mock calls
|
||||
$accountRepos->shouldReceive('setUser')->atLeast()->once();
|
||||
|
||||
// account reports USD
|
||||
$accountRepos->shouldReceive('getMetaValue')->atLeast()->once()->andReturn('2');
|
||||
// journal is EUR.
|
||||
$accountRepos->shouldReceive('getOpeningBalance')->atLeast()->once()->andReturn($journal);
|
||||
$accountRepos->shouldReceive('getAccountsByType')->atLeast()->once()->andReturn(new Collection([$account]));
|
||||
$userRepos->shouldReceive('all')->atLeast()->once()->andReturn(new Collection([$this->user()]));
|
||||
|
||||
// check config
|
||||
FireflyConfig::shouldReceive('get')->withArgs(['4780_account_currencies', false])->andReturn($false);
|
||||
FireflyConfig::shouldReceive('set')->withArgs(['4780_account_currencies', true]);
|
||||
|
||||
// check preferences:
|
||||
Preferences::shouldReceive('getForUser')->withArgs([Mockery::any(), 'currencyPreference', 'EUR'])->andReturn($pref);
|
||||
|
||||
$this->artisan('firefly-iii:account-currencies')
|
||||
->expectsOutput(sprintf('Account #%d ("%s") now has a correct currency for opening balance.', $account->id, $account->name))
|
||||
->assertExitCode(0);
|
||||
|
||||
// check if currency has been changed for the journal + transactions.
|
||||
$this->assertCount(1, TransactionJournal::where('id', $journal->id)->where('transaction_currency_id', 2)->get());
|
||||
$this->assertCount(2, Transaction::where('transaction_journal_id', $journal->id)->where('transaction_currency_id', 2)->get());
|
||||
}
|
||||
|
||||
/**
|
||||
* Perfect run with opening balance.
|
||||
*
|
||||
* @covers \FireflyIII\Console\Commands\Upgrade\AccountCurrencies
|
||||
*/
|
||||
public function testHandleOpeningBalance(): void
|
||||
{
|
||||
$false = new Configuration;
|
||||
$false->data = false;
|
||||
$pref = new Preference;
|
||||
$pref->data = 'EUR';
|
||||
$accountRepos = $this->mock(AccountRepositoryInterface::class);
|
||||
$userRepos = $this->mock(UserRepositoryInterface::class);
|
||||
$journal = $this->getRandomWithdrawal();
|
||||
$account = $this->getRandomAsset();
|
||||
// mock calls
|
||||
$accountRepos->shouldReceive('setUser')->atLeast()->once();
|
||||
$accountRepos->shouldReceive('getMetaValue')->atLeast()->once()->andReturn('1');
|
||||
$accountRepos->shouldReceive('getOpeningBalance')->atLeast()->once()->andReturn($journal);
|
||||
$userRepos->shouldReceive('all')->atLeast()->once()->andReturn(new Collection([$this->user()]));
|
||||
$accountRepos->shouldReceive('getAccountsByType')->atLeast()->once()->andReturn(new Collection([$account]));
|
||||
|
||||
// check config
|
||||
FireflyConfig::shouldReceive('get')->withArgs(['4780_account_currencies', false])->andReturn($false);
|
||||
FireflyConfig::shouldReceive('set')->withArgs(['4780_account_currencies', true]);
|
||||
|
||||
// check preferences:
|
||||
Preferences::shouldReceive('getForUser')->withArgs([Mockery::any(), 'currencyPreference', 'EUR'])->andReturn($pref);
|
||||
|
||||
$this->artisan('firefly-iii:account-currencies')
|
||||
->expectsOutput('All accounts are OK.')
|
||||
->assertExitCode(0);
|
||||
|
||||
// nothing changed, dont check output.
|
||||
}
|
||||
|
||||
/**
|
||||
* Perfect run with opening balance with different currencies
|
||||
*
|
||||
* @covers \FireflyIII\Console\Commands\Upgrade\AccountCurrencies
|
||||
*/
|
||||
public function testHandleDifferent(): void
|
||||
{
|
||||
$false = new Configuration;
|
||||
$false->data = false;
|
||||
$pref = new Preference;
|
||||
$pref->data = 'USD';
|
||||
$accountRepos = $this->mock(AccountRepositoryInterface::class);
|
||||
$userRepos = $this->mock(UserRepositoryInterface::class);
|
||||
$journal = $this->getRandomWithdrawal();
|
||||
$account = $this->getRandomAsset();
|
||||
$euro = TransactionCurrency::where('code', 'EUR')->first();
|
||||
|
||||
// delete meta data of account just in case:
|
||||
AccountMeta::where('account_id', $account->id)->where('name', 'currency_id')->forceDelete();
|
||||
// mock calls
|
||||
$accountRepos->shouldReceive('setUser')->atLeast()->once();
|
||||
$accountRepos->shouldReceive('getMetaValue')->atLeast()->once()->andReturn('0');
|
||||
$accountRepos->shouldReceive('getOpeningBalance')->atLeast()->once()->andReturn($journal);
|
||||
$userRepos->shouldReceive('all')->atLeast()->once()->andReturn(new Collection([$this->user()]));
|
||||
$accountRepos->shouldReceive('getAccountsByType')->atLeast()->once()->andReturn(new Collection([$account]));
|
||||
|
||||
// check config
|
||||
FireflyConfig::shouldReceive('get')->withArgs(['4780_account_currencies', false])->andReturn($false);
|
||||
FireflyConfig::shouldReceive('set')->withArgs(['4780_account_currencies', true]);
|
||||
|
||||
// check preferences:
|
||||
Preferences::shouldReceive('getForUser')->withArgs([Mockery::any(), 'currencyPreference', 'EUR'])->andReturn($pref);
|
||||
|
||||
$this->artisan('firefly-iii:account-currencies')
|
||||
->expectsOutput(sprintf('Account #%d ("%s") now has a currency setting (#%d).', $account->id, $account->name, $euro->id))
|
||||
->assertExitCode(0);
|
||||
|
||||
// verify account meta data change.
|
||||
$this->assertCount(1,
|
||||
AccountMeta::where('account_id', $account->id)
|
||||
->where('name', 'currency_id')
|
||||
->where('data', $euro->id)->get());
|
||||
}
|
||||
|
||||
/**
|
||||
* No known currency preferences.
|
||||
*
|
||||
* @covers \FireflyIII\Console\Commands\Upgrade\AccountCurrencies
|
||||
*/
|
||||
public function testHandleZeroPreference(): void
|
||||
{
|
||||
$false = new Configuration;
|
||||
$false->data = false;
|
||||
$pref = new Preference;
|
||||
$pref->data = 'EUR';
|
||||
$accountRepos = $this->mock(AccountRepositoryInterface::class);
|
||||
$userRepos = $this->mock(UserRepositoryInterface::class);
|
||||
$account = $this->getRandomAsset();
|
||||
$euro = TransactionCurrency::where('code', 'EUR')->first();
|
||||
// mock calls
|
||||
$accountRepos->shouldReceive('setUser')->atLeast()->once();
|
||||
$accountRepos->shouldReceive('getMetaValue')->atLeast()->once()->andReturn('0');
|
||||
$accountRepos->shouldReceive('getOpeningBalance')->atLeast()->once()->andReturn(null);
|
||||
$userRepos->shouldReceive('all')->atLeast()->once()->andReturn(new Collection([$this->user()]));
|
||||
$accountRepos->shouldReceive('getAccountsByType')->atLeast()->once()->andReturn(new Collection([$account]));
|
||||
|
||||
// check config
|
||||
FireflyConfig::shouldReceive('get')->withArgs(['4780_account_currencies', false])->andReturn($false);
|
||||
FireflyConfig::shouldReceive('set')->withArgs(['4780_account_currencies', true]);
|
||||
|
||||
// check preferences:
|
||||
Preferences::shouldReceive('getForUser')->withArgs([Mockery::any(), 'currencyPreference', 'EUR'])->andReturn($pref);
|
||||
|
||||
$this->artisan('firefly-iii:account-currencies')
|
||||
->expectsOutput(sprintf('Account #%d ("%s") now has a currency setting (%s).',
|
||||
$account->id, $account->name, $euro->code
|
||||
))
|
||||
->expectsOutput('Corrected 1 account(s).')
|
||||
->assertExitCode(0);
|
||||
|
||||
$this->assertCount(1, AccountMeta::where('account_id', $account->id)
|
||||
->where('name', 'currency_id')
|
||||
->where('data', $euro->id)->get());
|
||||
}
|
||||
|
||||
/**
|
||||
* @covers \FireflyIII\Console\Commands\Upgrade\AccountCurrencies
|
||||
*/
|
||||
public function testHandleNoPreference(): void
|
||||
{
|
||||
$false = new Configuration;
|
||||
$false->data = false;
|
||||
$pref = new Preference;
|
||||
$pref->data = false;
|
||||
$accountRepos = $this->mock(AccountRepositoryInterface::class);
|
||||
$userRepos = $this->mock(UserRepositoryInterface::class);
|
||||
$account = $this->getRandomAsset();
|
||||
// mock calls
|
||||
$accountRepos->shouldReceive('setUser')->atLeast()->once();
|
||||
$accountRepos->shouldReceive('getMetaValue')->atLeast()->once()->andReturn('1');
|
||||
$accountRepos->shouldReceive('getOpeningBalance')->atLeast()->once()->andReturn(null);
|
||||
$userRepos->shouldReceive('all')->atLeast()->once()->andReturn(new Collection([$this->user()]));
|
||||
$accountRepos->shouldReceive('getAccountsByType')->atLeast()->once()->andReturn(new Collection([$account]));
|
||||
|
||||
// check config
|
||||
FireflyConfig::shouldReceive('get')->withArgs(['4780_account_currencies', false])->andReturn($false);
|
||||
FireflyConfig::shouldReceive('set')->withArgs(['4780_account_currencies', true]);
|
||||
|
||||
// check preferences:
|
||||
Preferences::shouldReceive('getForUser')->withArgs([Mockery::any(), 'currencyPreference', 'EUR'])->andReturn($pref);
|
||||
|
||||
$this->artisan('firefly-iii:account-currencies')
|
||||
->expectsOutput('All accounts are OK.')
|
||||
->assertExitCode(0);
|
||||
// nothing changed, so nothing to verify.
|
||||
}
|
||||
|
||||
/**
|
||||
* @covers \FireflyIII\Console\Commands\Upgrade\AccountCurrencies
|
||||
*/
|
||||
public function testHandleInvalidPreference(): void
|
||||
{
|
||||
$false = new Configuration;
|
||||
$false->data = false;
|
||||
$pref = new Preference;
|
||||
$pref->data = 'ABC';
|
||||
$accountRepos = $this->mock(AccountRepositoryInterface::class);
|
||||
$userRepos = $this->mock(UserRepositoryInterface::class);
|
||||
$account = $this->getRandomAsset();
|
||||
|
||||
// mock calls
|
||||
$accountRepos->shouldReceive('setUser')->atLeast()->once();
|
||||
$accountRepos->shouldReceive('getAccountsByType')->atLeast()->once()->andReturn(new Collection([$account]));
|
||||
$userRepos->shouldReceive('all')->atLeast()->once()->andReturn(new Collection([$this->user()]));
|
||||
|
||||
// check config
|
||||
FireflyConfig::shouldReceive('get')->withArgs(['4780_account_currencies', false])->andReturn($false);
|
||||
FireflyConfig::shouldReceive('set')->withArgs(['4780_account_currencies', true]);
|
||||
|
||||
// check preferences:
|
||||
Preferences::shouldReceive('getForUser')->withArgs([Mockery::any(), 'currencyPreference', 'EUR'])->andReturn($pref);
|
||||
|
||||
$this->artisan('firefly-iii:account-currencies')
|
||||
->expectsOutput('User has a preference for "ABC", but this currency does not exist.')
|
||||
->assertExitCode(0);
|
||||
|
||||
// nothing changed, so nothing to verify.
|
||||
}
|
||||
|
||||
/**
|
||||
* @covers \FireflyIII\Console\Commands\Upgrade\AccountCurrencies
|
||||
*/
|
||||
public function testHandleAlreadyExecuted(): void
|
||||
{
|
||||
$true = new Configuration;
|
||||
$true->data = true;
|
||||
$pref = new Preference;
|
||||
$pref->data = 'EUR';
|
||||
$this->mock(AccountRepositoryInterface::class);
|
||||
$this->mock(UserRepositoryInterface::class);
|
||||
|
||||
// check config
|
||||
FireflyConfig::shouldReceive('get')->withArgs(['4780_account_currencies', false])->andReturn($true);
|
||||
FireflyConfig::shouldReceive('set')->withArgs(['4780_account_currencies', true]);
|
||||
|
||||
// check preferences:
|
||||
Preferences::shouldReceive('getForUser')->withArgs([Mockery::any(), 'currencyPreference', 'EUR'])->andReturn($pref);
|
||||
|
||||
$this->artisan('firefly-iii:account-currencies')
|
||||
->expectsOutput('This command has already been executed.')
|
||||
->assertExitCode(0);
|
||||
// nothing changed, so nothing to verify.
|
||||
}
|
||||
}
|
||||
244
tests/Unit/Console/Commands/Upgrade/BackToJournalsTest.php
Normal file
244
tests/Unit/Console/Commands/Upgrade/BackToJournalsTest.php
Normal file
@@ -0,0 +1,244 @@
|
||||
<?php
|
||||
/**
|
||||
* BackToJournalsTest.php
|
||||
* Copyright (c) 2019 thegrumpydictator@gmail.com
|
||||
*
|
||||
* This file is part of Firefly III.
|
||||
*
|
||||
* Firefly III is free software: you can redistribute it and/or modify
|
||||
* it under the terms of the GNU General Public License as published by
|
||||
* the Free Software Foundation, either version 3 of the License, or
|
||||
* (at your option) any later version.
|
||||
*
|
||||
* Firefly III is distributed in the hope that it will be useful,
|
||||
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||||
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||||
* GNU General Public License for more details.
|
||||
*
|
||||
* You should have received a copy of the GNU General Public License
|
||||
* along with Firefly III. If not, see <http://www.gnu.org/licenses/>.
|
||||
*/
|
||||
|
||||
namespace Tests\Unit\Console\Commands\Upgrade;
|
||||
|
||||
|
||||
use FireflyConfig;
|
||||
use FireflyIII\Models\Budget;
|
||||
use FireflyIII\Models\Category;
|
||||
use FireflyIII\Models\Configuration;
|
||||
use FireflyIII\Models\Transaction;
|
||||
use Log;
|
||||
use Tests\TestCase;
|
||||
|
||||
/**
|
||||
* Class BackToJournalsTest
|
||||
*/
|
||||
class BackToJournalsTest extends TestCase
|
||||
{
|
||||
/**
|
||||
*
|
||||
*/
|
||||
public function setUp(): void
|
||||
{
|
||||
parent::setUp();
|
||||
Log::info(sprintf('Now in %s.', get_class($this)));
|
||||
}
|
||||
|
||||
/**
|
||||
* Perfect run. Will report on nothing.
|
||||
*
|
||||
* @covers \FireflyIII\Console\Commands\Upgrade\BackToJournals
|
||||
*/
|
||||
public function testHandle(): void
|
||||
{
|
||||
// verify preference:
|
||||
$false = new Configuration;
|
||||
$false->data = false;
|
||||
$true = new Configuration;
|
||||
$true->data = true;
|
||||
FireflyConfig::shouldReceive('get')->withArgs(['4780_back_to_journals', false])->andReturn($false);
|
||||
FireflyConfig::shouldReceive('get')->withArgs(['4780_migrated_to_groups', false])->andReturn($true);
|
||||
|
||||
// set new preference after running:
|
||||
FireflyConfig::shouldReceive('set')->withArgs(['4780_back_to_journals', true]);
|
||||
|
||||
$this->artisan('firefly-iii:back-to-journals')
|
||||
->expectsOutput('Check 0 transaction journal(s) for budget info.')
|
||||
->expectsOutput('Check 0 transaction journal(s) for category info.')
|
||||
->assertExitCode(0);
|
||||
|
||||
}
|
||||
|
||||
/**
|
||||
* Transaction has a budget, journal doesn't.
|
||||
*
|
||||
* @covers \FireflyIII\Console\Commands\Upgrade\BackToJournals
|
||||
*/
|
||||
public function testHandleBudget(): void
|
||||
{
|
||||
$journal = $this->getRandomWithdrawal();
|
||||
/** @var Transaction $transaction */
|
||||
$transaction = $journal->transactions()->first();
|
||||
/** @var Budget $budget */
|
||||
$budget = $this->user()->budgets()->first();
|
||||
$transaction->budgets()->sync([$budget->id]);
|
||||
$journal->budgets()->sync([]);
|
||||
$journal->save();
|
||||
$transaction->save();
|
||||
|
||||
|
||||
// verify preference:
|
||||
$false = new Configuration;
|
||||
$false->data = false;
|
||||
$true = new Configuration;
|
||||
$true->data = true;
|
||||
FireflyConfig::shouldReceive('get')->withArgs(['4780_back_to_journals', false])->andReturn($false);
|
||||
FireflyConfig::shouldReceive('get')->withArgs(['4780_migrated_to_groups', false])->andReturn($true);
|
||||
|
||||
// set new preference after running:
|
||||
FireflyConfig::shouldReceive('set')->withArgs(['4780_back_to_journals', true]);
|
||||
|
||||
$this->artisan('firefly-iii:back-to-journals')
|
||||
->expectsOutput('Check 1 transaction journal(s) for budget info.')
|
||||
->expectsOutput('Check 0 transaction journal(s) for category info.')
|
||||
->assertExitCode(0);
|
||||
|
||||
// transaction should have no budget:
|
||||
$this->assertEquals(0, $transaction->budgets()->count());
|
||||
// journal should have one.
|
||||
$this->assertEquals(1, $journal->budgets()->count());
|
||||
// should be $budget:
|
||||
$this->assertEquals($budget->id, $journal->budgets()->first()->id);
|
||||
}
|
||||
|
||||
/**
|
||||
* Transaction has a category, journal doesn't.
|
||||
*
|
||||
* @covers \FireflyIII\Console\Commands\Upgrade\BackToJournals
|
||||
*/
|
||||
public function testHandleCategory(): void
|
||||
{
|
||||
$journal = $this->getRandomWithdrawal();
|
||||
/** @var Transaction $transaction */
|
||||
$transaction = $journal->transactions()->first();
|
||||
/** @var Category $category */
|
||||
$category = $this->user()->categories()->first();
|
||||
$transaction->categories()->sync([$category->id]);
|
||||
$journal->categories()->sync([]);
|
||||
$journal->save();
|
||||
$transaction->save();
|
||||
|
||||
// verify preference:
|
||||
$false = new Configuration;
|
||||
$false->data = false;
|
||||
$true = new Configuration;
|
||||
$true->data = true;
|
||||
|
||||
FireflyConfig::shouldReceive('get')->withArgs(['4780_back_to_journals', false])->andReturn($false);
|
||||
FireflyConfig::shouldReceive('get')->withArgs(['4780_migrated_to_groups', false])->andReturn($true);
|
||||
|
||||
// set new preference after running:
|
||||
FireflyConfig::shouldReceive('set')->withArgs(['4780_back_to_journals', true]);
|
||||
|
||||
$this->artisan('firefly-iii:back-to-journals')
|
||||
->expectsOutput('Check 0 transaction journal(s) for budget info.')
|
||||
->expectsOutput('Check 1 transaction journal(s) for category info.')
|
||||
->assertExitCode(0);
|
||||
|
||||
// transaction should have no category:
|
||||
$this->assertEquals(0, $transaction->categories()->count());
|
||||
// journal should have one.
|
||||
$this->assertEquals(1, $journal->categories()->count());
|
||||
// should be $category:
|
||||
$this->assertEquals($category->id, $journal->categories()->first()->id);
|
||||
}
|
||||
|
||||
/**
|
||||
* Transaction has a budget, journal has another
|
||||
*
|
||||
* @covers \FireflyIII\Console\Commands\Upgrade\BackToJournals
|
||||
*/
|
||||
public function testHandleDifferentBudget(): void
|
||||
{
|
||||
$journal = $this->getRandomWithdrawal();
|
||||
/** @var Transaction $transaction */
|
||||
$transaction = $journal->transactions()->first();
|
||||
/** @var Budget $budget */
|
||||
$budget = $this->user()->budgets()->first();
|
||||
$otherBudget = $this->user()->budgets()->where('id', '!=', $budget->id)->first();
|
||||
$transaction->budgets()->sync([$budget->id]);
|
||||
$journal->budgets()->sync([$otherBudget->id]);
|
||||
$journal->save();
|
||||
$transaction->save();
|
||||
|
||||
|
||||
// verify preference:
|
||||
$false = new Configuration;
|
||||
$false->data = false;
|
||||
$true = new Configuration;
|
||||
$true->data = true;
|
||||
FireflyConfig::shouldReceive('get')->withArgs(['4780_back_to_journals', false])->andReturn($false);
|
||||
FireflyConfig::shouldReceive('get')->withArgs(['4780_migrated_to_groups', false])->andReturn($true);
|
||||
|
||||
// set new preference after running:
|
||||
FireflyConfig::shouldReceive('set')->withArgs(['4780_back_to_journals', true]);
|
||||
|
||||
$this->artisan('firefly-iii:back-to-journals')
|
||||
->expectsOutput('Check 1 transaction journal(s) for budget info.')
|
||||
->expectsOutput('Check 0 transaction journal(s) for category info.')
|
||||
->assertExitCode(0);
|
||||
|
||||
// transaction should have no budget:
|
||||
$this->assertEquals(0, $transaction->budgets()->count());
|
||||
// journal should have one.
|
||||
$this->assertEquals(1, $journal->budgets()->count());
|
||||
// should be $budget:
|
||||
$this->assertEquals($budget->id, $journal->budgets()->first()->id);
|
||||
|
||||
}
|
||||
|
||||
|
||||
/**
|
||||
* Transaction has a category, journal has another
|
||||
*
|
||||
* @covers \FireflyIII\Console\Commands\Upgrade\BackToJournals
|
||||
*/
|
||||
public function testHandleDifferentCategory(): void
|
||||
{
|
||||
$journal = $this->getRandomWithdrawal();
|
||||
/** @var Transaction $transaction */
|
||||
$transaction = $journal->transactions()->first();
|
||||
/** @var Category $category */
|
||||
$category = $this->user()->categories()->first();
|
||||
$otherCategory = $this->user()->categories()->where('id', '!=', $category->id)->first();
|
||||
$transaction->categories()->sync([$category->id]);
|
||||
$journal->categories()->sync([$otherCategory->id]);
|
||||
$journal->save();
|
||||
$transaction->save();
|
||||
|
||||
// verify preference:
|
||||
$false = new Configuration;
|
||||
$false->data = false;
|
||||
$true = new Configuration;
|
||||
$true->data = true;
|
||||
FireflyConfig::shouldReceive('get')->withArgs(['4780_back_to_journals', false])->andReturn($false);
|
||||
FireflyConfig::shouldReceive('get')->withArgs(['4780_migrated_to_groups', false])->andReturn($true);
|
||||
|
||||
// set new preference after running:
|
||||
FireflyConfig::shouldReceive('set')->withArgs(['4780_back_to_journals', true]);
|
||||
|
||||
$this->artisan('firefly-iii:back-to-journals')
|
||||
->expectsOutput('Check 0 transaction journal(s) for budget info.')
|
||||
->expectsOutput('Check 1 transaction journal(s) for category info.')
|
||||
->assertExitCode(0);
|
||||
|
||||
// transaction should have no category:
|
||||
$this->assertEquals(0, $transaction->categories()->count());
|
||||
// journal should have one.
|
||||
$this->assertEquals(1, $journal->categories()->count());
|
||||
// should be $category:
|
||||
$this->assertEquals($category->id, $journal->categories()->first()->id);
|
||||
|
||||
}
|
||||
|
||||
}
|
||||
@@ -0,0 +1,85 @@
|
||||
<?php
|
||||
/**
|
||||
* BudgetLimitCurrencyTest.php
|
||||
* Copyright (c) 2019 thegrumpydictator@gmail.com
|
||||
*
|
||||
* This file is part of Firefly III.
|
||||
*
|
||||
* Firefly III is free software: you can redistribute it and/or modify
|
||||
* it under the terms of the GNU General Public License as published by
|
||||
* the Free Software Foundation, either version 3 of the License, or
|
||||
* (at your option) any later version.
|
||||
*
|
||||
* Firefly III is distributed in the hope that it will be useful,
|
||||
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||||
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||||
* GNU General Public License for more details.
|
||||
*
|
||||
* You should have received a copy of the GNU General Public License
|
||||
* along with Firefly III. If not, see <http://www.gnu.org/licenses/>.
|
||||
*/
|
||||
|
||||
namespace Tests\Unit\Console\Commands\Upgrade;
|
||||
|
||||
|
||||
use FireflyConfig;
|
||||
use FireflyIII\Models\BudgetLimit;
|
||||
use FireflyIII\Models\Configuration;
|
||||
use Log;
|
||||
use Tests\TestCase;
|
||||
|
||||
/**
|
||||
* Class BudgetLimitCurrencyTest
|
||||
*/
|
||||
class BudgetLimitCurrencyTest extends TestCase
|
||||
{
|
||||
/**
|
||||
*
|
||||
*/
|
||||
public function setUp(): void
|
||||
{
|
||||
parent::setUp();
|
||||
Log::info(sprintf('Now in %s.', get_class($this)));
|
||||
}
|
||||
|
||||
/**
|
||||
* @covers \FireflyIII\Console\Commands\Upgrade\BudgetLimitCurrency
|
||||
*/
|
||||
public function testHandle(): void
|
||||
{
|
||||
$this->artisan('firefly-iii:bl-currency')
|
||||
->assertExitCode(0);
|
||||
}
|
||||
|
||||
/**
|
||||
* Create a bad budget limit.
|
||||
* @covers \FireflyIII\Console\Commands\Upgrade\BudgetLimitCurrency
|
||||
*/
|
||||
public function testHandleBadLimit(): void
|
||||
{
|
||||
$false = new Configuration;
|
||||
$false->data = false;
|
||||
$budget = $this->user()->budgets()->first();
|
||||
$limit = BudgetLimit::create(
|
||||
[
|
||||
'budget_id' => $budget->id,
|
||||
'amount' => '10',
|
||||
'start_date' => '2019-01-01',
|
||||
'end_date' => '2019-01-31',
|
||||
]);
|
||||
|
||||
FireflyConfig::shouldReceive('get')->withArgs(['4780_bl_currency', false])->andReturn($false);
|
||||
FireflyConfig::shouldReceive('set')->withArgs(['4780_bl_currency', true]);
|
||||
|
||||
$this->artisan('firefly-iii:bl-currency')
|
||||
->expectsOutput(
|
||||
sprintf('Budget limit #%d (part of budget "%s") now has a currency setting (%s).',
|
||||
$limit->id, $budget->name, 'Euro'
|
||||
)
|
||||
)
|
||||
->assertExitCode(0);
|
||||
|
||||
// assume currency is filled in.
|
||||
$this->assertCount(1, BudgetLimit::where('id', $limit->id)->where('transaction_currency_id', 1)->get());
|
||||
}
|
||||
}
|
||||
129
tests/Unit/Console/Commands/Upgrade/CCLiabilitiesTest.php
Normal file
129
tests/Unit/Console/Commands/Upgrade/CCLiabilitiesTest.php
Normal file
@@ -0,0 +1,129 @@
|
||||
<?php
|
||||
/**
|
||||
* CCLiabilitiesTest.php
|
||||
* Copyright (c) 2019 thegrumpydictator@gmail.com
|
||||
*
|
||||
* This file is part of Firefly III.
|
||||
*
|
||||
* Firefly III is free software: you can redistribute it and/or modify
|
||||
* it under the terms of the GNU General Public License as published by
|
||||
* the Free Software Foundation, either version 3 of the License, or
|
||||
* (at your option) any later version.
|
||||
*
|
||||
* Firefly III is distributed in the hope that it will be useful,
|
||||
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||||
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||||
* GNU General Public License for more details.
|
||||
*
|
||||
* You should have received a copy of the GNU General Public License
|
||||
* along with Firefly III. If not, see <http://www.gnu.org/licenses/>.
|
||||
*/
|
||||
|
||||
namespace Tests\Unit\Console\Commands\Upgrade;
|
||||
|
||||
|
||||
use FireflyConfig;
|
||||
use FireflyIII\Models\Account;
|
||||
use FireflyIII\Models\AccountType;
|
||||
use FireflyIII\Models\Configuration;
|
||||
use Log;
|
||||
use Tests\TestCase;
|
||||
|
||||
/**
|
||||
* Class CCLiabilitiesTest
|
||||
*/
|
||||
class CCLiabilitiesTest extends TestCase
|
||||
{
|
||||
/**
|
||||
*
|
||||
*/
|
||||
public function setUp(): void
|
||||
{
|
||||
parent::setUp();
|
||||
Log::info(sprintf('Now in %s.', get_class($this)));
|
||||
}
|
||||
|
||||
/**
|
||||
* @covers \FireflyIII\Console\Commands\Upgrade\CCLiabilities
|
||||
*/
|
||||
public function testHandle(): void
|
||||
{
|
||||
$false = new Configuration;
|
||||
$false->data = false;
|
||||
FireflyConfig::shouldReceive('get')->withArgs(['4780_cc_liabilities', false])->andReturn($false);
|
||||
FireflyConfig::shouldReceive('set')->withArgs(['4780_cc_liabilities', true]);
|
||||
|
||||
|
||||
$this->artisan('firefly-iii:cc-liabilities')
|
||||
->expectsOutput('No incorrectly stored credit card liabilities.')
|
||||
->assertExitCode(0);
|
||||
|
||||
// nothing changed, so nothing to verify.
|
||||
}
|
||||
|
||||
/**
|
||||
* Add type to make the script run.
|
||||
*
|
||||
* @covers \FireflyIII\Console\Commands\Upgrade\CCLiabilities
|
||||
*/
|
||||
public function testHandleEmpty(): void
|
||||
{
|
||||
$type = AccountType::create(
|
||||
[
|
||||
'type' => AccountType::CREDITCARD,
|
||||
]
|
||||
);
|
||||
$false = new Configuration;
|
||||
$false->data = false;
|
||||
FireflyConfig::shouldReceive('get')->withArgs(['4780_cc_liabilities', false])->andReturn($false);
|
||||
FireflyConfig::shouldReceive('set')->withArgs(['4780_cc_liabilities', true]);
|
||||
|
||||
|
||||
$this->artisan('firefly-iii:cc-liabilities')
|
||||
->expectsOutput('No incorrectly stored credit card liabilities.')
|
||||
->assertExitCode(0);
|
||||
$type->forceDelete();
|
||||
// nothing changed, so nothing to verify.
|
||||
}
|
||||
|
||||
/**
|
||||
* Add some things to make it trigger.
|
||||
*
|
||||
* @covers \FireflyIII\Console\Commands\Upgrade\CCLiabilities
|
||||
*/
|
||||
public function testHandleCase(): void
|
||||
{
|
||||
$type = AccountType::create(
|
||||
[
|
||||
'type' => AccountType::CREDITCARD,
|
||||
]
|
||||
);
|
||||
|
||||
$account = Account::create(
|
||||
[
|
||||
'name' => 'CC',
|
||||
'user_id' => 1,
|
||||
'account_type_id' => $type->id,
|
||||
|
||||
]
|
||||
);
|
||||
|
||||
$false = new Configuration;
|
||||
$false->data = false;
|
||||
FireflyConfig::shouldReceive('get')->withArgs(['4780_cc_liabilities', false])->andReturn($false);
|
||||
FireflyConfig::shouldReceive('set')->withArgs(['4780_cc_liabilities', true]);
|
||||
|
||||
|
||||
$this->artisan('firefly-iii:cc-liabilities')
|
||||
->expectsOutput(sprintf('Converted credit card liability account "%s" (#%d) to generic debt liability.', $account->name, $account->id))
|
||||
->expectsOutput('Credit card liability types are no longer supported and have been converted to generic debts. See: http://bit.ly/FF3-credit-cards')
|
||||
->assertExitCode(0);
|
||||
|
||||
// verify new type.
|
||||
$this->assertCount(0, Account::where('id', $account->id)->where('account_type_id', $type->id)->get());
|
||||
|
||||
$account->forceDelete();
|
||||
$type->forceDelete();
|
||||
|
||||
}
|
||||
}
|
||||
354
tests/Unit/Console/Commands/Upgrade/JournalCurrenciesTest.php
Normal file
354
tests/Unit/Console/Commands/Upgrade/JournalCurrenciesTest.php
Normal file
@@ -0,0 +1,354 @@
|
||||
<?php
|
||||
/**
|
||||
* JournalCurrenciesTest.php
|
||||
* Copyright (c) 2019 thegrumpydictator@gmail.com
|
||||
*
|
||||
* This file is part of Firefly III.
|
||||
*
|
||||
* Firefly III is free software: you can redistribute it and/or modify
|
||||
* it under the terms of the GNU General Public License as published by
|
||||
* the Free Software Foundation, either version 3 of the License, or
|
||||
* (at your option) any later version.
|
||||
*
|
||||
* Firefly III is distributed in the hope that it will be useful,
|
||||
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||||
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||||
* GNU General Public License for more details.
|
||||
*
|
||||
* You should have received a copy of the GNU General Public License
|
||||
* along with Firefly III. If not, see <http://www.gnu.org/licenses/>.
|
||||
*/
|
||||
|
||||
namespace Tests\Unit\Console\Commands\Upgrade;
|
||||
|
||||
|
||||
use FireflyConfig;
|
||||
use FireflyIII\Models\Account;
|
||||
use FireflyIII\Models\Configuration;
|
||||
use FireflyIII\Models\Transaction;
|
||||
use FireflyIII\Models\TransactionCurrency;
|
||||
use FireflyIII\Models\TransactionType;
|
||||
use FireflyIII\Repositories\Account\AccountRepositoryInterface;
|
||||
use FireflyIII\Repositories\Currency\CurrencyRepositoryInterface;
|
||||
use FireflyIII\Repositories\Journal\JournalRepositoryInterface;
|
||||
use Illuminate\Support\Collection;
|
||||
use Log;
|
||||
use Mockery;
|
||||
use Tests\TestCase;
|
||||
|
||||
/**
|
||||
* Class JournalCurrenciesTest
|
||||
*/
|
||||
class JournalCurrenciesTest extends TestCase
|
||||
{
|
||||
/**
|
||||
*
|
||||
*/
|
||||
public function setUp(): void
|
||||
{
|
||||
parent::setUp();
|
||||
Log::info(sprintf('Now in %s.', get_class($this)));
|
||||
}
|
||||
|
||||
/**
|
||||
* Basic run. Would not change anything.
|
||||
*
|
||||
* @covers \FireflyIII\Console\Commands\Upgrade\JournalCurrencies
|
||||
*/
|
||||
public function testHandle(): void
|
||||
{
|
||||
// mock classes
|
||||
$accountRepos = $this->mock(AccountRepositoryInterface::class);
|
||||
$currencyRepos = $this->mock(CurrencyRepositoryInterface::class);
|
||||
$journalRepos = $this->mock(JournalRepositoryInterface::class);
|
||||
$euro = TransactionCurrency::find(1);
|
||||
|
||||
// update transfer if necessary for the test:
|
||||
$false = new Configuration;
|
||||
$false->data = false;
|
||||
FireflyConfig::shouldReceive('get')->withArgs(['4780_journal_currencies', false])->andReturn($false);
|
||||
FireflyConfig::shouldReceive('set')->withArgs(['4780_journal_currencies', true]);
|
||||
|
||||
// mock stuff
|
||||
$journalRepos->shouldReceive('getAllJournals')->atLeast()->once()
|
||||
->withArgs([[TransactionType::TRANSFER]])
|
||||
->andReturn(new Collection);
|
||||
|
||||
// for the "other journals" check, return nothing.
|
||||
$journalRepos->shouldReceive('getAllJournals')->atLeast()->once()
|
||||
->withArgs([[TransactionType::WITHDRAWAL, TransactionType::DEPOSIT, TransactionType::OPENING_BALANCE, TransactionType::RECONCILIATION,]])
|
||||
->andReturn(new Collection);
|
||||
|
||||
// transaction would be verified, nothing more.
|
||||
$this->artisan('firefly-iii:journal-currencies')
|
||||
->expectsOutput('All transactions are correct.')
|
||||
->assertExitCode(0);
|
||||
// nothing changed, so no verification.
|
||||
|
||||
}
|
||||
|
||||
/**
|
||||
* Submit a single transfer which has no issues.
|
||||
*
|
||||
* @covers \FireflyIII\Console\Commands\Upgrade\JournalCurrencies
|
||||
*/
|
||||
public function testHandleTransfer(): void
|
||||
{
|
||||
// mock classes
|
||||
$accountRepos = $this->mock(AccountRepositoryInterface::class);
|
||||
$currencyRepos = $this->mock(CurrencyRepositoryInterface::class);
|
||||
$journalRepos = $this->mock(JournalRepositoryInterface::class);
|
||||
$euro = TransactionCurrency::find(1);
|
||||
$transfer = $this->getRandomTransfer();
|
||||
|
||||
// update transfer if necessary for the test:
|
||||
$collection = new Collection([$transfer]);
|
||||
$false = new Configuration;
|
||||
$false->data = false;
|
||||
FireflyConfig::shouldReceive('get')->withArgs(['4780_journal_currencies', false])->andReturn($false);
|
||||
FireflyConfig::shouldReceive('set')->withArgs(['4780_journal_currencies', true]);
|
||||
|
||||
// mock stuff
|
||||
$accountRepos->shouldReceive('setUser')->atLeast()->once();
|
||||
$journalRepos->shouldReceive('setUser')->atLeast()->once();
|
||||
$currencyRepos->shouldReceive('setUser')->atLeast()->once();
|
||||
|
||||
// return single tranfer
|
||||
$journalRepos->shouldReceive('getAllJournals')->atLeast()->once()
|
||||
->withArgs([[TransactionType::TRANSFER]])
|
||||
->andReturn($collection);
|
||||
|
||||
// for the "other journals" check, return nothing.
|
||||
$journalRepos->shouldReceive('getAllJournals')->atLeast()->once()
|
||||
->withArgs([[TransactionType::WITHDRAWAL, TransactionType::DEPOSIT, TransactionType::OPENING_BALANCE, TransactionType::RECONCILIATION,]])
|
||||
->andReturn(new Collection);
|
||||
|
||||
$accountRepos->shouldReceive('getMetaValue')->atLeast()->once()->withArgs([Mockery::any(), 'currency_id'])->andReturn($euro->id);
|
||||
$currencyRepos->shouldReceive('findNull')->atLeast()->once()->andReturn($euro);
|
||||
|
||||
// transaction would be verified, nothing more.
|
||||
$this->artisan('firefly-iii:journal-currencies')
|
||||
->expectsOutput('Verified 1 transaction(s) and journal(s).')
|
||||
->assertExitCode(0);
|
||||
// nothing changed, so no verification.
|
||||
}
|
||||
|
||||
/**
|
||||
* Submit a single transfer where the source account has no currency preference.
|
||||
*
|
||||
* @covers \FireflyIII\Console\Commands\Upgrade\JournalCurrencies
|
||||
*/
|
||||
public function testHandleTransferSourceNoPref(): void
|
||||
{
|
||||
// mock classes
|
||||
$accountRepos = $this->mock(AccountRepositoryInterface::class);
|
||||
$currencyRepos = $this->mock(CurrencyRepositoryInterface::class);
|
||||
$journalRepos = $this->mock(JournalRepositoryInterface::class);
|
||||
$euro = TransactionCurrency::find(1);
|
||||
$transfer = $this->getRandomTransfer();
|
||||
|
||||
// edit source to remove currency preference:
|
||||
/** @var Account $source */
|
||||
$source = $transfer->transactions()->where('amount', '<', 0)->first()->account;
|
||||
// AccountMeta::where('account_id', $source->id)->where('name', 'currency_id')->delete();
|
||||
|
||||
// update transfer if necessary for the test:
|
||||
$collection = new Collection([$transfer]);
|
||||
$false = new Configuration;
|
||||
$false->data = false;
|
||||
FireflyConfig::shouldReceive('get')->withArgs(['4780_journal_currencies', false])->andReturn($false);
|
||||
FireflyConfig::shouldReceive('set')->withArgs(['4780_journal_currencies', true]);
|
||||
|
||||
// mock stuff
|
||||
$accountRepos->shouldReceive('setUser')->atLeast()->once();
|
||||
$journalRepos->shouldReceive('setUser')->atLeast()->once();
|
||||
$currencyRepos->shouldReceive('setUser')->atLeast()->once();
|
||||
|
||||
// return single transfer
|
||||
$journalRepos->shouldReceive('getAllJournals')->atLeast()->once()
|
||||
->withArgs([[TransactionType::TRANSFER]])
|
||||
->andReturn($collection);
|
||||
|
||||
// for the "other journals" check, return nothing.
|
||||
$journalRepos->shouldReceive('getAllJournals')->atLeast()->once()
|
||||
->withArgs([[TransactionType::WITHDRAWAL, TransactionType::DEPOSIT, TransactionType::OPENING_BALANCE, TransactionType::RECONCILIATION,]])
|
||||
->andReturn(new Collection);
|
||||
|
||||
// return NULL for first currency ID and currency.
|
||||
$accountRepos->shouldReceive('getMetaValue')->atLeast()->once()->withArgs([Mockery::any(), 'currency_id'])->andReturnNull();
|
||||
$currencyRepos->shouldReceive('findNull')->atLeast()->once()->andReturnNull();
|
||||
|
||||
// transaction would be verified, nothing more.
|
||||
$this->artisan('firefly-iii:journal-currencies')
|
||||
->expectsOutput(sprintf('Account #%d ("%s") must have currency preference but has none.', $source->id, $source->name))
|
||||
->assertExitCode(0);
|
||||
// nothing changed, so no verification.
|
||||
|
||||
}
|
||||
|
||||
/**
|
||||
* Submit a single transfer where the source transaction has no currency set.
|
||||
* Because this is not done over repositories, we must edit the DB.
|
||||
*
|
||||
* @covers \FireflyIII\Console\Commands\Upgrade\JournalCurrencies
|
||||
*/
|
||||
public function testHandleTransferSourceNoCurrency(): void
|
||||
{
|
||||
// mock classes
|
||||
$accountRepos = $this->mock(AccountRepositoryInterface::class);
|
||||
$currencyRepos = $this->mock(CurrencyRepositoryInterface::class);
|
||||
$journalRepos = $this->mock(JournalRepositoryInterface::class);
|
||||
$euro = TransactionCurrency::find(1);
|
||||
$transfer = $this->getRandomTransfer();
|
||||
/** @var Transaction $source */
|
||||
$source = $transfer->transactions()->where('amount', '<', 0)->first();
|
||||
$source->transaction_currency_id = null;
|
||||
$source->save();
|
||||
|
||||
// update transfer if necessary for the test:
|
||||
$collection = new Collection([$transfer]);
|
||||
$false = new Configuration;
|
||||
$false->data = false;
|
||||
FireflyConfig::shouldReceive('get')->withArgs(['4780_journal_currencies', false])->andReturn($false);
|
||||
FireflyConfig::shouldReceive('set')->withArgs(['4780_journal_currencies', true]);
|
||||
|
||||
// mock stuff
|
||||
$accountRepos->shouldReceive('setUser')->atLeast()->once();
|
||||
$journalRepos->shouldReceive('setUser')->atLeast()->once();
|
||||
$currencyRepos->shouldReceive('setUser')->atLeast()->once();
|
||||
|
||||
// return single tranfer
|
||||
$journalRepos->shouldReceive('getAllJournals')->atLeast()->once()
|
||||
->withArgs([[TransactionType::TRANSFER]])
|
||||
->andReturn($collection);
|
||||
|
||||
// for the "other journals" check, return nothing.
|
||||
$journalRepos->shouldReceive('getAllJournals')->atLeast()->once()
|
||||
->withArgs([[TransactionType::WITHDRAWAL, TransactionType::DEPOSIT, TransactionType::OPENING_BALANCE, TransactionType::RECONCILIATION,]])
|
||||
->andReturn(new Collection);
|
||||
|
||||
$accountRepos->shouldReceive('getMetaValue')->atLeast()->once()->withArgs([Mockery::any(), 'currency_id'])->andReturn($euro->id);
|
||||
$currencyRepos->shouldReceive('findNull')->atLeast()->once()->andReturn($euro);
|
||||
|
||||
// transaction would be verified, nothing more.
|
||||
$this->artisan('firefly-iii:journal-currencies')
|
||||
->expectsOutput(sprintf('Transaction #%d has no currency setting, now set to %s.', $source->id, $euro->code))
|
||||
->expectsOutput('Verified 2 transaction(s) and journal(s).')
|
||||
->assertExitCode(0);
|
||||
|
||||
// check transaction
|
||||
$this->assertCount(1, Transaction::where('id', $source->id)->where('transaction_currency_id', $euro->id)->get());
|
||||
}
|
||||
|
||||
/**
|
||||
* Submit a single transfer where the source transaction has a different currency than the source account does.
|
||||
*
|
||||
* @covers \FireflyIII\Console\Commands\Upgrade\JournalCurrencies
|
||||
*/
|
||||
public function testHandleMismatchedTransfer(): void
|
||||
{
|
||||
// mock classes
|
||||
$accountRepos = $this->mock(AccountRepositoryInterface::class);
|
||||
$currencyRepos = $this->mock(CurrencyRepositoryInterface::class);
|
||||
$journalRepos = $this->mock(JournalRepositoryInterface::class);
|
||||
$euro = TransactionCurrency::find(1);
|
||||
$usd = TransactionCurrency::where('code', 'USD')->first();
|
||||
$transfer = $this->getRandomTransfer();
|
||||
|
||||
/** @var Transaction $source */
|
||||
$source = $transfer->transactions()->where('amount', '<', 0)->first();
|
||||
$source->transaction_currency_id = $usd->id;
|
||||
$source->save();
|
||||
|
||||
// update transfer if necessary for the test:
|
||||
$collection = new Collection([$transfer]);
|
||||
$false = new Configuration;
|
||||
$false->data = false;
|
||||
FireflyConfig::shouldReceive('get')->withArgs(['4780_journal_currencies', false])->andReturn($false);
|
||||
FireflyConfig::shouldReceive('set')->withArgs(['4780_journal_currencies', true]);
|
||||
|
||||
// mock stuff
|
||||
$accountRepos->shouldReceive('setUser')->atLeast()->once();
|
||||
$journalRepos->shouldReceive('setUser')->atLeast()->once();
|
||||
$currencyRepos->shouldReceive('setUser')->atLeast()->once();
|
||||
|
||||
// return single tranfer
|
||||
$journalRepos->shouldReceive('getAllJournals')->atLeast()->once()
|
||||
->withArgs([[TransactionType::TRANSFER]])
|
||||
->andReturn($collection);
|
||||
|
||||
// for the "other journals" check, return nothing.
|
||||
$journalRepos->shouldReceive('getAllJournals')->atLeast()->once()
|
||||
->withArgs([[TransactionType::WITHDRAWAL, TransactionType::DEPOSIT, TransactionType::OPENING_BALANCE, TransactionType::RECONCILIATION,]])
|
||||
->andReturn(new Collection);
|
||||
|
||||
$accountRepos->shouldReceive('getMetaValue')->atLeast()->once()->withArgs([Mockery::any(), 'currency_id'])->andReturn($euro->id);
|
||||
$currencyRepos->shouldReceive('findNull')->atLeast()->once()->andReturn($euro);
|
||||
|
||||
// transaction would be verified, nothing more.
|
||||
$this->artisan('firefly-iii:journal-currencies')
|
||||
->expectsOutput(
|
||||
sprintf(
|
||||
'Transaction #%d has a currency setting #%d that should be #%d. Amount remains %s, currency is changed.',
|
||||
$source->id,
|
||||
$source->transaction_currency_id,
|
||||
$euro->id,
|
||||
$source->amount
|
||||
)
|
||||
)
|
||||
->expectsOutput('Verified 2 transaction(s) and journal(s).')
|
||||
->assertExitCode(0);
|
||||
// nothing changed, so no verification.
|
||||
}
|
||||
|
||||
/**
|
||||
* Submit a single transfer where the destination account has no currency preference.
|
||||
*
|
||||
* @covers \FireflyIII\Console\Commands\Upgrade\JournalCurrencies
|
||||
*/
|
||||
public function testHandleTransferNoDestinationCurrency(): void
|
||||
{
|
||||
// mock classes
|
||||
$accountRepos = $this->mock(AccountRepositoryInterface::class);
|
||||
$currencyRepos = $this->mock(CurrencyRepositoryInterface::class);
|
||||
$journalRepos = $this->mock(JournalRepositoryInterface::class);
|
||||
$euro = TransactionCurrency::find(1);
|
||||
$transfer = $this->getRandomTransfer();
|
||||
|
||||
/** @var Account $destination */
|
||||
$destination = $transfer->transactions()->where('amount', '>', 0)->first()->account;
|
||||
|
||||
// update transfer if necessary for the test:
|
||||
$collection = new Collection([$transfer]);
|
||||
$false = new Configuration;
|
||||
$false->data = false;
|
||||
FireflyConfig::shouldReceive('get')->withArgs(['4780_journal_currencies', false])->andReturn($false);
|
||||
FireflyConfig::shouldReceive('set')->withArgs(['4780_journal_currencies', true]);
|
||||
|
||||
// mock stuff
|
||||
$accountRepos->shouldReceive('setUser')->atLeast()->once();
|
||||
$journalRepos->shouldReceive('setUser')->atLeast()->once();
|
||||
$currencyRepos->shouldReceive('setUser')->atLeast()->once();
|
||||
|
||||
// return single tranfer
|
||||
$journalRepos->shouldReceive('getAllJournals')->atLeast()->once()
|
||||
->withArgs([[TransactionType::TRANSFER]])
|
||||
->andReturn($collection);
|
||||
|
||||
// for the "other journals" check, return nothing.
|
||||
$journalRepos->shouldReceive('getAllJournals')->atLeast()->once()
|
||||
->withArgs([[TransactionType::WITHDRAWAL, TransactionType::DEPOSIT, TransactionType::OPENING_BALANCE, TransactionType::RECONCILIATION,]])
|
||||
->andReturn(new Collection);
|
||||
|
||||
$accountRepos->shouldReceive('getMetaValue')->atLeast()->once()->withArgs([Mockery::any(), 'currency_id'])->andReturn($euro->id, 0);
|
||||
$currencyRepos->shouldReceive('findNull')->atLeast()->once()->andReturn($euro, null);
|
||||
|
||||
// transaction would be verified, nothing more.
|
||||
$this->artisan('firefly-iii:journal-currencies')
|
||||
->expectsOutput(sprintf('Account #%d ("%s") must have currency preference but has none.', $destination->id, $destination->name))
|
||||
->assertExitCode(0);
|
||||
// nothing changed, so no verification.
|
||||
}
|
||||
|
||||
|
||||
}
|
||||
Reference in New Issue
Block a user