kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-10-12 15:35:15 +00:00
Code Issues Projects Releases Wiki Activity

Fix some code quality issues

Browse Source
This commit is contained in:
James Cole
2023-02-12 08:07:08 +01:00
parent 1fd455dbab
commit 2ad2d53f88
6 changed files with 4 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/Helpers/Webhook/Sha3SignatureGenerator.php
View File

@@ -51,7 +51,7 @@ class Sha3SignatureGenerator implements SignatureGeneratorInterface
$json = json_encode($message->message, JSON_THROW_ON_ERROR); $json = json_encode($message->message, JSON_THROW_ON_ERROR);
} catch (JsonException $e) { } catch (JsonException $e) {
Log::error('Could not generate hash.'); Log::error('Could not generate hash.');
Log::error(sprintf('JSON value: %s', $message->message)); Log::error(sprintf('JSON value: %s', $json));
Log::error($e->getMessage()); Log::error($e->getMessage());
Log::error($e->getTraceAsString()); Log::error($e->getTraceAsString());
throw new FireflyException('Could not generate JSON for SHA3 hash.', 0, $e); throw new FireflyException('Could not generate JSON for SHA3 hash.', 0, $e);

5
app/Repositories/Journal/JournalCLIRepository.php
View File

@@ -36,9 +36,6 @@ use stdClass;
*/ */
class JournalCLIRepository implements JournalCLIRepositoryInterface class JournalCLIRepository implements JournalCLIRepositoryInterface
{ {
/** @var User */
private $user;
/** /**
* Get all transaction journals with a specific type, regardless of user. * Get all transaction journals with a specific type, regardless of user.
* *
@@ -234,6 +231,6 @@ class JournalCLIRepository implements JournalCLIRepositoryInterface
*/ */
public function setUser(User $user): void public function setUser(User $user): void
{ {
$this->user = $user; return;
} }
} }

2
app/Support/Chart/Budget/FrontpageChartGenerator.php
View File

@@ -44,7 +44,6 @@ class FrontpageChartGenerator
private Carbon $end; private Carbon $end;
private string $monthAndDayFormat; private string $monthAndDayFormat;
private Carbon $start; private Carbon $start;
private User $user;
/** /**
* FrontpageChartGenerator constructor. * FrontpageChartGenerator constructor.
@@ -226,7 +225,6 @@ class FrontpageChartGenerator
*/ */
public function setUser(User $user): void public function setUser(User $user): void
{ {
$this->user = $user;
$this->budgetRepository->setUser($user); $this->budgetRepository->setUser($user);
$this->blRepository->setUser($user); $this->blRepository->setUser($user);
$this->opsRepository->setUser($user); $this->opsRepository->setUser($user);

10
app/Support/Search/OperatorQuerySearch.php
View File

@@ -69,7 +69,6 @@ class OperatorQuerySearch implements SearchInterface
private CategoryRepositoryInterface $categoryRepository; private CategoryRepositoryInterface $categoryRepository;
private GroupCollectorInterface $collector; private GroupCollectorInterface $collector;
private CurrencyRepositoryInterface $currencyRepository; private CurrencyRepositoryInterface $currencyRepository;
private Carbon $date;
private array $invalidOperators; private array $invalidOperators;
private int $limit; private int $limit;
private Collection $operators; private Collection $operators;
@@ -94,7 +93,6 @@ class OperatorQuerySearch implements SearchInterface
$this->prohibitedWords = []; $this->prohibitedWords = [];
$this->invalidOperators = []; $this->invalidOperators = [];
$this->limit = 25; $this->limit = 25;
$this->date = today(config('app.timezone'));
$this->validOperators = array_keys(config('search.operators')); $this->validOperators = array_keys(config('search.operators'));
$this->startTime = microtime(true); $this->startTime = microtime(true);
$this->accountRepository = app(AccountRepositoryInterface::class); $this->accountRepository = app(AccountRepositoryInterface::class);
@@ -2019,14 +2017,6 @@ class OperatorQuerySearch implements SearchInterface
return $this->words; return $this->words;
} }
/**
* @param Carbon $date
*/
public function setDate(Carbon $date): void
{
$this->date = $date;
}
/** /**
* @inheritDoc * @inheritDoc

2
public/v1/lib/adminlte/css/AdminLTE.css vendored
View File

@@ -1806,7 +1806,7 @@ a:focus {
left: auto; left: auto;
} }
.box-header > .box-tools .dropdown-menu > li > a { .box-header > .box-tools .dropdown-menu > li > a {
color: #444 !important; color: #444;
} }
.btn-box-tool { .btn-box-tool {
padding: 5px; padding: 5px;

2
public/v1/lib/adminlte/css/AdminLTE.min.css vendored
View File

File diff suppressed because one or more lines are too long