kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-10-19 10:53:31 +00:00
Code Issues Projects Releases Wiki Activity

Fix phpstan level 3!

Browse Source
This commit is contained in:
James Cole
2025-01-04 07:10:37 +01:00
parent cd296aa9ac
commit 2baac1a6d7
52 changed files with 113 additions and 113 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
app/Services/Internal/Update/BillUpdateService.php
View File

@@ -250,6 +250,7 @@ class BillUpdateService
private function getRuleTrigger(Rule $rule, string $key): ?RuleTrigger
{
/** @var RuleTrigger|null */
return $rule->ruleTriggers()->where('trigger_type', $key)->first();
}
}

12
app/Services/Internal/Update/JournalUpdateService.php
View File

@@ -238,11 +238,9 @@ class JournalUpdateService
private function getSourceTransaction(): Transaction
{
if (null === $this->sourceTransaction) {
$this->sourceTransaction = $this->transactionJournal->transactions()->with(['account'])->where(
'amount',
'<',
0
)->first();
/** @var Transaction|null $result */
$result = $this->transactionJournal->transactions()->with(['account'])->where('amount', '<', 0)->first();
$this->sourceTransaction = $result;
}
Log::debug(sprintf('getSourceTransaction: %s', $this->sourceTransaction->amount));
@@ -321,7 +319,9 @@ class JournalUpdateService
private function getDestinationTransaction(): Transaction
{
if (null === $this->destinationTransaction) {
$this->destinationTransaction = $this->transactionJournal->transactions()->where('amount', '>', 0)->first();
/** @var Transaction|null $result */
$result = $this->transactionJournal->transactions()->where('amount', '>', 0)->first();
$this->destinationTransaction = $result;
}
return $this->destinationTransaction;