More phpstan issues fixed.

app/Console/Commands/Correction/CorrectionSkeleton.php.stub

@@ -10,17 +10,8 @@ use Illuminate\Console\Command;
  */
 class CorrectionSkeleton extends Command
 {
-    /**
-     * The console command description.
-     *
-     * @var string
-     */
     protected $description = 'DESCRIPTION HERE';
-    /**
-     * The name and signature of the console command.
-     *
-     * @var string
-     */
+
     protected $signature = 'firefly-iii:CORR_COMMAND';
 
     /**

app/Console/Commands/Correction/CreateAccessTokens.php

@@ -36,17 +36,8 @@ class CreateAccessTokens extends Command
 {
     use ShowsFriendlyMessages;
 
-    /**
-     * The console command description.
-     *
-     * @var string
-     */
     protected $description = 'Creates user access tokens which are used for command line access to personal data.';
-    /**
-     * The name and signature of the console command.
-     *
-     * @var string
-     */
+
     protected $signature = 'firefly-iii:create-access-tokens';
 
     /**

app/Console/Commands/Correction/CreateLinkTypes.php

@@ -34,17 +34,8 @@ class CreateLinkTypes extends Command
 {
     use ShowsFriendlyMessages;
 
-    /**
-     * The console command description.
-     *
-     * @var string
-     */
     protected $description = 'Creates all link types.';
-    /**
-     * The name and signature of the console command.
-     *
-     * @var string
-     */
+
     protected $signature = 'firefly-iii:create-link-types';
 
     /**

app/Console/Commands/Correction/DeleteEmptyJournals.php

@@ -37,17 +37,8 @@ class DeleteEmptyJournals extends Command
 {
     use ShowsFriendlyMessages;
 
-    /**
-     * The console command description.
-     *
-     * @var string
-     */
     protected $description = 'Delete empty and uneven transaction journals.';
-    /**
-     * The name and signature of the console command.
-     *
-     * @var string
-     */
+
     protected $signature = 'firefly-iii:delete-empty-journals';
 
     /**

app/Console/Commands/Correction/DeleteOrphanedTransactions.php

@@ -37,17 +37,8 @@ class DeleteOrphanedTransactions extends Command
 {
     use ShowsFriendlyMessages;
 
-    /**
-     * The console command description.
-     *
-     * @var string
-     */
     protected $description = 'Deletes orphaned transactions.';
-    /**
-     * The name and signature of the console command.
-     *
-     * @var string
-     */
+
     protected $signature = 'firefly-iii:delete-orphaned-transactions';
 
     /**

app/Console/Commands/Correction/DeleteZeroAmount.php

@@ -35,17 +35,8 @@ class DeleteZeroAmount extends Command
 {
     use ShowsFriendlyMessages;
 
-    /**
-     * The console command description.
-     *
-     * @var string
-     */
     protected $description = 'Delete transactions with zero amount.';
-    /**
-     * The name and signature of the console command.
-     *
-     * @var string
-     */
+
     protected $signature = 'firefly-iii:delete-zero-amount';
 
     /**

app/Console/Commands/Export/ExportData.php

@@ -48,17 +48,9 @@ class ExportData extends Command
     use ShowsFriendlyMessages;
     use VerifiesAccessToken;
 
-    /**
-     * The console command description.
-     *
-     * @var string
-     */
+
     protected $description = 'Command to export data from Firefly III.';
-    /**
-     * The name and signature of the console command.
-     *
-     * @var string
-     */
+
     protected $signature = 'firefly-iii:export-data
     {--user=1 : The user ID that the export should run for.}
     {--token= : The user\'s access token.}

app/Console/Commands/Integrity/ReportEmptyObjects.php

@@ -38,17 +38,9 @@ class ReportEmptyObjects extends Command
 {
     use ShowsFriendlyMessages;
 
-    /**
-     * The console command description.
-     *
-     * @var string
-     */
+
     protected $description = 'Reports on empty database objects.';
-    /**
-     * The name and signature of the console command.
-     *
-     * @var string
-     */
+
     protected $signature = 'firefly-iii:report-empty-objects';
 
     /**

app/Console/Commands/Integrity/ReportIntegrity.php

@@ -36,17 +36,9 @@ class ReportIntegrity extends Command
 {
     use ShowsFriendlyMessages;
 
-    /**
-     * The console command description.
-     *
-     * @var string
-     */
+
     protected $description = 'Will report on the integrity of your database.';
-    /**
-     * The name and signature of the console command.
-     *
-     * @var string
-     */
+
     protected $signature = 'firefly-iii:report-integrity';
 
     /**

app/Console/Commands/Integrity/ReportSkeleton.php.stub

@@ -10,17 +10,9 @@ use Illuminate\Console\Command;
  */
 class ReportSkeleton extends Command
 {
-    /**
-     * The console command description.
-     *
-     * @var string
-     */
+
     protected $description = 'DESCRIPTION HERE';
-    /**
-     * The name and signature of the console command.
-     *
-     * @var string
-     */
+
     protected $signature = 'firefly-iii:INT_COMMAND';
 
     /**

app/Console/Commands/System/CreateDatabase.php

@@ -36,17 +36,9 @@ class CreateDatabase extends Command
 {
     use ShowsFriendlyMessages;
 
-    /**
-     * The console command description.
-     *
-     * @var string
-     */
+
     protected $description = 'Tries to create the database if it doesn\'t exist yet.';
-    /**
-     * The name and signature of the console command.
-     *
-     * @var string
-     */
+
     protected $signature = 'firefly-iii:create-database';
 
     /**

app/Console/Commands/System/CreateFirstUser.php

@@ -39,17 +39,9 @@ class CreateFirstUser extends Command
 {
     use ShowsFriendlyMessages;
 
-    /**
-     * The console command description.
-     *
-     * @var string
-     */
+
     protected $description = 'Creates a new user and gives admin rights. Outputs the password on the command line. Strictly for testing.';
-    /**
-     * The name and signature of the console command.
-     *
-     * @var string
-     */
+
     protected $signature = 'firefly-iii:create-first-user {email}';
     private UserRepositoryInterface $repository;
 

app/Console/Commands/System/ForceMigration.php

@@ -40,17 +40,9 @@ class ForceMigration extends Command
     use ShowsFriendlyMessages;
     use VerifiesAccessToken;
 
-    /**
-     * The console command description.
-     *
-     * @var string
-     */
+
     protected $description = 'This command will force-run all database migrations.';
-    /**
-     * The name and signature of the console command.
-     *
-     * @var string
-     */
+
     protected $signature = 'firefly-iii:force-migrations
                             {--user=1 : The user ID.}
                             {--token= : The user\'s access token.}';

app/Console/Commands/System/OutputVersion.php

@@ -32,17 +32,9 @@ use Illuminate\Console\Command;
  */
 class OutputVersion extends Command
 {
-    /**
-     * The console command description.
-     *
-     * @var string
-     */
+
     protected $description = 'Outputs the Firefly III version';
-    /**
-     * The name and signature of the console command.
-     *
-     * @var string
-     */
+
     protected $signature = 'firefly-iii:output-version';
 
     /**

app/Console/Commands/System/ScanAttachments.php

@@ -39,18 +39,10 @@ class ScanAttachments extends Command
 {
     use ShowsFriendlyMessages;
 
-    /**
-     * The console command description.
-     *
-     * @var string
-     */
+
     protected $description = 'Rescan all attachments and re-set the correct MD5 hash and mime.';
 
-    /**
-     * The name and signature of the console command.
-     *
-     * @var string
-     */
+
     protected $signature = 'firefly-iii:scan-attachments';
 
     /**

app/Console/Commands/System/SetLatestVersion.php

@@ -34,17 +34,9 @@ class SetLatestVersion extends Command
 {
     use ShowsFriendlyMessages;
 
-    /**
-     * The console command description.
-     *
-     * @var string
-     */
+
     protected $description = 'Set latest version in DB.';
-    /**
-     * The name and signature of the console command.
-     *
-     * @var string
-     */
+
     protected $signature = 'firefly-iii:set-latest-version {--james-is-cool}';
 
     /**

app/Console/Commands/System/UpgradeFireflyInstructions.php

@@ -35,17 +35,9 @@ class UpgradeFireflyInstructions extends Command
 {
     use GeneratesInstallationId;
 
-    /**
-     * The console command description.
-     *
-     * @var string
-     */
+
     protected $description = 'Instructions in case of upgrade trouble.';
-    /**
-     * The name and signature of the console command.
-     *
-     * @var string
-     */
+
     protected $signature = 'firefly:instructions {task}';
 
     /**

app/Console/Commands/System/VerifySecurityAlerts.php

@@ -39,17 +39,9 @@ class VerifySecurityAlerts extends Command
 {
     use ShowsFriendlyMessages;
 
-    /**
-     * The console command description.
-     *
-     * @var string
-     */
+
     protected $description = 'Verify security alerts';
-    /**
-     * The name and signature of the console command.
-     *
-     * @var string
-     */
+
     protected $signature = 'firefly-iii:verify-security-alerts';
 
     /**

app/Console/Commands/Tools/ApplyRules.php

@@ -46,17 +46,9 @@ class ApplyRules extends Command
     use ShowsFriendlyMessages;
     use VerifiesAccessToken;
 
-    /**
-     * The console command description.
-     *
-     * @var string
-     */
+
     protected $description = 'This command will apply your rules and rule groups on a selection of your transactions.';
-    /**
-     * The name and signature of the console command.
-     *
-     * @var string
-     */
+
     protected $signature
         = 'firefly-iii:apply-rules
                             {--user=1 : The user ID.}

app/Console/Commands/Tools/Cron.php

@@ -45,17 +45,9 @@ class Cron extends Command
 {
     use ShowsFriendlyMessages;
 
-    /**
-     * The console command description.
-     *
-     * @var string
-     */
+
     protected $description = 'Runs all Firefly III cron-job related commands. Configure a cron job according to the official Firefly III documentation.';
-    /**
-     * The name and signature of the console command.
-     *
-     * @var string
-     */
+
     protected $signature = 'firefly-iii:cron
         {--F|force : Force the cron job(s) to execute.}
         {--date= : Set the date in YYYY-MM-DD to make Firefly III think that\'s the current date.}

app/Console/Commands/Upgrade/AppendBudgetLimitPeriods.php

@@ -37,17 +37,9 @@ class AppendBudgetLimitPeriods extends Command
     use ShowsFriendlyMessages;
 
     public const CONFIG_NAME = '550_budget_limit_periods';
-    /**
-     * The console command description.
-     *
-     * @var string
-     */
+
     protected $description = 'Append budget limits with their (estimated) timeframe.';
-    /**
-     * The name and signature of the console command.
-     *
-     * @var string
-     */
+
     protected $signature = 'firefly-iii:budget-limit-periods {--F|force : Force the execution of this command.}';
 
     /**

app/Console/Commands/Upgrade/BackToJournals.php

@@ -42,17 +42,9 @@ class BackToJournals extends Command
     use ShowsFriendlyMessages;
 
     public const CONFIG_NAME = '480_back_to_journals';
-    /**
-     * The console command description.
-     *
-     * @var string
-     */
+
     protected $description = 'Move meta data back to journals, not individual transactions.';
-    /**
-     * The name and signature of the console command.
-     *
-     * @var string
-     */
+
     protected $signature = 'firefly-iii:back-to-journals {--F|force : Force the execution of this command.}';
 
     /**

app/Console/Commands/Upgrade/BudgetLimitCurrency.php

@@ -38,17 +38,9 @@ class BudgetLimitCurrency extends Command
     use ShowsFriendlyMessages;
 
     public const CONFIG_NAME = '480_bl_currency';
-    /**
-     * The console command description.
-     *
-     * @var string
-     */
+
     protected $description = 'Give budget limits a currency';
-    /**
-     * The name and signature of the console command.
-     *
-     * @var string
-     */
+
     protected $signature = 'firefly-iii:bl-currency {--F|force : Force the execution of this command.}';
 
     /**

app/Console/Commands/Upgrade/FixPostgresSequences.php

@@ -35,17 +35,9 @@ class FixPostgresSequences extends Command
 {
     use ShowsFriendlyMessages;
 
-    /**
-     * The console command description.
-     *
-     * @var string
-     */
+
     protected $description = 'Fixes issues with PostgreSQL sequences.';
-    /**
-     * The name and signature of the console command.
-     *
-     * @var string
-     */
+
     protected $signature = 'firefly-iii:fix-pgsql-sequences';
 
     /**

app/Console/Commands/Upgrade/MigrateAttachments.php

@@ -39,17 +39,9 @@ class MigrateAttachments extends Command
     use ShowsFriendlyMessages;
 
     public const CONFIG_NAME = '480_migrate_attachments';
-    /**
-     * The console command description.
-     *
-     * @var string
-     */
+
     protected $description = 'Migrates attachment meta-data.';
-    /**
-     * The name and signature of the console command.
-     *
-     * @var string
-     */
+
     protected $signature = 'firefly-iii:migrate-attachments {--F|force : Force the execution of this command.}';
 
     /**

app/Console/Commands/Upgrade/MigrateJournalNotes.php

@@ -38,17 +38,9 @@ class MigrateJournalNotes extends Command
     use ShowsFriendlyMessages;
 
     public const CONFIG_NAME = '480_migrate_notes';
-    /**
-     * The console command description.
-     *
-     * @var string
-     */
+
     protected $description = 'Migrate notes for transaction journals.';
-    /**
-     * The name and signature of the console command.
-     *
-     * @var string
-     */
+
     protected $signature = 'firefly-iii:migrate-notes {--F|force : Force the execution of this command.}';
 
     /**

app/Console/Commands/Upgrade/MigrateRecurrenceMeta.php

@@ -41,17 +41,9 @@ class MigrateRecurrenceMeta extends Command
     use ShowsFriendlyMessages;
 
     public const CONFIG_NAME = '481_migrate_recurrence_meta';
-    /**
-     * The console command description.
-     *
-     * @var string
-     */
+
     protected $description = 'Migrate recurrence meta data';
-    /**
-     * The name and signature of the console command.
-     *
-     * @var string
-     */
+
     protected $signature = 'firefly-iii:migrate-recurrence-meta {--F|force : Force the execution of this command.}';
 
     /**

app/Console/Commands/Upgrade/MigrateRecurrenceType.php

@@ -40,17 +40,9 @@ class MigrateRecurrenceType extends Command
     use ShowsFriendlyMessages;
 
     public const CONFIG_NAME = '550_migrate_recurrence_type';
-    /**
-     * The console command description.
-     *
-     * @var string
-     */
+
     protected $description = 'Migrate transaction type of recurring transaction.';
-    /**
-     * The name and signature of the console command.
-     *
-     * @var string
-     */
+
     protected $signature = 'firefly-iii:migrate-recurrence-type {--F|force : Force the execution of this command.}';
 
     /**

app/Console/Commands/Upgrade/MigrateTagLocations.php

@@ -39,17 +39,9 @@ class MigrateTagLocations extends Command
     use ShowsFriendlyMessages;
 
     public const CONFIG_NAME = '500_migrate_tag_locations';
-    /**
-     * The console command description.
-     *
-     * @var string
-     */
+
     protected $description = 'Migrate tag locations.';
-    /**
-     * The name and signature of the console command.
-     *
-     * @var string
-     */
+
     protected $signature = 'firefly-iii:migrate-tag-locations {--F|force : Force the execution of this command.}';
 
     /**

app/Console/Commands/Upgrade/MigrateToRules.php

@@ -45,17 +45,9 @@ class MigrateToRules extends Command
     use ShowsFriendlyMessages;
 
     public const CONFIG_NAME = '480_bills_to_rules';
-    /**
-     * The console command description.
-     *
-     * @var string
-     */
+
     protected $description = 'Migrate bills to rules.';
-    /**
-     * The name and signature of the console command.
-     *
-     * @var string
-     */
+
     protected $signature = 'firefly-iii:bills-to-rules {--F|force : Force the execution of this command.}';
     private BillRepositoryInterface      $billRepository;
     private int                          $count;

app/Console/Commands/Upgrade/RenameAccountMeta.php

@@ -38,17 +38,9 @@ class RenameAccountMeta extends Command
     use ShowsFriendlyMessages;
 
     public const CONFIG_NAME = '480_rename_account_meta';
-    /**
-     * The console command description.
-     *
-     * @var string
-     */
+
     protected $description = 'Rename account meta-data to new format.';
-    /**
-     * The name and signature of the console command.
-     *
-     * @var string
-     */
+
     protected $signature = 'firefly-iii:rename-account-meta {--F|force : Force the execution of this command.}';
 
     /**

app/Console/Commands/Upgrade/UpgradeCurrencyPreferences.php

@@ -41,17 +41,9 @@ class UpgradeCurrencyPreferences extends Command
     use ShowsFriendlyMessages;
 
     public const CONFIG_NAME = '610_upgrade_currency_prefs';
-    /**
-     * The console command description.
-     *
-     * @var string
-     */
+
     protected $description = 'Upgrade user currency preferences';
-    /**
-     * The name and signature of the console command.
-     *
-     * @var string
-     */
+
     protected $signature = 'firefly-iii:upgrade-currency-preferences {--F|force : Force the execution of this command.}';
 
     /**

app/Console/Commands/Upgrade/UpgradeSkeleton.php.stub

@@ -12,17 +12,9 @@ class UpgradeSkeleton extends Command
 {
     use ShowsFriendlyMessages;
     public const CONFIG_NAME = '480_some_name';
-    /**
-     * The console command description.
-     *
-     * @var string
-     */
+
     protected $description = 'SOME DESCRIPTION';
-    /**
-     * The name and signature of the console command.
-     *
-     * @var string
-     */
+
     protected $signature = 'firefly-iii:UPGRSKELETON {--F|force : Force the execution of this command.}';
 
     /**