Fix small errors in bulk and mass controller

This commit is contained in:
James Cole
2018-03-04 09:12:33 +01:00
parent 8b52006959
commit 2f17521c06
3 changed files with 69 additions and 48 deletions

View File

@@ -37,6 +37,28 @@ use FireflyIII\Models\TransactionJournal;
trait JournalServiceTrait
{
/**
* @param TransactionJournal $journal
* @param array $data
*/
public function connectTags(TransactionJournal $journal, array $data): void
{
/** @var TagFactory $factory */
$factory = app(TagFactory::class);
$factory->setUser($journal->user);
$set = [];
if (!is_array($data['tags'])) {
return; // @codeCoverageIgnore
}
foreach ($data['tags'] as $string) {
if (strlen($string) > 0) {
$tag = $factory->findOrCreate($string);
$set[] = $tag->id;
}
}
$journal->tags()->sync($set);
}
/**
* Connect bill if present.
*
@@ -62,28 +84,6 @@ trait JournalServiceTrait
return;
}
/**
* @param TransactionJournal $journal
* @param array $data
*/
protected function connectTags(TransactionJournal $journal, array $data): void
{
/** @var TagFactory $factory */
$factory = app(TagFactory::class);
$factory->setUser($journal->user);
$set = [];
if (!is_array($data['tags'])) {
return; // @codeCoverageIgnore
}
foreach ($data['tags'] as $string) {
if (strlen($string) > 0) {
$tag = $factory->findOrCreate($string);
$set[] = $tag->id;
}
}
$journal->tags()->sync($set);
}
/**
* @param TransactionJournal $journal
* @param array $data