kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-09-23 04:46:44 +00:00
Code Issues Projects Releases Wiki Activity

Various code optimalisations.

Browse Source
This commit is contained in:
James Cole
2018-07-08 07:59:58 +02:00
parent 10492e3b2f
commit 2f2f907ffe
59 changed files with 309 additions and 279 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
app/Http/Controllers/RuleController.php
View File

@@ -104,7 +104,7 @@ class RuleController extends Controller
$oldActions = [];
$returnToBill = false;
if ($request->get('return') === 'true') {
if ('true' === $request->get('return')) {
$returnToBill = true;
}
@@ -359,7 +359,7 @@ class RuleController extends Controller
Preferences::mark();
// redirect to show bill.
if ($request->get('return_to_bill') === 'true' && (int)$request->get('bill_id') > 0) {
if ('true' === $request->get('return_to_bill') && (int)$request->get('bill_id') > 0) {
return redirect(route('bills.show', [(int)$request->get('bill_id')])); // @codeCoverageIgnore
}
@@ -792,6 +792,7 @@ class RuleController extends Controller
private function getTriggersForBill(Bill $bill): array
{
$triggers = [];
/** @noinspection BadExceptionsProcessingInspection */
try {
$triggers[] = view(
'rules.partials.trigger',
@@ -822,6 +823,7 @@ class RuleController extends Controller
'count' => 3,
]
)->render();
$triggers[] = view(
'rules.partials.trigger',
[