Various code optimalisations.

This commit is contained in:
James Cole
2018-07-08 07:59:58 +02:00
parent 10492e3b2f
commit 2f2f907ffe
59 changed files with 309 additions and 279 deletions

View File

@@ -48,12 +48,12 @@ class Installer
*/
public function handle($request, Closure $next)
{
if (env('APP_ENV') === 'testing') {
if ('testing' === env('APP_ENV')) {
return $next($request);
}
$url = $request->url();
$strpos = stripos($url, '/install');
if (!($strpos === false)) {
if (!(false === $strpos)) {
Log::debug(sprintf('URL is %s, will NOT run installer middleware', $url));
return $next($request);
@@ -102,7 +102,7 @@ class Installer
*/
protected function isAccessDenied(string $message): bool
{
return !(stripos($message, 'Access denied') === false);
return !(false === stripos($message, 'Access denied'));
}
/**
@@ -112,6 +112,6 @@ class Installer
*/
protected function noTablesExist(string $message): bool
{
return !(stripos($message, 'Base table or view not found') === false);
return !(false === stripos($message, 'Base table or view not found'));
}
}