From 309d3e8e959fb9f67e36b7fba6d428e24a58705c Mon Sep 17 00:00:00 2001 From: James Cole Date: Sat, 6 May 2023 15:59:31 +0200 Subject: [PATCH] Fix missing account validation step. --- app/Validation/Account/WithdrawalValidation.php | 4 +++- app/Validation/TransactionValidation.php | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/app/Validation/Account/WithdrawalValidation.php b/app/Validation/Account/WithdrawalValidation.php index dd0e262d3d..f8ce6eb55e 100644 --- a/app/Validation/Account/WithdrawalValidation.php +++ b/app/Validation/Account/WithdrawalValidation.php @@ -130,11 +130,13 @@ trait WithdrawalValidation { $accountId = array_key_exists('id', $array) ? $array['id'] : null; $accountName = array_key_exists('name', $array) ? $array['name'] : null; + $accountIban = array_key_exists('iban', $array) ? $array['iban'] : null; + $accountNumber =array_key_exists('number', $array) ? $array['number'] : null; Log::debug('Now in validateWithdrawalSource', $array); // source can be any of the following types. $validTypes = array_keys($this->combinations[$this->transactionType]); - if (null === $accountId && null === $accountName && false === $this->canCreateTypes($validTypes)) { + if (null === $accountId && null === $accountName && null === $accountNumber && null === $accountIban && false === $this->canCreateTypes($validTypes)) { // if both values are NULL we return false, // because the source of a withdrawal can't be created. $this->sourceError = (string)trans('validation.withdrawal_source_need_data'); diff --git a/app/Validation/TransactionValidation.php b/app/Validation/TransactionValidation.php index e246a6171c..2c80315ad5 100644 --- a/app/Validation/TransactionValidation.php +++ b/app/Validation/TransactionValidation.php @@ -90,7 +90,7 @@ trait TransactionValidation Log::error(sprintf('Transactions array is not countable, because its a %s', gettype($transactions))); return []; } - Log::debug('Returning transactions.', $transactions); + //Log::debug('Returning transactions.', $transactions); return $transactions; }