kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-10-18 02:03:40 +00:00
Code Issues Projects Releases Wiki Activity

Pick up some phpmd things

Browse Source
This commit is contained in:
James Cole
2023-12-21 05:46:05 +01:00
parent ebf4b00288
commit 337d14e71e
5 changed files with 38 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
app/TransactionRules/Actions/AppendNotesToDescription.php
View File

@@ -70,7 +70,7 @@ class AppendNotesToDescription implements ActionInterface
// only append if there is something to append
if ('' !== $note->text) {
$before = $object->description;
$object->description = trim(sprintf('%s %s', $object->description, (string)$this->clearString($note->text)));
$object->description = trim(sprintf('%s %s', $object->description, (string) $this->clearString($note->text)));
$object->save();
app('log')->debug(sprintf('Journal description is updated to "%s".', $object->description));
@@ -83,11 +83,17 @@ class AppendNotesToDescription implements ActionInterface
return false;
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
*/
public function get(string $key, mixed $default = null): mixed
{
return null;
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
*/
public function has(mixed $key): mixed
{
return null;

8
app/TransactionRules/Actions/MoveNotesToDescription.php
View File

@@ -77,7 +77,7 @@ class MoveNotesToDescription implements ActionInterface
}
$before = $object->description;
$beforeNote = $note->text;
$object->description = (string)$this->clearString($note->text);
$object->description = (string) $this->clearString($note->text);
$object->save();
$note->delete();
@@ -87,11 +87,17 @@ class MoveNotesToDescription implements ActionInterface
return true;
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
*/
public function get(string $key, mixed $default = null): mixed
{
return null;
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
*/
public function has(mixed $key): mixed
{
return null;