kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-10-12 23:45:10 +00:00
Code Issues Projects Releases Wiki Activity

Update find methods to return null

Browse Source
This commit is contained in:
James Cole
2018-02-16 15:19:19 +01:00
parent 28b00f6507
commit 33db99ffd3
16 changed files with 142 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
app/Repositories/Bill/BillRepository.php
View File

@@ -66,14 +66,12 @@ class BillRepository implements BillRepositoryInterface
*
* @return Bill
*/
public function find(int $billId): Bill
public function find(int $billId): ?Bill
{
$bill = $this->user->bills()->find($billId);
if (null === $bill) {
$bill = new Bill;
}
/** @var Bill $res */
$res = $this->user->bills()->find($billId);
return $bill;
return $res;
}
/**
@@ -83,7 +81,7 @@ class BillRepository implements BillRepositoryInterface
*
* @return Bill
*/
public function findByName(string $name): Bill
public function findByName(string $name): ?Bill
{
$bills = $this->user->bills()->get(['bills.*']);
@@ -94,7 +92,7 @@ class BillRepository implements BillRepositoryInterface
}
}
return new Bill;
return null;
}
/**

8
app/Repositories/Bill/BillRepositoryInterface.php
View File

@@ -47,18 +47,18 @@ interface BillRepositoryInterface
*
* @param int $billId
*
* @return Bill
* @return Bill|null
*/
public function find(int $billId): Bill;
public function find(int $billId): ?Bill;
/**
* Find a bill by name.
*
* @param string $name
*
* @return Bill
* @return Bill|null
*/
public function findByName(string $name): Bill;
public function findByName(string $name): ?Bill;
/**
* @return Collection