kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-10-12 15:35:15 +00:00
Code Issues Projects Releases Wiki Activity

Replace phpstan suggestions

Browse Source
This commit is contained in:
James Cole
2022-10-30 14:44:49 +01:00
parent c032ffd4f9
commit 33f370359c
45 changed files with 99 additions and 87 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
app/Api/V1/Requests/System/UpdateRequest.php
View File

@@ -47,15 +47,12 @@ class UpdateRequest extends FormRequest
public function getAll(): array
{
$name = $this->route()->parameter('dynamicConfigKey');
switch ($name) {
default:
break;
case 'configuration.is_demo_site':
case 'configuration.single_user_mode':
return ['value' => $this->boolean('value')];
case 'configuration.permission_update_check':
case 'configuration.last_update_check':
return ['value' => $this->convertInteger('value')];
if ($name === 'configuration.is_demo_site' || $name === 'configuration.single_user_mode') {
return ['value' => $this->boolean('value')];
}
if ($name === 'configuration.permission_update_check' || $name === 'configuration.last_update_check') {
return ['value' => $this->convertInteger('value')];
}
return ['value' => $this->convertString('value')];
@@ -69,16 +66,15 @@ class UpdateRequest extends FormRequest
public function rules(): array
{
$name = $this->route()->parameter('configName');
switch ($name) {
default:
break;
case 'configuration.is_demo_site':
case 'configuration.single_user_mode':
return ['value' => ['required', new IsBoolean()]];
case 'configuration.permission_update_check':
return ['value' => 'required|numeric|between:-1,1'];
case 'configuration.last_update_check':
return ['value' => 'required|numeric|min:464272080'];
if ($name === 'configuration.is_demo_site' || $name === 'configuration.single_user_mode') {
return ['value' => ['required', new IsBoolean()]];
}
if ($name === 'configuration.permission_update_check') {
return ['value' => 'required|numeric|between:-1,1'];
}
if ($name === 'configuration.last_update_check') {
return ['value' => 'required|numeric|min:464272080'];
}
return ['value' => 'required'];

2
app/Api/V1/Requests/System/UserUpdateRequest.php
View File

@@ -27,6 +27,7 @@ namespace FireflyIII\Api\V1\Requests\System;
use FireflyIII\Rules\IsBoolean;
use FireflyIII\Support\Request\ChecksLogin;
use FireflyIII\Support\Request\ConvertsDataTypes;
use FireflyIII\User;
use Illuminate\Foundation\Http\FormRequest;
use Illuminate\Validation\Validator;
@@ -75,6 +76,7 @@ class UserUpdateRequest extends FormRequest
*/
public function rules(): array
{
/** @var User $user */
$user = $this->route()->parameter('user');
return [