kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-10-22 03:53:37 +00:00
Code Issues Projects Releases Wiki Activity

Replace phpstan suggestions

Browse Source
This commit is contained in:
James Cole
2022-10-30 14:44:49 +01:00
parent c032ffd4f9
commit 33f370359c
45 changed files with 99 additions and 87 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/Validation/Account/ReconciliationValidation.php
View File

@@ -61,7 +61,7 @@ trait ReconciliationValidation
$search = $this->findExistingAccount($validTypes, $array);
if (null === $search) {
$this->sourceError = (string) trans('validation.reconciliation_source_bad_data', ['id' => $accountId, 'name' => $accountName]);
Log::warning('Not a valid source. Cant find it.', $validTypes);
app('log')->warning('Not a valid source. Cant find it.', $validTypes);
return false;
}
@@ -98,7 +98,7 @@ trait ReconciliationValidation
$search = $this->findExistingAccount($validTypes, $array);
if (null === $search) {
$this->sourceError = (string) trans('validation.reconciliation_source_bad_data', ['id' => $accountId, 'name' => $accountName]);
Log::warning('Not a valid source. Cant find it.', $validTypes);
app('log')->warning('Not a valid source. Cant find it.', $validTypes);
return false;
}

4
app/Validation/Account/TransferValidation.php
View File

@@ -103,7 +103,7 @@ trait TransferValidation
// if both values are NULL we return false,
// because the source of a withdrawal can't be created.
$this->sourceError = (string) trans('validation.transfer_source_need_data');
Log::warning('Not a valid source, need more data.');
app('log')->warning('Not a valid source, need more data.');
return false;
}
@@ -112,7 +112,7 @@ trait TransferValidation
$search = $this->findExistingAccount($validTypes, $array);
if (null === $search) {
$this->sourceError = (string) trans('validation.transfer_source_bad_data', ['id' => $accountId, 'name' => $accountName]);
Log::warning('Not a valid source, cant find it.', $validTypes);
app('log')->warning('Not a valid source, cant find it.', $validTypes);
return false;
}

8
app/Validation/Account/WithdrawalValidation.php
View File

@@ -63,7 +63,7 @@ trait WithdrawalValidation
// if both values are NULL we return TRUE
// because we assume the user doesnt want to submit / change anything.
$this->sourceError = (string) trans('validation.withdrawal_source_need_data');
Log::warning('[a] Not a valid source. Need more data.');
app('log')->warning('[a] Not a valid source. Need more data.');
return false;
}
@@ -72,7 +72,7 @@ trait WithdrawalValidation
$search = $this->findExistingAccount($validTypes, $array);
if (null === $search) {
$this->sourceError = (string) trans('validation.withdrawal_source_bad_data', ['id' => $accountId, 'name' => $accountName]);
Log::warning('Not a valid source. Cant find it.', $validTypes);
app('log')->warning('Not a valid source. Cant find it.', $validTypes);
return false;
}
@@ -137,7 +137,7 @@ trait WithdrawalValidation
// if both values are NULL we return false,
// because the source of a withdrawal can't be created.
$this->sourceError = (string) trans('validation.withdrawal_source_need_data');
Log::warning('[b] Not a valid source. Need more data.');
app('log')->warning('[b] Not a valid source. Need more data.');
return false;
}
@@ -146,7 +146,7 @@ trait WithdrawalValidation
$search = $this->findExistingAccount($validTypes, $array);
if (null === $search) {
$this->sourceError = (string) trans('validation.withdrawal_source_bad_data', ['id' => $accountId, 'name' => $accountName]);
Log::warning('Not a valid source. Cant find it.', $validTypes);
app('log')->warning('Not a valid source. Cant find it.', $validTypes);
return false;
}